Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/6479/1/src/libbsc/bsc_vty.c
File src/libbsc/bsc_vty.c:
Line 380: case NL_MODE_MANUAL_SI5SEP:
I'm not sure if this leads to the correct result. MANUAL_SI5SEP basically
means that the neighbor list for BCCH (SI2) is different from
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6501
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica4a7f463fcf1bd67fe082296cecea8d10f2fc5b
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6494
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I90eda8405f2d2eddfb041ca38b34fe30c397e09d
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6467
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3999755cdd4e0c2861582b20e2dbb7e1538e074
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 1:
I think this deserves a FIXME in the code and/or a separate redmine issue to
make sure we don't forget to work on the intra-BTS assignment later on?
--
To view, visit https://gerrit.osmocom.org/6493
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType:
Harald Welte has submitted this change and it was merged.
Change subject: libmsc: Add a function to return a unique ID of the subscriber
conn
..
libmsc: Add a function to return a unique ID of the subscriber conn
The ID will
Harald Welte has submitted this change and it was merged.
Change subject: iucs: Add a function to return the connection ID for the IU
SCCP conn
..
iucs: Add a function to return the connection ID for the IU SCCP conn
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6502
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b875772e3994ad3458ee60dbf880604486d9afd
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6497
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5b64504007fe03e0406a4b395cd0359232b77d2
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 4:
(1 comment)
https://gerrit.osmocom.org/#/c/5424/4/src/libmsc/a_iface_bssap.c
File src/libmsc/a_iface_bssap.c:
Line 313: memcpy(msg->l3h, TLVP_VAL(tp, GSM0808_IE_LAYER_3_INFORMATION),
msgb_l3len(msg));
> As the FIXME comment indicates, current code seems a bit hackish, like
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6463
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4478ebcaada00897cc38c5a299e07661139ed3c5
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6496
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id455a8becbb43884e8205d87b0371b216d0119fc
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6468
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife975a1c7c17a500b1693be620475a8bea72f86f
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6495
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6c2bc2b10dc424dfd94a9e11a9a62f51c48aa10
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: Makefile: Build gtp-{link,tunnel} by default, but don't install
them
..
Makefile: Build gtp-{link,tunnel} by default, but don't install them
They used
Patch Set 1: Code-Review+2
we could have added a new function that includes the free, something lie
gsmtap_sendmsg_free() and then migrate new cold over, deprecate the old API, ...
--
To view, visit https://gerrit.osmocom.org/6512
To unsubscribe, visit https://gerrit.osmocom.org/settings
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6515
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I51431ae7baca33ce5bab085cc3efe25f1a10b6d1
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/6478/1/src/libbsc/bsc_vty.c
File src/libbsc/bsc_vty.c:
Line 285: vty_out(vty, " ARFCNs:");
> actually the hopping is in the trx->ts, so I need to iterate all the ts fir
yes, or be cheap and simply state "ARFCNs: Hopping" for now. I
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6498
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I66c4f45afda614f874c9cdf0c22552f492315b71
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6517
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd2b3a66e5968686e6bbff59dbc89b7673def8dd
Gerrit-PatchSet: 1
Gerrit-Project: libgtpnl
Gerrit-Branch: master
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/6499/1/src/libbsc/handover_decision_2.c
File src/libbsc/handover_decision_2.c:
Line 7: * Author: Andreas Eversberg
Andreas' code is not copyright by sysmocom. So it must be copyright by
sysmocom + andreas, not "(C)
Patch Set 1:
what's the purpose of the tool? is it generically useful to the normal user?
If yes, bin_PROGRAMS is fine (but debian/* must be updated, too!). If it's
just a hack for developers, then noinst_PROGRAMS might be a better place, i.e.
not installing it during "make install".
--
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6514
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf64ed9b14247298ed8b4ab8735627f8235a499
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6513
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I099ae1c663c018da5db884f7e9d52c45af3ed817
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6509
to look at the new patch set (#3).
Support decoding of more cell ID list types in libosmocore.
Extend gsm0808_dec_cell_id_list() with support for more types of
cell identifier lists.
Review at https://gerrit.osmocom.org/6518
Track libosmocore API change in osmo-msc.
struct gsm0808_cell_id_list in libosmocore is changed by
https://gerrit.osmocom.org/#/c/6509/
This updates the only API user I am aware of.
Change-Id: I67377270cf3b081ac5dc9cd7b4dc28f74143753a
Depends:
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5424
to look at the new patch set (#5).
libmsc: bssap: Remove fixme and properly update msgb tail
Change-Id: I28073efd5cff58cd212341bceee784caf08d5ad8
---
M
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6324
to look at the new patch set (#6).
Add support for Access Control Class ramping.
Access Control Class (ACC) ramping is used to slowly make the cell
available to an
Pau Espin Pedrol has abandoned this change.
Change subject: Name systemd service after the software
..
Abandoned
--
To view, visit https://gerrit.osmocom.org/2225
To unsubscribe, visit https://gerrit.osmocom.org/settings
Pau Espin Pedrol has abandoned this change.
Change subject: Name systemd service after the software
..
Abandoned
--
To view, visit https://gerrit.osmocom.org/2224
To unsubscribe, visit https://gerrit.osmocom.org/settings
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6509
to look at the new patch set (#2).
Support decoding of more cell ID list types in libosmocore.
Extend gsm0808_dec_cell_id_list() with support for more types of
cell identifier lists.
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6520
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0e2a8ae8d9885fa44c9cc1f7dc7c7948abd683c
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6519
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe40a954aa4548e54b48c444014d7dbd2da9d956
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: modem: Remove ctx after deactivating it
..
modem: Remove ctx after deactivating it
Change-Id: Ib0e2a8ae8d9885fa44c9cc1f7dc7c7948abd683c
---
M
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: modem: deactive_context: Log when context is successfully
deactivated
..
modem: deactive_context: Log when context is successfully deactivated
Patch Set 1: Verified+1
Once it's merged, we need to merge in meta-sysmocom-bsp: branch
pespin/osmo-sip-connector to 201705 to have it included in the feeds.
--
To view, visit https://gerrit.osmocom.org/6524
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType:
Review at https://gerrit.osmocom.org/6520
modem: Remove ctx after deactivating it
Change-Id: Ib0e2a8ae8d9885fa44c9cc1f7dc7c7948abd683c
---
M src/osmo_gsm_tester/modem.py
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester
Harald Welte has submitted this change and it was merged.
Change subject: HO: bsc_handover_start_lchan_change(): set MS to max power on
handover
..
HO: bsc_handover_start_lchan_change(): set MS to max power on handover
For
Harald Welte has submitted this change and it was merged.
Change subject: HO: cosmetic: bsc_handover_start_lchan_change(): tweak local
vars
..
HO: cosmetic: bsc_handover_start_lchan_change(): tweak local vars
To keep this
Harald Welte has submitted this change and it was merged.
Change subject: HO: process_meas_rep: guard against modulo zero
..
HO: process_meas_rep: guard against modulo zero
Fixes: CID#182318
Change-Id:
Review at https://gerrit.osmocom.org/6522
contrib: Add systemd service file
Change-Id: I36dd16b75beb4d9bd8081aca6e44c5b72e58fead
---
A contrib/systemd/osmo-sip-connector.service
1 file changed, 12 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector
Patch Set 3:
(2 comments)
https://gerrit.osmocom.org/#/c/6471/3//COMMIT_MSG
Commit Message:
Line 38: handover2 window rxlev averaging 7
What about using a node instead of prepending the algorithm to each command?
https://gerrit.osmocom.org/#/c/6471/3/src/libbsc/handover_decision.c
File
Review at https://gerrit.osmocom.org/6524
Add osmo-sip-connector recipe
Change-Id: Iaf7f1c2c611dccbd13bcdd6a5b53d52bee0e84c6
---
A recipes-osmocom/osmo-sip-connector/osmo-sip-connector.inc
A recipes-osmocom/osmo-sip-connector/osmo-sip-connector_git.bb
2 files changed, 28 insertions(+), 0
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/6499/1/src/libbsc/handover_decision_2.c
File src/libbsc/handover_decision_2.c:
Line 7: * Author: Andreas Eversberg
> The other files like handover_cfg.c and handover_vty.c also have such copyr
other files: see
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6479
to look at the new patch set (#2).
vty: 'show bts': print neighbor cells
Print out the current neighbor cell list, works both for manual and
automatically populated modes.
Examples of
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6478
to look at the new patch set (#4).
vty: 'show bts': list the TRXs' ARFCNs
Change-Id: I56ee2edc7473dc5e9f3c3463194369024cd64995
---
M src/libbsc/bsc_vty.c
1 file changed, 33
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6522
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I36dd16b75beb4d9bd8081aca6e44c5b72e58fead
Gerrit-PatchSet: 1
Gerrit-Project: osmo-sip-connector
Gerrit-Branch:
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: contrib: Add systemd service file
..
contrib: Add systemd service file
Change-Id: I36dd16b75beb4d9bd8081aca6e44c5b72e58fead
---
A
Review at https://gerrit.osmocom.org/6519
modem: deactive_context: Log when context is successfully deactivated
Change-Id: Ibe40a954aa4548e54b48c444014d7dbd2da9d956
---
M src/osmo_gsm_tester/modem.py
1 file changed, 1 insertion(+), 0 deletions(-)
git pull
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6493
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d979094fa16620f1acc5933418797829710ba8
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/5424
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I28073efd5cff58cd212341bceee784caf08d5ad8
Gerrit-PatchSet: 5
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/6499/1/src/libbsc/handover_decision_2.c
File src/libbsc/handover_decision_2.c:
Line 7: * Author: Andreas Eversberg
> On the original handover_decision_2.c from branch jolly/new_handover, the c
The other files like
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6499
to look at the new patch set (#2).
HO: Implement load based handover, as handover_decision_2.c
Change-Id: Ie597eae82722baf32546331e443dd9d94f1f25e6
---
M configure.ac
M
Review at https://gerrit.osmocom.org/6521
cosmetic: adjust copyrights on handover_cfg.c,_vty.c
They are based on work by jolly, so it can't hurt to mark his copyright.
Change-Id: Id3856cf34d85d6354510a94960fe5ce810c10bc7
---
M src/libbsc/handover_cfg.c
M src/libbsc/handover_vty.c
2 files
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6509
to look at the new patch set (#4).
Support for more cell ID list types in libosmocore.
Extend gsm0808_dec_cell_id_list() with support for additional types of
cell identifier lists. The
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/6193/2/src/bts.cpp
File src/bts.cpp:
Line 971: return false;
You could change the return type from bool to int and then return -ENOMEM here,
instead of encoding the knowledge that 'return false' implies ENOMEM in the
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/6499/1/src/libbsc/handover_decision_2.c
File src/libbsc/handover_decision_2.c:
Line 7: * Author: Andreas Eversberg
> Andreas' code is not copyright by sysmocom. So it must be copyright by sys
On the original
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6493
to look at the new patch set (#2).
handover_logic.c: always do inter-cell channel activation
In commit [1], the channel activation kind was modified out-of-context to use
Immediate
Patch Set 3:
The sister function pcu_bitcount() is used on wider types (e.g. see
find_multi_slots() which uses it with unsigned int).
I think from an API point of view it makes more sense to keep both functions
consistent.
Is the goal to get rid of templates? In that case, why not use
Harald Welte has submitted this change and it was merged.
Change subject: HO: add new_lchan_type arg to bsc_handover_start()
..
HO: add new_lchan_type arg to bsc_handover_start()
Upcoming handover_decision_2 will want to be
Harald Welte has submitted this change and it was merged.
Change subject: HO: move penalty timers to own file as proper API
..
HO: move penalty timers to own file as proper API
Separate penalty timers API from specific struct
Harald Welte has submitted this change and it was merged.
Change subject: HO: cfg: tweak vty write
..
HO: cfg: tweak vty write
Have expicitly named vty write functions for bts and net levels, so that it is
trivial to add
Harald Welte has submitted this change and it was merged.
Change subject: HO: cosmetic: bsc_handover_start(): "fix" memcpy for AMR config
..
HO: cosmetic: bsc_handover_start(): "fix" memcpy for AMR config
memcpy obviously
Harald Welte has submitted this change and it was merged.
Change subject: HO: store speech codec list from BSSMAP Assignment in conn
..
HO: store speech codec list from BSSMAP Assignment in conn
On BSSMAP Assignment Request
Harald Welte has submitted this change and it was merged.
Change subject: handover_logic.c: always do inter-cell channel activation
..
handover_logic.c: always do inter-cell channel activation
In commit [1], the channel
Harald Welte has submitted this change and it was merged.
Change subject: HO: logging: more logs, and more concise logging
..
HO: logging: more logs, and more concise logging
Explicitly log "Handover" or "Assignment", add more
Harald Welte has submitted this change and it was merged.
Change subject: HO: always do async handover
..
HO: always do async handover
We're really only interested in async handover so far.
Set ho->async to true always.
Harald Welte has submitted this change and it was merged.
Change subject: handover_logic.c: on HO command, send new lchan's MS power
..
handover_logic.c: on HO command, send new lchan's MS power
Change-Id:
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5424
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I28073efd5cff58cd212341bceee784caf08d5ad8
Gerrit-PatchSet: 5
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: libmsc: bssap: Remove fixme and properly update msgb tail
..
libmsc: bssap: Remove fixme and properly update msgb tail
Change-Id:
Harald Welte has submitted this change and it was merged.
Change subject: Migrate Gb (NS/BSSGP) code over to Ericsson NS/BSSGP modules
..
Migrate Gb (NS/BSSGP) code over to Ericsson NS/BSSGP modules
When we started out,
Harald Welte has submitted this change and it was merged.
Change subject: BSSGP_Emulation: Remove one level of indent (like most other
code)
..
BSSGP_Emulation: Remove one level of indent (like most other code)
Change-Id:
Harald Welte has submitted this change and it was merged.
Change subject: Add L3_Common for shared L3 functions between MSC and SGSN
testing
..
Add L3_Common for shared L3 functions between MSC and SGSN testing
Change-Id:
Harald Welte has submitted this change and it was merged.
Change subject: bool2bit_tmpl(): Fix for '?' template case
..
bool2bit_tmpl(): Fix for '?' template case
Change-Id: I6dd3c4afdf61689a23aefc277a70cf298cb24c96
---
M
Harald Welte has submitted this change and it was merged.
Change subject: Osmocom_Gb_Types: Add ts_BSSGP_UL_UD and tr_BSSGP_PS_PAGING
..
Osmocom_Gb_Types: Add ts_BSSGP_UL_UD and tr_BSSGP_PS_PAGING
Change-Id:
Harald Welte has submitted this change and it was merged.
Change subject: L3_Templates: More GMM related templates
..
L3_Templates: More GMM related templates
Change-Id: Idf305731afb9a4c316e7320553705946c3edb633
---
M
Harald Welte has submitted this change and it was merged.
Change subject: sgsn: Skeleton of a SGSN test fremwork
..
sgsn: Skeleton of a SGSN test fremwork
Based on the exsting NS/BSSGP emulation as well as the VTY, GSUP and
Harald Welte has submitted this change and it was merged.
Change subject: Osmocom_Types: Add bool2bit() and bool2bit_templ()
..
Osmocom_Types: Add bool2bit() and bool2bit_templ()
Those can be very handy to convert boolean
Harald Welte has submitted this change and it was merged.
Change subject: L3_Templates: Fix ts_MI_TMSI_TLV / ts_MI_IMSI_LV / ts_MI_IMEI_LV
..
L3_Templates: Fix ts_MI_TMSI_TLV / ts_MI_IMSI_LV / ts_MI_IMEI_LV
It seems not all
Harald Welte has submitted this change and it was merged.
Change subject: L3_Templates: Add various GMM related templates
..
L3_Templates: Add various GMM related templates
... needed for upcoming SGSN testing
Change-Id:
Harald Welte has submitted this change and it was merged.
Change subject: bool2bit_tmpl(): Print unsupported template in failure case
..
bool2bit_tmpl(): Print unsupported template in failure case
Change-Id:
Harald Welte has submitted this change and it was merged.
Change subject: msc: move f_gen_{imei,imsi,msisdn} to L3_Templates.ttcn
..
msc: move f_gen_{imei,imsi,msisdn} to L3_Templates.ttcn
This allows them to be reused in
Patch Set 1: Verified+1
--
To view, visit https://gerrit.osmocom.org/6525
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic048ffc500a56f775046943e0eea89b5d939b372
Gerrit-PatchSet: 1
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6533
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0504ee9137eef08c2ab0c710d1b57b2c19bf0db8
Gerrit-PatchSet: 2
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6532
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I53c65e3a2b71e4c9b6691969d50def69b25ddfd0
Gerrit-PatchSet: 2
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6531
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6dd3c4afdf61689a23aefc277a70cf298cb24c96
Gerrit-PatchSet: 2
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6534
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf305731afb9a4c316e7320553705946c3edb633
Gerrit-PatchSet: 2
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Harald Welte has submitted this change and it was merged.
Change subject: General_Types: Add INT18b_BO_LAST type
..
General_Types: Add INT18b_BO_LAST type
Change-Id: I9611cad26bf9a447e63462caa608da1f5888a9d8
---
M
Review at https://gerrit.osmocom.org/6537
BSC: Do not access unbound BTS objects
BTS[1] in function f_start_handler() is not always populated.
- Check BTS[1] before accessing it.
Change-Id: I37fdf7e6ef521677613f4eadc6f1ea236c04ce8e
---
M bsc/BSC_Tests.ttcn
1 file changed, 4 insertions(+), 2
Review at https://gerrit.osmocom.org/6538
BSC: add TC_paging_counter to control section
The testcase TC_paging_counter is missing in the control section.
This means that if it is not started explicitly, it is not executed.
- Add TC_paging_counter to control section
Change-Id:
Review at https://gerrit.osmocom.org/6540
BSC: add codec-list to osmo-bsc.cfg
The provided osmo-bsc.cfg does not contain any codec list, this
causes failure of the assignment related tests.
- add missing codec list
Change-Id: Id2509bcac4c54c910efd2db749eaa2085daa358d
---
M bsc/osmo-bsc.cfg
1
Review at https://gerrit.osmocom.org/6541
BSC: Update BSC_Tests.cfg
The provided BSC_Tests.cfg, which contains as a commented line for
local debugging, does not contain all tests from the control section.
- Update BSC_Tests.cfg so that it contains all tests from the
control section
Review at https://gerrit.osmocom.org/6539
BSC: remove obsolete loglevels from osmo-bsc.cfg
The provided osmo-bsc.cfg contains obsolete log levels.
- Remove obsolete loglevels
Change-Id: I1c949b69ecaef8a8ed0163779a470378ab08
---
M bsc/osmo-bsc.cfg
1 file changed, 0 insertions(+), 15
Harald Welte has submitted this change and it was merged.
Change subject: BSC: Do not access unbound BTS objects
..
BSC: Do not access unbound BTS objects
BTS[1] in function f_start_handler() is not always populated.
- Check
Harald Welte has submitted this change and it was merged.
Change subject: BSC: add codec-list to osmo-bsc.cfg
..
BSC: add codec-list to osmo-bsc.cfg
The provided osmo-bsc.cfg does not contain any codec list, this
causes
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6540
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2509bcac4c54c910efd2db749eaa2085daa358d
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6538
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie37b8cb554ea1db64a8d7927eb300d368ce67137
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6539
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c949b69ecaef8a8ed0163779a470378ab08
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Harald Welte has submitted this change and it was merged.
Change subject: BSC: remove obsolete loglevels from osmo-bsc.cfg
..
BSC: remove obsolete loglevels from osmo-bsc.cfg
The provided osmo-bsc.cfg contains obsolete log
Review at https://gerrit.osmocom.org/6531
bool2bit_tmpl(): Fix for '?' template case
Change-Id: I6dd3c4afdf61689a23aefc277a70cf298cb24c96
---
M library/Osmocom_Types.ttcn
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
1 - 100 of 153 matches
Mail list logo