Change in simtrace2[master]: remsim: fix USB hanging USB transfer

2018-08-02 Thread Kévin Redon
Kévin Redon has uploaded this change for review. ( https://gerrit.osmocom.org/10319 Change subject: remsim: fix USB hanging USB transfer .. remsim: fix USB hanging USB transfer After a couple of seconds of USB data exchange

Change in simtrace2[master]: cardem (minor): trace tx data send over USB

2018-08-02 Thread Kévin Redon
Kévin Redon has uploaded this change for review. ( https://gerrit.osmocom.org/10318 Change subject: cardem (minor): trace tx data send over USB .. cardem (minor): trace tx data send over USB Change-Id:

Change in simtrace2[master]: cardem: add state name in trace

2018-08-02 Thread Kévin Redon
Kévin Redon has uploaded this change for review. ( https://gerrit.osmocom.org/10316 Change subject: cardem: add state name in trace .. cardem: add state name in trace this helps reading the output while debugging quite a lot

Change in simtrace2[master]: add libosmcore utilities

2018-08-02 Thread Kévin Redon
Kévin Redon has uploaded this change for review. ( https://gerrit.osmocom.org/10317 Change subject: add libosmcore utilities .. add libosmcore utilities osmo_hexdump is particularly useful. previously it was only defined, but

Change in simtrace2[master]: sniff: send incomplete TPDU when reset is asserted

2018-08-02 Thread Kévin Redon
Kévin Redon has uploaded this change for review. ( https://gerrit.osmocom.org/10312 Change subject: sniff: send incomplete TPDU when reset is asserted .. sniff: send incomplete TPDU when reset is asserted Change-Id:

Change in simtrace2[master]: cardem: minor typo fix in comment

2018-08-02 Thread Kévin Redon
Kévin Redon has uploaded this change for review. ( https://gerrit.osmocom.org/10314 Change subject: cardem: minor typo fix in comment .. cardem: minor typo fix in comment Change-Id: Ib1dee95e15db1c6bb3b45920d7c1a567e2ba474b

Change in simtrace2[master]: cardem (minor): remove to verbose log trace

2018-08-02 Thread Kévin Redon
Kévin Redon has uploaded this change for review. ( https://gerrit.osmocom.org/10315 Change subject: cardem (minor): remove to verbose log trace .. cardem (minor): remove to verbose log trace Change-Id:

Change in simtrace2[master]: cardem: use TC2 as WI and update WT after ATR

2018-08-02 Thread Kévin Redon
Kévin Redon has uploaded this change for review. ( https://gerrit.osmocom.org/10311 Change subject: cardem: use TC2 as WI and update WT after ATR .. cardem: use TC2 as WI and update WT after ATR Change-Id:

Change in simtrace2[master]: add synchronous UART transmission and use it in exceptions

2018-08-02 Thread Kévin Redon
Kévin Redon has uploaded this change for review. ( https://gerrit.osmocom.org/10313 Change subject: add synchronous UART transmission and use it in exceptions .. add synchronous UART transmission and use it in exceptions The

Change in osmo-hlr[master]: hlr_ussd.c: avoid using CR and NL in IUSE responses

2018-08-02 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/10323 Change subject: hlr_ussd.c: avoid using CR and NL in IUSE responses .. hlr_ussd.c: avoid using CR and NL in IUSE responses According to

Change in osmo-hlr[master]: hlr_ussd.c: fix: properly print a EUSE / IUSE name

2018-08-02 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/10322 Change subject: hlr_ussd.c: fix: properly print a EUSE / IUSE name .. hlr_ussd.c: fix: properly print a EUSE / IUSE name We need to

Change in osmo-hlr[master]: USSD/hlr_vty.c: print error if EUSE is not found

2018-08-02 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/10321 Change subject: USSD/hlr_vty.c: print error if EUSE is not found .. USSD/hlr_vty.c: print error if EUSE is not found Change-Id:

Change in osmo-mgw[master]: mgcp_sdp: restructure mgcp_write_response_sdp()

2018-08-02 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/10310 Change subject: mgcp_sdp: restructure mgcp_write_response_sdp() .. mgcp_sdp: restructure mgcp_write_response_sdp() The function

Change in osmo-mgw[master]: mgcp_sdp: restructure mgcp_write_response_sdp() (rtpmap)

2018-08-02 Thread dexter
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/10310 to look at the new patch set (#3). Change subject: mgcp_sdp: restructure mgcp_write_response_sdp() (rtpmap) ..

Change in osmo-mgw[master]: mgcp_sdp: restructure mgcp_write_response_sdp() (rtpmap)

2018-08-02 Thread dexter
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/10310 to look at the new patch set (#2). Change subject: mgcp_sdp: restructure mgcp_write_response_sdp() (rtpmap) ..

Change in osmo-mgw[master]: mgcp_sdp: restructure mgcp_write_response_sdp() (audio)

2018-08-02 Thread dexter
dexter has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/10320 ) Change subject: mgcp_sdp: restructure mgcp_write_response_sdp() (audio) .. mgcp_sdp: restructure mgcp_write_response_sdp() (audio) The function

Change in osmo-mgw[master]: mgcp_sdp: restructure mgcp_write_response_sdp() (audio)

2018-08-02 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/10320 Change subject: mgcp_sdp: restructure mgcp_write_response_sdp() (audio) .. mgcp_sdp: restructure mgcp_write_response_sdp() (audio) The function

Change in osmo-ttcn3-hacks[master]: IPA_Emulation: Add missing zero byte to strings in IPA CCM ID RESP

2018-08-02 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10324 ) Change subject: IPA_Emulation: Add missing zero byte to strings in IPA CCM ID RESP .. IPA_Emulation: Add missing zero byte to

Change in osmo-ttcn3-hacks[master]: IPA_Emulation: Add missing zero byte to strings in IPA CCM ID RESP

2018-08-02 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10324 ) Change subject: IPA_Emulation: Add missing zero byte to strings in IPA CCM ID RESP .. Patch Set 1: Code-Review+2 -- To view, visit

Change in simtrace2[master]: sniff: send incomplete TPDU when reset is asserted

2018-08-02 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10312 ) Change subject: sniff: send incomplete TPDU when reset is asserted .. sniff: send incomplete TPDU when reset is asserted Change-Id:

Change in simtrace2[master]: cardem: use TC2 as WI and update WT after ATR

2018-08-02 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10311 ) Change subject: cardem: use TC2 as WI and update WT after ATR .. cardem: use TC2 as WI and update WT after ATR Change-Id:

Change in simtrace2[master]: cardem: use TC2 as WI and update WT after ATR

2018-08-02 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10311 ) Change subject: cardem: use TC2 as WI and update WT after ATR .. Patch Set 1: Code-Review+2 -- To view, visit

Change in simtrace2[master]: sniff: send incomplete TPDU when reset is asserted

2018-08-02 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10312 ) Change subject: sniff: send incomplete TPDU when reset is asserted .. Patch Set 1: Code-Review+2 -- To view, visit

Change in simtrace2[master]: cardem: add state name in trace

2018-08-02 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10316 ) Change subject: cardem: add state name in trace .. Patch Set 1: (1 comment)

Change in simtrace2[master]: cardem: minor typo fix in comment

2018-08-02 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10314 ) Change subject: cardem: minor typo fix in comment .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/10314 To

Change in simtrace2[master]: cardem (minor): remove to verbose log trace

2018-08-02 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10315 ) Change subject: cardem (minor): remove to verbose log trace .. Patch Set 1: Code-Review+2 -- To view, visit

Change in simtrace2[master]: cardem (minor): trace tx data send over USB

2018-08-02 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10318 ) Change subject: cardem (minor): trace tx data send over USB .. Patch Set 1: why are you proposing this change? debug UART band-width is

Change in simtrace2[master]: remsim: fix USB hanging USB transfer

2018-08-02 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10319 ) Change subject: remsim: fix USB hanging USB transfer .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/10319 To

Change in simtrace2[master]: add libosmcore utilities

2018-08-02 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10317 ) Change subject: add libosmcore utilities .. Patch Set 1: Code-Review+2 we can do this, but in the not too distant future I would want to

Change in simtrace2[master]: add synchronous UART transmission and use it in exceptions

2018-08-02 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10313 ) Change subject: add synchronous UART transmission and use it in exceptions .. Patch Set 1: Code-Review+1 (1 comment) I think in general I

Change in libosmocore[master]: gsm/gsm0480.c: use the local msgb allocator

2018-08-02 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/10326 Change subject: gsm/gsm0480.c: use the local msgb allocator .. gsm/gsm0480.c: use the local msgb allocator Change-Id:

Change in libosmocore[master]: gsm/gsm0480.c: prevent NULL-pointer dereference

2018-08-02 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/10325 Change subject: gsm/gsm0480.c: prevent NULL-pointer dereference .. gsm/gsm0480.c: prevent NULL-pointer dereference Change-Id:

Change in osmo-msc[master]: libmsc/gsm_09_11.c: clean up the local GSM 04.80 API

2018-08-02 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/10327 Change subject: libmsc/gsm_09_11.c: clean up the local GSM 04.80 API .. libmsc/gsm_09_11.c: clean up the local GSM 04.80 API Since we

Change in osmo-hlr[master]: hlr_ussd.c: fix: properly print a EUSE / IUSE name

2018-08-02 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10322 ) Change subject: hlr_ussd.c: fix: properly print a EUSE / IUSE name .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-hlr[master]: hlr_ussd.c: fix: properly print a EUSE / IUSE name

2018-08-02 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10322 ) Change subject: hlr_ussd.c: fix: properly print a EUSE / IUSE name .. hlr_ussd.c: fix: properly print a EUSE / IUSE name We need to

Change in osmo-hlr[master]: USSD/hlr_vty.c: print error if EUSE is not found

2018-08-02 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10321 ) Change subject: USSD/hlr_vty.c: print error if EUSE is not found .. USSD/hlr_vty.c: print error if EUSE is not found Change-Id:

Change in osmo-hlr[master]: USSD/hlr_vty.c: print error if EUSE is not found

2018-08-02 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10321 ) Change subject: USSD/hlr_vty.c: print error if EUSE is not found .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-hlr[master]: hlr_ussd.c: avoid using CR and NL in IUSE responses

2018-08-02 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10323 ) Change subject: hlr_ussd.c: avoid using CR and NL in IUSE responses .. Patch Set 1: I actually intentionally added the \n in OsmoHLR as we

Change in osmo-hlr[master]: hlr_ussd.c: avoid using CR and NL in IUSE responses

2018-08-02 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/10323 ) Change subject: hlr_ussd.c: avoid using CR and NL in IUSE responses .. Patch Set 1: > I actually intentionally added the \n in OsmoHLR

Change in simtrace2[master]: add synchronous UART transmission and use it in exceptions

2018-08-02 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10313 ) Change subject: add synchronous UART transmission and use it in exceptions .. Patch Set 1: the ISR_NUMBER field in IPSR will tell us which

Change in libosmocore[master]: libosmogsm: (re)introduce gsm48_push_l3hdr()

2018-08-02 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/10328 Change subject: libosmogsm: (re)introduce gsm48_push_l3hdr() .. libosmogsm: (re)introduce gsm48_push_l3hdr() There was

Change in osmo-ttcn3-hacks[master]: IPA_Emulation: Add missing zero byte to strings in IPA CCM ID RESP

2018-08-02 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/10324 Change subject: IPA_Emulation: Add missing zero byte to strings in IPA CCM ID RESP .. IPA_Emulation: Add missing zero byte to strings in IPA

Change in libosmocore[master]: socket: do not set SO_REUSEADDR for IPPROTO_UDP

2018-08-02 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/10289 ) Change subject: socket: do not set SO_REUSEADDR for IPPROTO_UDP .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/10289 To

Change in libosmocore[master]: socket: do not set SO_REUSEADDR for IPPROTO_UDP

2018-08-02 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/10289 ) Change subject: socket: do not set SO_REUSEADDR for IPPROTO_UDP .. Patch Set 3: > Set Ready For Review I did not notice any major problems in my

Change in osmo-mgw[master]: mgcp_test: release endpoints after use

2018-08-02 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/10306 Change subject: mgcp_test: release endpoints after use .. mgcp_test: release endpoints after use The test function test_multilple_codec() in

Change in libosmocore[master]: socket: check return code of setsockopt

2018-08-02 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/10288 ) Change subject: socket: check return code of setsockopt .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/10288 To

Change in libosmocore[master]: socket: check return code of setsockopt

2018-08-02 Thread dexter
dexter has submitted this change and it was merged. ( https://gerrit.osmocom.org/10288 ) Change subject: socket: check return code of setsockopt .. socket: check return code of setsockopt the return code of the last

Change in osmo-mgw[master]: mgcp_client: increment local port number when port is in use

2018-08-02 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/10307 Change subject: mgcp_client: increment local port number when port is in use .. mgcp_client: increment local port number when port is in use The

Change in osmo-bts[master]: Clarify frame loss counter for l1sched_chan_state

2018-08-02 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10308 ) Change subject: Clarify frame loss counter for l1sched_chan_state .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-mgw[master]: mgcp_test: release endpoints after use

2018-08-02 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10306 ) Change subject: mgcp_test: release endpoints after use .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/10306 To

Change in osmo-mgw[master]: mgcp_test: release endpoints after use

2018-08-02 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10306 ) Change subject: mgcp_test: release endpoints after use .. mgcp_test: release endpoints after use The test function

Change in osmo-bts[master]: common/scheduler.c: track TDMA frame loss per logical channels

2018-08-02 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/10309 Change subject: common/scheduler.c: track TDMA frame loss per logical channels .. common/scheduler.c: track TDMA frame loss per logical

Change in osmo-bts[master]: Clarify frame loss counter for l1sched_chan_state

2018-08-02 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/10308 Change subject: Clarify frame loss counter for l1sched_chan_state .. Clarify frame loss counter for l1sched_chan_state Each logical

Change in osmo-bts[master]: common/scheduler.c: track TDMA frame loss per logical channels

2018-08-02 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/10309 ) Change subject: common/scheduler.c: track TDMA frame loss per logical channels .. common/scheduler.c: track TDMA frame loss per logical

Change in libosmocore[master]: socket: do not set SO_REUSEADDR for IPPROTO_UDP

2018-08-02 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10289 ) Change subject: socket: do not set SO_REUSEADDR for IPPROTO_UDP .. socket: do not set SO_REUSEADDR for IPPROTO_UDP When UDP is used

Change in osmo-mgw[master]: mgcp_client: increment local port number when port is in use

2018-08-02 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10307 ) Change subject: mgcp_client: increment local port number when port is in use .. mgcp_client: increment local port number when port

Change in osmo-bts[master]: Clarify frame loss counter for l1sched_chan_state

2018-08-02 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10308 ) Change subject: Clarify frame loss counter for l1sched_chan_state .. Clarify frame loss counter for l1sched_chan_state Each logical

Change in osmo-mgw[master]: mgcp_client: use IETF source port as for MGCP

2018-08-02 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10188 ) Change subject: mgcp_client: use IETF source port as for MGCP .. mgcp_client: use IETF source port as for MGCP At the moment the

Change in osmo-mgw[master]: mgcp_client: increment local port number when port is in use

2018-08-02 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10307 ) Change subject: mgcp_client: increment local port number when port is in use .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-mgw[master]: mgcp_client: use IETF source port as for MGCP

2018-08-02 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10188 ) Change subject: mgcp_client: use IETF source port as for MGCP .. Patch Set 2: Code-Review+2 -- To view, visit