Change in osmo-bsc[master]: cosmetic: fix spec ref for gsm0808_cipher_mode()

2018-10-25 Thread osmith
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11437 to look at the new patch set (#2). Change subject: cosmetic: fix spec ref for gsm0808_cipher_mode() ..

Change in osmo-bsc[master]: cosmetic: fix spec ref for gsm0808_cipher_mode()

2018-10-25 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/11437 ) Change subject: cosmetic: fix spec ref for gsm0808_cipher_mode() .. Patch Set 2: > You have to find the related section in 08.08 (or these days, 4

Change in simtrace2[master]: cardem: add more debug information for TPDU state

2018-10-25 Thread Kévin Redon
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11361 to look at the new patch set (#2). Change subject: cardem: add more debug information for TPDU state ..

Change in simtrace2[master]: cardem: add more debug information for TPDU state

2018-10-25 Thread Kévin Redon
Kévin Redon has posted comments on this change. ( https://gerrit.osmocom.org/11361 ) Change subject: cardem: add more debug information for TPDU state .. Patch Set 2: fixed both valid comments, and updated a related debugging

Change in osmo-bts[master]: common/scheduler.c: track TDMA frame loss per logical channels

2018-10-25 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/10309 ) Change subject: common/scheduler.c: track TDMA frame loss per logical channels .. Patch Set 4: Code-Review+2 -- To view, visit https://

Change in libosmocore[master]: add osmo_sock_get_{local, remote}_ip{, _port}()

2018-10-25 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11455 Change subject: add osmo_sock_get_{local,remote}_ip{,_port}() .. add osmo_sock_get_{local,remote}_ip{,_port}() Return only the IP or port of either

Change in libosmocore[master]: cosmetic: fix typo (soocket -> socket)

2018-10-25 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11454 Change subject: cosmetic: fix typo (soocket -> socket) .. cosmetic: fix typo (soocket -> socket) Change-Id: I2184bf12398902d933f3744bc094418cc6961e8

Change in libosmocore[master]: cosmetic: fix typo (soocket -> socket)

2018-10-25 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11454 ) Change subject: cosmetic: fix typo (soocket -> socket) .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/11454 To unsubscrib

Change in libosmocore[master]: add osmo_sock_get_{local, remote}_ip{, _port}()

2018-10-25 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11455 ) Change subject: add osmo_sock_get_{local,remote}_ip{,_port}() .. Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/11455/1/include/osmocom/cor

Change in libosmocore[master]: cosmetic: fix typo (soocket -> socket)

2018-10-25 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11454 ) Change subject: cosmetic: fix typo (soocket -> socket) .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11454

Change in libosmocore[master]: cosmetic: fix typo (soocket -> socket)

2018-10-25 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/11454 ) Change subject: cosmetic: fix typo (soocket -> socket) .. cosmetic: fix typo (soocket -> socket) Change-Id: I2184bf12398902d933f

Change in libosmocore[master]: add osmo_sock_get_{local, remote}_ip{, _port}()

2018-10-25 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/11455 ) Change subject: add osmo_sock_get_{local,remote}_ip{,_port}() .. Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/11455/1/include/osmocom/

Change in osmocom-bb[master]: mobile: fix vty bind ip override

2018-10-25 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11457 ) Change subject: mobile: fix vty bind ip override .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/11457 To unsubscribe, or for he

Change in osmocom-bb[master]: mobile: cleanup app init

2018-10-25 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11456 ) Change subject: mobile: cleanup app init .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/11456 To unsubscribe, or for help writi

Build failed in Jenkins: master-asn1c » a1=default,a2=default,a3=default,osmocom-master-debian9 #287

2018-10-25 Thread jenkins
See -- [...truncated 3.67 KB...] + ./configure checking build system type... x86_64-unknown-linux-gnu checking host sy

Change in libosmocore[master]: add osmo_sock_get_{local, remote}_ip{, _port}()

2018-10-25 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11455 ) Change subject: add osmo_sock_get_{local,remote}_ip{,_port}() .. Patch Set 1: Not sure how can we make this function - maybe we can somehow use OSMO_

Change in osmo-bsc[master]: cosmetic: fix spec ref for gsm0808_cipher_mode()

2018-10-25 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11437 ) Change subject: cosmetic: fix spec ref for gsm0808_cipher_mode() .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/11437 To

Change in osmo-msc[master]: Fix VLR test macro

2018-10-25 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/6296 ) Change subject: Fix VLR test macro .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/6296 To unsubscribe, or for help writing mail

Change in osmo-msc[master]: Update VLR test helper

2018-10-25 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11458 ) Change subject: Update VLR test helper .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/11458 To unsubscribe, or for help writing

Change in osmo-gsm-tester[master]: process: Make sure sync process is terminated if ogt is stopped

2018-10-25 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/11459 Change subject: process: Make sure sync process is terminated if ogt is stopped .. process: Make sure sync process is terminated if ogt is

Change in osmo-gsm-tester[master]: utils: Introduce modem-netns-setup.py

2018-10-25 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/11461 Change subject: utils: Introduce modem-netns-setup.py .. utils: Introduce modem-netns-setup.py Used to quickly set modem net interfaces i

Change in osmo-gsm-tester[master]: utils: Introduce show_usb_device.py

2018-10-25 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/11460 Change subject: utils: Introduce show_usb_device.py .. utils: Introduce show_usb_device.py This is a small script written by Alexander Co

Change in osmo-gsm-tester[master]: WIP: gprs

2018-10-25 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/11462 Change subject: WIP: gprs .. WIP: gprs Change-Id: Icb06bdfcdd37c797be95ab5addb28da2d9f6681c --- A example/scenarios/modem-ec20.conf M src

Change in osmo-mgw[master]: add MGCP CRCX command statistics to osmo-mgw

2018-10-25 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/11463 Change subject: add MGCP CRCX command statistics to osmo-mgw .. add MGCP CRCX command statistics to osmo-mgw Add a counter group for CRCX

Change in osmo-mgw[master]: add MGCP CRCX command statistics to osmo-mgw

2018-10-25 Thread Stefan Sperling
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11463 to look at the new patch set (#2). Change subject: add MGCP CRCX command statistics to osmo-mgw .. add MGCP CRCX comm

Change in osmo-mgw[master]: use a dynamic name for rtp connection rate counters

2018-10-25 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11439 ) Change subject: use a dynamic name for rtp connection rate counters .. Patch Set 1: Code-Review-1 this is not really how rate counter groups

Change in osmo-bsc[master]: cipher mode reject: send proper cause codes

2018-10-25 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11438 ) Change subject: cipher mode reject: send proper cause codes .. cipher mode reject: send proper cause codes bssmap_handle_cipher_mode

Change in osmo-bsc[master]: cosmetic: fix spec ref for gsm0808_cipher_mode()

2018-10-25 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11437 ) Change subject: cosmetic: fix spec ref for gsm0808_cipher_mode() .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org

Change in osmo-bsc[master]: cosmetic: fix spec ref for gsm0808_cipher_mode()

2018-10-25 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11437 ) Change subject: cosmetic: fix spec ref for gsm0808_cipher_mode() .. cosmetic: fix spec ref for gsm0808_cipher_mode() Change-Id: I359

Change in simtrace2[master]: cardem: add more debug information for TPDU state

2018-10-25 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11361 ) Change subject: cardem: add more debug information for TPDU state .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.or

Change in simtrace2[master]: cardem: add more debug information for TPDU state

2018-10-25 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11361 ) Change subject: cardem: add more debug information for TPDU state .. cardem: add more debug information for TPDU state this just add

Change in osmo-bts[master]: common/scheduler.c: track TDMA frame loss per logical channels

2018-10-25 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10309 ) Change subject: common/scheduler.c: track TDMA frame loss per logical channels .. common/scheduler.c: track TDMA frame loss per logic

Change in osmocom-bb[master]: mobile: cleanup app init

2018-10-25 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11456 ) Change subject: mobile: cleanup app init .. Patch Set 1: Code-Review+1 (3 comments) https://gerrit.osmocom.org/#/c/11456/1//COMMIT_MSG Comm

Change in osmocom-bb[master]: mobile: fix vty bind ip override

2018-10-25 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11457 ) Change subject: mobile: fix vty bind ip override .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11457 To unsubs

Change in libosmocore[master]: add osmo_sock_get_{local, remote}_ip{, _port}()

2018-10-25 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11455 ) Change subject: add osmo_sock_get_{local,remote}_ip{,_port}() .. Patch Set 1: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/114

Change in osmo-msc[master]: Update VLR test helper

2018-10-25 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11458 ) Change subject: Update VLR test helper .. Patch Set 1: Code-Review+2 nice, but again one of those patches where I'm wondering "why spend tim

Change in osmo-msc[master]: Fix VLR test macro

2018-10-25 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/6296 ) Change subject: Fix VLR test macro .. Patch Set 7: are the tests ever likely going to have more than one "conn" they want to match on? If n

Change in osmo-gsm-tester[master]: First round of clean-ups of imports and unused variables

2018-10-25 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11067 ) Change subject: First round of clean-ups of imports and unused variables .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osm

Change in docker-playground[master]: jenkins-common.sh: add docker_images_require()

2018-10-25 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11365 ) Change subject: jenkins-common.sh: add docker_images_require() .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/1

Change in docker-playground[master]: rename m3ua-test, sua-test to nplab-*-test

2018-10-25 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11368 ) Change subject: rename m3ua-test, sua-test to nplab-*-test .. Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11368

Change in docker-playground[master]: Remove top-level Makefile

2018-10-25 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11369 ) Change subject: Remove top-level Makefile .. Patch Set 7: I think this change in usage (shell script vs makefile) should be documented in a

Change in docker-playground[master]: ttcn3-bts-test: Log fake_trx output to file

2018-10-25 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11431 ) Change subject: ttcn3-bts-test: Log fake_trx output to file .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/1143

Change in docker-playground[master]: ttcn3-bts-test: Log fake_trx output to file

2018-10-25 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11431 ) Change subject: ttcn3-bts-test: Log fake_trx output to file .. ttcn3-bts-test: Log fake_trx output to file Change-Id: I82a80b045e6f2

Change in osmo-mgw[master]: check_rtp_origin(): Avoid using memcmp for comparing integer types

2018-10-25 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11403 ) Change subject: check_rtp_origin(): Avoid using memcmp for comparing integer types .. check_rtp_origin(): Avoid using memcmp for com

Change in osmo-mgw[master]: check_rtp_origin(): Don't memcmp sockadd_in and in_addr

2018-10-25 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11402 ) Change subject: check_rtp_origin(): Don't memcmp sockadd_in and in_addr .. check_rtp_origin(): Don't memcmp sockadd_in and in_addr W