Change in osmo-ttcn3-hacks[master]: hlr/HLR_EUSE.ttcn: remove redundant code from f_main_mo()

2018-11-04 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/11578 Change subject: hlr/HLR_EUSE.ttcn: remove redundant code from f_main_mo() .. hlr/HLR_EUSE.ttcn: remove redundant code from f_main_mo()

Change in osmo-gsm-tester[master]: ms_driver: Consult the suite to get the binaries

2018-11-04 Thread Holger Freyther
Holger Freyther has uploaded this change for review. ( https://gerrit.osmocom.org/11599 Change subject: ms_driver: Consult the suite to get the binaries .. ms_driver: Consult the suite to get the binaries Change-Id:

Change in osmo-gsm-tester[master]: ms_driver: use the util.Dir and create one dir per instance

2018-11-04 Thread Holger Freyther
Holger Freyther has uploaded this change for review. ( https://gerrit.osmocom.org/11598 Change subject: ms_driver: use the util.Dir and create one dir per instance .. ms_driver: use the util.Dir and create one dir per instance

Change in osmo-gsm-tester[master]: ms_driver: Allow to specify env and binary name/path

2018-11-04 Thread Holger Freyther
Holger Freyther has uploaded this change for review. ( https://gerrit.osmocom.org/11596 Change subject: ms_driver: Allow to specify env and binary name/path .. ms_driver: Allow to specify env and binary name/path For the

Change in osmo-gsm-tester[master]: ms_driver: Use terminate not kill and initialize in ctor

2018-11-04 Thread Holger Freyther
Holger Freyther has uploaded this change for review. ( https://gerrit.osmocom.org/11595 Change subject: ms_driver: Use terminate not kill and initialize in ctor .. ms_driver: Use terminate not kill and initialize in ctor

Change in osmo-gsm-tester[master]: ms_driver: Switch to process.Process from subprocess

2018-11-04 Thread Holger Freyther
Holger Freyther has uploaded this change for review. ( https://gerrit.osmocom.org/11597 Change subject: ms_driver: Switch to process.Process from subprocess .. ms_driver: Switch to process.Process from subprocess Use a single

Change in osmo-gsm-tester[master]: ms_driver: Initialize event_server_sk_tmp_dira in ctor

2018-11-04 Thread Holger Freyther
Holger Freyther has uploaded this change for review. ( https://gerrit.osmocom.org/11594 Change subject: ms_driver: Initialize event_server_sk_tmp_dira in ctor .. ms_driver: Initialize event_server_sk_tmp_dira in ctor

Change in osmo-gsm-tester[master]: misc: Use RPATH to avoid having tests to set LD_LIBRARY_PATH

2018-11-04 Thread Holger Freyther
Holger Freyther has uploaded this change for review. ( https://gerrit.osmocom.org/11580 Change subject: misc: Use RPATH to avoid having tests to set LD_LIBRARY_PATH .. misc: Use RPATH to avoid having tests to set

Change in osmo-gsm-tester[master]: suits: Add an initial test for the ms_driver

2018-11-04 Thread Holger Freyther
Hello Pau Espin Pedrol, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/10687 to look at the new patch set (#7). Change subject: suits: Add an initial test for the ms_driver ..

Build failed in Jenkins: master-asn1c ยป a1=default,a2=default,a3=default,osmocom-master-debian9 #297

2018-11-04 Thread jenkins
See -- [...truncated 3.67 KB...] + ./configure checking build system type... x86_64-unknown-linux-gnu checking host

Change in osmo-bsc[master]: don't use rsl_cause_name() in LOGP statements

2018-11-04 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11399 ) Change subject: don't use rsl_cause_name() in LOGP statements .. Patch Set 1: sorry, I was oblivious of this patch and implemented a

Change in osmo-bsc[master]: vty doc: drop "(HO algo 2 only)" strings

2018-11-04 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/11581 Change subject: vty doc: drop "(HO algo 2 only)" strings .. vty doc: drop "(HO algo 2 only)" strings These indicators are a legacy of early

Change in osmo-gsm-manuals[master]: ggsn: update vty reference

2018-11-04 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/11584 Change subject: ggsn: update vty reference .. ggsn: update vty reference Change-Id: I8a5c37505c0180d5c04c7792d6d0afdb0dffb282 --- M

Change in osmo-gsm-manuals[master]: mgw: update vty reference

2018-11-04 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/11586 Change subject: mgw: update vty reference .. mgw: update vty reference Change-Id: Ib30ea8b02f8a950648b85e7ebc96a40ba5a36b34 --- M

Change in osmo-gsm-manuals[master]: stp: update vty reference

2018-11-04 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/11590 Change subject: stp: update vty reference .. stp: update vty reference Change-Id: Id5f1067760db7a11ec380a541bfe7357a21a3bb3 --- M

Change in osmo-gsm-manuals[master]: hlr: update vty reference

2018-11-04 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/11585 Change subject: hlr: update vty reference .. hlr: update vty reference Change-Id: I5a2322c0488cb36b089303bbfec5d4db18c41099 --- M

Change in osmo-gsm-manuals[master]: stp: update vty reference with added SCCP commands

2018-11-04 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/11591 Change subject: stp: update vty reference with added SCCP commands .. stp: update vty reference with added SCCP commands After

Change in libosmo-sccp[master]: osmo-stp: add SCCP related VTY commands

2018-11-04 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/11583 Change subject: osmo-stp: add SCCP related VTY commands .. osmo-stp: add SCCP related VTY commands Call osmo_sccp_vty_init(), so far

Change in osmo-gsm-manuals[master]: sip-connector: update vty reference

2018-11-04 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/11589 Change subject: sip-connector: update vty reference .. sip-connector: update vty reference Change-Id:

Change in libosmo-sccp[master]: osmo-stp: add SCCP related VTY commands

2018-11-04 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11583 to look at the new patch set (#2). Change subject: osmo-stp: add SCCP related VTY commands .. osmo-stp: add SCCP

Change in osmo-ci[master]: misc: Install patchelf to add/set an rpath if wanted

2018-11-04 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11579 ) Change subject: misc: Install patchelf to add/set an rpath if wanted .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-ttcn3-hacks[master]: hlr/HLR_EUSE.ttcn: remove redundant code from f_main_mo()

2018-11-04 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11578 ) Change subject: hlr/HLR_EUSE.ttcn: remove redundant code from f_main_mo() .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-bsc[master]: RSL: restructure MDCX functions

2018-11-04 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11550 ) Change subject: RSL: restructure MDCX functions .. Patch Set 3: Code-Review-1 (5 comments)

Change in osmo-bsc[master]: LCLS: move MGCP MDCX into separate function

2018-11-04 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11564 ) Change subject: LCLS: move MGCP MDCX into separate function .. Patch Set 1: Code-Review+2 (1 comment)

Change in osmo-bsc[master]: LCLS: explicitly check for mode before closing the loop

2018-11-04 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11565 ) Change subject: LCLS: explicitly check for mode before closing the loop .. Patch Set 1: Code-Review-1 (5 comments)

Change in osmo-bsc[master]: LCLS: move mode check into separate function

2018-11-04 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11551 ) Change subject: LCLS: move mode check into separate function .. Patch Set 3: Code-Review-1 (2 comments)

Change in osmo-dev[master]: deps: osmo-sgsn depends on osmo-hlr's liboso-gsup-client

2018-11-04 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11537 ) Change subject: deps: osmo-sgsn depends on osmo-hlr's liboso-gsup-client .. Patch Set 3: Code-Review+2 -- To view, visit

Change in osmo-dev[master]: deps: osmo-sgsn depends on osmo-hlr's liboso-gsup-client

2018-11-04 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11537 ) Change subject: deps: osmo-sgsn depends on osmo-hlr's liboso-gsup-client .. Patch Set 3: Verified+1 -- To view, visit

Change in osmo-dev[master]: deps: osmo-sgsn depends on osmo-hlr's liboso-gsup-client

2018-11-04 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/11537 ) Change subject: deps: osmo-sgsn depends on osmo-hlr's liboso-gsup-client .. deps: osmo-sgsn depends on osmo-hlr's

Change in osmo-ci[master]: jobs: ttcn3-testsuites.yml for ttcn3/nplab jobs

2018-11-04 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11370 ) Change subject: jobs: ttcn3-testsuites.yml for ttcn3/nplab jobs .. Patch Set 4: Code-Review+2 if you're not overwriting the manual jobs,

Change in osmo-ci[master]: misc: Install patchelf to add/set an rpath if wanted

2018-11-04 Thread Holger Freyther
Holger Freyther has uploaded this change for review. ( https://gerrit.osmocom.org/11579 Change subject: misc: Install patchelf to add/set an rpath if wanted .. misc: Install patchelf to add/set an rpath if wanted Change-Id:

Change in osmo-bsc[master]: LCLS: add bts-loop variant

2018-11-04 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11552 ) Change subject: LCLS: add bts-loop variant .. Patch Set 3: Code-Review-1 (8 comments)

Change in libosmocore[master]: Update 3GPP TS 08.08 Cause handling

2018-11-04 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11577 ) Change subject: Update 3GPP TS 08.08 Cause handling .. Patch Set 2: Code-Review-1 (7 comments)

Change in libosmocore[master]: Update 3GPP TS 08.08 Cause handling

2018-11-04 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11577 ) Change subject: Update 3GPP TS 08.08 Cause handling .. Patch Set 2: (I took the liberty to remove the +2 vote even though it wasn't mine,

Change in libosmocore[master]: Update 3GPP TS 08.08 Cause handling

2018-11-04 Thread Neels Hofmeyr
Neels Hofmeyr has removed a vote on this change. Change subject: Update 3GPP TS 08.08 Cause handling .. Removed Code-Review+2 by Harald Welte -- To view, visit https://gerrit.osmocom.org/11577 To unsubscribe, or for help

Change in osmo-msc[master]: Update VLR test helper

2018-11-04 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11458 ) Change subject: Update VLR test helper .. Patch Set 1: Code-Review-1 (1 comment) not sure why, but if you merge please fix the commit

Change in osmo-msc[master]: Update VLR test helper

2018-11-04 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11458 ) Change subject: Update VLR test helper .. Patch Set 1: hrm, why is a -1 vote hidden by a +2? I'd at least want to see the author that

Change in osmo-pcu[master]: Move EGPRS WS computation to C code

2018-11-04 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/6241 ) Change subject: Move EGPRS WS computation to C code .. Patch Set 4: Code-Review-1 (2 comments)

Change in osmo-ttcn3-hacks[master]: LCLS: explicitly check for *CX adjustment

2018-11-04 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11558 ) Change subject: LCLS: explicitly check for *CX adjustment .. Patch Set 2: (1 comment)

Change in osmo-ttcn3-hacks[master]: BSC LCLS: add bts-loop tests

2018-11-04 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11559 ) Change subject: BSC LCLS: add bts-loop tests .. Patch Set 3: just a general idea ... when I refactored osmo-bsc's FSMs, I managed to

Change in docker-playground[master]: ttcn3-bts-test: Log RACH requests in GSMTAP

2018-11-04 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11567 ) Change subject: ttcn3-bts-test: Log RACH requests in GSMTAP .. Patch Set 1: Code-Review+2 -- To view, visit

Change in docker-playground[master]: ttcn3-bts-test: Log RACH requests in GSMTAP

2018-11-04 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11567 ) Change subject: ttcn3-bts-test: Log RACH requests in GSMTAP .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-gsm-tester[master]: Introduce iperf3 testing infrastructure

2018-11-04 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11476 ) Change subject: Introduce iperf3 testing infrastructure .. Patch Set 3: Code-Review+2 I have no idea what this is doing but it looks like

Change in osmo-dev[master]: replace src/* git scripts with a single src/gits

2018-11-04 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11560 ) Change subject: replace src/* git scripts with a single src/gits .. Patch Set 4: osmith, if you're reading this -- I'm counting on your

Change in osmo-sip-connector[master]: configure.ac: add --enable-sanitize

2018-11-04 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/11592 Change subject: configure.ac: add --enable-sanitize .. configure.ac: add --enable-sanitize Add --enable-sanitize to ./configure, as a

Change in osmo-dev[master]: sanitize.opts: add --enable-sanitize to ALL builds

2018-11-04 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/11593 Change subject: sanitize.opts: add --enable-sanitize to ALL builds .. sanitize.opts: add --enable-sanitize to ALL builds Actually, add it

Change in osmo-sip-connector[master]: configure.ac: add --enable-sanitize

2018-11-04 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11592 ) Change subject: configure.ac: add --enable-sanitize .. Patch Set 1: Code-Review+1 (1 comment)

Change in osmo-ttcn3-hacks[master]: hlr/HLR_EUSE.ttcn: remove redundant code from f_main_mo()

2018-11-04 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/11578 ) Change subject: hlr/HLR_EUSE.ttcn: remove redundant code from f_main_mo() .. hlr/HLR_EUSE.ttcn: remove redundant code from

Change in osmocom-bb[master]: l1ctl_proto.h: use flexible array member for traffic messages

2018-11-04 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/11395 ) Change subject: l1ctl_proto.h: use flexible array member for traffic messages .. l1ctl_proto.h: use flexible array member for