Change in osmo-gsm-tester[master]: srs_enb: enable console trace, use RemoteProcess class and fix params

2020-03-30 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17587 ) Change subject: srs_enb: enable console trace, use RemoteProcess class and fix params .. srs_enb: enable console trace, use

Change in osmo-pcu[master]: Move gsm_rlcmac.cpp -> .c

2020-03-30 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17627 ) Change subject: Move gsm_rlcmac.cpp -> .c .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-pcu[master]: gsm_rlcmac: Disable unused CSN1 descriptors

2020-03-30 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17626 ) Change subject: gsm_rlcmac: Disable unused CSN1 descriptors .. Patch Set 2: Code-Review+1 -- To view, visit

Change in osmo-pcu[master]: direct-phy: fix handle_ph_ra_ind(): handle PH-RA.ind on PRACH SAPI

2020-03-30 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17669 ) Change subject: direct-phy: fix handle_ph_ra_ind(): handle PH-RA.ind on PRACH SAPI .. direct-phy: fix handle_ph_ra_ind(): handle

Change in osmo-pcu[master]: Move gsm_rlcmac.cpp -> .c

2020-03-30 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17627 ) Change subject: Move gsm_rlcmac.cpp -> .c .. Move gsm_rlcmac.cpp -> .c Original file from wireshark.git (packet-gsm_csn1.c) is being built

Change in osmo-ttcn3-hacks[master]: BTS: fix as_l1_count_paging(): use ispresent() instead of isvalue()

2020-03-30 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17655 ) Change subject: BTS: fix as_l1_count_paging(): use ispresent() instead of isvalue() .. Patch Set 1: Code-Review+2 -- To

Change in osmo-pcu[master]: rlcmac: support decode FDD_CELL_INFORMATION of "UTRAN FDD Description

2020-03-30 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17628 ) Change subject: rlcmac: support decode FDD_CELL_INFORMATION of "UTRAN FDD Description .. rlcmac: support decode FDD_CELL_INFORMATION of

Change in osmo-pcu[master]: csn1: Remove code block from CSN_NEXT_EXIST_LH

2020-03-30 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17633 ) Change subject: csn1: Remove code block from CSN_NEXT_EXIST_LH .. csn1: Remove code block from CSN_NEXT_EXIST_LH It was removed in

Change in osmo-pcu[master]: rlcmac: add dissection of 2G->3G/4G PS handover

2020-03-30 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17629 ) Change subject: rlcmac: add dissection of 2G->3G/4G PS handover .. Patch Set 3: Code-Review+2 -- To view, visit

Change in osmo-pcu[master]: gsm_rlcmac: Disable unused CSN1 descriptors

2020-03-30 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17626 ) Change subject: gsm_rlcmac: Disable unused CSN1 descriptors .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-pcu[master]: gsm_rlcmac: Disable unused CSN1 descriptors

2020-03-30 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17626 ) Change subject: gsm_rlcmac: Disable unused CSN1 descriptors .. gsm_rlcmac: Disable unused CSN1 descriptors When switching to C compiler, it

Change in osmo-pcu[master]: csn1: Fix Several typos & whitespace

2020-03-30 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17630 ) Change subject: csn1: Fix Several typos & whitespace .. csn1: Fix Several typos & whitespace Change-Id:

Change in osmo-pcu[master]: csn1: verify enough bits present to decode whole CSN_UINT_ARRAY

2020-03-30 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17631 ) Change subject: csn1: verify enough bits present to decode whole CSN_UINT_ARRAY .. csn1: verify enough bits present to decode whole

Change in osmo-pcu[master]: csn1: Properly verify CSN_BITMAP length

2020-03-30 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17632 ) Change subject: csn1: Properly verify CSN_BITMAP length .. csn1: Properly verify CSN_BITMAP length Change-Id:

Change in osmo-ttcn3-hacks[master]: library/L3_Templates: remove tr_PAGING_REQ1_MI1_TMSI, use existing MI...

2020-03-30 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17656 ) Change subject: library/L3_Templates: remove tr_PAGING_REQ1_MI1_TMSI, use existing MI templates .. library/L3_Templates: remove

Change in osmo-ttcn3-hacks[master]: library/L3_Templates: remove tr_PAGING_REQ1_MI1_TMSI, use existing MI...

2020-03-30 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17656 ) Change subject: library/L3_Templates: remove tr_PAGING_REQ1_MI1_TMSI, use existing MI templates .. Patch Set 1:

Change in osmo-ttcn3-hacks[master]: BTS: fix as_l1_count_paging(): use ispresent() instead of isvalue()

2020-03-30 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17655 ) Change subject: BTS: fix as_l1_count_paging(): use ispresent() instead of isvalue() .. BTS: fix as_l1_count_paging(): use ispresent()

Change in osmo-pcu[master]: rlcmac: add dissection of 2G->3G/4G PS handover

2020-03-30 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17629 ) Change subject: rlcmac: add dissection of 2G->3G/4G PS handover .. rlcmac: add dissection of 2G->3G/4G PS handover Port from wireshark.git

Change in osmo-pcu[master]: rlcmac: support decode FDD_CELL_INFORMATION of "UTRAN FDD Description

2020-03-30 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17628 ) Change subject: rlcmac: support decode FDD_CELL_INFORMATION of "UTRAN FDD Description .. Patch Set 3: Code-Review+2 -- To view,

Change in pysim[master]: Move parsing of HPLMNAcT to generic Card class

2020-03-30 Thread herlesupreeth
herlesupreeth has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/17663 ) Change subject: Move parsing of HPLMNAcT to generic Card class .. Move parsing of HPLMNAcT to generic Card class Change-Id:

Change in pysim[master]: Move parsing of MSISDN to generic Card class

2020-03-30 Thread herlesupreeth
herlesupreeth has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/17665 ) Change subject: Move parsing of MSISDN to generic Card class .. Move parsing of MSISDN to generic Card class Change-Id:

Change in pysim[master]: Move parsing of AD to generic Card class

2020-03-30 Thread herlesupreeth
herlesupreeth has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/17666 ) Change subject: Move parsing of AD to generic Card class .. Move parsing of AD to generic Card class Change-Id:

Change in pysim[master]: Move parsing of PLMNwAcT to generic Card class

2020-03-30 Thread herlesupreeth
herlesupreeth has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/17661 ) Change subject: Move parsing of PLMNwAcT to generic Card class .. Move parsing of PLMNwAcT to generic Card class Change-Id:

Change in pysim[master]: Move parsing of OPLMNwAcT to generic Card class

2020-03-30 Thread herlesupreeth
herlesupreeth has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/17662 ) Change subject: Move parsing of OPLMNwAcT to generic Card class .. Move parsing of OPLMNwAcT to generic Card class Change-Id:

Change in pysim[master]: Move parsing of SMSP to generic Card class

2020-03-30 Thread herlesupreeth
herlesupreeth has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/17658 ) Change subject: Move parsing of SMSP to generic Card class .. Move parsing of SMSP to generic Card class Change-Id:

Change in pysim[master]: utils.py: Add helper method to parse Service Table

2020-03-30 Thread herlesupreeth
herlesupreeth has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/17668 ) Change subject: utils.py: Add helper method to parse Service Table .. utils.py: Add helper method to parse Service Table This

Change in pysim[master]: Define mapping between SIM Service Number and its description

2020-03-30 Thread herlesupreeth
herlesupreeth has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/17667 ) Change subject: Define mapping between SIM Service Number and its description .. Define mapping between SIM Service Number and

Change in pysim[master]: Move parsing of PLMNsel to generic Card class

2020-03-30 Thread herlesupreeth
herlesupreeth has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/17660 ) Change subject: Move parsing of PLMNsel to generic Card class .. Move parsing of PLMNsel to generic Card class Change-Id:

Change in pysim[master]: Move parsing of GID2 to generic Card class

2020-03-30 Thread herlesupreeth
herlesupreeth has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/17657 ) Change subject: Move parsing of GID2 to generic Card class .. Move parsing of GID2 to generic Card class Change-Id:

Change in pysim[master]: Move parsing of GID2 to generic Card class

2020-03-30 Thread laforge
laforge has removed a vote from this change. ( https://gerrit.osmocom.org/c/pysim/+/17657 ) Change subject: Move parsing of GID2 to generic Card class .. Removed Code-Review+2 by laforge -- To view, visit

Change in pysim[master]: Move parsing of PLMNsel to generic Card class

2020-03-30 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/17660 ) Change subject: Move parsing of PLMNsel to generic Card class .. Patch Set 1: (1 comment)

Change in osmo-pcu[master]: direct-phy: fix handle_ph_ra_ind(): handle PH-RA.ind on PRACH SAPI

2020-03-30 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17669 ) Change subject: direct-phy: fix handle_ph_ra_ind(): handle PH-RA.ind on PRACH SAPI .. Patch Set 1: > Patch Set 1: > > The question

Change in pysim[master]: Move parsing of ACC to generic Card class

2020-03-30 Thread herlesupreeth
herlesupreeth has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/17664 ) Change subject: Move parsing of ACC to generic Card class .. Move parsing of ACC to generic Card class Change-Id:

Change in pysim[master]: pySim-read.py: Use the method declared in cards.py to read SPN

2020-03-30 Thread herlesupreeth
herlesupreeth has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/17659 ) Change subject: pySim-read.py: Use the method declared in cards.py to read SPN .. pySim-read.py: Use the method declared in

Change in osmo-pcu[master]: direct-phy: fix handle_ph_ra_ind(): handle PH-RA.ind on PRACH SAPI

2020-03-30 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17669 ) Change subject: direct-phy: fix handle_ph_ra_ind(): handle PH-RA.ind on PRACH SAPI .. Patch Set 1: The question is whether the RA

Change in osmo-ttcn3-hacks[master]: BTS: fix as_l1_count_paging(): use ispresent() instead of isvalue()

2020-03-30 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17655 ) Change subject: BTS: fix as_l1_count_paging(): use ispresent() instead of isvalue() .. BTS: fix as_l1_count_paging(): use

Change in osmo-ttcn3-hacks[master]: library/L3_Templates: remove tr_PAGING_REQ1_MI1_TMSI, use existing MI...

2020-03-30 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17656 ) Change subject: library/L3_Templates: remove tr_PAGING_REQ1_MI1_TMSI, use existing MI templates .. library/L3_Templates:

Change in pysim[master]: Move parsing of SMSP to generic Card class

2020-03-30 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/17658 ) Change subject: Move parsing of SMSP to generic Card class .. Patch Set 1: -Code-Review (1 comment)

Change in pysim[master]: Move parsing of GID2 to generic Card class

2020-03-30 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/17657 ) Change subject: Move parsing of GID2 to generic Card class .. Patch Set 1: (1 comment)

Change in pysim[master]: utils.py: Add helper method to parse Service Table

2020-03-30 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/17668 ) Change subject: utils.py: Add helper method to parse Service Table .. Patch Set 1: Code-Review+1 -- To view, visit

Change in pysim[master]: Move parsing of PLMNwAcT to generic Card class

2020-03-30 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/17661 ) Change subject: Move parsing of PLMNwAcT to generic Card class .. Patch Set 1: (1 comment)

Change in pysim[master]: Define mapping between SIM Service Number and its description

2020-03-30 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/17667 ) Change subject: Define mapping between SIM Service Number and its description .. Patch Set 1: Code-Review+1 -- To view, visit

Change in pysim[master]: Move parsing of GID2 to generic Card class

2020-03-30 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/17657 ) Change subject: Move parsing of GID2 to generic Card class .. Patch Set 1: Code-Review+2 -- To view, visit

Change in pysim[master]: Move parsing of SMSP to generic Card class

2020-03-30 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/17658 ) Change subject: Move parsing of SMSP to generic Card class .. Patch Set 1: Code-Review+2 -- To view, visit

Change in pysim[master]: pySim-read.py: Use the method declared in cards.py to read SPN

2020-03-30 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/17659 ) Change subject: pySim-read.py: Use the method declared in cards.py to read SPN .. Patch Set 1: Code-Review+2 -- To view, visit

Change in libosmocore[master]: tests/coding: check return value of encoding / decoding functions

2020-03-30 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/17670 ) Change subject: tests/coding: check return value of encoding / decoding functions .. tests/coding: check return value of

Change in libosmocore[master]: coding: fix documentation of PDTCH encoding functions

2020-03-30 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/17672 ) Change subject: coding: fix documentation of PDTCH encoding functions .. coding: fix documentation of PDTCH encoding functions

Change in libosmocore[master]: tests/coding: reduce verbosity of 8-bit / 11-bit RACH coding tests

2020-03-30 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/17671 ) Change subject: tests/coding: reduce verbosity of 8-bit / 11-bit RACH coding tests .. tests/coding: reduce verbosity of 8-bit /

Change in libosmocore[master]: tests/coding: reduce verbosity of 8-bit / 11-bit RACH coding tests

2020-03-30 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/17671 ) Change subject: tests/coding: reduce verbosity of 8-bit / 11-bit RACH coding tests .. Patch Set 1: Code-Review+1 -- To view,

Change in libosmocore[master]: coding: fix documentation of PDTCH encoding functions

2020-03-30 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/17672 ) Change subject: coding: fix documentation of PDTCH encoding functions .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmocom-bb[master]: trx_toolkit/trx_sniff.py: pass the whole msg to burst_pass_filter()

2020-03-30 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/17673 ) Change subject: trx_toolkit/trx_sniff.py: pass the whole msg to burst_pass_filter() .. trx_toolkit/trx_sniff.py: pass the whole

Change in osmocom-bb[master]: trx_toolkit/trx_sniff.py: add option to ignore NOPE / IDLE indications

2020-03-30 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/17674 ) Change subject: trx_toolkit/trx_sniff.py: add option to ignore NOPE / IDLE indications .. trx_toolkit/trx_sniff.py: add option

Change in osmocom-bb[master]: trx_toolkit/trx_sniff.py: add options to filter bursts by RSSI

2020-03-30 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/17675 ) Change subject: trx_toolkit/trx_sniff.py: add options to filter bursts by RSSI .. trx_toolkit/trx_sniff.py: add options to filter

Change in osmocom-bb[master]: trx_toolkit/trx_sniff.py: add option to ignore NOPE / IDLE indications

2020-03-30 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/17674 ) Change subject: trx_toolkit/trx_sniff.py: add option to ignore NOPE / IDLE indications .. Patch Set 1: Code-Review+1 -- To view,

Change in osmocom-bb[master]: trx_toolkit/trx_sniff.py: add options to filter bursts by RSSI

2020-03-30 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/17675 ) Change subject: trx_toolkit/trx_sniff.py: add options to filter bursts by RSSI .. Patch Set 1: Code-Review+1 -- To view, visit

Change in libosmocore[master]: tests/coding: reduce verbosity of 8-bit / 11-bit RACH coding tests

2020-03-30 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/17671 ) Change subject: tests/coding: reduce verbosity of 8-bit / 11-bit RACH coding tests .. Patch Set 1: Code-Review+2 -- To view,

Change in libosmocore[master]: tests/coding: check return value of encoding / decoding functions

2020-03-30 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/17670 ) Change subject: tests/coding: check return value of encoding / decoding functions .. Patch Set 1: (1 comment)

Change in osmocom-bb[master]: trx_toolkit/trx_sniff.py: pass the whole msg to burst_pass_filter()

2020-03-30 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/17673 ) Change subject: trx_toolkit/trx_sniff.py: pass the whole msg to burst_pass_filter() .. Patch Set 1: Code-Review+1 -- To view,

Change in osmo-msc[master]: manual: link to new common cs7-config.adoc, remove some dup of that

2020-03-30 Thread neels
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/17580 to look at the new patch set (#2). Change subject: manual: link to new common cs7-config.adoc, remove some dup of that

Change in docker-playground[master]: update OBS Release.key; the old one expired today.

2020-03-30 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/17678 ) Change subject: update OBS Release.key; the old one expired today. .. Patch Set 1: Verified+1 -- To view, visit

Change in docker-playground[master]: update OBS Release.key; the old one expired today.

2020-03-30 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/17678 ) Change subject: update OBS Release.key; the old one expired today. .. Patch Set 1: Code-Review+2 -- To view, visit

Change in docker-playground[master]: update OBS Release.key; the old one expired today.

2020-03-30 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/17678 ) Change subject: update OBS Release.key; the old one expired today. .. Patch Set 1: I don't know if it's the case already,

Change in osmo-sgsn[master]: manual: explain IuPS, add SCCP/M3UA section from common chapters

2020-03-30 Thread neels
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/17507 to look at the new patch set (#2). Change subject: manual: explain IuPS, add SCCP/M3UA section from common chapters

Change in osmo-iuh[master]: manual: add "Configuring Primary Links" and "Multiple instances"

2020-03-30 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/17505 ) Change subject: manual: add "Configuring Primary Links" and "Multiple instances" .. Patch Set 3: Code-Review+1 -- To view, visit

Change in osmo-sgsn[master]: manual: explain IuPS, add SCCP/M3UA section from common chapters

2020-03-30 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/17507 ) Change subject: manual: explain IuPS, add SCCP/M3UA section from common chapters .. Patch Set 2: Code-Review+1 -- To view, visit

Change in osmo-sgsn[master]: gsup: send RAT type on LU

2020-03-30 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/16745 ) Change subject: gsup: send RAT type on LU .. Patch Set 1: That's weird -- in my memory I looked for anything in 29.002 reflecting

Change in docker-playground[master]: ttcn3-bsc-test: Enable CBSP tests

2020-03-30 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/17677 ) Change subject: ttcn3-bsc-test: Enable CBSP tests .. ttcn3-bsc-test: Enable CBSP tests for some strange reason, the tests

Change in osmo-bsc[master]: manual: add "Multiple Instances" section, akin to other manuals

2020-03-30 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/17503 ) Change subject: manual: add "Multiple Instances" section, akin to other manuals .. Patch Set 5: (1 comment)

Change in osmo-bsc[master]: manual: add SCCP/M3UA section from common chapters

2020-03-30 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/17504 ) Change subject: manual: add SCCP/M3UA section from common chapters .. Patch Set 6: Code-Review+2 combining earlier +1 -- To view,

Change in osmo-msc[master]: manual: link to new common cs7-config.adoc, remove some dup of that

2020-03-30 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/17580 ) Change subject: manual: link to new common cs7-config.adoc, remove some dup of that .. Patch Set 2: (1 comment)

Change in osmo-iuh[master]: manual: link to new common cs7-config.adoc

2020-03-30 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/17506 ) Change subject: manual: link to new common cs7-config.adoc .. Patch Set 3: Code-Review+2 -- To view, visit

Change in osmocom-bb[master]: mobile: add audio config, with unused audio loopback setting

2020-03-30 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/17593 ) Change subject: mobile: add audio config, with unused audio loopback setting .. Patch Set 2: Code-Review-1 (3 comments)

Change in docker-playground[master]: ttcn3-bsc-test: Enable CBSP tests

2020-03-30 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/17677 ) Change subject: ttcn3-bsc-test: Enable CBSP tests .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-bsc[master]: manual: add SCCPlite section

2020-03-30 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/17532 ) Change subject: manual: add SCCPlite section .. Patch Set 4: Code-Review+2 -- To view, visit

Change in osmo-bsc[master]: manual: add SCCP/M3UA section from common chapters

2020-03-30 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/17504 ) Change subject: manual: add SCCP/M3UA section from common chapters .. manual: add SCCP/M3UA section from common chapters Link to the

Change in osmo-bsc[master]: manual: add SCCPlite section

2020-03-30 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/17532 ) Change subject: manual: add SCCPlite section .. manual: add SCCPlite section Change-Id: I8eddc47353d6afd756865321a9e97f6cee4ce2d7 --- M

Change in osmo-iuh[master]: manual: add "Configuring Primary Links" and "Multiple instances"

2020-03-30 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/17505 ) Change subject: manual: add "Configuring Primary Links" and "Multiple instances" .. Patch Set 3: (1 comment)

Change in osmo-ci[master]: update OBS Release.key; the old one expired today.

2020-03-30 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/17679 ) Change subject: update OBS Release.key; the old one expired today. .. update OBS Release.key; the old one expired today. Change-Id:

Change in osmo-ci[master]: update OBS Release.key; the old one expired today.

2020-03-30 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/17679 ) Change subject: update OBS Release.key; the old one expired today. .. Patch Set 1: Verified+1 Code-Review+2 -- To view, visit

Change in osmo-msc[master]: manual: link to new common cs7-config.adoc, remove some dup of that

2020-03-30 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/17580 ) Change subject: manual: link to new common cs7-config.adoc, remove some dup of that .. Patch Set 2: (1 comment)

Change in osmo-sgsn[master]: manual: explain IuPS, add SCCP/M3UA section from common chapters

2020-03-30 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/17507 ) Change subject: manual: explain IuPS, add SCCP/M3UA section from common chapters .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: mgw: use library version of RTP_CodecPort_CtrlFunct

2020-03-30 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17680 ) Change subject: mgw: use library version of RTP_CodecPort_CtrlFunct .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmocom-bb[master]: mobile: loopback voice frames

2020-03-30 Thread neels
neels has removed a vote from this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/17381 ) Change subject: mobile: loopback voice frames .. Removed Code-Review-1 by laforge -- To view, visit

Change in libosmocore[master]: coding: fix documentation of PDTCH encoding functions

2020-03-30 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/17672 ) Change subject: coding: fix documentation of PDTCH encoding functions .. Patch Set 1: (1 comment)

Change in osmo-msc[master]: manual: add missing mention of MGCP in "Multiple instances"

2020-03-30 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/17579 ) Change subject: manual: add missing mention of MGCP in "Multiple instances" .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ci[master]: update OBS Release.key; the old one expired today.

2020-03-30 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/17679 ) Change subject: update OBS Release.key; the old one expired today. .. update OBS Release.key; the old one expired today. Change-Id:

Change in osmocom-bb[master]: mobile: loopback voice frames

2020-03-30 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/17381 ) Change subject: mobile: loopback voice frames .. Patch Set 4: > Patch Set 4: Code-Review-1 > > should be configurable It is

Change in osmo-ttcn3-hacks[master]: Initial SIMTRACE testsuite

2020-03-30 Thread laforge
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17676 to look at the new patch set (#2). Change subject: Initial SIMTRACE testsuite .. Initial

Change in osmo-iuh[master]: manual: add "Configuring Primary Links" and "Multiple instances"

2020-03-30 Thread neels
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-iuh/+/17505 to look at the new patch set (#3). Change subject: manual: add "Configuring Primary Links" and "Multiple instances"

Change in osmo-iuh[master]: manual: link to new common cs7-config.adoc

2020-03-30 Thread neels
Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-iuh/+/17506 to look at the new patch set (#3). Change subject: manual: link to new common cs7-config.adoc

Change in osmo-iuh[master]: manual: add "Configuring Primary Links" and "Multiple instances"

2020-03-30 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/17505 ) Change subject: manual: add "Configuring Primary Links" and "Multiple instances" .. Patch Set 3: (1 comment)

Change in osmo-iuh[master]: manual: link to new common cs7-config.adoc

2020-03-30 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/17506 ) Change subject: manual: link to new common cs7-config.adoc .. Patch Set 3: Code-Review+1 -- To view, visit

Change in osmo-ttcn3-hacks[master]: mgw: use library version of RTP_CodecPort_CtrlFunct

2020-03-30 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17680 ) Change subject: mgw: use library version of RTP_CodecPort_CtrlFunct .. mgw: use library version of RTP_CodecPort_CtrlFunct

Change in osmo-ttcn3-hacks[master]: bts: Add RTP payload testing to performance tests

2020-03-30 Thread dexter
Hello pespin, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17285 to look at the new patch set (#3). Change subject: bts: Add RTP payload testing to performance tests

Change in osmocom-bb[master]: mobile: loopback voice frames

2020-03-30 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/17381 ) Change subject: mobile: loopback voice frames .. Patch Set 4: let me remove the -1 since it is misleading... -- To view, visit

Change in osmo-ttcn3-hacks[master]: bts: Add RTP payload testing to performance tests

2020-03-30 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17285 ) Change subject: bts: Add RTP payload testing to performance tests .. Patch Set 3: Code-Review-1 (3 comments)

Change in osmocom-bb[master]: mobile: loopback voice frames

2020-03-30 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/17381 ) Change subject: mobile: loopback voice frames .. Patch Set 4: OK, back to my original opinion: the msgb_pull and msgb_push are very

Change in docker-playground[master]: ttcn3-bsc-test: Enable CBSP tests

2020-03-30 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/17677 ) Change subject: ttcn3-bsc-test: Enable CBSP tests .. Patch Set 4: Verified+1 Code-Review+2 -- To view, visit

Change in docker-playground[master]: ttcn3-bsc-test: Enable CBSP tests

2020-03-30 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/17677 ) Change subject: ttcn3-bsc-test: Enable CBSP tests .. ttcn3-bsc-test: Enable CBSP tests for some strange reason, the tests developed

Change in docker-playground[master]: ttcn3-bsc-test: Enable CBSP tests

2020-03-30 Thread laforge
Hello pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/17677 to look at the new patch set (#4). Change subject: ttcn3-bsc-test: Enable CBSP tests .. ttcn3-bsc-test:

  1   2   >