Pau Espin Pedrol has submitted this change and it was merged.
Change subject: bts_osmo.py: ready_for_pcu is of public access from tests, move
it accordingly
..
bts_osmo.py: ready_for_pcu is of public access from tests, move it
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/#/c/7159/3/src/osmo_gsm_tester/bts_osmo.py
File src/osmo_gsm_tester/bts_osmo.py:
Line 80: def ready_for_pcu(self):
> I still disagree and believe non-public member functions should have leadin
ready_for_pcu is public so it's fine if it doe
Patch Set 5: Code-Review+2
(1 comment)
https://gerrit.osmocom.org/#/c/7159/3/src/osmo_gsm_tester/bts_osmo.py
File src/osmo_gsm_tester/bts_osmo.py:
Line 80: def ready_for_pcu(self):
> This change improves legibility of the code by correctly sorting the file f
I still disagree and believe non
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/#/c/7159/3/src/osmo_gsm_tester/bts_osmo.py
File src/osmo_gsm_tester/bts_osmo.py:
Line 80: def ready_for_pcu(self):
> from a python doc point of view, nothing has changed at all. If a function
This change improves legibility of the code by
Patch Set 3: Code-Review+1
(1 comment)
if you must, but...
https://gerrit.osmocom.org/#/c/7159/3/src/osmo_gsm_tester/bts_osmo.py
File src/osmo_gsm_tester/bts_osmo.py:
Line 80: def ready_for_pcu(self):
from a python doc point of view, nothing has changed at all. If a function is
considered
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/7159
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8978854404897ae5de7e3100d55d86c7a5c1df1
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/7159
bts_osmo.py: ready_for_pcu is of public access from tests, move it accordingly
Change-Id: Ie8978854404897ae5de7e3100d55d86c7a5c1df1
---
M src/osmo_gsm_tester/bts_osmo.py
1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.osmocom.o
