Harald Welte has submitted this change and it was merged.
Change subject: mcgp: let the MGW allocate the MGCP endpoint
..
mcgp: let the MGW allocate the MGCP endpoint
osmo-msc still uses endpoints that are allocated locally by
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6319
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee3e446b6689626516f01c521abe3d4603cd3e13
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Patch Set 2: Code-Review-1
I would love to merge this, but without an updsate to the tests its not
possible to merge.
--
To view, visit https://gerrit.osmocom.org/6319
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/6319/2/src/libmsc/msc_mgcp.c
File src/libmsc/msc_mgcp.c:
Line 252: MGCP_ENDPOINT_MAXLEN) {
While this code is correct because sizeof(mgcp_msg.endpoint) and
MGCP_ENDPOINT_MAXLEN have the same value, I would stick to the idiom:
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6319
to look at the new patch set (#2).
mcgp: let the MGW allocate the MGCP endpoint
osmo-msc still uses endpoints that are allocated locally by the
MGCP-Client. Since osmo-mgw now supports
Patch Set 1:
(3 comments)
https://gerrit.osmocom.org/#/c/6319/1//COMMIT_MSG
Commit Message:
Line 18: OS#2710
in order to be easily picked up by robots, please put this on the same line.
Also drop the blank line between this and the Change-Id.
Patch Set 1:
(5 comments)
https://gerrit.osmocom.org/#/c/6319/1/src/libmsc/msc_mgcp.c
File src/libmsc/msc_mgcp.c:
Line 240: osmo_strlcpy(mgcp_msg.endpoint, mgcp_ctx->rtp_endpoint,
sizeof(mgcp_msg.endpoint));
This change removes a check for truncation. Is this intended?
You could keep
Patch Set 1:
> do we have a TTCN-3 test case for this in OsmoMSC yet, so we can
> make sure the feature works as expected? If not, please provide
> one (or indicate what is missing in terms of infrastructure to
> write one).
There is no test for this yet. If we apply the patch we possibly
Patch Set 1:
do we have a TTCN-3 test case for this in OsmoMSC yet, so we can make sure the
feature works as expected? If not, please provide one (or indicate what is
missing in terms of infrastructure to write one).
--
To view, visit https://gerrit.osmocom.org/6319
To unsubscribe, visit
Review at https://gerrit.osmocom.org/6319
mcgp: let the MGW allocate the MGCP endpoint
osmo-msc still uses endpoints that are allocated locally by the
MGCP-Client. Since osmo-mgw now supports the more comfortable,
dynamic variant we should make use of it.
- Replace the endpoint numer
10 matches
Mail list logo
