Re: [PATCH] Output AAC as M4A for iTunes with metadata tags (Shevek)

2011-03-31 Thread Shevek
On 31 March 2011 14:35, richard rich...@richsim900.plus.com wrote: Sorry to spoil things, but the patch to ffmpeg has not solved the problem with my Marantz CD6003. These are the tests I've done. I am also finding the new version of ffmpeg doesn't work with iTunes - it reports an incorrect

Re: [PATCH] Output AAC as M4A for iTunes with metadata tags (Shevek)

2011-03-31 Thread Shevek
On 31 March 2011 14:55, Nick Ludlam n...@recoil.org wrote: On 31 Mar 2011, at 14:43, Shevek wrote: On 31 March 2011 14:35, richard rich...@richsim900.plus.com wrote: Sorry to spoil things, but the patch to ffmpeg has not solved the problem with my Marantz CD6003. These are the tests I've

Re: [PATCH] Output AAC as M4A for iTunes with metadata tags (Shevek)

2011-03-31 Thread Jon Davies
On 31 March 2011 14:35, richard rich...@richsim900.plus.com wrote: Sorry to spoil things, but the patch to ffmpeg has not solved the problem with my Marantz CD6003. These are the tests I've done. ...snip We seem to have established that ffmpeg isn't generating entirely valid mpeg4 files, I

Re: [PATCH] Output AAC as M4A for iTunes with metadata tags (Shevek)

2011-03-31 Thread Shevek
On 31 March 2011 15:34, Jon Davies j...@hedgerows.org.uk wrote: On 31 March 2011 14:35, richard rich...@richsim900.plus.com wrote: Sorry to spoil things, but the patch to ffmpeg has not solved the problem with my Marantz CD6003. These are the tests I've done. ...snip We seem to have

Re: [PATCH] Output AAC as M4A for iTunes with metadata tags (Shevek)

2011-03-31 Thread dinkypumpkin
On 31 Mar 2011, at 16:01, Shevek wrote: This is possibly a stupid question, but can ffmpeg pipe to itself to do both things separately but in one command? This worked for me: ffmpeg -i test.flv -vn -acodec copy -f adts - | ffmpeg -i - -vn -acodec copy -absf aac_adtstoasc -y test.m4a I

RE: [PATCH] Output AAC as M4A for iTunes with metadata tags (Shevek)

2011-03-31 Thread bat guano
Subject: [PATCH] Output AAC as M4A for iTunes with metadata tags (Shevek) From: rich...@richsim900.plus.com To: get_iplayer@lists.infradead.org Date: Thu, 31 Mar 2011 14:35:54 +0100 Sorry to spoil things, but the patch to ffmpeg has not solved the

Re: [PATCH] Output AAC as M4A for iTunes with metadata tags (Shevek)

2011-03-31 Thread Shevek
On 31 March 2011 16:21, dinkypumpkin dinkypump...@gmail.com wrote: On 31 Mar 2011, at 16:01, Shevek wrote: This is possibly a stupid question, but can ffmpeg pipe to itself to do both things separately but in one command? This worked for me: ffmpeg -i test.flv -vn -acodec copy -f adts - |

Re: [PATCH] Output AAC as M4A for iTunes with metadata tags (Shevek)

2011-03-31 Thread Roger Burton West
On Thu, Mar 31, 2011 at 08:22:26PM +0100, Shevek wrote: What am I doing wrong? You can't use shell functions (such as pipe) with the list-form invocation of system(). Easiest option (though it's vulnerable to shellmetas showing up in filenames) is probably to do it all in one string: set $cmd

Re: [PATCH] Output AAC as M4A for iTunes with metadata tags (Shevek)

2011-03-31 Thread dinkypumpkin
On 31 Mar 2011, at 20:33, Roger Burton West wrote: On Thu, Mar 31, 2011 at 08:22:26PM +0100, Shevek wrote: What am I doing wrong? You can't use shell functions (such as pipe) with the list-form invocation of system(). Sorry, Shevek - I should have warned you about that beforehand.

Re: [PATCH] Output AAC as M4A for iTunes with metadata tags (Shevek)

2011-03-31 Thread Shevek
On 31 March 2011 20:33, Roger Burton West ro...@firedrake.org wrote: On Thu, Mar 31, 2011 at 08:22:26PM +0100, Shevek wrote: What am I doing wrong? You can't use shell functions (such as pipe) with the list-form invocation of system(). I thought it would be something like that. Thanks for the

Re: [PATCH] Output AAC as M4A for iTunes with metadata tags (Shevek)

2011-03-31 Thread Shevek
On 31 March 2011 20:36, dinkypumpkin dinkypump...@gmail.com wrote: On 31 Mar 2011, at 20:33, Roger Burton West wrote: On Thu, Mar 31, 2011 at 08:22:26PM +0100, Shevek wrote: What am I doing wrong? You can't use shell functions (such as pipe) with the list-form invocation of system().

Re: [PATCH] Output AAC as M4A for iTunes with metadata tags (Shevek)

2011-03-31 Thread Shevek
On 31 March 2011 20:33, Roger Burton West ro...@firedrake.org wrote: On Thu, Mar 31, 2011 at 08:22:26PM +0100, Shevek wrote: What am I doing wrong? Easiest option (though it's vulnerable to shellmetas showing up in filenames) is probably to do it all in one string: set $cmd instead of @cmd

Re: [PATCH] Output AAC as M4A for iTunes with metadata tags (Shevek)

2011-03-31 Thread Shevek
On 31 March 2011 20:49, dinkypumpkin dinkypump...@gmail.com wrote: On 31 Mar 2011, at 20:44, Shevek wrote: On 31 March 2011 20:33, Roger Burton West ro...@firedrake.org wrote: On Thu, Mar 31, 2011 at 08:22:26PM +0100, Shevek wrote: What am I doing wrong? Easiest option (though it's

RE: [PATCH] Output AAC as M4A for iTunes with metadata tags (Shevek)

2011-03-31 Thread bat guano
OK, this is what I came up with and it works: @cmd = ( $bin-{ffmpeg} . ' -i ' . $file_tmp . ' -vn -acodec copy -f adts - | ' . $bin-{ffmpeg} . ' -i - -vn -acodec copy -absf aac_adtstoasc -y ' . $prog-{filepart} . '', ); does anyone have any

Re: [PATCH] Output AAC as M4A for iTunes with metadata tags (Shevek)

2011-03-31 Thread dinkypumpkin
On 31 Mar 2011, at 20:52, Shevek wrote: On 31 March 2011 20:49, dinkypumpkin dinkypump...@gmail.com wrote: Path to ffmpeg exe might have spaces, so should be quoted as well. good spot... it's odd, because up till now none of the paths have been quoted, but it has always worked,

Re: [PATCH] Output AAC as M4A for iTunes with metadata tags (Shevek)

2011-03-31 Thread Roger Burton West
On Thu, Mar 31, 2011 at 08:56:59PM +0100, dinkypumpkin wrote: Yes. Perl pros here should correct me, but I think now that you effectively passing a list of length = 1 to system() or open3 (under the hood of main::run_cmd), you need to handle all internal quoting yourself. Yes. The array form

Re: [PATCH] Output AAC as M4A for iTunes with metadata tags (Shevek)

2011-03-31 Thread dinkypumpkin
On 31 Mar 2011, at 20:54, bat guano wrote: OK, this is what I came up with and it works: @cmd = ( $bin-{ffmpeg} . ' -i ' . $file_tmp . ' -vn -acodec copy -f adts - | ' . $bin-{ffmpeg} . ' -i - -vn -acodec copy -absf aac_adtstoasc -y ' . $prog-{filepart} . '', ); does anyone have any

Re: [PATCH] Output AAC as M4A for iTunes with metadata tags (Shevek)

2011-03-28 Thread Jon Davies
On 28 March 2011 13:59, richard rich...@richsim900.plus.com wrote: I've done some tests with MediaInfo and AtomicParsley to try and find why EasyTag makes the m4a file playable on my Marantz cd player. ... 2. Bells_after.m4a :- This is the default file after amending in EasyTag (deleting album

Re: [PATCH] Output AAC as M4A for iTunes with metadata tags (Shevek)

2011-03-27 Thread Shevek
I'll see if I can update my patch to remove that tag... Sent from my iPhone On 27 Mar 2011, at 14:11, richard rich...@richsim900.plus.com wrote: Neither Shevek's patch to output as m4a (or Nick Ludlam's) play on my hifi CD player (Marantz CD6003) via the USB port. It gives a header error.

RE: [PATCH] Output AAC as M4A for iTunes with metadata tags (Shevek)

2011-03-27 Thread bat guano
From: she...@o2.co.uk Subject: Re: [PATCH] Output AAC as M4A for iTunes with metadata tags (Shevek) Date: Sun, 27 Mar 2011 14:16:35 +0100 To: rich...@richsim900.plus.com CC: get_iplayer@lists.infradead.org I'll see if I can update my patch to

Re: [PATCH] Output AAC as M4A for iTunes with metadata tags (Shevek)

2011-03-27 Thread James Cook
On Sun, 27 Mar 2011 14:05:17 +, you wrote: In my opinion, ffmpeg handles aac/m4a files in a way that isn't friendly with some players. It's not just the BBC files either. When I convert other files to m4a using ffmpeg like this:- ffmpeg -i foo -acodec libfaac foo.m4a they won't play in the

RE: [PATCH] Output AAC as M4A for iTunes with metadata tags (Shevek)

2011-03-27 Thread bat guano
Which version of ffmpeg are you using? I'm using this version with Ubuntu Karmic:- FFmpeg version git-N-28651-gf55dd6c, Copyright (c) 2000-2011 the FFmpeg developers   built on Mar 26 2011 11:51:58 with gcc 4.4.1   configuration: --enable-gpl