[Gimp-developer] API proposal for libgimp export dialog

2009-07-14 Thread Martin Nordholts
Hi, Continuing the work on http://gui.gimp.org/index.php/Save_%2B_export_specification , here is my API proposal for common export dialog logic to be shared by file format plug-ins: GtkWidget * gimp_export_dialog_new (const gchar *format_name, const

[Gimp-developer] file-pdf patch

2009-07-14 Thread Thomas Frieling
Hi all! Just wanted to share a litte patch for file-pdf.c to support a max width/height and a page number as parameters. Maybe someone can clean the code and push it into the next gimp release. Usage: gimp -i -b '(pdftojpg inputfilename maxWidth maxHeight outputfilename quality radius delta

Re: [Gimp-developer] file-pdf patch

2009-07-14 Thread Thomas Frieling
I guess I also need to copypast the patch (attachments don't seem to work here...) So here it is: *** file-pdf.c 2008-11-20 23:43:49.0 +0100 --- file-pdf-patched.c 2009-05-07 16:51:02.0 +0200 *** *** 264,271 static const GimpParamDef thumb_args[] = {

Re: [Gimp-developer] file-pdf patch

2009-07-14 Thread Martin Nordholts
On 07/14/2009 08:00 PM, Thomas Frieling wrote: Hi all! Just wanted to share a litte patch for file-pdf.c to support a max width/height and a page number as parameters. Maybe someone can clean the code and push it into the next gimp release. Hi! Please attach this patch to bugzilla in

Re: [Gimp-developer] API proposal for libgimp export dialog

2009-07-14 Thread Sven Neumann
Hi, On Tue, 2009-07-14 at 12:44 +0200, Martin Nordholts wrote: Continuing the work on http://gui.gimp.org/index.php/Save_%2B_export_specification , here is my API proposal for common export dialog logic to be shared by file format plug-ins: GtkWidget * gimp_export_dialog_new (const

Re: [Gimp-developer] API proposal for libgimp export dialog

2009-07-14 Thread Sven Neumann
Hi, On Tue, 2009-07-14 at 12:44 +0200, Martin Nordholts wrote: Continuing the work on http://gui.gimp.org/index.php/Save_%2B_export_specification , here is my API proposal for common export dialog logic to be shared by file format plug-ins: GtkWidget * gimp_export_dialog_new (const

Re: [Gimp-developer] file-pdf patch

2009-07-14 Thread Sven Neumann
Hi, On Tue, 2009-07-14 at 20:04 +0200, Thomas Frieling wrote: I guess I also need to copypast the patch (attachments don't seem to work here...) That's why we kindly asked you to open an enhancement request and then attach your patch there. Thanks. Sven

Re: [Gimp-developer] API proposal for libgimp export dialog

2009-07-14 Thread Martin Nordholts
On 07/14/2009 10:44 PM, Sven Neumann wrote: This function creates a new dialog, and plug-ins then use GtkWidget * gimp_export_dialog_get_container (GtkWidget *dialog); to get a vbox that the file-format specific widgets with export options are put it. I'd suggest to have

Re: [Gimp-developer] API proposal for libgimp export dialog

2009-07-14 Thread Martin Nordholts
On 07/14/2009 10:47 PM, Sven Neumann wrote: Hi, On Tue, 2009-07-14 at 12:44 +0200, Martin Nordholts wrote: Continuing the work on http://gui.gimp.org/index.php/Save_%2B_export_specification , here is my API proposal for common export dialog logic to be shared by file format plug-ins:

Re: [Gimp-developer] API proposal for libgimp export dialog

2009-07-14 Thread Sven Neumann
Hi, On Tue, 2009-07-14 at 22:54 +0200, Martin Nordholts wrote: That's fine, but it doesn't deal with the problem of how the file plug-in deals with the actual export. So far the gimp_export_image() functions does take care of all the nasty details. We definitely don't want to duplicate

Re: [Gimp-developer] API proposal for libgimp export dialog

2009-07-14 Thread Martin Nordholts
On 07/14/2009 10:55 PM, Sven Neumann wrote: Hi, On Tue, 2009-07-14 at 22:54 +0200, Martin Nordholts wrote: The plan is to let plug-ins still use gimp_export_image() for creating an image suitable for exporting, it's just that we will remove that function's bad habit of asking annoying

Re: [Gimp-developer] API proposal for libgimp export dialog

2009-07-14 Thread Sven Neumann
Hi, On Tue, 2009-07-14 at 22:59 +0200, Martin Nordholts wrote: Exactly how will it break existing plug-ins? It will just be changed to act as if the user clicked the Export button. Take a look at the code on the branch and you'll see what I mean There are questions to ask the user and we

Re: [Gimp-developer] meta-data browser: EntryWidget + treemodel = chicken/egg problem

2009-07-14 Thread Roman Joost
Hi Martin, On Mon, Jul 13, 2009 at 12:02:29PM +0200, Martin Nordholts wrote: On 07/12/2009 03:12 PM, Roman Joost wrote: When I enter the first characters in the entry, the following happens: 1. the schema is set (row-changed signal is emitted) 2. the property *value* is set