Re: [Gimp-developer] HSL patch

2007-01-12 Thread Sven Neumann
Hi, On Thu, 2007-01-11 at 21:10 -0500, Robert L Krawitz wrote: Uh, maybe that I didn't look closely enough :-? Here's an updated patch. Thanks. I think it's about time that you open a bug report for this new feature and attach your patch to it. That's still the preferred way of submitting

Re: [Gimp-developer] HSL patch

2007-01-12 Thread Robert L Krawitz
From: Sven Neumann [EMAIL PROTECTED] Date: Fri, 12 Jan 2007 21:33:01 +0100 On Thu, 2007-01-11 at 21:10 -0500, Robert L Krawitz wrote: Uh, maybe that I didn't look closely enough :-? Here's an updated patch. Thanks. I think it's about time that you open a bug report for this

Re: [Gimp-developer] HSL patch

2007-01-11 Thread Robert L Krawitz
From: Sven Neumann [EMAIL PROTECTED] Date: Thu, 11 Jan 2007 08:22:20 +0100 On Wed, 2007-01-10 at 06:53 -0500, Robert L Krawitz wrote: From: Sven Neumann [EMAIL PROTECTED] Date: Wed, 10 Jan 2007 08:53:02 +0100 can you explain to me why your patch introduces new

Re: [Gimp-developer] HSL patch

2007-01-11 Thread Sven Neumann
Hi, On Thu, 2007-01-11 at 07:23 -0500, Robert L Krawitz wrote: I'll try to get to it tonight, although I think it would be useful to have the floating point version also -- if someone's writing a plugin that's doing multiple transformations, it keeps more precision to do the math in floating

Re: [Gimp-developer] HSL patch

2007-01-10 Thread Robert L Krawitz
From: Sven Neumann [EMAIL PROTECTED] Date: Wed, 10 Jan 2007 08:53:02 +0100 can you explain to me why your patch introduces new functions in libgimpcolor? Couldn't you just use the existing gimp_rgb_to_hsl() and gimp_hsl_to_rgb()? I did it the way I did to use the same

Re: [Gimp-developer] HSL patch

2007-01-10 Thread Sven Neumann
Hi, On Wed, 2007-01-10 at 06:53 -0500, Robert L Krawitz wrote: From: Sven Neumann [EMAIL PROTECTED] Date: Wed, 10 Jan 2007 08:53:02 +0100 can you explain to me why your patch introduces new functions in libgimpcolor? Couldn't you just use the existing gimp_rgb_to_hsl() and

Re: [Gimp-developer] HSL patch

2007-01-09 Thread Sven Neumann
Hi, can you explain to me why your patch introduces new functions in libgimpcolor? Couldn't you just use the existing gimp_rgb_to_hsl() and gimp_hsl_to_rgb()? Sven ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU