Re: [Gimp-developer] Silent profile embedding.

2009-02-08 Thread Sven Neumann
Hi,

On Sat, 2009-02-07 at 23:03 +0100, Martin Nordholts wrote:

 So I can go ahead and revert this commit then? (rev 23135):
 
 2007-08-07  Sven Neumann  s...@gimp.org
 
 * plug-ins/common/png.c (save_image): in the absence of an
 embedded color profile, write the sRGB chunk.

I don't think we should do any code changes before we know exactly what
we want. IMO we should first determine what we want, create a set of
test cases and find out what the current code is doing. Then, when we
know what needs to be changed, open bug reports and do the changes.
Otherwise we will end up with an inconsistent mess.


Sven


___
Gimp-developer mailing list
Gimp-developer@lists.XCF.Berkeley.EDU
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer


Re: [Gimp-developer] Silent profile embedding.

2009-02-08 Thread Hal V. Engel
On Sunday 08 February 2009 08:39:38 am Sven Neumann wrote:
 Hi,

 On Sun, 2009-02-08 at 06:44 +0900, Yoshinori Yamakawa wrote:
  I wrote a small patch for checking embedded profile .
  http://cue.yellowmagic.info/softwares/files/profile_status.diff
 
  Example 1: Image has no profiles
  http://cue.yellowmagic.info/softwares/images/gimp_profile_status1.png
 
  Example 2: Open the gray-scaled image that has Dot Gain 15% profile
  http://cue.yellowmagic.info/softwares/images/gimp_profile_status2.png

 I don't quite understand what this patch is supposed to do. The display
 of color profile information in the Image Properties dialog is already
 there. What does your patch add? To me it looks like the dialog only
 becomes more confusing and misleading.


 Sven

I am finding this thread to be confusing.  In the Color Management section of 
the Preferences dialog there is a drop down to set the File Open behavior 
and the options are Ask what to do, Keep embedded profile and Convert to 
RGB workspace.  Shouldn't this setting also affect the way files opened 
without an embedded profile work?   If not then either is should be 
generalized to do so or another preference item for how to handle images with 
no profile should be added with similar options.  that way the user will have 
control over how this behaves. 

Hal
___
Gimp-developer mailing list
Gimp-developer@lists.XCF.Berkeley.EDU
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer


Re: [Gimp-developer] Silent profile embedding.

2009-02-08 Thread Yoshinori Yamakawa
On Sun, 08 Feb 2009 17:39:38 +0100
Sven Neumann s...@gimp.org wrote:

 I don't quite understand what this patch is supposed to do. The display
 of color profile information in the Image Properties dialog is already
 there. What does your patch add? To me it looks like the dialog only
 becomes more confusing and misleading.
 
I'm sorry that I can't explain in English very well.

See the following image:
http://cue.yellowmagic.info/softwares/images/gimp_profile_status_comparison.png

In case of using the GIMP and any other softwares, handling the image without 
color profile is very important.
Some software may handle it in the different workspace.
Some software may handle it without color management.
The behavior of the other software becomes unpredictable if the GIMP covers 
that the image doesn't have profile.

-- 
Yoshinori Yamakawa y...@yellowmagic.info
___
Gimp-developer mailing list
Gimp-developer@lists.XCF.Berkeley.EDU
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer


[Gimp-developer] brush rotation

2009-02-08 Thread Joao S. O. Bueno
For those of you who don'tṫ follow trunk closely or the irc channel, I can't 
resist the urge to tell that Alexia Death and Mich have been working on brush 
dynamics over the last few days - and have thus far added brush rotation.
It now works both as a fixed factor and following painting direction. 
Yaii!!

(as any brand new feature, it still buggy and error prone, but they are 
actvelyy fixing everything)

js
--
___
Gimp-developer mailing list
Gimp-developer@lists.XCF.Berkeley.EDU
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer