Re: [Gimp-developer] connecting to update signal in uimanager
On 06/30/2009 02:02 AM, Jordan Stinson wrote: > Hi there, > > I'm trying to hack gimp. For my purposes, I want to be notified when > certain actions become sensitive, or insensitive. Why not subscribe to changes to whatever it is that changes the sensitivity of your action instead of subscribing to changes of the sensitivity of the action itself? / Martin ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] connecting to update signal in uimanager
Jordan Stinson (jordan.stinso...@gmail.com) wrote: > I'm trying to hack gimp. For my purposes, I want to be notified when certain > actions become sensitive, or insensitive. The way I wanted to do this was to > store the actions I wanted to keep track of and connect to the UIManager's > update signal. That way, when an update happened, my callback function would > be called and I could loop through my list and check the sensitive property > of my actions. Wouldn't it make more sense to connect to "notify::sensitive" on the actions you're interested in? Bye, Simon -- si...@budig.de http://simon.budig.de/ ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
[Gimp-developer] connecting to update signal in uimanager
Hi there, I'm trying to hack gimp. For my purposes, I want to be notified when certain actions become sensitive, or insensitive. The way I wanted to do this was to store the actions I wanted to keep track of and connect to the UIManager's update signal. That way, when an update happened, my callback function would be called and I could loop through my list and check the sensitive property of my actions. My problem is when I connect to the update command, I set the update data (the last parameter), which doesn't end up being what is passed to my callback function. In fact, its a GimpDisplay pointer that's being passed, instead of the pointer to my data. I'm pretty new to GTK as well as GIMP, so please forgive my ignorance. Thanks in advance! - Jordan ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Support for SpaceNavigator
Hi, On Mon, 2009-06-29 at 22:58 +0200, Håvard Tørring wrote: > I am testing this with panning by mapping events from 3dconnexion to > view-scroll-up/down/left/ > right. In the mentioned function, the if test fails on > GIMP_ENUM_ACTION (action)->value_variable returning 0. I assume this > means that the view-scroll actions does not take any value. Is this > correct? Are there any panning actions I could use that accepts > value? I don't think that any suitable actions exist. Sven ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Support for SpaceNavigator
I am testing this with panning by mapping events from 3dconnexion to view-scroll-up/down/left/right. In the mentioned function, the if test fails on GIMP_ENUM_ACTION (action)->value_variable returning 0. I assume this means that the view-scroll actions does not take any value. Is this correct? Are there any panning actions I could use that accepts value? Havard Torring On Sun, Jun 28, 2009 at 11:49 PM, Håvard Tørring wrote: > I am testing this with panning by mapping events from 3dconnexion to > view-scroll-up/down/left/right. In the mentioned function, the if test fails > on GIMP_ENUM_ACTION (action)->value_variable returning 0. I assume this > means that the view-scroll actions does not take any value. Is this correct? > Are there any panning actions I could use that accepts value? > > Havard Torring > > > On Mon, Jun 22, 2009 at 11:27 PM, Sven Neumann wrote: > >> On Mon, 2009-06-22 at 21:41 +0200, Håvard Tørring wrote: >> > OK, I'll give it a try,.. >> > >> > I have a little problem getting into the code. I am new to the gtk >> > environment, the event handling and much of the gui stuff, so >> > unfortunately the learning curve is pretty steep. Anyhow, this is what >> > I have found. >> > >> > As far as I can see, the following line in gimpcontrollerinfo.c emits >> > the signal that initiates the scroll function >> > >> > g_signal_emit (info, info_signals[EVENT_MAPPED], 0, >> > controller, event, action_name, &retval); >> > >> > event contains the value, so I would be happy if I could pick up this >> > value later on, when the actual scrolling is performed. >> >> This signal is then handled in gimp_controllers_event_mapped() as found >> in gimpcontrollers.c. Here the event is translated into the activation >> of a GtkAction. As you can see the event's value is multiplied by 1000 >> and passed with the action. Later this value is then passed to >> action_select_value() where it is divided by 1000 again and interpreted >> as an absolute value normalized to the scroll-bar range. This is all a >> rather bad hack. To some extent it works for controllers that send >> absolute events. The device you are trying to use there sends relative >> events values though and all the assumptions that this code relies on >> break badly. This will need a clever redesign. >> >> >> Sven >> >> >> > ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Submitting GIT patch
On 06/29/2009 05:10 PM, Eric Daoust wrote: > I am ready to submit a working nohalo1 patch for GEGL that is a faster > replacement for sharp. I believe this is the procedure I must follow. > (I will backup my files just in case) > > -create local branch so that I am not committing to the main trunk > -remove sharp from the branch > -add nohalo1 > -commit to the branch > -switch back to main branch, pull > -switch back to my local branch > -rebase with master > -fix conflicts > -create the patch > Hi, First of all, remeber that your git repository of GEGL is a clone, you can mess it up however badly you like without affecting everyone elses repo. When you get push access you need to be more careful though ;) When you have cloned, create and checkout a branch to do your work on: git checkout -b gsoc2009-adaptive-resampler origin/master Then do your changes. Make sure to commit often. In general, the more commits the better. Commits are easy to squash together but it's more work to separate a single commit into two. You don't need to switch back to master, to rebase with origin/master, just do: git pull --rebase while you are on your gsoc2009-adaptive-resampler branch. And note that in the end, it is not a matter of creating "the patch". Rather, your delivery should be a series of git commits created with git format-patch origin/master..gsoc2009-adaptive-resampler -o output-folder You then tarball the output-folder and send it to us, preferably coordinated through #gegl on irc.gimp.org. Hope this helps, feel free to ask further quetions if you need clarifications. Oh and a final thing, make sure to look at gitk --all after each git operation so that you can see what is going on. / Martin > I found a similar procedure at this page: > https://rails.lighthouseapp.com/projects/8994/sending-patches > > Any help/advice is greatly appreciated. > > Thank you for your time, > Eric > ___ > Gimp-developer mailing list > Gimp-developer@lists.XCF.Berkeley.EDU > https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer > ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] New color mode
On 06/29/2009 10:31 AM, Emil Assarsson wrote: > I meant the modes that are used to mix colors with layers and brush > like Normal, Dissolve, Multiply, Divide etc... > Currently, the Color layer mode when using GEGL is supposed to use the Hue and Saturation of the upper layer and the Lightness from the lower layer. Maybe the RGB -> HSL conversion is buggy? We want Color to behave correctly in GIMP 2.8 when using GEGL for the projection, see http://bugzilla.gnome.org/show_bug.cgi?id=325564 . It is great that you want to look at this, and all you have to do is experiment with different algorithms in gimp_operation_point_layer_mode_get_new_color_hsl() in app/gegl/gimpoperationpointlayermode.c. Good luck! Best regards, Martin ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
[Gimp-developer] Submitting GIT patch
Hello, I'm no expert in GIT but in my experience with SVN things can become a mess if we're not careful, so I want to make sure I am doing things correctly. I am ready to submit a working nohalo1 patch for GEGL that is a faster replacement for sharp. I believe this is the procedure I must follow. (I will backup my files just in case) -create local branch so that I am not committing to the main trunk -remove sharp from the branch -add nohalo1 -commit to the branch -switch back to main branch, pull -switch back to my local branch -rebase with master -fix conflicts -create the patch I found a similar procedure at this page: https://rails.lighthouseapp.com/projects/8994/sending-patches Any help/advice is greatly appreciated. Thank you for your time, Eric ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] New color mode
I meant desaturated sorry :-P > I find the normal too desaturated and would like to make a new more vivid. ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] New color mode
Hi, I'm sorry that I didn't find the right terms... I meant the modes that are used to mix colors with layers and brush like Normal, Dissolve, Multiply, Divide etc... For instance: Place a high green and a high red area on a canvas. Then mix them together with a brush set to like 45% Opacity. The mid blend will be very dull. I want to create an alternative where the blend is more a combination of color, value and normal where the blend keeps some more of it's vividness. I think I have to experiment with this a lot to find the correct algorithms for it... sometimes I want it to prefer a warm path and sometimes a cold. I think this mode could mimic the real life oil- and watercolors a little bit better if I get it right. -- Emil ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer