[Gimp-developer] [PATCH] Improve brush outline for fuzzy brushes, sample screenshot included
Hi
I think the current brush outline for fuzzy brushes is too big. The
attached patch improves the brush outline for fuzzy brushes (see
screenshot [1]). If using a higher threshold doesn't result in any
outline at all, the patch fallbacks to the old brush outline so that a
brush outline always is shown even if the brush only has low-intensity
values.
Does this patch make sense to anyone else?
/ Martin
[1] http://www.chromecode.com/temp/improve-fuzzy-brush-outline.png
--
My GIMP Blog:
http://www.chromecode.com/
From c59b28cd84a94534cf9ad3c309d4666ca8a8eaf4 Mon Sep 17 00:00:00 2001
From: Martin Nordholts mart...@src.gnome.org
Date: Sun, 30 Aug 2009 11:40:44 +0200
Subject: [PATCH] app: Improve brush outline for fuzzy brushes
Use a 25% threshold instead of 0% so that we get a nicer outline for
fuzzy brushes. If the 25% doesn't result in a outline at all, fallback
to 0% though.
---
app/base/boundary.h |4 ++--
app/paint/gimpbrushcore.c | 13 -
2 files changed, 14 insertions(+), 3 deletions(-)
diff --git a/app/base/boundary.h b/app/base/boundary.h
index 9577d9c..4cff8bb 100644
--- a/app/base/boundary.h
+++ b/app/base/boundary.h
@@ -19,8 +19,8 @@
#define __BOUNDARY_H__
-/* half intensity for mask */
-#define BOUNDARY_HALF_WAY 127
+#define BOUNDARY_ONE_QUARTER 64
+#define BOUNDARY_HALF_WAY127
typedef enum
diff --git a/app/paint/gimpbrushcore.c b/app/paint/gimpbrushcore.c
index 1d424c1..4980ca0 100644
--- a/app/paint/gimpbrushcore.c
+++ b/app/paint/gimpbrushcore.c
@@ -849,11 +849,22 @@ gimp_brush_core_create_bound_segs (GimpBrushCore*core,
smooth_region (PR);
+ /* Use BOUNDARY_ONE_QUARTER to get a nice mask for fuzzy brushes */
boundary = boundary_find (PR, BOUNDARY_WITHIN_BOUNDS,
0, 0, PR.w, PR.h,
-0,
+BOUNDARY_ONE_QUARTER,
core-n_brush_bound_segs);
+ /* If we didn't get any boundary try without a threshold */
+ if (core-n_brush_bound_segs = 0)
+{
+ g_free (boundary);
+ boundary = boundary_find (PR, BOUNDARY_WITHIN_BOUNDS,
+0, 0, PR.w, PR.h,
+0,
+core-n_brush_bound_segs);
+}
+
core-brush_bound_segs = boundary_sort (boundary,
core-n_brush_bound_segs,
num_groups);
--
1.6.2.5
___
Gimp-developer mailing list
Gimp-developer@lists.XCF.Berkeley.EDU
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] [PATCH] Improve brush outline for fuzzy brushes, sample screenshot included
Hi all, My opinion about that is the same as shirakawa if we want to do photography retouch and superexact works like these, but artisticaly i would prefer something like Martin says. It is more useful for the eye, if we want to make an stroke fast and not acuratly but in the aprox right place.the old method requieres user imagination to preview in his mind what will happen... but i have to say that i don´t use this brush outline feature becouse it makes my gimp sloower with complex outlines.So if somebody has the solution for this... i am listening. best regards 2009/8/30 SHIRAKAWA Akira shirakawa.ak...@gmail.com Martin Nordholts wrote: I think the current brush outline for fuzzy brushes is too big. The attached patch improves the brush outline for fuzzy brushes (see screenshot [1]). If using a higher threshold doesn't result in any outline at all, the patch fallbacks to the old brush outline so that a brush outline always is shown even if the brush only has low-intensity values. In my opinion the idea of the brush outline is that it represents its total area of effect, or in other words, the area where pixels will be affected in a way or another while drawing. The brush outline for fuzzy brushes (assuming dynamics aren't applied) *looks* too big, but it actually isn't. This is most evident by drawing a few strokes with the fuzzy brush on a transparent layer and then adjusting the alpha level channel on ColorsLevels to coordinates (0;255) . A more useful patch (in my opinion) for brush outlines would be making them change together with brush dynamics (even if the user isn't actually drawing, just moving the cursor on the drawing area) if they are enabled. This could be useful in many ways, but I have the impression it would lead to performance issues. -- SHIRAKAWA Akira ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer -- ___ Ramon Miranda http://ramonmirandavisualart.blogspot.com http://code.google.com/p/gps-gimp-paint-studio/ ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] [PATCH] Improve brush outline for fuzzy brushes, sample screenshot included
hi, what about using a dashed outline for fuzzy brushes? perhaps like a) in http://yahvuu.files.wordpress.com/2009/08/fuzzy-outline.png I think it's rewarding to visually mark fuzzy outlines / feathered selections, as it opens the path for on-canvas adjustments -- as has been pointed out on the brainstorm [1]-[3]. Not trivial to get it right, though. greetings, peter [1] http://gimp-brainstorm.blogspot.com/2007/09/feathering.html [2] http://gimp-brainstorm.blogspot.com/2009/02/quick-brush-radius.html [3] http://gimp-brainstorm.blogspot.com/2009/07/selective-distort.html ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] [PATCH] Improve brush outline for fuzzy brushes, sample screenshot included
On Sunday 30 August 2009, Martin Nordholts wrote: [1] http://www.chromecode.com/temp/improve-fuzzy-brush-outline.png One more thing that has always irritated me (not related to your change though): The lower-left - upper right lines (/) seem to use a different corner case of the same algorithm (looks like a different algorithm even) as compared to the other side (\). Other than that I think it makes sense to show not the total affected area but only the area which is affected by more than a certain nonzero threshold (say opacity = 20%). My weekend comment, Daniel signature.asc Description: This is a digitally signed message part. ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] [PATCH] Improve brush outline for fuzzy brushes, sample screenshot included
yahvuu wrote: hi, what about using a dashed outline for fuzzy brushes? perhaps like a) in http://yahvuu.files.wordpress.com/2009/08/fuzzy-outline.png This is a very good idea, but I think it would be more logic and consistent with the style of brush outlines in GIMP if it was the opposite: solid external outline (representing the brush area limits), and dashed internal outline. One of the reasons for this is that hardness (which creates the fuzzyness) is a brush attribute which can dynamically change with brush dynamics (in static conditions hardness could be 100% hard, but become completely fuzzy as drawing pressure increases for example), and would better work with my proposal of varying in realtime brush outlines according to them. -- SHIRAKAWA Akira ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] [PATCH] Improve brush outline for fuzzy brushes, sample screenshot included
hi, SHIRAKAWA Akira wrote: yahvuu wrote: hi, what about using a dashed outline for fuzzy brushes? perhaps like a) in http://yahvuu.files.wordpress.com/2009/08/fuzzy-outline.png This is a very good idea, but I think it would be more logic and consistent with the style of brush outlines in GIMP if it was the opposite: solid external outline (representing the brush area limits), and dashed internal outline. this is now variant b) in the updated picture http://yahvuu.files.wordpress.com/2009/08/fuzzy-outline1.png greetings, peter ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] GIMP in-game feature
I believe that the GIMP logos are licensed under the GPL. If you wish to have them relicensed as CC then you could speak to the author of a particular logo. I am not sure about compatibility with the Free Art License. 2009/8/30 Eckhard M. b...@neeneenee.de: Please, can someone answer my request. Thanks. Am Samstag, den 29.08.2009, 19:59 +0200 schrieb Eckhard M. Jäger: Dear GIMP developers, i am a artist of the TORCS-NG racing game project. TORCS-NG is the active development fork of the famous open source 3D racing game TORCS. In the past the TORCS-NG team startet creating virtual brands for car- and track design. I proposed to feature open source projects we (the TORCS-NG team) love. We like to feature GIMP as a panel at the border of a track or a car skin too. So we like to get the permission to do so and we like to know what kind of license the GIMP logo has (the artwork must be distrubuted as CC/ Free Art License). We created a small gallery so you can imagine what TORCS-NG will be. Here you find examples of car skins: http://www.neeneenee.de/torcs-ng/gallery/ Best regards. Eckhard M. Jäger ___/\___ Plastiktütenpenner ist kein anerkannter Beruf. |\/\/\/| | |Bart. | (O)(O)b...@neeneenee.de C _) | ,_/ Linux for Designers - http://my.opera.com/area42/blog/ | / SweeTS delicious Typo3 development - http://typo3.area42.de/ / \ ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] GIMP in-game feature
On 08/30/2009 09:09 PM, Eckhard M. Jäger wrote: Please, can someone answer my request. Thanks. GIMP is distributed under GPL and LGPL / Martin -- My GIMP Blog: http://www.chromecode.com/ ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] [PATCH] Improve brush outline for fuzzy brushes, sample screenshot included
Hello Martin, once i suggested at GIMP brainstorm painting two lines for fuzzy brushes and feather borders. One dotted where pacity = 100% and on with just any secound dot where opacity = 0%. A center mark would be great too. So artists know where is the center of the stroke (may for connecting border or painting along a line) and where is 100% color and where is it faded out. This border feature would be great for feather borders too (without center mark of course). Take a look at this mockup: http://www.neeneenee.de/bart/gimp-border.png Best regards and happy development! ___/\___ Ich werde nie einen Emmy gewinnen. |\/\/\/| | |Bart. | (O)(O)b...@neeneenee.de C _) | ,_/ Linux for Designers - http://my.opera.com/area42/blog/ | / SweeTS delicious Typo3 development - http://typo3.area42.de/ / \ Am Sonntag, den 30.08.2009, 11:42 +0200 schrieb Martin Nordholts: Hi I think the current brush outline for fuzzy brushes is too big. The attached patch improves the brush outline for fuzzy brushes (see screenshot [1]). If using a higher threshold doesn't result in any outline at all, the patch fallbacks to the old brush outline so that a brush outline always is shown even if the brush only has low-intensity values. Does this patch make sense to anyone else? / Martin [1] http://www.chromecode.com/temp/improve-fuzzy-brush-outline.png ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] GIMP in-game feature
Quoting Eckhard M.\ Jäger b...@neeneenee.de: So we like to get the permission to do so and we like to know what kind of license the GIMP logo has (the artwork must be distrubuted as CC/ Free Art License). According to http://www.gimp.org/about/linking.html , the provided images of Wilber, GIMP's mascot/logo, can be copied freely. My interpretation of this (which carries no authority whatsoever) is that there should be no problem with your usage of the Wilber image as long as it is being associated with the GIMP project. As far as precise, formal licensing terms are concerned, the Wilber artwork was initially created by Tuomas Kuosmanen (http://www.tigert.com/) and he should probably be contacted for such information. ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] GIMP in-game feature
On 08/30/2009 09:51 PM, Eckhard M. Jäger wrote: Hello Martin, thanks a lot for your help, so it should be possible. So we have your permission too? Hi, Hold on. There seems to be confusion here. CC and GPL are not compatible, which would be a problem for you. And I don't have the authority to give you permissions to use the logo in any way, I'm not the author of it. / Martin -- My GIMP Blog: http://www.chromecode.com/ ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] [PATCH] Improve brush outline for fuzzy brushes, sample screenshot included
On Sunday 30 August 2009 22:30:54 Eckhard M. Jäger wrote: Hello Martin, once i suggested at GIMP brainstorm painting two lines for fuzzy brushes and feather borders. One dotted where pacity = 100% and on with just any secound dot where opacity = 0%. A center mark would be great too. There is just one major problem with this suggestion. Outline drawing is second most expensive operation in painting, first being the operation of applying the stamp to the canvas. Drawing two outlines would double that. Until there is on demand rendering with a gegl paint core, I do not see the resources to do this. --Gegl ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
