Re: [Gimp-developer] [Gegl-developer] Difference between c2g from Gimp and from Gegl command line
On 28 August 2011 08:47, Thomas Baruchel baruc...@gmx.com wrote: Hi, I am new to GEGL but I would be interested by writing XML scripts in order to perform some complex actions from the command line. I managed to make c2g work with XML scripts, but obviously the output is not the same than what I get from Gimp. Here are the two ways I found for making c2g work: gegl -o - -x geglnode operation='gegl:c2g'paramsparam name='radius'384/paramparam name='samples'10/paramparam name='iterations'23/paramparam name='rgamma'1.8/paramparam name='strength'1/paramparam name='gamma'1/param/params/nodenode operation='gegl:load'paramsparam name='path'file.png/param/params/node/gegl | display - gegl -o - -x imagestackfilter type='gegl:c2g'paramsparam name='radius'384/paramparam name='samples'10/paramparam name='iterations'23/paramparam name='rgamma'1.8/paramparam name='strength'1/paramparam name='gamma'1/param/params/filterlayer src='file.png'//stack/image | display - As you can see, I use here the default settings from Gimp (except for samples where I tried with 10 both in Gimp and here). However this single operation performed on a picture doesn't give the same output. Do you have an explanation for that? You are using the GEGL operation tool for this in GIMP, right? I'm seeing the same behavior here, tested with your examples and with the color-temperature operation. If there is no bug filed for this issue, please file one. By the way, what is the most convenient way for having the input file from the standard input rather than setting its path in the XML file? There is such an example on http://gegl.org but I couldn't manage to get it work and I couldn't find what I had to change in my own command lines above to do it. Using path = - on a load operation is meant to work for this purpose. If it does not, that is a regression and is worth a bug report. Best regards, -- Thomas Baruchel ___ Gegl-developer mailing list gegl-develo...@lists.xcf.berkeley.edu https://lists.XCF.Berkeley.EDU/mailman/listinfo/gegl-developer -- Jon Nordby - www.jonnor.com ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] gegl chanting
On 5 April 2011 08:49, shivani maheshwari shivani.mah...@gmail.com wrote: What is the main purpose of gegl chanting?? To let gegl operations be GObjects, but without having to write all the boilerplate involved. See gegl/gegl-chant.h -- Jon Nordby - www.jonnor.com ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Write basic gegl plugin
On 5 April 2011 08:55, sourav de souravde1...@gmail.com wrote: On Tue, Apr 5, 2011 at 11:11 AM, Madhav yadav mad.cool.sp...@gmail.com wrote: If i have to submit my sample on the gegl master branch then how will i go forthh. Use git to commit your changes and create a patch/patches. See http://wiki.gimp.org/index.php/Hacking:Patches I also recommend reading a tutorial on general git usage. After that you create a ticket in bugzilla under the gegl product, and add the patch(es) there. We will then review the code, and once everything has been sorted out, it will be pushed to master. -- Jon Nordby - www.jonnor.com ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Write basic gegl plugin
On 5 April 2011 11:08, Madhav yadav mad.cool.sp...@gmail.com wrote: Don;t we need to authenticate to add new files to the branch?? No, with git you primarily work against your local repository. You can do whatever you like there. Please read a tutorial or two on git, so that you come to terms with the basic concepts. -- Jon Nordby - www.jonnor.com ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Write basic gegl plugin
Get the code, build it on your computer, start working on the plugin. On 4 April 2011 17:02, shivani maheshwari shivani.mah...@gmail.com wrote: Yes i did see that . But I am not able to gather where to begin from?? On Mon, Apr 4, 2011 at 8:09 PM, Tobias Jakobs tobias.jak...@googlemail.com wrote: Have you seen this page? http://wiki.gimp.org/index.php/Users:Beginner_Developer%27s_FAQ On Mon, Apr 4, 2011 at 16:32, Madhav yadav mad.cool.sp...@gmail.com wrote: Hello, I want to write basic gegl pluginCan anybody help me with the same.. ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer -- Shivani Maheshwari Under Graduation( BTech.) Indian Institute of Information Technology, Allahabad (Amethi Campus) India ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer -- Jon Nordby - www.jonnor.com ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] gegl build fails
On 30 March 2011 19:24, Michael J. Hammel mjham...@graphics-muse.org wrote: On Wed, 2011-03-30 at 19:10 +0200, Jon Nordby wrote: GISCAN Gegl-0.1.gir WARNING: Skipping unknown interface GeglVisitable GICOMP Gegl-0.1.gir Gegl-0.1.gir: error: Type reference 'GeglMatrix3' not found Yeah, this has been reported by other as well. I'll try to fix it now. Which distribution are you using, and what is the version of gobject-introspection? Fedora 13. Is gobject-introspection within gobject-2.0? If so: $ pkg-config --modversion gobject-2.0 2.24.1 No, the introspection toolchain is separate. Typically packaged as gobject-introspection or similar. Anyhow, does it work for you now? I pushed a fix. -- Jon Nordby - www.jonnor.com ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] gegl build fails
On 30 March 2011 18:28, Michael J. Hammel mjham...@graphics-muse.org wrote: On Wed, 2011-03-30 at 10:21 +0530, Mukund Sivaraman wrote: export XDG_DATA_DIRS=/usr/local/gimpgit/share/ That got me a little further: GISCAN Gegl-0.1.gir WARNING: Skipping unknown interface GeglVisitable GICOMP Gegl-0.1.gir Gegl-0.1.gir: error: Type reference 'GeglMatrix3' not found Yeah, this has been reported by other as well. I'll try to fix it now. Which distribution are you using, and what is the version of gobject-introspection? -- Jon Nordby - www.jonnor.com ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Enabling a 2.8 release: planning for a 2.10 release
On 15 March 2011 07:43, Martin Nordholts ense...@gmail.com wrote: Not including API to work with layer groups in Python is not a regression, it's just missing functionality in one of the scripting languages. It is unfortunate if GIMP 2.8 will be released without layer groups support in Python, but the alternative is worse: not releasing GIMP 2.8 at all. And we should arrange for the Python bindings to be automatically generated from the PDB rather than wasting man-weeks on manually keeping it up to date. Not an easy task perhaps, but the only sensible one. Long term, bindings should of course be generated (or rather be dynamic using pygobject, when/if possible). However I need layer groups exposed for the Python API in order to support layer groups in OpenRaster, so I will probably do these bindings for 2.8. Just need to find the time. Do we have a bug open about this issue? -- Jon Nordby - www.jonnor.com ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Photoshop “compatibility” mode
On 31 January 2011 17:33, Christopher Curtis ccurt...@gmail.com wrote: On Sun, Jan 30, 2011 at 8:51 PM, Liam R E Quin l...@holoweb.net wrote: I'm actually Ok with this. But we have to agree what we mean by peer applications - I'd say gimp and inkscape are, for example, and not gimp and photoshop. So your argument is that on the Software Spectrum GIMP is not a graphics application but is first a GNOME application. For the people who want, you know, to create GNOME. It just happens to create GNOME using graphics. No, I am quite certain the argument is that GIMP users workflow/pipeline is more likely to also include Inkscape than Photoshop. Which in my experience is fairly sound. -- Regards Jon Nordby - www.jonnor.com ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] IMPORTANT: GIMP AND OPENSOURCE SCAM ON EBAY!
On 23 September 2010 21:55, Alexia Death alexiade...@gmail.com wrote: On Thu, Sep 23, 2010 at 9:11 PM, Jay Smith j...@jaysmith.com wrote: I suspect that a paid Foundation position might annoy some developers who have been busting their tails for years, for free. Not really. We do it for fun and all have jobs that cover our asses. One of the things that has been discussed is that GIMP could really use a paid developer for example. Someone who is paid to work full time to just work on GIMP. There wasn't any opposition to the idea, just nobody had time or will to push it into reality. I guess one of the blockers is the question of what entity should do the hiring. Witch brings us right back at the lack of a dedicated paper pusher. You could probably use the GNOME foundation as the hiring entity and for the other formal stuff. But yes, someone needs to do the initial work, and follow up. Paper-pushing and cat herding indeed. Why do we have so few people interested in that in FOSS? The goals are noble enough. -- Regards Jon Nordby - www.jonnor.com ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] shorthanded and outnumbered (Re: Native RAW support)
On 20 September 2010 15:10, oli...@first.in-berlin.de wrote: Is this is not addressed, then it makes no sense to mourn about shorthanded and outnumbered developers. You're more than welcome to address the issue. -- Regards Jon Nordby - www.jonnor.com ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] GPU-accelerated Image Filtering w/ CUDA
On 29 August 2010 20:13, Alan Reiner etothe...@gmail.com wrote: This is a long message, so let me start with the punchline: *I have a lot of CUDA code that harnesses a user's GPU to accelerate very tedious image processing operations, potentially 200x speedup. I am ready to donate this code to the GIMP project. Hi The first thing you should do if you want an (open source) project to to able use your code is to provide the code. Preferably in the form of a public source control repository. Without this first step, nothing can happen. :) Please let me know if anyone is interested to work with me on this: etothe...@gmail.com Please note that it is expected in open source projects that communication is kept in public channels (eg: a mailing list like this one) unless there is a very good reason not to. For this reason I've cc'ed the list in this reply, and I urge you to do the same. -- Regards Jon Nordby - www.jonnor.com ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Newbie startup problems
On 26 August 2010 10:25, Phani Bhushan Tholeti tpb...@gmail.com wrote: Can somebody suggest what can be done as a start off? I suggest having a look though the bugtracker, the wiki, relevant user forums and the archives for this bugtracker to see if you find anything that suits you. Find a problem you're interested in solving. If you cannot find that, but still think you want to do something, just pick a task and have a go at it. -- Regards Jon Nordby - www.jonnor.com ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Usability of menus (search, gegl ops, ...)
On 9 August 2010 23:42, yahvuu yah...@gmail.com wrote: Hi all, On 09.08.2010 22:51, LightningIsMyName wrote: 0. How do we want the search to work? A user can bring a search dialog up? Will the search be based on a string? A tree? Just a quick and cheap thought: if you're talking about search, that means i'm already using the keyboard to type in what i want to do, and then we're only one step away from a command line within GIMP. What do you call the existing scheme and python interpreters in GIMP? I'd say that we already have this, and have had it for years. -- Regards Jon Nordby - www.jonnor.com ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Help a newbie fill in some holes
On 19 July 2010 17:36, Joseph Areeda are...@gmail.com wrote: Rotate by an arbitrary angle. I've scanned an image but the page was not square in the scanner or camera. The best way to do this is to draw a line on the edge of the page and have a command that rotates it to horizontal or vertical. The algorithm is well defined and easy (except for indexed color images). This was brought up recently, in the following thread http://www.mail-archive.com/gimp-developer%40lists.xcf.berkeley.edu/msg20264.html See especially the last email. Draw arrows and shapes over an image (new vector layer). I found a shape drawing plugin that is fine except you fill in a form instead of draw the outline with a cursor, and it doesn't use the pen defined in the main window. See the branch soc-2006-vector-layers in git: http://git.gnome.org/browse/gimp/refs/heads IIRC, this has been dropped from the 2.8 schedule due to resource constraints. Half the gimp world would probably love the people who finally gets this merged and polished up. -- Regards Jon Nordby - www.jonnor.com ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
[Gimp-developer] [PATCH] x2: OpenRaster visibility attribute, OpenRaster layer position bugfix
Attached and inlined.
From 9fc67096c7da7722b38c5f7bf1741795a635d7cd Mon Sep 17 00:00:00 2001
From: Jon Nordby jono...@gmail.com
Date: Thu, 6 May 2010 03:44:01 +0200
Subject: [PATCH 1/2] plug-ins: OpenRaster, fix wrong layer positions
Don't store layer offsets in the PNG, or honor them on loading. The layer
position is given by the OpenRaster layer attributes alone. This caused a bug
where the offsets were applied twice, positioning the layer wrong.
---
plug-ins/pygimp/plug-ins/file-openraster.py | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/plug-ins/pygimp/plug-ins/file-openraster.py
b/plug-ins/pygimp/plug-ins/file-openraster.py
index f4bf6e2..b41fc09 100755
--- a/plug-ins/pygimp/plug-ins/file-openraster.py
+++ b/plug-ins/pygimp/plug-ins/file-openraster.py
@@ -86,7 +86,7 @@ def save_ora(img, drawable, filename, raw_filename):
def store_layer(img, drawable, path):
tmp = os.path.join(tempdir, 'tmp.png')
interlace, compression = 0, 2
- png_chunks = (1, 1, 1, 1, 1) # write all PNG chunks
+ png_chunks = (1, 1, 0, 1, 1) # write all PNG chunks except oFFs(ets)
pdb['file-png-save'](img, drawable, tmp, 'tmp.png',
interlace, compression, *png_chunks)
orafile.write(tmp, path)
@@ -172,7 +172,7 @@ def load_ora(filename, raw_filename):
# import layer, set attributes and add to image
gimp_layer = pdb['gimp-file-load-layer'](img, tmp)
gimp_layer.name = name
- gimp_layer.translate(x, y) # move to correct position
+ gimp_layer.set_offsets(x, y) # move to correct position
gimp_layer.opacity = opac * 100 # a float between 0 and 100
img.add_layer(gimp_layer, layer_no)
--
1.7.0.5
From fd3be813070a27d1409edabe570ca7a43cf94e93 Mon Sep 17 00:00:00 2001
From: Jon Nordby jono...@gmail.com
Date: Tue, 4 May 2010 12:42:53 +0200
Subject: [PATCH 2/2] plug-ins: OpenRaster visibility layer attribute
---
plug-ins/pygimp/plug-ins/file-openraster.py | 11 +++
1 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/plug-ins/pygimp/plug-ins/file-openraster.py
b/plug-ins/pygimp/plug-ins/file-openraster.py
index b41fc09..4c4ae67 100755
--- a/plug-ins/pygimp/plug-ins/file-openraster.py
+++ b/plug-ins/pygimp/plug-ins/file-openraster.py
@@ -35,8 +35,9 @@ def get_layer_attributes(layer):
x = int(a.get('x', '0'))
y = int(a.get('y', '0'))
opac = float(a.get('opacity', '1.0'))
+visible = a.get('visibility', 'visible') != 'hidden'
-return path, name, x, y, opac
+return path, name, x, y, opac, visible
def thumbnail_ora(filename, thumb_size):
@@ -92,7 +93,7 @@ def save_ora(img, drawable, filename, raw_filename):
orafile.write(tmp, path)
os.remove(tmp)
-def add_layer(x, y, opac, gimp_layer, path):
+def add_layer(x, y, opac, gimp_layer, path, visible=True):
store_layer(img, gimp_layer, path)
# create layer attributes
layer = ET.Element('layer')
@@ -103,13 +104,14 @@ def save_ora(img, drawable, filename, raw_filename):
a['x'] = str(x)
a['y'] = str(y)
a['opacity'] = str(opac)
+a['visibility'] = 'visible' if visible else 'hidden'
return layer
# save layers
for lay in img.layers:
x, y = lay.offsets
opac = lay.opacity / 100.0 # needs to be between 0.0 and 1.0
-add_layer(x, y, opac, lay, 'data/%s.png' % lay.name)
+add_layer(x, y, opac, lay, 'data/%s.png' % lay.name, lay.visible)
# save thumbnail
w, h = img.width, img.height
@@ -154,7 +156,7 @@ def load_ora(filename, raw_filename):
return res
for layer_no, layer in enumerate(get_layers(stack)):
-path, name, x, y, opac = get_layer_attributes(layer)
+path, name, x, y, opac, visible = get_layer_attributes(layer)
if not path.lower().endswith('.png'):
continue
@@ -174,6 +176,7 @@ def load_ora(filename, raw_filename):
gimp_layer.name = name
gimp_layer.set_offsets(x, y) # move to correct position
gimp_layer.opacity = opac * 100 # a float between 0 and 100
+gimp_layer.visible = visible
img.add_layer(gimp_layer, layer_no)
os.remove(tmp)
--
1.7.0.5
--
Regards Jon Nordby - www.jonnor.com
0001-plug-ins-OpenRaster-fix-wrong-layer-positions.patch
Description: Binary data
0002-plug-ins-OpenRaster-visibility-layer-attribute.patch
Description: Binary data
___
Gimp-developer mailing list
Gimp-developer@lists.XCF.Berkeley.EDU
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] VTF plug-in
On Fri, Apr 9, 2010 at 2:52 AM, Michael Hansen us3...@web.de wrote: Maybe my request is a little bit naive (because I guess, that everyone has enough work to do with more important things), but anyway: What I am really missing at the moment is a plug-in to import and export the VTF (Valve Texture Format) file format. More information: http://developer.valvesoftware.com/wiki/Valve_Texture_Format There already exists a Photoshop plug-in: http://nemesis.thewavelength.net/index.php?c=154#p154 And there also exists an open source library: http://nemesis.thewavelength.net/index.php?p=40 Or does anyone has an advise how to get the Photoshop plug-in working in GIMP? Hi Michael, People work on what they think is important, which might not coincide with what you think is important. So, if you want to get it done, the best way is to just do it yourself. I don't know anything about Photoshop plug-ins, but writing a GIMP file handler plug-in based should not be very hard if the above mentioned library does the heavy lifting. If it has a command line tool for converting to/from a image format that GIMP knows, a quick and dirty way could be to call that in the script. If so, its doable with some 10 lines of Python + the boilerplate to register the plugin. -- Regards Jon Nordby - www.jonnor.com ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] cannot start 2.7 from git
On Fri, Apr 2, 2010 at 1:49 PM, Alexander Rabtchevich alexander.v.rabtchev...@iaph.bas-net.by wrote: Hello I compiled current git under Ubuntu 9.10 against babl 0.1.2 and gegl 0.1.2 without gtk-docs. When I try to run gimp only writes in the console console output Is there a solution? Make sure that you don't have a Gimp (2.6) instance running. If you do, it will connect to it and just pop up a new image window there when you run gimp-2.7. If that is not the issue, please pastebin the entire console output (and the command you are running). -- Regards Jon Nordby - www.jonnor.com ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] [PATCH] OpenRaster: optimize PNG saving
On Sat, Mar 6, 2010 at 3:30 PM, Martin Nordholts ense...@gmail.com wrote: On 02/27/2010 03:14 PM, Jon Nordby wrote: Sets lower compression and disables interlacing. On a 5 layer image of 4500x6000px this gives an order of magnitude better save-times, with 50% increase in file size. Hi Jon Sorry for the late follow-up and thanks for maintaining the ORA plug-in. 50% increase in file size is pretty significant, maybe the compression ratio should be exposed in a UI? First some absolute numbers (rough measurements) so we don't get lost in relative figures. Saving said image on a 2Ghz core2duo with enough memory too keep it from swapping yields: xcf - 150MB - under 10 seconds xcf.gz - 65MB - about 23 seconds ora, before patch (maximum compression) - 48MB - about 7 minutes ora, after patch - 63MB - about 30 seconds Do you really think there it is a big point to introduce a UI for selecting compression? In my experience, the predominant usecase for OpenRaster seems to be for interchange between different applications when working locally. And for that I don't see the point. @@ -85,7 +85,7 @@ def save_ora(img, drawable, filename, raw_filename): def store_layer(img, drawable, path): tmp = os.path.join(tempdir, 'tmp.png') - pdb['file-png-save-defaults'](img, drawable, tmp, 'tmp.png') + pdb['file-png-save'](img, drawable, tmp, 'tmp.png', 0, 2, 1, 1, 1, 1, 1) It would be nice to make 0, 2, 1, 1, 1, 1, 1 immediately interpretable, for example by commenting or using local variables like so: embed_profile = 1 function(1, # save_comment embed_profile) You are right. Attached patch addresses this. -- Regards Jon Nordby - www.jonnor.com 0001-OpenRaster-optimize-PNG-saving-2.patch Description: Binary data ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
[Gimp-developer] [PATCH] OpenRaster: optimize PNG saving
From 0e41e65f31ae07c91f2ed5dc8f0c51d05949be51 Mon Sep 17 00:00:00 2001 From: Jon Nordby jono...@gmail.com Date: Sat, 27 Feb 2010 14:28:58 +0100 Subject: [PATCH] OpenRaster: optimize PNG saving Sets lower compression and disables interlacing. On a 5 layer image of 4500x6000px this gives an order of magnitude better save-times, with 50% increase in file size. --- plug-ins/pygimp/plug-ins/file-openraster.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/plug-ins/pygimp/plug-ins/file-openraster.py b/plug-ins/pygimp/plug-ins/file-openraster.py index 2016c2b..eeefe13 100755 --- a/plug-ins/pygimp/plug-ins/file-openraster.py +++ b/plug-ins/pygimp/plug-ins/file-openraster.py @@ -85,7 +85,7 @@ def save_ora(img, drawable, filename, raw_filename): def store_layer(img, drawable, path): tmp = os.path.join(tempdir, 'tmp.png') - pdb['file-png-save-defaults'](img, drawable, tmp, 'tmp.png') + pdb['file-png-save'](img, drawable, tmp, 'tmp.png', 0, 2, 1, 1, 1, 1, 1) orafile.write(tmp, path) os.remove(tmp) -- 1.7.0 -- Regards Jon Nordby - www.jonnor.com 0001-OpenRaster-optimize-PNG-saving.patch Description: Binary data ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] [Bug 605366] OpenRaster support
I've updated the patch to incorporate Svens feedback; changed the file and procedures to file-openraster-* Hoping this can be committed now. Also, please consider shipping it with the next 2.6 stable. -- Regards Jon Nordby - www.jonnor.com 0002-Basic-working-OpenRaster-file-support.patch Description: Binary data ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] [Bug 605366] OpenRaster support
On Mon, Dec 28, 2009 at 12:39 PM, Sven Neumann s...@gimp.org wrote: On Sun, 2009-12-27 at 18:59 +0100, Jon Nordby wrote: Please test, review and give feedback on the following patch/plug-in. On any aspect. It gives GIMP the ability to load and save OpenRaster files. Very nice indeed. Would you mind renaming the file and procedures to file-openraster-* ? No a problem. Any other feedback? Anything; code or naming conventions, code clarity, issues, et.c.? Is there anything else keeping this from being accepted? And can anyone answer my questions in my previous mail? - The thumbnail function does not seem to be called (at least a print statement does not give output) but thumbnailing does work as expected.* Anyone got an explanation? - Should the plug-in set mime-type association on the saving function somehow? * In the open file dialog that is. Happy new years to all! -- Regards Jon Nordby - www.jonnor.com ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] [Bug 605366] OpenRaster support
On Thu, Dec 24, 2009 at 4:47 PM, Martin Nordholts ense...@gmail.com wrote: Jon Nordby wrote: Picking up this right now. As stated in the report, there is a Python input handler plug-in (written by me) available that provides OpenRaster support. Are you be interested in shipping this for 2.8? What would it take? Personally I think we should accept a sane patch that gives GIMP the ability to load OpenRaster files, for 2.8. Please test, review and give feedback on the following patch/plug-in. On any aspect. It gives GIMP the ability to load and save OpenRaster files. Tested with GIMP 2.6.8 and current git (f0348aff40b27) using Python 2.6. Should work equally well with python 2.5 and maybe also 2.4. Some questions: - The thumbnail function does not seem to be called (at least a print statement does not give output) but thumbnailing does work as expected. Anyone got an explanation? - Should the plug-in set mime-type association on the saving function somehow? Known limitations: - Nested layers are flattened instead of leveraging nested layers available in 2.7+git - Thumbnail scaling is not implemented -- Regards Jon Nordby - www.jonnor.com 0001-Basic-working-OpenRaster-file-support.patch Description: Binary data file-ora.py Description: Binary data ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
