Re: [Gimp-developer] Does "Hue", "Saturation", "Value" layer modes need HSV? How about CIE LCH instead?

2009-08-02 Thread David Gowers
On Mon, Aug 3, 2009 at 5:13 AM, Martin Nordholts wrote: > The input I've gotten so far removed any remaining doubt about porting > those layer modes to LCH, so I've done that now: > > commit 18603ac192493296b191197a3e2b62c710398afd > Author: Martin Nordholts > Date: Sun Aug 2 21:35:10 2009 +02

Re: [Gimp-developer] Does "Hue", "Saturation", "Value" layer modes need HSV? How about CIE LCH instead?

2009-08-02 Thread Martin Nordholts
The input I've gotten so far removed any remaining doubt about porting those layer modes to LCH, so I've done that now: commit 18603ac192493296b191197a3e2b62c710398afd Author: Martin Nordholts Date: Sun Aug 2 21:35:10 2009 +0200 Bug 401754 – Port Hue, Saturation, Value to CIE LCH When

Re: [Gimp-developer] Does "Hue", "Saturation", "Value" layer modes need HSV? How about CIE LCH instead?

2009-08-02 Thread Emil Assarsson
Nice work Martin :-) I'm trying to make a valid comparison of the two images from PS and Gimp but it seems like the have block distortions from jpeg compression or something? I mostly use the color layer mode for overlay painting on black and white sketches. Here is an example of the use: http://

Re: [Gimp-developer] Does "Hue", "Saturation", "Value" layer modes need HSV? How about CIE LCH instead?

2009-08-02 Thread Martin Nordholts
On 08/02/2009 12:59 PM, David Gowers wrote: > LCH processing is definitely slower than HSV or HSL (whether optimized > or not), so this may have an impact on display update speed (and > consequently on user experience) Problems with real-time responsiveness when using LCH is a good point, and usi

Re: [Gimp-developer] Does "Hue", "Saturation", "Value" layer modes need HSV? How about CIE LCH instead?

2009-08-02 Thread David Gowers
On Sun, Aug 2, 2009 at 7:49 PM, SHIRAKAWA Akira wrote: > Martin Nordholts wrote: > > > Does anyone see any problems with using CIE LCH instead of HSV for these > > layer modes? We can ignore backwards compatibility issues for now. > > I very rarely use layer modes (and I'm not a GIMP hacker so I'm

Re: [Gimp-developer] Does "Hue", "Saturation", "Value" layer modes need HSV? How about CIE LCH instead?

2009-08-02 Thread Martin Nordholts
On 08/02/2009 12:19 PM, SHIRAKAWA Akira wrote: > Martin Nordholts wrote: > >> Does anyone see any problems with using CIE LCH instead of HSV for >> these layer modes? We can ignore backwards compatibility issues for now. > > Except for the final results, will there be any change at a user > interac

Re: [Gimp-developer] Does "Hue", "Saturation", "Value" layer modes need HSV? How about CIE LCH instead?

2009-08-02 Thread SHIRAKAWA Akira
Martin Nordholts wrote: > Does anyone see any problems with using CIE LCH instead of HSV for these > layer modes? We can ignore backwards compatibility issues for now. I very rarely use layer modes (and I'm not a GIMP hacker so I'm probably missing something), but if using internally CIE LCH fo

[Gimp-developer] Does "Hue", "Saturation", "Value" layer modes need HSV? How about CIE LCH instead?

2009-08-02 Thread Martin Nordholts
Hi, The "Color" layer mode has since long produced bad results, see bug 325564 [1] for a way to see this. The cause is a combination of rounding errors due to 8bit processing and poor properties/usage of the underlying color model HSL. I have just implemented Color based on the CIE LCH color m