Re: [Gimp-developer] Blur tool darkens image?

2007-04-28 Thread Jasper Schalken
Yep, you fixed it good! However, some artefacts appear when blurring near the edge of the image. It seems to blur/spread even further: http://schalken.wubbles.net/gimpblurnearedge.ogg On 28/04/07, Sven Neumann <[EMAIL PROTECTED]> wrote: > Hi, > > On Fri, 2007-04-27 at 22:06 +1000, Jasper Schalke

Re: [Gimp-developer] Blur tool darkens image?

2007-04-28 Thread gg
On Sat, 28 Apr 2007 09:43:45 +0200, Jasper Schalken <[EMAIL PROTECTED]> wrote: > It seems to blur/spread even further: I presume you are saying that there is some difference with the new version. Perhaps a more explicit description would be helpful if a couple of sentences could save us dow

Re: [Gimp-developer] Blur tool darkens image?

2007-04-28 Thread Jasper Schalken
> I presume you are saying that there is some difference with the new > version. No this was present in the previous version, however trivial in comparison to the darkening bug. > Perhaps a more explicit description would be helpful if a couple > of sentences could save us downloading a movie. It

Re: [Gimp-developer] Blur tool darkens image?

2007-04-28 Thread gg
On Sat, 28 Apr 2007 13:56:33 +0200, Jasper Schalken <[EMAIL PROTECTED]> wrote: >> I presume you are saying that there is some difference with the new >> version. > > No this was present in the previous version, however trivial in > comparison to the darkening bug. > >> Perhaps a more explicit de

Re: [Gimp-developer] Blur tool darkens image?

2007-04-28 Thread Jasper Schalken
Isn't it possible for the code to simply disregard pixels outside the image? That is, instead of pretending they actually exist and have a colour (if it works as I described above, that colour being the average of all the other pixel's colours), just don't include them in the blur at all. Only blu

Re: [Gimp-developer] Blur tool darkens image?

2007-04-28 Thread gg
On Sat, 28 Apr 2007 18:42:50 +0200, Jasper Schalken <[EMAIL PROTECTED]> wrote: > Isn't it possible for the code to simply disregard pixels outside the > image? That is, instead of pretending they actually exist and have a > colour (if it works as I described above, that colour being the > avera

Re: [Gimp-developer] Blur tool darkens image?

2007-04-28 Thread Geert Jordaens
For info on different technics of handling the edge you could always have a look at : http://www.cs.cornell.edu/Courses/cs465/2003fa/lectures/04filt-resamp/ Geert ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF

Re: [Gimp-developer] Blur tool darkens image?

2007-04-28 Thread Jasper Schalken
> You could have a look at the matrix convolution filter code. (Be warned > there are some minor bugs concerning edge effects IIRC) but it will serve > as an introduction to the different ways of treating edge data. Is that "void convolve_region(...) {...}" in /gimp/trunk/app/paint-funcs/paint-fun

Re: [Gimp-developer] Blur tool darkens image?

2007-04-28 Thread Jasper Schalken
The bug report: http://bugzilla.gnome.org/show_bug.cgi?id=434279 On 29/04/07, Jasper Schalken <[EMAIL PROTECTED]> wrote: > > You could have a look at the matrix convolution filter code. (Be warned > > there are some minor bugs concerning edge effects IIRC) but it will serve > > as an introduction