Re: [Gimp-developer] MMX in 1.3 tree

2003-07-11 Thread Nathan Carl Summers
On Fri, 11 Jul 2003, Steinar H. Gunderson wrote: > On Fri, Jul 11, 2003 at 12:52:08AM +0200, David Neary wrote: > I don't think there should be a % in the list of clobbered registers. What's > worse, I don't even think most versions of gcc know about MMX registers at > all (I might be mistaken, th

Re: [Gimp-developer] MMX in 1.3 tree

2003-07-11 Thread pcg
On Fri, Jul 11, 2003 at 12:13:29PM +0200, "Steinar H. Gunderson" <[EMAIL PROTECTED]> wrote: > I don't think there should be a % in the list of clobbered registers. yupp, there is no %mm1 register :) > worse, I don't even think most versions of gcc know about MMX registers at versions 2.x (usual

Re: [Gimp-developer] MMX in 1.3 tree

2003-07-11 Thread Steinar H. Gunderson
On Fri, Jul 11, 2003 at 12:52:08AM +0200, David Neary wrote: > asm("movq %0, %%mm1" > : > : "m"(rgba8_alpha_mask) > : "%mm1"); > > breaks on the second %mm1; I don't think there should be a % in the list of clobbered registers. What's worse, I don't even think most versions of gcc kn

Re: [Gimp-developer] MMX in 1.3 tree

2003-07-11 Thread pcg
On Thu, Jul 10, 2003 at 01:17:49PM +0200, Sven Neumann <[EMAIL PROTECTED]> wrote: > __asm__ __volatile__ () > > while the new code in The GIMP seems to be using > > asm() > > I don't know this stuff good enough to know the difference, but I'd __keyword__-style keywords are always there, eve

Re: [Gimp-developer] MMX in 1.3 tree

2003-07-10 Thread David Neary
David Neary wrote: > It seems that the thing which is annoying my compiler > is teh doubling of the % signs - with one % all passes well, with > two, not so well. A sligntly modified configure confirms this. > > Are the two %s necessary to prefix the mm registers? This is, of course, nonesense.

Re: [Gimp-developer] MMX in 1.3 tree

2003-07-10 Thread David Neary
Sven Neumann wrote: > Hi David, > > could you please test the attached diff to configure.in. It should > find the problem with your compiler and it even simplifies things a > bit. I have stried, and my computer passes the mmx test with flying colours :) It seems that the thing which is annoying

Re: [Gimp-developer] MMX in 1.3 tree

2003-07-10 Thread Sven Neumann
Hi, Helvetix Victorinox <[EMAIL PROTECTED]> writes: > This isn't quite ready to go yet. But thanks for the note. The > default build behaviour right now is to not build the new code. Please, if possible, let the code be build. We need as much testing as possible and we lack experience with bui

Re: [Gimp-developer] MMX in 1.3 tree

2003-07-10 Thread Helvetix Victorinox
This isn't quite ready to go yet. But thanks for the note. The default build behaviour right now is to not build the new code. Helvetix On Thu, Jul 10, 2003 at 08:36:44AM +0200, David Neary wrote: > > Hi, > > The new MMX composite code in the 1.3 tree doesn't build for me - > am I the only o

Re: [Gimp-developer] MMX in 1.3 tree

2003-07-10 Thread Sven Neumann
Hi David, could you please test the attached diff to configure.in. It should find the problem with your compiler and it even simplifies things a bit. Sven Index: configure.in === RCS file: /cvs/gnome/gimp/configure.in,v retrieving

Re: [Gimp-developer] MMX in 1.3 tree

2003-07-10 Thread Sven Neumann
Hi, David Neary <[EMAIL PROTECTED]> writes: > The new code is missing a #ifdef somewhere, I think - perhaps > composite-mmx.c shouldn't be build at all if USE_MMX isn't > defined... but that's another issue. I've added an #ifdef that causes the file content to be skipped. I prefer #ifdefs over a

Re: [Gimp-developer] MMX in 1.3 tree

2003-07-10 Thread Sven Neumann
Hi, David Neary <[EMAIL PROTECTED]> writes: > That said, some day soon, the GIMP developers are going to have > to get together for a brainstorning session about how we can > communicate better with the user base, and vice versa. With IRC, > Bugzilla, 2 mailing lists, usenet, the [EMAIL PROTECTED

Re: [Gimp-developer] MMX in 1.3 tree

2003-07-10 Thread Sven Neumann
Hi, indeed there was an #ifdef missing. My latest commit should fix the build for you. Can you please check config.log nevertheless since I'd like to make sure that the configure check did it's job correctly. These new checks could need some more testing. So if you are on an obscure hardware-plat

Re: [Gimp-developer] MMX in 1.3 tree

2003-07-10 Thread David Neary
Sven Neumann wrote: > Hi, > > David Neary <[EMAIL PROTECTED]> writes: > > > The new MMX composite code in the 1.3 tree doesn't build for me - > > am I the only one? My processor is a 350MHz K6-2 with mmx > > support, and the error says that there are a bunch (6, I think) > > of unknown registers

Re: [Gimp-developer] MMX in 1.3 tree

2003-07-10 Thread Sven Neumann
Hi, David Neary <[EMAIL PROTECTED]> writes: > The new MMX composite code in the 1.3 tree doesn't build for me - > am I the only one? My processor is a 350MHz K6-2 with mmx > support, and the error says that there are a bunch (6, I think) > of unknown registers in the asm (%mm0, %mm1, ...). The c

[Gimp-developer] MMX in 1.3 tree

2003-07-10 Thread David Neary
Hi, The new MMX composite code in the 1.3 tree doesn't build for me - am I the only one? My processor is a 350MHz K6-2 with mmx support, and the error says that there are a bunch (6, I think) of unknown registers in the asm (%mm0, %mm1, ...). I'm mailing this to the list because, to be quite hon