[jira] [Commented] (GIRAPH-18) Refactor BspServiceWorker::loadVertices()

2011-08-30 Thread Avery Ching (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-18?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094330#comment-13094330 ] Avery Ching commented on GIRAPH-18: --- This isn't the only area that needs refactoring =).

[jira] [Commented] (GIRAPH-14) Support for the Facebook Hadoop branch

2011-08-30 Thread Jakob Homan (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094321#comment-13094321 ] Jakob Homan commented on GIRAPH-14: --- Applied the patch and verified everything still work

[jira] [Updated] (GIRAPH-14) Support for the Facebook Hadoop branch

2011-08-30 Thread Avery Ching (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-14?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Avery Ching updated GIRAPH-14: -- Attachment: facebook3.patch Updated with README instructions for building with the Facebook Hadoop relea

[jira] [Commented] (GIRAPH-14) Support for the Facebook Hadoop branch

2011-08-30 Thread Avery Ching (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094305#comment-13094305 ] Avery Ching commented on GIRAPH-14: --- In theory, I believe that Facebook's distro is onlin

[jira] [Commented] (GIRAPH-14) Support for the Facebook Hadoop branch

2011-08-30 Thread Jakob Homan (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094271#comment-13094271 ] Jakob Homan commented on GIRAPH-14: --- I'm not up to date on FB's distribution. It's availa

[jira] [Updated] (GIRAPH-18) Refactor BspServiceWorker::loadVertices()

2011-08-30 Thread Jakob Homan (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-18?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jakob Homan updated GIRAPH-18: -- Attachment: GIRAPH-18.patch Patch: * Refactors BspServiceWorker::loadVertices() into several smaller f

[jira] [Created] (GIRAPH-18) Refactor BspServiceWorker::loadVertices()

2011-08-30 Thread Jakob Homan (JIRA)
Refactor BspServiceWorker::loadVertices() - Key: GIRAPH-18 URL: https://issues.apache.org/jira/browse/GIRAPH-18 Project: Giraph Issue Type: Improvement Reporter: Jakob Homan Ass

[jira] [Commented] (GIRAPH-14) Support for the Facebook Hadoop branch

2011-08-30 Thread Avery Ching (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094216#comment-13094216 ] Avery Ching commented on GIRAPH-14: --- Great to hear it! When one of the committers gets a

[jira] [Commented] (GIRAPH-14) Support for the Facebook Hadoop branch

2011-08-30 Thread Joe Xie (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094209#comment-13094209 ] Joe Xie commented on GIRAPH-14: --- thank you Avery! It passed the unittest for me too. > Supp

[jira] [Updated] (GIRAPH-14) Support for the Facebook Hadoop branch

2011-08-30 Thread Avery Ching (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-14?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Avery Ching updated GIRAPH-14: -- Attachment: facebook2.txt Looks like I needed to change the groupId so that the right dependencies are

[jira] [Assigned] (GIRAPH-4) New project logo

2011-08-30 Thread Jakob Homan (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-4?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jakob Homan reassigned GIRAPH-4: Assignee: Kenin Coloma > New project logo > > > Key: GIRAPH-4 >

[jira] [Commented] (GIRAPH-4) New project logo

2011-08-30 Thread Kenin Coloma (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-4?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094137#comment-13094137 ] Kenin Coloma commented on GIRAPH-4: --- Sure, I'll get on it. > New project logo > -

[jira] [Commented] (GIRAPH-4) New project logo

2011-08-30 Thread Avery Ching (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-4?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094134#comment-13094134 ] Avery Ching commented on GIRAPH-4: -- Yes, it would certainly be nice to have a real logo. D

[jira] [Commented] (GIRAPH-4) New project logo

2011-08-30 Thread Kenin Coloma (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-4?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094128#comment-13094128 ] Kenin Coloma commented on GIRAPH-4: --- What a great idea! > New project logo >

Re: Reviewboard for code reviews

2011-08-30 Thread Avery Ching
Okay, let's make it optional for now. For me, it definitely helps to visualize the changes better. Also, I think the feedback tool is pretty good. Avery On Aug 30, 2011, at 11:52 AM, Henry Saputra wrote: > Argh I meant "It should just an option to help review and should not > be required for

Re: Reviewboard for code reviews

2011-08-30 Thread Henry Saputra
Argh I meant "It should just an option to help review and should not be required for patches." - Henry On Tue, Aug 30, 2011 at 11:51 AM, Henry Saputra wrote: > +1 > > It should just optional to help review not required. > > - Henry > > On Tue, Aug 30, 2011 at 11:48 AM, Jakob Homan wrote: >> We'

Re: Reviewboard for code reviews

2011-08-30 Thread Henry Saputra
+1 It should just optional to help review not required. - Henry On Tue, Aug 30, 2011 at 11:48 AM, Jakob Homan wrote: > We've just gone around on this one for Kafka and, if reviewboard is > provided, it would be good to keep it as an optional part of the > process.  I've had very negative experi

Re: Reviewboard for code reviews

2011-08-30 Thread Jakob Homan
We've just gone around on this one for Kafka and, if reviewboard is provided, it would be good to keep it as an optional part of the process. I've had very negative experiences with it, both in Hadoop and Hive. If one would like to do a reviewboard review, that's great - but for those who don't,

Re: Reviewboard for code reviews

2011-08-30 Thread Avery Ching
Thanks Henry. I have filed issue https://issues.apache.org/jira/browse/INFRA-3892 to get reviewboard access. Avery On Aug 30, 2011, at 11:35 AM, Henry Saputra wrote: Hi Avery, yes you should file INFRA ticket to add Giraph as Groups in reviews board. I filed tickets to create one for Kafka a

Re: Reviewboard for code reviews

2011-08-30 Thread Henry Saputra
Hi Avery, yes you should file INFRA ticket to add Giraph as Groups in reviews board. I filed tickets to create one for Kafka and Gora. - Henry On Mon, Aug 29, 2011 at 10:13 PM, Avery Ching wrote: > https://blogs.apache.org/infra/entry/reviewboard_instance_running_at_the > > I'll file an INFRA t

[jira] [Commented] (GIRAPH-14) Support for the Facebook Hadoop branch

2011-08-30 Thread Avery Ching (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093879#comment-13093879 ] Avery Ching commented on GIRAPH-14: --- It's good to hear that you can run it on your cluste

[jira] [Commented] (GIRAPH-17) Giraph doesn't give up properly after the maximum connect attempts to ZooKeeper

2011-08-30 Thread Avery Ching (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093861#comment-13093861 ] Avery Ching commented on GIRAPH-17: --- Thanks for taking a look. Committed. > Giraph does

[jira] [Commented] (GIRAPH-14) Support for the Facebook Hadoop branch

2011-08-30 Thread Joe Xie (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093831#comment-13093831 ] Joe Xie commented on GIRAPH-14: --- Thank you Avery! maybe my test file in the trunk is obsolete

[jira] [Commented] (GIRAPH-14) Support for the Facebook Hadoop branch

2011-08-30 Thread Joe Xie (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093828#comment-13093828 ] Joe Xie commented on GIRAPH-14: --- Great job Avery! I can compile on my side too and it works w

[jira] [Commented] (GIRAPH-17) Giraph doesn't give up properly after the maximum connect attempts to ZooKeeper

2011-08-30 Thread Owen O'Malley (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093820#comment-13093820 ] Owen O'Malley commented on GIRAPH-17: - Ok, thanks. In that case, +1. > Giraph doesn't

[jira] [Commented] (GIRAPH-17) Giraph doesn't give up properly after the maximum connect attempts to ZooKeeper

2011-08-30 Thread Avery Ching (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093808#comment-13093808 ] Avery Ching commented on GIRAPH-17: --- Sure. The main part of this fix is -if

[jira] [Commented] (GIRAPH-17) Giraph doesn't give up properly after the maximum connect attempts to ZooKeeper

2011-08-30 Thread Owen O'Malley (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093786#comment-13093786 ] Owen O'Malley commented on GIRAPH-17: - Can you explain the fix? It looks like cleanup a