[
https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13209727#comment-13209727
]
Avery Ching commented on GIRAPH-40:
---
Can another committer please look at this as per
[
https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13209801#comment-13209801
]
Avery Ching commented on GIRAPH-40:
---
Thanks so much for the reviews Jakob and Sebastian.
[
https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13209814#comment-13209814
]
Hudson commented on GIRAPH-40:
--
Integrated in Giraph-trunk-Commit #83 (See
[
https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13208731#comment-13208731
]
Jakob Homan commented on GIRAPH-40:
---
ok, looks good to me. +1. However, since no one
[
https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13208750#comment-13208750
]
Jakob Homan commented on GIRAPH-40:
---
Actually, I have a concern:
Compiles will now fail
[
https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13208786#comment-13208786
]
Jakob Homan commented on GIRAPH-40:
---
Thanks. +1 on latest patch, while still hoping to
[
https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207185#comment-13207185
]
Jakob Homan commented on GIRAPH-40:
---
bq. The below examples are what Checkstyle wants to
[
https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207188#comment-13207188
]
Avery Ching commented on GIRAPH-40:
---
So for the first example, we need to follow that
[
https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207195#comment-13207195
]
Jakob Homan commented on GIRAPH-40:
---
bq. So for the first example, we need to follow that
[
https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207203#comment-13207203
]
Avery Ching commented on GIRAPH-40:
---
I'm not a checkstyle expert, but I don't think so. I
[
https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207205#comment-13207205
]
Jakob Homan commented on GIRAPH-40:
---
OK. If we can fix it later, it'll be less traumatic
[
https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206291#comment-13206291
]
Avery Ching commented on GIRAPH-40:
---
Thank you for the feedback Claudio. I'll continue
[
https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13205976#comment-13205976
]
Avery Ching commented on GIRAPH-40:
---
Here are some examples of one problem: Checkstyle
[
https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13199806#comment-13199806
]
Claudio Martella commented on GIRAPH-40:
I'm pretty much in favor of this, it's
[
https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13199938#comment-13199938
]
Avery Ching commented on GIRAPH-40:
---
By the way Claudio, I think several IDEs have
[
https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13199935#comment-13199935
]
Avery Ching commented on GIRAPH-40:
---
What I meant and am working on, is failing the build
16 matches
Mail list logo
