[PATCH] t9402: sed -i is not portable

2012-11-10 Thread Torsten Bögershausen
The command line sed -i -e s/foo/bar/ filename works as expected under GNU/Linux: all foo are replaced by bar in the file filename sed on other systems like e.g. Mac OS X creates a backup file called filename-e, because the -i must be followed by a file name. As the -i is not in POSIX either,

Re: bare vs non-bare 1.7 then =1.7 ?

2012-11-10 Thread Enrico Weigelt
When experimenting in order to train some colleagues, I saw that If I clone a repository, I couldn't push to it because it was a non-bare one. Searchin for some explanations, I found this ressource: http://www.bitflop.com/document/111 That's just a precaution (technically it's not

Re: Support for a series of patches, i.e. patchset or changeset?

2012-11-10 Thread Enrico Weigelt
snip yet another idea: you coud always put your patchsets into separate branches, rebase them ontop target branch before merging, and then do an non-ff-merge, which will make the history look like: * merged origin/feature_foo |\ | * first preparation fo feature foo | * part a | * part b |/ *

t9350-fast-export.sh broken on peff/pu under Mac OS X

2012-11-10 Thread Torsten Bögershausen
The short version: echo -n doesn't seem to be portable. The following works for me: (And is this a typo: test_expect_success 'test biridectionality' ') /Torsten diff ../../git.peff/t/t9350-fast-export.sh t9350-fast-export.sh 444,445c444,445 echo -n marks-cur echo -n

Do not add an empty value from config credential.helper

2012-11-10 Thread 乙酸鋰
Below is current git message when a local config credential.helper has an empty value. Please skip an empty value. $ git push --force origin master git: 'credential-' is not a git command. See 'git --help'. Did you mean this? credential Total 0 (delta 0), reused 0 (delta 0) To

overriding/removing inherited credential.helper

2012-11-10 Thread 乙酸鋰
In credential.c, line 67: if (!strcmp(key, helper)) string_list_append(c-helpers, value); In global config, I add one credential helper. But I do not want to use any credential helper in a specific repository. Currently there is no way in local config to override and remove inherited

Re: Bizarre problem cloning repo from Codeplex

2012-11-10 Thread Andreas Schwab
Enrico Weigelt enrico.weig...@vnc.biz writes: Their webserver seems to be configured quite restrictively (eg. cannot access files like 'packed-refs'). Probably it just doesn't exist. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5

http-backend GIT_COMMITTER_NAME -EMAIL documentation bug

2012-11-10 Thread gima
Documentation says that envvars GIT_COMMITTER_NAME and GIT_COMMITTER_EMAIL formed from REMOTE_USER and REMOTE_ADDR, but doesn't mention that they are left alone if they have been set already. Referring to: https://github.com/git/git/blob/master/Documentation/git-http-backend.txt#L178 Source

Re: What's cooking in git.git (Nov 2012, #02; Fri, 9)

2012-11-10 Thread Paul Fox
kalle olavi niemitalo wrote: Jeff King p...@peff.net writes: Comments welcome from people using unusual editors (e.g., a script that starts an editor in another window then blocks, waiting for the user to finish). I often run a shell in Emacs in X, then start git commit in

Re: git-reset man page

2012-11-10 Thread Krzysztof Mazur
On Sat, Nov 10, 2012 at 10:55:13AM +0100, Angelo Borsotti wrote: Hi the man page of git-reset, synopsys, does not allow for an argumentless call, and the description does not tell either what is the meaning of it. This issue was already reported by Bojan Petrović:

Re: Help requested - trying to build a tool doing whole-tree commits

2012-11-10 Thread Junio C Hamano
Unknown unknown@unknown.invalid writes: (Apologies if this arrives twice. I'm on the road, with somewhat flaky email.) Because of my work on reposurgeon, I am sometimes asked to produce git repositories for very old projects that not only are still using CVS but have ancient releases not in

Re: What's cooking in git.git (Nov 2012, #02; Fri, 9)

2012-11-10 Thread Junio C Hamano
Jeff King p...@peff.net writes: On Fri, Nov 09, 2012 at 12:27:35PM -0800, Junio C Hamano wrote: What we should have arranged was to have https://github.com/git/git (which is not even owned by me, but I asked somebody at GitHub to assign me a write privilege) writable by the interim

Re: RFD: fast-import is picky with author names (and maybe it should - but how much so?)

2012-11-10 Thread Michael J Gruber
Felipe Contreras venit, vidit, dixit 09.11.2012 15:34: On Fri, Nov 9, 2012 at 10:28 AM, Michael J Gruber g...@drmicha.warpmail.net wrote: Hg seems to store just anything in the author field (committer). The various interfaces that are floating around do some behind-the-back conversion to

old folders returning

2012-11-10 Thread David Coombes
Issue: I renamed a deprecated folder that i needed the code for, added .old to name. I then pushed to the repository and the original folder and the newly renamed are now in the repository and on my local branch. I renamed 'autoflow' to 'autoflow.old' and worked away ok. But after the

Re: old folders returning

2012-11-10 Thread Andy Hawkins
Hi, In article can4prmavggqn3zm1atde5cadjszzlovpoqasjrzfuvrkrqs...@mail.gmail.com, David Coombeswebe...@gmail.com wrote: The only suggestion I can think of is that the name wasn't cleared after the git add * and then git went looking for an earlier copy. But seems the issue is with

Re: What's cooking in git.git (Oct 2012, #09; Mon, 29)

2012-11-10 Thread Ramsay Jones
Jeff King wrote: On Fri, Nov 02, 2012 at 09:33:14PM +, Ramsay Jones wrote: (Linux is my main platform, but I like to keep cygwin working because it has kept me sane on Windows ever since (about) 1995 ...) Stranger in a strange land ;-) I used a different trick around the same time to

[PATCH] remote-curl.c: Fix a gcc warning

2012-11-10 Thread Ramsay Jones
In particular, gcc complains as follows: CC remote-curl.o remote-curl.c: In function `rpc_service': remote-curl.c:403: warning: 'gzip_size' might be used uninitialized \ in this function The 'gzip_size' variable would not, in fact, be used uninitialized. However, in

Re: RFD: fast-import is picky with author names (and maybe it should - but how much so?)

2012-11-10 Thread Felipe Contreras
On Sat, Nov 10, 2012 at 6:28 PM, Michael J Gruber g...@drmicha.warpmail.net wrote: Felipe Contreras venit, vidit, dixit 09.11.2012 15:34: On Fri, Nov 9, 2012 at 10:28 AM, Michael J Gruber g...@drmicha.warpmail.net wrote: Hg seems to store just anything in the author field (committer). The

Re: [PATCH v3 1/3] git-submodule add: Add -r/--record option

2012-11-10 Thread W. Trevor King
On Thu, Nov 08, 2012 at 11:34:54PM -0800, Junio C Hamano wrote: W. Trevor King wk...@tremily.us writes: By remaining agnostic on the variable usage, this patch makes submodule setup more convenient for all parties. I personally do not think remaining agnostic on the usage is a good

Re: What's cooking in git.git (Nov 2012, #02; Fri, 9)

2012-11-10 Thread Junio C Hamano
SZEDER Gábor sze...@ira.uka.de writes: I think it is better to keep the tests simple and maintainable. Maintainable? There is nothing to maintain here ... OTOH, this series has some serious drawbacks. It makes debugging more difficult Are these referring to the same aspect of the

Re: [msysGit] [PATCH] git tag --contains : avoid stack overflow

2012-11-10 Thread Philip Oakley
From: Jean-Jacques Lafay jeanjacques.la...@gmail.com Sent: Saturday, November 10, 2012 5:36 PM In large repos, the recursion implementation of contains(commit, commit_list) may result in a stack overflow. Replace the recursion with a loop to fix it. Signed-off-by: Jean-Jacques Lafay

Re: git-reset man page

2012-11-10 Thread Junio C Hamano
Krzysztof Mazur krzys...@podlesie.net writes: Maybe we should just add that paths is an shortcut for pathspec and fix places where paths and pathspec are mixed or path is used as pathspec. We should unify uses of paths and path (the former should be path... or something). Some places you

Re: git-reset man page

2012-11-10 Thread Krzysztof Mazur
On Sat, Nov 10, 2012 at 12:02:12PM -0800, Junio C Hamano wrote: Krzysztof Mazur krzys...@podlesie.net writes: Maybe we should just add that paths is an shortcut for pathspec and fix places where paths and pathspec are mixed or path is used as pathspec. We should unify uses of paths and

Re: What's cooking in git.git (Nov 2012, #02; Fri, 9)

2012-11-10 Thread Andreas Schwab
Kalle Olavi Niemitalo k...@iki.fi writes: With strace, it looks like CVS sets SIG_IGN as the handler of SIGINT and SIGQUIT only in the parent process after forking, not in the child process that executes the editor. CVS also temporarily blocks signals by calling sigprocmask, but it undoes

Re: [msysGit] [PATCH] git tag --contains : avoid stack overflow

2012-11-10 Thread Pat Thoyts
On 10 November 2012 21:13, Jean-Jacques Lafay jeanjacques.la...@gmail.com wrote: Le samedi 10 novembre 2012 21:00:10 UTC+1, Philip Oakley a écrit : From: Jean-Jacques Lafay jeanjacq...@gmail.com Sent: Saturday, November 10, 2012 5:36 PM In large repos, the recursion implementation of

Re: t5801-remote-helpers.sh fails

2012-11-10 Thread Felipe Contreras
On Sat, Nov 10, 2012 at 8:20 PM, Torsten Bögershausen tbo...@web.de wrote: On 11/10/2012 08:15 PM, Felipe Contreras wrote: Hi, On Sat, Nov 10, 2012 at 2:48 PM, Torsten Bögershausen tbo...@web.de wrote: on peff/pu t5801 fails, the error is in git-remote-testgit, please see below. That's

Re: What's cooking in git.git (Nov 2012, #02; Fri, 9)

2012-11-10 Thread Paul Fox
kalle olavi niemitalo wrote: Paul Fox p...@foxharp.boston.ma.us writes: when i implemented the change, i wondered if some twisted emacs workflow would be an issue. ;-) and i almost blocked SIGQUIT as well -- the two programs i looked at for precedent (CVS and MH) both block both

Re: Reviews on mailing-list

2012-11-10 Thread Felipe Contreras
On Sun, Nov 11, 2012 at 12:19 AM, Deniz Türkoglu de...@spotify.com wrote: This is my first mail to the git mailing list. I have been following the list for some time now and I would like to suggest moving the reviews out of the mailing list, for example to a gerrit instance, I believe it

[PATCH] git-credential-gnome-keyring: Remove die

2012-11-10 Thread Matt Kraai
git-credential-gnome-keyring defines die, but it is unused and incorrect (it passes a va_list to error, which does not expect one), so remove it. Signed-off-by: Matt Kraai kr...@ftbfs.org --- .../credential/gnome-keyring/git-credential-gnome-keyring.c | 10 -- 1 file changed, 10

Re: t9350-fast-export.sh broken on peff/pu under Mac OS X

2012-11-10 Thread Stefano Lattarini
On 11/11/2012 12:11 AM, Felipe Contreras wrote: On Sat, Nov 10, 2012 at 11:39 PM, Junio C Hamano gits...@pobox.com wrote: Felipe Contreras felipe.contre...@gmail.com writes: On Sat, Nov 10, 2012 at 3:37 PM, Torsten Bögershausen tbo...@web.de wrote: The short version: echo -n doesn't seem to

Re: t9350-fast-export.sh broken on peff/pu under Mac OS X

2012-11-10 Thread Felipe Contreras
On Sun, Nov 11, 2012 at 1:19 AM, Stefano Lattarini stefano.lattar...@gmail.com wrote: On 11/11/2012 12:11 AM, Felipe Contreras wrote: On Sat, Nov 10, 2012 at 11:39 PM, Junio C Hamano gits...@pobox.com wrote: Felipe Contreras felipe.contre...@gmail.com writes: On Sat, Nov 10, 2012 at 3:37 PM,

Re: Reviews on mailing-list

2012-11-10 Thread Thiago Farina
On Sat, Nov 10, 2012 at 9:40 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Sun, Nov 11, 2012 at 12:19 AM, Deniz Türkoglu de...@spotify.com wrote: This is my first mail to the git mailing list. I have been following the list for some time now and I would like to suggest moving the

Re: Reviews on mailing-list

2012-11-10 Thread Deniz Türkoglu
On Sat, Nov 10, 2012 at 3:40 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Sun, Nov 11, 2012 at 12:19 AM, Deniz Türkoglu de...@spotify.com wrote: This is my first mail to the git mailing list. I have been following the list for some time now and I would like to suggest moving the

Re: [PATCH v4 3/6] Color skipped tests blue

2012-11-10 Thread Adam Spiers
On Fri, Sep 21, 2012 at 02:13:25AM -0400, Jeff King wrote: On Wed, Sep 19, 2012 at 09:24:23PM +0100, Adam Spiers wrote: t/test-lib.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/t/test-lib.sh b/t/test-lib.sh index 5293830..78c88c2 100755 ---

[PATCH] gitweb: git_summary - show $project in title

2012-11-10 Thread Henrich Schuchardt
Gitweb pages are structured by divs of class title with grey background. The shortlog, and the log page show the project name as the first title. Page summary only shows an empty grey box above the project details. This provides an inconstent user experience. This patch adds the missing project

Re: Reviews on mailing-list

2012-11-10 Thread Junio C Hamano
Thiago Farina tfrans...@gmail.com wrote: Requiring a web browser is a huge requirement, ham?? No, but requiring reviews and discussions typed in the browser is. Pardon terseness, typo and HTML from a tablet. -- To unsubscribe from this list: send the line unsubscribe git in the body of a

Re: What's cooking in git.git (Nov 2012, #02; Fri, 9)

2012-11-10 Thread Kalle Olavi Niemitalo
Paul Fox p...@foxharp.boston.ma.us writes: you're sending SIGINT to the cvs commit command, and that causes the editor to die right away? That's right. It is not a quirk of shell-mode in Emacs, because I get the same result with ^C in xterm too. %

Re: Reviews on mailing-list

2012-11-10 Thread Ramkumar Ramachandra
Deniz Türkoglu wrote: I have spoken to Shawn Pearce (gerrit project lead, google) and he said he is OK with hosting the gerrit instance. I would like to hear your thoughts on this. I personally think email is by far the best interface for patches, reviews, and discussions. Git patches are