Expose the `config_set` C API as a set of simple commands in order to
facilitate testing. Add tests for the `config_set` API as well as for
`git_config_get_*()` family for the usual config files.
Signed-off-by: Tanay Abhra tanay...@gmail.com
---
.gitignore | 1 +
Makefile
Hi,
[PATCH V5]: `config_set` now uses a single hashmap. Corrected style nits raised
in
the thread[7]. Thanks to Junio and Matthieu for their
suggestions.
[PATCH v4]: Introduced `config_set` construct which points to a ordered set of
config-files cached as
Currently `git_config()` uses a callback mechanism and file rereads for
config values. Due to this approach, it is not uncommon for the config
files to be parsed several times during the run of a git program, with
different callbacks picking out different variables useful to themselves.
Add a
On Sun, Jul 6, 2014 at 12:06 AM, David Turner dtur...@twopensource.com wrote:
Add tests to confirm that invalidation of subdirectories nether over-
s/nether/neither/
nor under-invalidates.
Signed-off-by: David Turner dtur...@twitter.com
---
--
To unsubscribe from this list: send the line
On 06/07/14 08:19, Tanay Abhra wrote:
Currently `git_config()` uses a callback mechanism and file rereads for
config values. Due to this approach, it is not uncommon for the config
files to be parsed several times during the run of a git program, with
different callbacks picking out different
From: Denton, Cari-Lee
Sent: July 6, 2014 12:44 AM
To: Denton, Cari-Lee
Subject: FYI
You are picked, e-mail:
mackenzie.glo...@yahoo.esmailto:mackenzie.glo...@yahoo.es for Info.
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a
-w looks good for my very specific whitespace case, but imagine you
are adding or removing parenthesis like, it is still codestyle but -w
doesn't cut it anymore.
So yes, I want a flag!
Well, if I think about it, the tools can implement themselves.
They just have to look into the commit message
They just have to look into the commit message and look for
#codestylefix or whatever other string.
In many projects I have seen, they have a format for commits, such as
docs: Add support for XXX, formatting: Space before parethesis and
after comas, tests: and so on.
Maybe, being able to
Hi,
I'm trying to get the git p4 tests to pass on my machine (OS X
Mavericks) from master before making some changes. I'm experiencing a
test failure in detect copies of the rename test.
The test creates file2 with some content, creates a few copies (each
with a commit), then does the following
Hi,
On Sat, Jul 5, 2014 at 1:43 AM, Andi Kleen a...@firstfloor.org wrote:
From: Andi Kleen a...@linux.intel.com
Signed-off-by: Andi Kleen a...@linux.intel.com
---
diff-res | 26 ++
1 file changed, 26 insertions(+)
create mode 100755 diff-res
diff --git
a justification why the geometric mean is used here would increase my
confident significantly.
It's just a standard way to summarize sets of benchmarks. For example SPEC
uses the same approach.
Anyways the script is not essential to the rest of the profile feedback
feature. Just ignore it if
On Sun, Jul 6, 2014 at 6:15 PM, Andi Kleen a...@linux.intel.com wrote:
a justification why the geometric mean is used here would increase my
confident significantly.
It's just a standard way to summarize sets of benchmarks. For example SPEC
uses the same approach.
No, SPEC would have
Tanay Abhra tanay...@gmail.com writes:
Add a default `config_set`, `the_config_set` to cache all key-value pairs
read from usual config files (repo specific .git/config, user wide
~/.gitconfig and the global /etc/gitconfig). `the_config_set` uses a
single hashmap populated using
Tanay Abhra tanay...@gmail.com writes:
+test_expect_success 'get value for a simple key' '
+ echo very blue expect
+ test-config get_value core.penguin actual
+ test_cmp expect actual
+'
All these tests would greatly benefit from a helper like
test_expect_config () {
Tanay Abhra tanay...@gmail.com writes:
diff --git a/test-config.c b/test-config.c
new file mode 100644
index 000..45ccd0a
--- /dev/null
+++ b/test-config.c
@@ -0,0 +1,127 @@
+#include cache.h
+#include hashmap.h
Useless include, you're not using the hashmap directly.
+int main(int
Hi.
What future does this have? Currently it is marked as
Stalled, but still mergeable with some trivial conflicts
and seem to be working (except some bugs in interaction with
submodules, see below). It would be very nice if this
feature is officially supported.
I also have a comment about how
A couple of quick nits.
Tanay Abhra wrote:
+test_expect_success 'clear default config' '
+ rm -f .git/config
+'
Unnecessary; a fresh temporary directory is created for each test run.
+test_expect_success 'initialize default config' '
You might want to mark this as setup.
--
To
ml.christophbon...@gmail.com wrote on Sun, 06 Jul 2014 16:32 +0200:
I'm trying to get the git p4 tests to pass on my machine (OS X
Mavericks) from master before making some changes. I'm experiencing a
test failure in detect copies of the rename test.
The test creates file2 with some content,
The --no-ff option instructs git-rebase to always recreate commits as
they are being replayed, even if fast-forwards are possible.
However, if git-rebase is asked to recreate merge commits (via the -p
option), it suddenly ignores the --no-ff option and fast-forwards
both normal and merge commits
19 matches
Mail list logo
