Re: [PATCH v12 2/5] test-parse-options: print quiet as integer

On Tue, Apr 5, 2016 at 11:39 AM, Pranit Bauva wrote: > On Mon, Apr 4, 2016 at 3:00 AM, Eric Sunshine wrote: >> On Sat, Apr 2, 2016 at 7:33 PM, Pranit Bauva wrote: >>> Current implementation of parse-options.c treats

Re: [PATCH 1/2] imap-send.c: implements the GIT_CURL_DEBUG environment variable

On Tue, Apr 5, 2016 at 6:21 AM, Elia Pinto wrote: > 2016-04-01 22:25 GMT+02:00 Eric Sunshine : >> In addition to review comments by others, why are the new curl_dump() >> and curl_trace() functions duplicated in both patches rather than >>

Re: [PATCH v1] correct blame for files commited with CRLF

On 05.04.16 23:12, Junio C Hamano wrote: > tbo...@web.de writes: > >> +git config core.autocrlf true && >> +mv crlfinrepo tmp && >> +git checkout crlfinrepo && >> +rm tmp && > > Why not just "rm -f crlfinrepo" and "git checkout crlfinrepo"? The intention was to get a new inode

ATTN: BENEFICIARY

-- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Can `git grep` have `--Author` option?

This is a feature request. >From time to time, I want to re-use MY code. So git grep with --Author options >is really useful. My current git version is 2.6.3, looks it doesn't have this >option. -- Best Regards, Chen Bin -- Help me, help you -- To unsubscribe from this list: send the line

Re: git diff --exit-code does not honour textconv setting

Michael J Gruber writes: >> The "test" command is used as it does not generate any output on stdout. > > "test" is a bit of a red herring here since it will receive commands. > But your example works even with "true" which ignores its commands and > produces no output.

Re: Triangular workflows and some anecdotes from the trenches

Chris Packham writes: > We ran into something at $dayjob the other day. The actual problem was > a developer ended up amending a commit that had already been pushed. > It happens occasionally and is usually recoverable with a simple > rebase and is generally a learning

reply

Good day, friend. I'm a Banker with HSBC here in Malaysia.I have an interesting business deal for you that will be of immense benefit to both of us.Although this may be hard for you to believe,we stand to gain $7million in a matter of days. Please grant me the benefit of doubt and hear me out.

Re: [PATCH] diff: run arguments through precompose_argv

Torsten Bögershausen writes: > On 05.04.16 21:15, Johannes Sixt wrote: >> Am 05.04.2016 um 19:09 schrieb Junio C Hamano: Thanks-to: Torsten Bögershausen >> >> I sense NFD disease: The combining diaresis should combine with the o, not >> the g. Here is a

Re: [PATCH] send-email: more meaningful Message-ID

Junio C Hamano wrote: > Eric Wong writes: > > > Using a mmddHHMMSS date representation is more meaningful to > > humans, especially when used for lookups on NNTP servers or linking > > to archive sites via Message-ID (e.g. mid.gmane.org or > >

Re: [PATCH v1] correct blame for files commited with CRLF

tbo...@web.de writes: > + git config core.autocrlf true && > + mv crlfinrepo tmp && > + git checkout crlfinrepo && > + rm tmp && Why not just "rm -f crlfinrepo" and "git checkout crlfinrepo"? > + git blame crlfinrepo >actual && > + grep "A U Thor" actual > +' > + >

Re: [PATCH] send-email: more meaningful Message-ID

Eric Wong writes: > Using a mmddHHMMSS date representation is more meaningful to > humans, especially when used for lookups on NNTP servers or linking > to archive sites via Message-ID (e.g. mid.gmane.org or > mid.mail-archive.com). This timestamp format more easily

Re: Is OS X still supported?

Thanks for the information that binary builds are availably on SourceForge faster than on git-scm. I can see the v2.8.1 for OS X was uploaded few hours ago to the SF, so my main problem (lack of security fixes in git for OS X) is solved. The automation process should be probably reviewed, though

Re: [PATCH v1] correct blame for files commited with CRLF

tbo...@web.de writes: > This fix is completely independent of the rest of the series, > so break out 6/7 from tb/safe-crlf-output. Sounds sensible. It is somewhat sad and strange that we need to rely on what is in the index to show the current working tree state, but this makes the things

Re: [PATCH] api-trace.txt: fix typo

Eric Sunshine writes: > On Tue, Apr 5, 2016 at 6:05 AM, Elia Pinto wrote: >> The correct api is trace_printf_key >> >> Signed-off-by: Elia Pinto >> --- >> diff --git a/Documentation/technical/api-trace.txt >>

Condominium Owners List

Hi, Would you be interested in reaching out to "Condominium Owners List"? with opt-in verified email addresses from the USA. We also have contacts of Real Estate Investors, Home Owners, Mortgage Holders, Mortgage with Home, Investors List, New Movers List, Golfers Email List, High Net-worth

Fsck message override issue

I'm not having luck with overriding the fsck message types (zeroPaddedFilemode specifically). I've tried adding [fsck] zeroPaddedFilemode = ignore to both global and local configs, but it seems to have no effect: $ git --version git version 2.8.0 $ git config --get fetch.fsckobjects

[PATCH] send-email: more meaningful Message-ID

Using a mmddHHMMSS date representation is more meaningful to humans, especially when used for lookups on NNTP servers or linking to archive sites via Message-ID (e.g. mid.gmane.org or mid.mail-archive.com). This timestamp format more easily gives a reader of the URL itself a rough date of a

Re: [PATCH] diff: run arguments through precompose_argv

On 05.04.16 21:15, Johannes Sixt wrote: > Am 05.04.2016 um 19:09 schrieb Junio C Hamano: >>> Thanks-to: Torsten Bögershausen > > I sense NFD disease: The combining diaresis should combine with the o, not > the g. Here is a correct line to copy-and-paste if you like: > >

[PATCH v1] correct blame for files commited with CRLF

From: Torsten Bögershausen git blame reports lines as not "Not Committed Yet" when they have CRLF in the index, CRLF in the worktree and core.autocrlf is true. Since commit c48053 "new safer autocrlf handling", files that have CRLF in the index are not normalized at commit when

Re: [PATCH] diff: run arguments through precompose_argv

Am 05.04.2016 um 19:09 schrieb Junio C Hamano: Thanks-to: Torsten Bögershausen I sense NFD disease: The combining diaresis should combine with the o, not the g. Here is a correct line to copy-and-paste if you like: Thanks-to: Torsten Bögershausen -- Hannes

Re: Timestamp of zero in reflog considered invalid

Junio C Hamano writes: > Checking the value against ULONG_MAX and errno==ERANGE would be an > improvement. It may be debatable if we should silently ignore an > entry with an invalid timestamp, but that is a separate issue. > > refs.c | 3 ++- > 1 file changed, 2

Re: [PATCH] api-trace.txt: fix typo

On Tue, Apr 5, 2016 at 6:05 AM, Elia Pinto wrote: > The correct api is trace_printf_key > > Signed-off-by: Elia Pinto > --- > diff --git a/Documentation/technical/api-trace.txt > b/Documentation/technical/api-trace.txt > @@ -28,7 +28,7 @@ static

Re: [PATCH] diff: run arguments through precompose_argv

Alexander Rinass writes: > File paths containing decomposed unicode chars passed to diff > command are not converted to precomposed unicode form. > > As a result, no diff is displayed when feeding such a file path to the > diff command. > > Opposite to most builtin commands,

Re: [PATCH v5 0/6] tag: move PGP verification code to tag.c

Sorry, forgot to add, this is a follow on to [1]. Thanks, -Santiago. [1]: http://git.661346.n2.nabble.com/PATCH-v4-0-6-tag-move-PGP-verification-code-to-tag-c-td7652451.html On Tue, Apr 05, 2016 at 12:07:23PM -0400, santi...@nyu.edu wrote: > From: Santiago Torres > > v5

Re: Feature request: config option for default git commit -v

W dniu 05.04.2016 o 16:47, Pranit Bauva pisze: > On Tue, Apr 5, 2016 at 8:08 PM, Jacek Wielemborek wrote: >> Hello, >> >> I'm asking for this one because there's quite a lot of interest >> (including me) in this feature and there is no convenient walkaround: >> >>

[PATCH v5 0/6] tag: move PGP verification code to tag.c

From: Santiago Torres v5 (this): Added helpful feedback by Eric * Reordering of the patches, to avoid temporal inclusion of a regression * Fix typos here and there. * Review commit messages, as some weren't representative of what the patches were doing anymore. *

[PATCH v5 1/6] builtin/verify-tag.c: Ignore SIGPIPE on gpg-interface

From: Santiago Torres The verify_signed_buffer comand might cause a SIGPIPE signal when the gpg child process terminates early (due to a bad keyid, for example) and git tries to write to it afterwards. Previously, ignoring SIGPIPE was done on the builtin/verify-tag.c command to

[PATCH v5 2/6] t7030-verify-tag: Adds validation for multiple tags

From: Santiago Torres The verify-tag command supports multiple tag names as an argument. However, existing tests only test for invocation with a single tag, so we add a test invoking with multiple tags. Helped-by: Jeff King Signed-off-by: Santiago Torres

[PATCH v5 5/6] builtin/verify-tag: move verification code to tag.c

From: Santiago Torres The PGP verification routine for tags could be accessed by other commands that require it. We do this by moving it to the common tag.c module. We rename the verify_tag() function to gpg_verify_tag() to avoid conflicts with the mktag.c function.

[PATCH v5 4/6] builtin/verify-tag: replace name argument with sha1

From: Santiago Torres This change is meant to prepare verify_tag for libification. Many existing modules/commands already do the refname to sha1 resolution, so should avoid resolving the refname twice. To avoid breaking builtin/verify-tag, we move the refname resolution outside

[PATCH v5 6/6] tag: use gpg_verify_function in tag -v call

From: Santiago Torres Instead of running the verify-tag plumbing command, we use the gpg_verify_tag() function within the verify_tag function to avoid doing an additional fork call. Signed-off-by: Santiago Torres --- builtin/tag.c | 8 +--- 1 file

[PATCH v5 3/6] builtin/verify-tag: change variable name for readability

From: Santiago Torres The run_gpg_verify function has two variables size, and len. This may come off as confusing when reading the code. We clarify which one pertains to the length of the tag headers by renaming len to payload_length. Signed-off-by: Santiago Torres

Re: [PATCH v12 5/5] commit: add a commit.verbose config variable

On Tue, Apr 5, 2016 at 4:59 AM, Eric Sunshine wrote: > On Sun, Apr 3, 2016 at 8:58 PM, Eric Sunshine wrote: >> The fact that the 32 new tests are nearly identical suggests strongly >> that the testing should instead either be table-driven or be

Re: [PATCH v12 4/5] t7507-commit-verbose: improve test coverage by testing number of diffs

On Mon, Apr 4, 2016 at 5:32 AM, Eric Sunshine wrote: > On Sat, Apr 2, 2016 at 7:33 PM, Pranit Bauva wrote: >> Make the fake "editor" store output of grep in a file so that we can >> see how many diffs were contained in the message and use them in

Re: Timestamp of zero in reflog considered invalid

Erik Bray writes: > I tracked the issue to refs/files-backend.c in show_one_reflog_ent : > > https://github.com/git/git/blob/11529ecec914d2f0d7575e6d443c2d5a6ff75424/refs/files-backend.c#L2923 > > in which > > !(timestamp = strtoul(email_end + 2, , 10)) || > > implies an

Re: [PATCH v12 3/5] parse-options.c: make OPTION_COUNTUP respect "unspecified" values

On Mon, Apr 4, 2016 at 4:40 AM, Eric Sunshine wrote: > On Sat, Apr 2, 2016 at 7:33 PM, Pranit Bauva wrote: >> The reason to make it respect "unspecified" values is to give the >> ability to differentiate whether `--option` or `--no-option` was >>

Re: [PATCH v12 2/5] test-parse-options: print quiet as integer

[+cc:Duy Nguyen, Jonathan Nieder] On Mon, Apr 4, 2016 at 3:00 AM, Eric Sunshine wrote: > On Sat, Apr 2, 2016 at 7:33 PM, Pranit Bauva wrote: >> Current implementation of parse-options.c treats OPT__QUIET() as integer >> and not boolean and thus

Re: Feature request: config option for default git commit -v

On Tue, Apr 5, 2016 at 8:08 PM, Jacek Wielemborek wrote: > Hello, > > I'm asking for this one because there's quite a lot of interest > (including me) in this feature and there is no convenient walkaround: > > https://stackoverflow.com/questions/5875275/git-commit-v-by-default >

Feature request: config option for default git commit -v

Hello, I'm asking for this one because there's quite a lot of interest (including me) in this feature and there is no convenient walkaround: https://stackoverflow.com/questions/5875275/git-commit-v-by-default Cheers, d33tah signature.asc Description: OpenPGP digital signature

Re: git diff --exit-code does not honour textconv setting

Georg Pichler venit, vidit, dixit 20.03.2016 13:43: > Hi, > > I realized that "git diff --exit-code" does not honour textconv settings. > Maybe this behaviour is desired. It can be partially circumvented by using > the "-b" flag if one does not care about whitespace changes. > To reproduce this,

Re: [RFC/PATCH] git.spec: fix changelog dates

Michael J Gruber wrote: > Remi Galan Alfonso venit, vidit, dixit 05.04.2016 14:28: > > Michael J Gruber wrote: > >> A few changelog entries have inconsistent dates, which rpmlint reports > >> as errors. > >> > >> Fix them based on these

Re: [RFC/PATCH] git.spec: fix changelog dates

Remi Galan Alfonso venit, vidit, dixit 05.04.2016 14:28: > Michael J Gruber wrote: >> A few changelog entries have inconsistent dates, which rpmlint reports >> as errors. >> >> Fix them based on these assumptions: >> - It's easier to mistype a number than a weekday

Re: support block comments in gitconfig

Am 05.04.2016 um 04:19 schrieb Timothee Cour: > Could we have block comments in gitconfig? > It's a nice-to-have supported in most languages. > eg: > > #{ > commented out block > #} > > or other intuitive syntax Maybe not what you're looking for, but couldn't you use the include functionality

Re: [RFC/PATCH] git.spec: fix changelog dates

Michael J Gruber wrote: > A few changelog entries have inconsistent dates, which rpmlint reports > as errors. > > Fix them based on these assumptions: > - It's easier to mistype a number than a weekday abbreviation. > - changelog date must be before git commit date > -

[RFC/PATCH] git.spec: fix changelog dates

A few changelog entries have inconsistent dates, which rpmlint reports as errors. Fix them based on these assumptions: - It's easier to mistype a number than a weekday abbreviation. - changelog date must be before git commit date - The mistyped date is just a few days off. Signed-off-by: Michael

Re: support block comments in gitconfig

Hi Timothee, On Mon, 4 Apr 2016, Timothee Cour wrote: > Could we have block comments in gitconfig? > It's a nice-to-have supported in most languages. > eg: > > #{ > commented out block > #} > > or other intuitive syntax You could have such block comments. If you implemented that feature.

Timestamp of zero in reflog considered invalid

Hi all, I found this issue through a test suite for a Python git interface, which during the tests at some point sets GIT_COMMITTER_DATE=1970-01-01T00:00:00 To reproduce the issue: $ git init $ echo foo > testfile $ git add testfile $ git commit -m "test" $ echo bar >> testfile $ export

Triangular workflows and some anecdotes from the trenches

Hi, We ran into something at $dayjob the other day. The actual problem was a developer ended up amending a commit that had already been pushed. It happens occasionally and is usually recoverable with a simple rebase and is generally a learning experience. In this particular case however things

[PATCH] completion: complete --cherry-mark for git log

Signed-off-by: Michael J Gruber --- contrib/completion/git-completion.bash | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index e3918c8..d87cf4d 100644 ---

Re: [ANNOUNCE] Git v2.8.1 (and call-for-help to "make rpmbuild" users)

2016-04-03 21:21 GMT+02:00 Junio C Hamano : > If you do not build RPM binary packages from our pristine source, > you can safely ignore this release and stop reading this message. > > Now that the audience of this message has been limited to a narrow > target, before I make an

Re: [PATCH 1/2] imap-send.c: implements the GIT_CURL_DEBUG environment variable

2016-04-01 22:25 GMT+02:00 Eric Sunshine : > On Fri, Apr 1, 2016 at 6:44 AM, Elia Pinto wrote: >> Implements the GIT_CURL_DEBUG environment variable to allow a greater >> degree of detail of GIT_CURL_VERBOSE, in particular the complete >>

[PATCH] api-trace.txt: fix typo

The correct api is trace_printf_key Signed-off-by: Elia Pinto --- Documentation/technical/api-trace.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/technical/api-trace.txt b/Documentation/technical/api-trace.txt index

Re: [ANNOUNCE] Git v2.8.1 (and call-for-help to "make rpmbuild" users)

Junio C Hamano venit, vidit, dixit 03.04.2016 21:21: > If you do not build RPM binary packages from our pristine source, > you can safely ignore this release and stop reading this message. > > Now that the audience of this message has been limited to a narrow > target, before I make an

Re: [PATCH v5 4/4] pretty: test --expand-tabs

Jeff King wrote: > > +test_expand --pretty=fuller > > +test_expand --pretty=fuller > > Duplicated fuller? Just brush it off :) [Those too young to get the joke can look up "fuller brush" in Wikipedia.] -- To unsubscribe from this list: send the line "unsubscribe git" in the

Re: [PATCH v3 3/4] format-patch: introduce --base=auto option

Ye Xiaolong writes: > ---1---o---A > /\ / > ---O X > \/ \ > ---2---o---o---B > > For this criss-cross merges, as neither merge base(like 1) is better > than the other(both 1 and 2 are 'best' merge bases), I think it should > be fine to

[PATCH] Makefile: fix misdirected redirections

In general "echo 2>&1 $msg" to redirect a possible error message that comes from 'echo' itself into the same standard output stream $msg is getting written to does not make any sense; it is not like we are expecting to see any errors out of 'echo' in these statements, and even if it were the case,

[PATCH] Makefile: stop pretending to support rpmbuild

Dennis Kaarsemaker writes: > On za, 2016-04-02 at 20:41 -0700, Junio C Hamano wrote: >> I think by now it is very clear that nobody active in the Git >> development community tests RPM binaries built with git.spec.in we >> have in our tree. I suspect RPM based distros are

Re: [PATCH v3 3/4] format-patch: introduce --base=auto option

On Fri, Apr 01, 2016 at 09:06:20AM -0700, Junio C Hamano wrote: >Ye Xiaolong writes: > >> On Thu, Mar 31, 2016 at 10:43:48AM -0700, Junio C Hamano wrote: >>>Xiaolong Ye writes: >>> Introduce --base=auto to record the base commit info

Re: [PATCH v5 4/4] pretty: test --expand-tabs

Jeff King writes: > On Mon, Apr 04, 2016 at 05:58:37PM -0700, Junio C Hamano wrote: > >> +count_expand () >> +{ > > This function takes a lot of unnamed arguments that we process with > "shift". It might be nice to give a brief comment describing them. > ... >> +test_expand

Re: [PATCH v5 4/4] pretty: test --expand-tabs

Jeff King writes: > On Mon, Apr 04, 2016 at 09:10:46PM -0400, Eric Sunshine wrote: > >> > + count=$1 ;# expected tabs >> >> Why semicolon before the hash here and above? > > I am in the habit of doing this, too. I have a vague recollection of > getting bitten by a shell

Re: [PATCH] branch: fix shortening of non-remote symrefs

Hello, On Sun, Apr 3, 2016 at 9:44 AM, Jeff King wrote: > On Sun, Apr 03, 2016 at 02:54:22PM +1200, Phil Sainty wrote: > >> Given the following symbolic reference: >> >> $ git symbolic-ref refs/heads/m refs/heads/master >> >> >> Correct in 2.6.6: >> >> $ PATH=~/git/git-2.6.6:$PATH