Re: git reveals a bug in (some versions) BSD diff

I'm seeing this on a standard os/x 10.3.9 install which seems to have an old, but still GNU based, diff. $ which diff /usr/bin/diff $ diff --version diff - GNU diffutils version 2.7 $ sh ./t4101-apply-nonl.sh * ok 1: apply diff between 0 and 1 * ok 2: apply diff between 0 and 2 * ok 3: app

[PATCH] fix null TZ problems on os/x

Kernel Version 7.9.0: Wed Mar 30 20:11:17 PST 2005; root:xnu/xnu-517.12.7.obj~1/RELEASE_PPC Signed-off-by: Brad Roberts <[EMAIL PROTECTED]> --- diff --git a/t/t1100-commit-tree-options.sh b/t/t1100-commit-tree-options.sh --- a/t/t1100-commit-tree-options.sh +++ b/t/t1100-c

[PATCH 01-19/19] All of the above combined

Make the cache management code behave more like a library. There are no longer any global variables in read-cache.c. Nothing ever uses more than one cache yet, but I can see how it might simplify some of the merge code. Signed-off-by: Brad Roberts <[EMAIL PROTECTED]> --- c

[PATCH 19/19] the end goal of the last dozen or so commits, there's no longer a global cache variable

tree 38adb888a4c1adfe083f24d4ec51018e0b5a8335 parent 0a556dc01b8e48f684ce6e0c26f8c00b5e39c4ac author Brad Roberts <[EMAIL PROTECTED]> 1114093024 -0700 committer Brad Roberts <[EMAIL PROTECTED]> 1114093024 -0700 [PATCH] the end goal of the last dozen or so commits, there's no

[PATCH 18/19] rename cache_match_stat to ce_match_stat to match other cache_entry related functions/macros

tree f8dd454f774d42526149193970b612a46f3ddd26 parent 058c25fd81e5949354d96f2aad222ae73a6c1dee author Brad Roberts <[EMAIL PROTECTED]> 1114088345 -0700 committer Brad Roberts <[EMAIL PROTECTED]> 1114088345 -0700 [PATCH] rename cache_match_stat to ce_match_stat to match other cache_en

[PATCH 17/19] temporarily change add_cache_entry to create an empty cache on demand

tree 6feaeb314fb1bea393250972b109b7d218cf37d7 parent b965055600b8bf4927ea631446cd6cde714aef95 author Brad Roberts <[EMAIL PROTECTED]> 1114087949 -0700 committer Brad Roberts <[EMAIL PROTECTED]> 1114087949 -0700 [PATCH] temporarily change add_cache_entry to create an empty cache on

[PATCH 16/19] change all call sites that use the return value of read_cache to get the # of cache entries.

tree 6bce19032505c2939bf74eeca5e51aeefa4e1600 parent f07f7073f45a7f81e5b6cf26f5181e14fd051d81 author Brad Roberts <[EMAIL PROTECTED]> 1114086602 -0700 committer Brad Roberts <[EMAIL PROTECTED]> 1114086602 -0700 [PATCH] change all call sites that use the return value of read_cache to g

[PATCH 15/19] introduce a cache struct and move the various cache globals into it.

tree c806c7328a6c9297df108ab00ebe1c4014496cb0 parent b7d4fa53d4ee449b4b9b4f3c9dd40d6c99db4bc1 author Brad Roberts <[EMAIL PROTECTED]> 1114086327 -0700 committer Brad Roberts <[EMAIL PROTECTED]> 1114086327 -0700 [PATCH] introduce a cache struct and move the various cache globals i

[PATCH 14/19] move cache_header out of the public view

tree a2c82ce3512904f82f78d87d86709a471f67ef9f parent ff3667537379d5b0680e8c4f9a14d82dc9835430 author Brad Roberts <[EMAIL PROTECTED]> 1114083477 -0700 committer Brad Roberts <[EMAIL PROTECTED]> 1114083477 -0700 [PATCH] move cache_header out of the public view Signed-off-by: Brad Rob

[PATCH 13/19] Remove active_cache, active_nr, and active_alloc from public view

tree 9198385d73b718a2fd016362a9d93ccce1e7423c parent cc414a188c0e8fefa7bea4f969cc7adfe4265d6f author Brad Roberts <[EMAIL PROTECTED]> 1114083132 -0700 committer Brad Roberts <[EMAIL PROTECTED]> 1114083132 -0700 [PATCH] Remove active_cache, active_nr, and active_alloc from public view

[PATCH 12/19] fix up diff-cache.c to use new cache api's

tree 44f1ef88a5d0effdf2337f4c72b88b2bdcd9a54b parent 8a4556bdf5bc847117c840a8fd7fa42f6efb16e1 author Brad Roberts <[EMAIL PROTECTED]> 1114082996 -0700 committer Brad Roberts <[EMAIL PROTECTED]> 1114082996 -0700 [PATCH] fix up diff-cache.c to use new cache api's Along the way,

[PATCH 11/19] migrate write-tree.c to use the new cache api's

tree 3a2928786f84d81cfb1a5846cdaf9f3d5403cbcf parent a94803645fb68119be8835d466585c91e664a173 author Brad Roberts <[EMAIL PROTECTED]> 1114077713 -0700 committer Brad Roberts <[EMAIL PROTECTED]> 1114077713 -0700 [PATCH] migrate write-tree.c to use the new cache api's Along the

[PATCH 10/19] migrate check-files.c to the new cache api's

tree 54aca1a1c5f41995c79fdf6b5f720574d0bfd8ef parent 50a6596bf7f51ecd598cd02d9c44379a9b92044a author Brad Roberts <[EMAIL PROTECTED]> 1114077105 -0700 committer Brad Roberts <[EMAIL PROTECTED]> 1114077105 -0700 [PATCH] migrate check-files.c to the new cache api's Signed-off

[PATCH 09/19] migrate read-tree.c to the new cache api's

tree 7a3cab4437a849857cc899017b97eea1787a6ce1 parent 099367f98cc063c33733d15c7a2d9737bea853d9 author Brad Roberts <[EMAIL PROTECTED]> 1114077044 -0700 committer Brad Roberts <[EMAIL PROTECTED]> 1114077044 -0700 [PATCH] migrate read-tree.c to the new cache api's Signed-off

[PATCH 08/19] rename remove_entry_at to remove_cache_entry_at and expose as a public api

tree 68af3fb1d46759f437d15f310a9aea2931708601 parent e2acfff5e544a8c6769a9e665927092b3edd7579 author Brad Roberts <[EMAIL PROTECTED]> 1114075605 -0700 committer Brad Roberts <[EMAIL PROTECTED]> 1114075605 -0700 [PATCH] rename remove_entry_at to remove_cache_entry_at and expose as a

[PATCH 06/19] migrate show-files.c to the new cache api's

tree a3bd48d2beba79d70e97d8647ee35a645e494350 parent f908b2542a9a3ea321633a31cf0e7ca2c8b669d4 author Brad Roberts <[EMAIL PROTECTED]> 1114074486 -0700 committer Brad Roberts <[EMAIL PROTECTED]> 1114074486 -0700 [PATCH] migrate show-files.c to the new cache api's Signed-off

[PATCH 07/19] migrate merge-cache.c over to the new cache api's

tree 8140acee0f9c57bfd87f40d1f99242c772afcdf2 parent 32efd81a3292a923ce5b5ae2e39ffefd0b08664d author Brad Roberts <[EMAIL PROTECTED]> 1114074631 -0700 committer Brad Roberts <[EMAIL PROTECTED]> 1114074631 -0700 [PATCH] migrate merge-cache.c over to the new cache api's Signed-off

[PATCH 03/19] convert show-diff.c to use new cache hiding api's

tree bbc50100a5cfd22264c2b0731ef8678656a399d8 parent 27fc41dcd4aecafdaf583f3962697a2fa3fb6480 author Brad Roberts <[EMAIL PROTECTED]> 1114073516 -0700 committer Brad Roberts <[EMAIL PROTECTED]> 1114073516 -0700 [PATCH] convert show-diff.c to use new cache hiding api's Signed-off

[PATCH 02/19] Add new api's to front the active_cache and active_nr cache internals

tree ebbf2c037e68116c4ff934f140ca12cdbe13311d parent 77de9e0b7a81ddc22526c9415f0273171f631d3f author Brad Roberts <[EMAIL PROTECTED]> 1114073146 -0700 committer Brad Roberts <[EMAIL PROTECTED]> 1114073146 -0700 [PATCH] Add new api's to front the active_cache and active_nr cache

[PATCH 04/19] Migrate update-cache.c to use the new cache api's

tree 34f7fc89e28a40387e811057065592ed2f0218a2 parent d70686e08f453199e5451b27fc7d0b36b73a5c7f author Brad Roberts <[EMAIL PROTECTED]> 1114073784 -0700 committer Brad Roberts <[EMAIL PROTECTED]> 1114073784 -0700 [PATCH] Migrate update-cache.c to use the new cache api's Signed-off

[PATCH 05/19] migrate checkout-cache.c to the new cache api's

tree b95df78e4cc90db8c4c8d0ad870bef74b7fd29e2 parent 40bf732f5bcb986943070a2ed6c09a16543d81be author Brad Roberts <[EMAIL PROTECTED]> 1114074234 -0700 committer Brad Roberts <[EMAIL PROTECTED]> 1114074234 -0700 [PATCH] migrate checkout-cache.c to the new cache api's Signed-off

[PATCH 01/19] write_cache api signature change, isolate active_cache and active_nr inside read-cache.c

tree f45fd10b26bf98349b63427805a96bd0551cad74 parent 43fdf65356c50483233cb3d6e391b0849b2a2a50 parent cd1c034369b73da7503da365fa556aab27004814 author Brad Roberts <[EMAIL PROTECTED]> 1114072582 -0700 committer Brad Roberts <[EMAIL PROTECTED]> 1114072582 -0700 [PATCH] write_cache a

[PATCH 00/19] summary of patch set

Tonight I did a bunch of tiny steps towards making the cache management code behave more like a library. There are no longer any global variables in read-cache.c. Nothing ever uses more than one cache yet, but I can see how it might simplify some of the merge code. They're also visible here: ht

Re: [3/5] Add http-pull

On Sun, 17 Apr 2005, Petr Baudis wrote: > Date: Sun, 17 Apr 2005 21:59:00 +0200 > From: Petr Baudis <[EMAIL PROTECTED]> > To: Daniel Barkalow <[EMAIL PROTECTED]> > Cc: git@vger.kernel.org > Subject: Re: [3/5] Add http-pull > > Dear diary, on Sun, Apr 17, 2005 at 09:24:27PM CEST, I got a letter > w

Re: [patch] fork optional branch point normazilation

The patch needed some tweaking, but not in the way you thought. :) commit a6aa192641e9ea242332fee4916abf5ad2640d75 tree c69878b009ec2f505d75aa7d99e9ee30cd21ab02 parent 60e1274460f50bcecdc3f162b4fced9e5ebf2dfb author Brad Roberts <[EMAIL PROTECTED]> 1113789519 -0700 committer Brad Roberts &

Re: [patch] fork optional branch point normazilation

On Sun, 17 Apr 2005, Linus Torvalds wrote: > On Sun, 17 Apr 2005, Brad Roberts wrote: > > > > (ok, author looks better, but committer doesn't obey the AUTHOR_ vars yet) > > They should't, but maybe I should add COMMITTER_xxx overrides. I just do > _not_ want peop

[patch] Fix off by one error in show-diff.c:sq_expand

tree b2eb41fec5cb7a3b83b53f1eb59e59785e57cf5d parent 1c45567134945bccefc1b5fbacc2862cd8f346c4 author Brad Roberts <[EMAIL PROTECTED]> 1113752911 -0700 committer Brad Roberts,,, <[EMAIL PROTECTED]> 1113752911 -0700 Fix off by one error in sq_expand, forgot space for the null. Signed-

Re: Re: Merge with git-pasky II.

On Sun, 17 Apr 2005, Ingo Molnar wrote: > Date: Sun, 17 Apr 2005 16:52:32 +0200 > From: Ingo Molnar <[EMAIL PROTECTED]> > To: Linus Torvalds <[EMAIL PROTECTED]> > Cc: Petr Baudis <[EMAIL PROTECTED]>, Simon Fowler <[EMAIL PROTECTED]>, > David Lang <[EMAIL PROTECTED]>, git@vger.kernel.org > Sub

Re: fork optional branch point normazilation

> > > > Index: gitfork.sh > > === > > --- 51b1bddbbc05e50d5bbf1f9662e503c2e85d5e96/gitfork.sh (mode:100755 > > sha1:e5692ea9bdbc39b028fe1e1205381da632541bab) > > +++ c291316b28eff4042c80850cd93445345a606835/gitfork.sh (mode:100755

[patch] fork optional branch point normazilation

cc908 tree c291316b28eff4042c80850cd93445345a606835 parent 1cdbc0a19b8d9b68f1f42735e2f14f1289823a63 author Brad Roberts <[EMAIL PROTECTED]> 1113738584 -0700 committer Brad Roberts,,, <[EMAIL PROTECTED]> 1113738584 -0700 gitfork needs to normalize the optional third parameter before

[patch] fix for memory leak in write-tree.c

I've made my tree rsync'able: rsync://gameboy2.puremagic.com/git commit 1cdbc0a19b8d9b68f1f42735e2f14f1289823a63 tree 0e060fed0642337e675368913ec8d4f910a9f019 parent 11ed64c1b141c9ba397a1ca76aef2cd250976007 author Brad Roberts,,, <[EMAIL PROTECTED]> 1113736632 -0700 commit

Re: [PATCH] libgit

> Converted git to libgit. Moved all the main() calls into a single > multi-call binary - git-main. > Made extern a bunch of functions that were static. Verified it at least > still minimally worked. > Note: this is only a first step towards creating a generic library. > Figuring out what functions

active_cache leaks

Ok.. so there's been a couple attempts to patch the leak that were all wrong due to mixed memory management for that array. Here's a seed for discussion on how to plug that leak. Some would argue that it's not leaking enough to fix, but for those that want to turn git into a library, the lifetime