[PATCH v6 04/40] t0021/rot13-filter: improve error message

2017-09-16 Thread Christian Couder
If there is no new line at the end of something it receives, the packet_txt_read() function die()s, but it's difficult to debug without much context. Let's give a bit more information when that happens. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t0021/rot13-filter.

Re: [RFC/PATCH v4 00/49] Add initial experimental external ODB support

2017-09-15 Thread Christian Couder
(It looks like I did not reply to this other email yet, sorry about this late reply.) On Wed, Jul 12, 2017 at 9:06 PM, Jonathan Tan <jonathanta...@google.com> wrote: > On Tue, 20 Jun 2017 09:54:34 +0200 > Christian Couder <christian.cou...@gmail.com> wrote: > >> Git

Re: [RFC/PATCH v4 00/49] Add initial experimental external ODB support

2017-09-15 Thread Christian Couder
(It looks like I did not reply to this email yet, sorry about this late reply.) On Thu, Jul 6, 2017 at 7:36 PM, Ben Peart <peart...@gmail.com> wrote: > > On 7/1/2017 3:41 PM, Christian Couder wrote: >> >> On Fri, Jun 23, 2017 at 8:24 PM, Ben Peart <peart...@gmail.com&g

Re: [PATCH v5 25/40] external-odb: add 'get_direct' support

2017-09-15 Thread Christian Couder
On Thu, Sep 14, 2017 at 8:19 PM, Jonathan Tan <jonathanta...@google.com> wrote: > On Thu, 14 Sep 2017 10:39:35 +0200 > Christian Couder <christian.cou...@gmail.com> wrote: > >> From the following email: >> >> https://public-inbox.org/git/201708041451

Re: [PATCH v5 10/40] Add initial external odb support

2017-09-14 Thread Christian Couder
On Thu, Aug 3, 2017 at 9:34 PM, Junio C Hamano <gits...@pobox.com> wrote: > Christian Couder <christian.cou...@gmail.com> writes: > >> diff --git a/external-odb.h b/external-odb.h >> new file mode 100644 >> index 00..9989490c9e >> --- /dev/nu

Re: [PATCH v5 14/40] external-odb: accept only blobs for now

2017-09-14 Thread Christian Couder
On Thu, Aug 3, 2017 at 9:52 PM, Junio C Hamano <gits...@pobox.com> wrote: > Christian Couder <christian.cou...@gmail.com> writes: > >> The mechanism to decide which blobs should be sent to which >> external object database will be very simple for now. >> If

Re: [PATCH v5 13/40] external odb: add 'put_raw_obj' support

2017-09-14 Thread Christian Couder
On Thu, Aug 3, 2017 at 9:50 PM, Junio C Hamano <gits...@pobox.com> wrote: > Christian Couder <christian.cou...@gmail.com> writes: > >> Add support for a 'put_raw_obj' capability/instruction to send new >> objects to an external odb. Objects will be sent as they

Re: [PATCH v5 25/40] external-odb: add 'get_direct' support

2017-09-14 Thread Christian Couder
On Thu, Aug 3, 2017 at 11:40 PM, Junio C Hamano <gits...@pobox.com> wrote: > Christian Couder <christian.cou...@gmail.com> writes: > >> This implements the 'get_direct' capability/instruction that makes >> it possible for external odb helper scripts to pass blobs to G

Re: [PATCH v5 19/40] lib-httpd: add upload.sh

2017-09-14 Thread Christian Couder
On Thu, Aug 3, 2017 at 10:07 PM, Junio C Hamano <gits...@pobox.com> wrote: > Christian Couder <christian.cou...@gmail.com> writes: > >> +OLDIFS="$IFS" >> +IFS='&' >> +set -- $QUERY_STRING >> +IFS="$OLDIFS" >> + >> +while

Re: [PATCH v5 11/40] odb-helper: add odb_helper_init() to send 'init' instruction

2017-09-14 Thread Christian Couder
On Sun, Sep 10, 2017 at 2:12 PM, Lars Schneider <larsxschnei...@gmail.com> wrote: > >> On 03 Aug 2017, at 10:18, Christian Couder <christian.cou...@gmail.com> >> wrote: >> >> +static void parse_capabilities(char *cap_buf, >> +

Re: [PATCH v5 12/40] t0400: add 'put_raw_obj' instruction to odb-helper script

2017-09-14 Thread Christian Couder
On Sun, Sep 10, 2017 at 2:12 PM, Lars Schneider <larsxschnei...@gmail.com> wrote: > >> On 03 Aug 2017, at 10:18, Christian Couder <christian.cou...@gmail.com> >> wrote: >> >> To properly test passing objects from Git to an external odb >> we n

Re: [PATCH v5 00/40] Add initial experimental external ODB support

2017-09-14 Thread Christian Couder
On Sun, Sep 10, 2017 at 2:30 PM, Lars Schneider <larsxschnei...@gmail.com> wrote: > >> On 03 Aug 2017, at 10:18, Christian Couder <christian.cou...@gmail.com> >> wrote: >> >> ... >> >> * The "helpers" (registered commands) >> &

Re: Git in Outreachy round 15?

2017-09-05 Thread Christian Couder
Hi, On Sat, Sep 2, 2017 at 12:30 AM, Jeff King wrote: > > The big questions on whether we can make this happen are: > > 1. Do we have mentor interest? > > I'm willing to mentor, but I'd like to hear whether other people > are interested, as well. Either way I can take

Re: [PATCH v5 35/40] Add Documentation/technical/external-odb.txt

2017-08-30 Thread Christian Couder
On Wed, Aug 30, 2017 at 2:50 PM, Ben Peart <peart...@gmail.com> wrote: > > > On 8/29/2017 11:43 AM, Christian Couder wrote: >> >> On Mon, Aug 28, 2017 at 8:59 PM, Ben Peart <peart...@gmail.com> wrote: >>> >>> >>> On 8/3/2

Re: [PATCH v5 35/40] Add Documentation/technical/external-odb.txt

2017-08-29 Thread Christian Couder
On Mon, Aug 28, 2017 at 8:59 PM, Ben Peart <peart...@gmail.com> wrote: > > On 8/3/2017 5:19 AM, Christian Couder wrote: >> >> +Helpers >> +=== >> + >> +ODB helpers are commands that have to be registered using either the >> +"odb..subp

Re: [PATCH v5 35/40] Add Documentation/technical/external-odb.txt

2017-08-29 Thread Christian Couder
On Fri, Aug 25, 2017 at 11:23 PM, Jonathan Tan <jonathanta...@google.com> wrote: > On Fri, 25 Aug 2017 08:14:08 +0200 > Christian Couder <christian.cou...@gmail.com> wrote: > >> As Git is used by more and more by people having different needs, I >> think it is no

[PATCH] sha1-lookup: remove sha1_entry_pos() from header file

2017-08-25 Thread Christian Couder
Since f1068efefe (sha1_file: drop experimental GIT_USE_LOOKUP search, 2017-08-09) the definition of sha1_entry_pos() has been removed from "sha1-lookup.c", so there is no need anymore for its declaration in "sha1-lookup.h". Signed-off-by: Christian Couder <chrisc...@t

Re: [PATCH v5 35/40] Add Documentation/technical/external-odb.txt

2017-08-25 Thread Christian Couder
On Thu, Aug 3, 2017 at 8:38 PM, Stefan Beller <sbel...@google.com> wrote: > On Thu, Aug 3, 2017 at 2:19 AM, Christian Couder > <christian.cou...@gmail.com> wrote: >> This describes the external odb mechanism's purpose and >> how it works. > > Thanks for provi

Re: sequencer status

2017-08-23 Thread Christian Couder
Hi, On Wed, Aug 23, 2017 at 10:10 AM, Nicolas Morey-Chaisemartin wrote: > Hi, > > I've created a small tool to display the current sequencer status. > It mimics what Magit does to display what was done and what is left to do. > > As someone who often rebase large

Re: Advice needed for basic setup for home user

2017-08-22 Thread Christian Couder
On Tue, Aug 22, 2017 at 10:11 PM, Harry Putnam wrote: > > I run 5-10 vbox vms' on this host with various OS's involved. > With each host, I've kept a local repo of some key OS rc files. > and a couple of hundred home made scripts. > > They all follow the same pattern of setup,

Re: [PATCH] sub-process: print the cmd when a capability is unsupported

2017-08-16 Thread Christian Couder
On Wed, Aug 16, 2017 at 5:58 PM, Junio C Hamano <gits...@pobox.com> wrote: > Christian Couder <christian.cou...@gmail.com> writes: > >>>> I am still wondering if protocol errors should be fatal, >>> >>> Yes, please. >> >> Unfortunately

[PATCH v2] sub-process: print the cmd when a capability is unsupported

2017-08-16 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- Change since previous version: - Use process->argv[0] instead of adding a new parameter to handshake_capabilities(), thanks to Lars. sub-process.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sub-

Re: [PATCH] sub-process: print the cmd when a capability is unsupported

2017-08-16 Thread Christian Couder
On Wed, Aug 16, 2017 at 2:22 AM, Jonathan Nieder <jrnie...@gmail.com> wrote: > Jonathan Tan wrote: >> Christian Couder <christian.cou...@gmail.com> wrote: > >>> In handshake_capabilities() we use warning() when a capability >>> is not suppor

[ANNOUNCE] Git Rev News edition 30

2017-08-16 Thread Christian Couder
Hi everyone, The 30th edition of Git Rev News is now published: https://git.github.io/rev_news/2017/08/16/edition-30/ Thanks a lot to all the contributors and helpers! Enjoy, Christian, Thomas, Jakub and Markus.

Re: [PATCH] sub-process: print the cmd when a capability is unsupported

2017-08-15 Thread Christian Couder
On Tue, Aug 15, 2017 at 9:35 PM, Lars Schneider <larsxschnei...@gmail.com> wrote: > >> On 15 Aug 2017, at 21:29, Christian Couder <christian.cou...@gmail.com> >> wrote: >> >> On Tue, Aug 15, 2017 at 9:00 PM, Lars Schneider >> <larsxschnei...@g

Re: [PATCH] sub-process: print the cmd when a capability is unsupported

2017-08-15 Thread Christian Couder
On Tue, Aug 15, 2017 at 9:29 PM, Christian Couder <christian.cou...@gmail.com> wrote: > On Tue, Aug 15, 2017 at 9:00 PM, Lars Schneider > <larsxschnei...@gmail.com> wrote: >> >>> On 15 Aug 2017, at 19:36, Christian Couder <christian.cou...@gmail.com> >>

Re: [PATCH] sub-process: print the cmd when a capability is unsupported

2017-08-15 Thread Christian Couder
On Tue, Aug 15, 2017 at 9:00 PM, Lars Schneider <larsxschnei...@gmail.com> wrote: > >> On 15 Aug 2017, at 19:36, Christian Couder <christian.cou...@gmail.com> >> wrote: >> >> In handshake_capabilities() we use warning() when a capability >> is not sup

[PATCH] sub-process: print the cmd when a capability is unsupported

2017-08-15 Thread Christian Couder
this function, we use error() and then subprocess_start() outputs: initialization for subprocess '' failed so we can know which subprocess cmd failed. Let's improve the warning() message, so that we can know which subprocess cmd failed. Signed-off-by: Christian Couder <chrisc...@tuxfamily.

Draft of Git Rev News edition 30

2017-08-14 Thread Christian Couder
Hi, A draft of a new Git Rev News edition is available here: https://github.com/git/git.github.io/blob/master/rev_news/drafts/edition-30.md Everyone is welcome to contribute in any section either by editing the above page on GitHub and sending a pull request, or by commenting on this GitHub

Re: [PATCH 4/5] interpret-trailers: add an option to normalize output

2017-08-11 Thread Christian Couder
On Fri, Aug 11, 2017 at 11:06 AM, Jeff King <p...@peff.net> wrote: > On Fri, Aug 11, 2017 at 09:02:24AM +0200, Christian Couder wrote: > >> > But I really don't want callers to think of it as "unfold". I want it to >> > be "turn this into so

Re: [PATCH 4/5] interpret-trailers: add an option to normalize output

2017-08-11 Thread Christian Couder
On Fri, Aug 11, 2017 at 1:10 AM, Jeff King wrote: > On Fri, Aug 11, 2017 at 12:02:49AM +0100, Ramsay Jones wrote: > >> > But some of those things are not 1:1 mappings with normalization. For >> > instance, --json presumably implies --only-trailers. Or are we proposing >> > to

Re: [PATCH 4/5] interpret-trailers: add an option to normalize output

2017-08-10 Thread Christian Couder
On Thu, Aug 10, 2017 at 9:44 PM, Stefan Beller <sbel...@google.com> wrote: > On Thu, Aug 10, 2017 at 12:39 PM, Christian Couder > <christian.cou...@gmail.com> wrote: >> On Thu, Aug 10, 2017 at 8:37 PM, Jeff King <p...@peff.net> wrote: >>> On Thu, Aug 10,

Re: [PATCH 4/5] interpret-trailers: add an option to normalize output

2017-08-10 Thread Christian Couder
On Thu, Aug 10, 2017 at 9:42 PM, Jeff King <p...@peff.net> wrote: > On Thu, Aug 10, 2017 at 09:39:21PM +0200, Christian Couder wrote: > >> > If you prefer the normalized form (and the input was line-broken in a >> > way that you don't like), then this would convert

Re: [PATCH 4/5] interpret-trailers: add an option to normalize output

2017-08-10 Thread Christian Couder
On Thu, Aug 10, 2017 at 8:37 PM, Jeff King wrote: > On Thu, Aug 10, 2017 at 11:35:00AM -0700, Stefan Beller wrote: > >> On Thu, Aug 10, 2017 at 1:03 AM, Jeff King wrote: >> > The point of "--only-trailers" is to give a caller an output >> > that's easy for them to

Re: [PATCH] apply: remove prefix_length member from apply_state

2017-08-10 Thread Christian Couder
On Wed, Aug 9, 2017 at 5:54 PM, René Scharfe wrote: > Use a NULL-and-NUL check to see if we have a prefix and consistently use > C string functions on it instead of storing its length in a member of > struct apply_state. This avoids strlen() calls and simplifies the code. This

Re: [RFC PATCH 01/10] pack: move pack name-related functions

2017-08-09 Thread Christian Couder
On Tue, Aug 8, 2017 at 10:50 PM, Jonathan Tan wrote: > On Tue, 8 Aug 2017 13:36:24 -0700 > Stefan Beller wrote: >> >> There are also packed refs, so one could (like I did) think that >> pack.c is for generic packing of things, maybe packfile.c >>

Re: [GSoC][PATCH 08/13] submodule: port submodule subcommand 'summary' from shell to C

2017-08-07 Thread Christian Couder
On Mon, Aug 7, 2017 at 11:18 PM, Prathamesh Chavan wrote: > +static enum { > + DIFF_INDEX, > + DIFF_FILES > +} diff_cmd = DIFF_INDEX; Using an enum could be a good idea, but I am not sure about using a static variable. > +static int

Re: [GSoC][PATCH 08/13] submodule: port submodule subcommand 'summary' from shell to C

2017-08-05 Thread Christian Couder
On Sat, Aug 5, 2017 at 12:28 PM, Prathamesh Chavan <pc44...@gmail.com> wrote: > On Tue, Aug 1, 2017 at 4:57 AM, Christian Couder > <christian.cou...@gmail.com> wrote: >> On Mon, Jul 31, 2017 at 10:56 PM, Prathamesh Chavan <pc44...@gmail.com> >> wrote:

Re: [PATCH v5 08/40] Git/Packet.pm: add capability functions

2017-08-04 Thread Christian Couder
On Thu, Aug 3, 2017 at 9:14 PM, Junio C Hamano <gits...@pobox.com> wrote: > Christian Couder <christian.cou...@gmail.com> writes: > >> Add functions to help read and write capabilities. >> Use these functions in 't/t0021/rot13-filter.pl'. >> >&g

Re: [PATCH v5 04/40] Add Git/Packet.pm from parts of t0021/rot13-filter.pl

2017-08-04 Thread Christian Couder
On Thu, Aug 3, 2017 at 9:11 PM, Junio C Hamano wrote: >> diff --git a/perl/Git/Packet.pm b/perl/Git/Packet.pm >> new file mode 100644 >> index 00..aaffecbe2a >> --- /dev/null >> +++ b/perl/Git/Packet.pm >> @@ -0,0 +1,71 @@ >> +package Git::Packet; >> +use 5.008; >>

[PATCH v5 06/40] Git/Packet.pm: improve error message

2017-08-03 Thread Christian Couder
Try to give a bit more information when we die() because there is no new line at the end of something we receive. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- perl/Git/Packet.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/perl/Git/Packet.pm b/pe

[PATCH v5 01/40] builtin/clone: get rid of 'value' strbuf

2017-08-03 Thread Christian Couder
This makes the code simpler by removing a few lines, and getting rid of one variable. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- builtin/clone.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/builtin/clone.c b/builtin/clone.c index 08b5

[PATCH v5 02/40] t0021/rot13-filter: refactor packet reading functions

2017-08-03 Thread Christian Couder
To make it possible in a following commit to move packet reading and writing functions into a Packet.pm module, let's refactor these functions, so they don't handle printing debug output and exiting. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t0021/rot13-filter.p

[PATCH v5 05/40] t0021/rot13-filter: use Git/Packet.pm

2017-08-03 Thread Christian Couder
After creating Git/Packet.pm from part of t0021/rot13-filter.pl, we can now simplify this script by using Git/Packet.pm. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t0021/rot13-filter.pl | 51 +++-- 1 file changed, 3 inse

[PATCH v5 08/40] Git/Packet.pm: add capability functions

2017-08-03 Thread Christian Couder
Add functions to help read and write capabilities. Use these functions in 't/t0021/rot13-filter.pl'. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- perl/Git/Packet.pm | 33 + t/t0021/rot13-filter.pl | 9 ++--- 2 files chang

[PATCH v5 16/40] Add GIT_NO_EXTERNAL_ODB env variable

2017-08-03 Thread Christian Couder
This new environment variable will be used to perform git commands without involving any external odb mechanism. This makes it possible for example to create new blobs that will not be sent to an external odb even if the external odb supports "put_*" instructions. Signed-off-by: Christ

[PATCH v5 10/40] Add initial external odb support

2017-08-03 Thread Christian Couder
cript mode is supported, and only the 'have' and 'get_git_obj' instructions are supported. Helped-by: Jeff King <p...@peff.net> Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- Makefile| 2 + cache.h | 1 + externa

[PATCH v5 24/40] Add t0420 to test transfer to HTTP external odb

2017-08-03 Thread Christian Couder
This tests that an apache web server can be used as an external object database and store files in their native format instead of converting them to a Git object. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t0420-transfer-http-e-odb.sh

[PATCH v5 17/40] Add t0410 to test external ODB transfer

2017-08-03 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t0410-transfer-e-odb.sh | 144 ++ 1 file changed, 144 insertions(+) create mode 100755 t/t0410-transfer-e-odb.sh diff --git a/t/t0410-transfer-e-odb.sh b/t/t0410-transfer-e-odb.

[PATCH v5 18/40] lib-httpd: pass config file to start_httpd()

2017-08-03 Thread Christian Couder
This makes it possible to start an apache web server with different config files. This will be used in a later patch to pass a config file that makes apache store external objects. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/lib-httpd.sh | 6 -- 1 file chan

[PATCH v5 40/40] Add t0430 to test cloning using bundles

2017-08-03 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t0430-clone-bundle-e-odb.sh | 85 +++ 1 file changed, 85 insertions(+) create mode 100755 t/t0430-clone-bundle-e-odb.sh diff --git a/t/t0430-clone-bundle-e-odb.sh b/t/t0430-clone-bu

[PATCH v5 35/40] Add Documentation/technical/external-odb.txt

2017-08-03 Thread Christian Couder
This describes the external odb mechanism's purpose and how it works. Helped-by: Ben Peart <benpe...@microsoft.com> Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- Documentation/technical/external-odb.txt | 295 +++ 1 file changed, 29

[PATCH v5 26/40] odb-helper: add 'script_mode' to 'struct odb_helper'

2017-08-03 Thread Christian Couder
rs defined using the existing "odb..scriptcommand" are marked with the 'script_mode' field set to 1. Implementation of the different capabilities/instructions in the new (sub-)process mode is left for following commits. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org>

[PATCH v5 32/40] odb-helper: add have_object_process()

2017-08-03 Thread Christian Couder
This adds the infrastructure to handle 'have' instructions in process mode. The answer from the helper sub-process should be like the output in script mode, that is lines like this: sha1 SPACE size SPACE type NEWLINE Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- odb-he

[PATCH v5 38/40] clone: disable external odb before initial clone

2017-08-03 Thread Christian Couder
To make it possible to have the external odb mechanism only kick in after the initial part of a clone, we should disable it during the initial part of the clone. Let's do that by saving and then restoring the value of the 'use_external_odb' global variable. Signed-off-by: Christian Couder

[PATCH v5 25/40] external-odb: add 'get_direct' support

2017-08-03 Thread Christian Couder
me kind of mechanism to "put" objects into an external odb, where the odb helper would access blobs it wants to send to an external odb directly from files, but it would be strange to call that a fault-in mode too. Signed-off-by: Christian Couder <chrisc...@tuxfam

[PATCH v5 27/40] odb-helper: add init_object_process()

2017-08-03 Thread Christian Couder
From: Ben Peart <benpe...@microsoft.com> This adds the infrastructure to launch and use long running sub-processes as external odb helpers. For now only the 'init' and 'get_direct' capabilities are supported with sub-processes. Signed-off-by: Christian Couder <chrisc...@tuxf

[PATCH v5 23/40] pack-objects: don't pack objects in external odbs

2017-08-03 Thread Christian Couder
Objects managed by an external ODB should not be put into pack files. They should be transfered using other mechanism that can be specific to the external odb. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- builtin/pack-objects.c | 4 1 file changed, 4 insertions(+)

[PATCH v5 15/40] t0400: add test for external odb write support

2017-08-03 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t0400-external-odb.sh | 8 1 file changed, 8 insertions(+) diff --git a/t/t0400-external-odb.sh b/t/t0400-external-odb.sh index 3fa0449883..fa355bd7bb 100755 --- a/t/t0400-external-odb.sh +++ b/t/t0400-external-

[PATCH v5 30/40] odb-helper: add put_object_process()

2017-08-03 Thread Christian Couder
This adds the infrastructure to send objects to a sub-process handling the communication with an external odb. For now we only handle sending raw blobs using the 'put_raw_obj' instruction. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- odb-helper.

[PATCH v5 39/40] Add tests for 'clone --initial-refspec'

2017-08-03 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t0420-transfer-http-e-odb.sh | 7 + t/t0470-read-object-http-e-odb.sh | 7 + t/t0480-read-object-have-http-e-odb.sh | 7 + t/t5616-clone-initial-refspec.sh | 48 +++

[PATCH v5 31/40] Add t0470 to test passing raw objects

2017-08-03 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t0470-read-object-http-e-odb.sh | 109 ++ t/t0470/read-object-plain | 83 + 2 files changed, 192 insertions(+) create mode 100755 t/t0470-read-object-

[PATCH v5 34/40] external-odb: use 'odb=magic' attribute to mark odb blobs

2017-08-03 Thread Christian Couder
To tell which blobs should be sent to the "magic" external odb, let's require that the blobs be marked using the 'odb=magic' attribute. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- external-odb.c | 22 --

[PATCH v5 36/40] clone: add 'initial' param to write_remote_refs()

2017-08-03 Thread Christian Couder
We want to make it possible to separate fetching remote refs into an initial part and a later part. To prepare for that, let's add an 'initial' boolean parameter to write_remote_refs() to tell this function if we are performing the initial part or not. Signed-off-by: Christian Couder <chr

[PATCH v5 21/40] lib-httpd: add apache-e-odb.conf

2017-08-03 Thread Christian Couder
This is an apache config file to test external object databases. It uses the upload.sh and list.sh cgi that have been added previously to make apache store external objects. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/lib-httpd/apache-e-odb.conf

[PATCH v5 37/40] clone: add --initial-refspec option

2017-08-03 Thread Christian Couder
the initial fetch. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- builtin/clone.c | 55 ++- 1 file changed, 54 insertions(+), 1 deletion(-) diff --git a/builtin/clone.c b/builtin/clone.c index 2362dda880..76e561534d 100644 --- a/b

[PATCH v5 29/40] Add t0460 to test passing git objects

2017-08-03 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t0460-read-object-git.sh | 28 + t/t0460/read-object-git| 78 ++ 2 files changed, 106 insertions(+) create mode 100755 t/t0460-read-object-git.sh create mode 10

[PATCH v5 19/40] lib-httpd: add upload.sh

2017-08-03 Thread Christian Couder
This cgi will be used to upload objects to, or to delete objects from, an apache web server. This way the apache server can work as an external object database. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/lib-httpd.sh| 1 + t/lib-httpd/upload.s

[PATCH v5 22/40] odb-helper: add odb_helper_get_raw_object()

2017-08-03 Thread Christian Couder
The existing odb_helper_get_object() is renamed odb_helper_get_git_object() and a new odb_helper_get_raw_object() is introduced to deal with external objects that are not in Git format. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- odb-helper.c

[PATCH v5 20/40] lib-httpd: add list.sh

2017-08-03 Thread Christian Couder
This cgi script can list Git objects that have been uploaded as files to an apache web server. This script can also retrieve the content of each of these files. This will help make apache work as an external object database. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> ---

[PATCH v5 13/40] external odb: add 'put_raw_obj' support

2017-08-03 Thread Christian Couder
by an odb helper. This is not a great default, but let's leave it to following commits to tweak that. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- external-odb.c | 15 +++ external-odb.h | 2 ++ odb-helper.c | 43 ++- odb-he

[PATCH v5 12/40] t0400: add 'put_raw_obj' instruction to odb-helper script

2017-08-03 Thread Christian Couder
odb-helper script works well. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t0400-external-odb.sh | 24 1 file changed, 24 insertions(+) diff --git a/t/t0400-external-odb.sh b/t/t0400-external-odb.sh index ed89f3ab40..3fa0449883 100755 --- a/t

[PATCH v5 33/40] Add t0480 to test "have" capability and raw objects

2017-08-03 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t0480-read-object-have-http-e-odb.sh | 109 + t/t0480/read-object-plain-have | 103 +++ 2 files changed, 212 insertions(+) create mode 100755 t/t0480-read-

[PATCH v5 14/40] external-odb: accept only blobs for now

2017-08-03 Thread Christian Couder
The mechanism to decide which blobs should be sent to which external object database will be very simple for now. If the external odb helper support any "put_*" instruction all the new blobs will be sent to it. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- ex

[PATCH v5 28/40] Add t0450 to test 'get_direct' mechanism

2017-08-03 Thread Christian Couder
From: Ben Peart <benpe...@microsoft.com> Signed-off-by: Ben Peart <benpe...@microsoft.com> Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t0450-read-object.sh | 28 + t/t0450/read-object| 68 +

[PATCH v5 11/40] odb-helper: add odb_helper_init() to send 'init' instruction

2017-08-03 Thread Christian Couder
variable in struct odb_helper to store them. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- external-odb.c | 9 - odb-helper.c| 54 + odb-helper.h| 12 +++ t/t0400-external-odb.s

[PATCH v5 00/40] Add initial experimental external ODB support

2017-08-03 Thread Christian Couder
benpe...@microsoft.com/ https://public-inbox.org/git/20170322165220.5660-1-benpe...@microsoft.com/ https://public-inbox.org/git/20170714132651.170708-1-benpe...@microsoft.com/ Links ~ This patch series is available here: https://github.com/chriscool/git/commits/external-odb Version 1, 2, 3 and 4 are he

[PATCH v5 03/40] t0021/rot13-filter: improve 'if .. elsif .. else' style

2017-08-03 Thread Christian Couder
Before further refactoring the "t0021/rot13-filter.pl" script, let's modernize the style of its 'if .. elsif .. else' clauses to improve its readability by making it more similar to our other perl scripts. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t0021/rot1

[PATCH v5 09/40] sha1_file: prepare for external odbs

2017-08-03 Thread Christian Couder
split out 'sha1_file_name_alt()' from 'sha1_file_name()' and 'open_sha1_file_alt()' from 'open_sha1_file()', as we will need both of these new functions too. Helped-by: Jeff King <p...@peff.net> Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- cache.h | 8

[PATCH v5 04/40] Add Git/Packet.pm from parts of t0021/rot13-filter.pl

2017-08-03 Thread Christian Couder
This will make it possible to reuse packet reading and writing functions in other test scripts. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- perl/Git/Packet.pm | 71 ++ 1 file changed, 71 insertions(+) create mode 10064

[PATCH v5 07/40] Git/Packet.pm: add packet_initialize()

2017-08-03 Thread Christian Couder
Add a function to initialize the communication. And use this function in 't/t0021/rot13-filter.pl'. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- perl/Git/Packet.pm | 13 + t/t0021/rot13-filter.pl | 8 +--- 2 files changed, 14 insertions(+), 7 del

Re: [RFC/PATCH v3 01/16] Add initial external odb support

2017-08-03 Thread Christian Couder
On Thu, Dec 1, 2016 at 12:37 AM, Jeff King <p...@peff.net> wrote: > On Wed, Nov 30, 2016 at 03:30:09PM -0800, Junio C Hamano wrote: > >> Christian Couder <christian.cou...@gmail.com> writes: >> >> > From: Jeff King <p...@peff.net> >> > >>

Re: [RFC/PATCH v3 01/16] Add initial external odb support

2017-08-03 Thread Christian Couder
(I realized that I didn't answer this email about the v3 version. Sorry about this late answer.) On Thu, Dec 1, 2016 at 12:30 AM, Junio C Hamano <gits...@pobox.com> wrote: > Christian Couder <christian.cou...@gmail.com> writes: > >> From: Jeff King <p...@peff.net>

Re: [GSoC][PATCH 08/13] submodule: port submodule subcommand 'summary' from shell to C

2017-07-31 Thread Christian Couder
On Mon, Jul 31, 2017 at 10:56 PM, Prathamesh Chavan wrote: > * variable head was no longer used in module_summary() and instead the strbuf > was utilized. Good but there might be a few problems in the way it is used. See below. > +static int

Re: [GSoC][PATCH v2 04/13] submodule: port submodule subcommand 'status' from shell to C

2017-07-29 Thread Christian Couder
On Sun, Jul 30, 2017 at 12:23 AM, Prathamesh Chavan wrote: > +static void print_status(struct status_cb *info, char state, const char > *path, > +const struct object_id *oid, const char *displaypath) > +{ > + if (info->quiet) > +

Re: [GSoC][PATCH v2 08/13] submodule: port submodule subcommand 'summary' from shell to C

2017-07-29 Thread Christian Couder
On Sun, Jul 30, 2017 at 12:23 AM, Prathamesh Chavan wrote: > +static int module_summary(int argc, const char **argv, const char *prefix) > +{ > + struct summary_cb info = SUMMARY_CB_INIT; > + int cached = 0; > + char *diff_cmd = "diff-index"; > + int

Re: [PATCH v1 0/4] Teach 'run' perf script to read config files

2017-07-26 Thread Christian Couder
On Fri, Jul 14, 2017 at 8:27 AM, Christian Couder <christian.cou...@gmail.com> wrote: > On Thu, Jul 13, 2017 at 10:55 PM, Jeff King <p...@peff.net> wrote: >> On Thu, Jul 13, 2017 at 08:57:01PM +0200, Christian Couder wrote: >> >>> >> We want to make it po

Re: Request for git merge --signoff

2017-07-24 Thread Christian Couder
On Sat, Jul 1, 2017 at 5:24 PM, Dan Kohn wrote: > https://github.com/coreinfrastructure/best-practices-badge is a user > of the https://github.com/probot/dco bot which checks that commits > have a signoff. The issue is that there is no `--signoff` option in > git for

[PATCH v2] refs: use skip_prefix() in ref_is_hidden()

2017-07-21 Thread Christian Couder
This is shorter, makes the logic a bit easier to follow, and is perhaps a bit faster too. The logic is to make the final decision only when "subject" is there, its early part matches "match", and the match is at the slash boundary (or the whole thing). Signed-off-by: Chri

[PATCH] refs: use skip_prefix() in ref_is_hidden()

2017-07-21 Thread Christian Couder
This saves one line, makes the code a bit easier to understand and perhaps a bit faster too. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- refs.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/refs.c b/refs.c index ba22f4acef..15cb36d426

Re: [GSoC][PATCH 8/8] submodule: port submodule subcommand 'summary' from shell to C

2017-07-19 Thread Christian Couder
On Tue, Jul 18, 2017 at 10:49 PM, Prathamesh Chavan wrote: > +static void print_submodule_summary(struct summary_cb *info, > + struct module_cb *p) > +{ > + int missing_src = 0; > + int missing_dst = 0; > + char

Re: [GSoC][PATCH 6/8] submodule: port submodule subcommand 'deinit' from shell to C

2017-07-19 Thread Christian Couder
On Tue, Jul 18, 2017 at 10:49 PM, Prathamesh Chavan wrote: > +static void deinit_submodule(const struct cache_entry *list_item, > +void *cb_data) > +{ > + struct deinit_cb *info = cb_data; > + const struct submodule *sub; > + char

[ANNOUNCE] Git Rev News edition 29

2017-07-19 Thread Christian Couder
Hi everyone, The 29th edition of Git Rev News is now published: https://git.github.io/rev_news/2017/07/19/edition-29/ Thanks a lot to all the contributors and helpers! Enjoy, Christian, Thomas, Jakub and Markus.

Re: [PATCH v5 8/8] sha1_file: refactor has_sha1_file_with_flags

2017-07-18 Thread Christian Couder
On Thu, Jun 22, 2017 at 2:40 AM, Jonathan Tan wrote: > diff --git a/sha1_file.c b/sha1_file.c > index bf6b64ec8..778f01d92 100644 > --- a/sha1_file.c > +++ b/sha1_file.c > @@ -3494,18 +3494,10 @@ int has_sha1_pack(const unsigned char *sha1) > > int

Draft of Git Rev News edition 29

2017-07-17 Thread Christian Couder
Hi, A draft of a new Git Rev News edition is available here: https://github.com/git/git.github.io/blob/master/rev_news/drafts/edition-29.md Everyone is welcome to contribute in any section either by editing the above page on GitHub and sending a pull request, or by commenting on this GitHub

Re: [ANNOUNCE] Git v2.14.0-rc0

2017-07-14 Thread Christian Couder
On Sat, Jul 15, 2017 at 1:17 AM, Ævar Arnfjörð Bjarmason wrote: > > On Thu, Jul 13 2017, Junio C. Hamano jotted: >> * "git send-email" learned to overcome some SMTP server limitation >>that does not allow many pieces of e-mails to be sent over a single >>session. > >

Re: [PATCH v2 1/1] sha1_file: Add support for downloading blobs on demand

2017-07-14 Thread Christian Couder
On Fri, Jul 14, 2017 at 3:26 PM, Ben Peart wrote: > diff --git a/contrib/long-running-read-object/example.pl > b/contrib/long-running-read-object/example.pl > new file mode 100755 > index 00..b8f37f836a > --- /dev/null > +++

Re: [PATCH v1 0/4] Teach 'run' perf script to read config files

2017-07-14 Thread Christian Couder
On Thu, Jul 13, 2017 at 10:55 PM, Jeff King <p...@peff.net> wrote: > On Thu, Jul 13, 2017 at 08:57:01PM +0200, Christian Couder wrote: > >> >> We want to make it possible to store the parameters to the 'run' >> >> script in a config file. This will make it

Re: [PATCH v1 0/4] Teach 'run' perf script to read config files

2017-07-13 Thread Christian Couder
On Thu, Jul 13, 2017 at 8:40 PM, Jeff King wrote: > On Thu, Jul 13, 2017 at 11:29:10AM -0700, Junio C Hamano wrote: > >> > So then I think your config file primarily becomes about defining the >> > properties of each run. I'm not sure if it would look like what you're >> > starting

Re: [PATCH v1 0/4] Teach 'run' perf script to read config files

2017-07-13 Thread Christian Couder
On Thu, Jul 13, 2017 at 6:58 PM, Jeff King <p...@peff.net> wrote: > On Thu, Jul 13, 2017 at 08:50:46AM +0200, Christian Couder wrote: > >> Goal >> >> >> Using many long environment variables to give parameters to the 'run' >> script is error prone and

<    2   3   4   5   6   7   8   9   10   11   >