If there is no new line at the end of something it receives,
the packet_txt_read() function die()s, but it's difficult to
debug without much context.
Let's give a bit more information when that happens.
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org>
---
t/t0021/rot13-filter.
(It looks like I did not reply to this other email yet, sorry about
this late reply.)
On Wed, Jul 12, 2017 at 9:06 PM, Jonathan Tan <jonathanta...@google.com> wrote:
> On Tue, 20 Jun 2017 09:54:34 +0200
> Christian Couder <christian.cou...@gmail.com> wrote:
>
>> Git
(It looks like I did not reply to this email yet, sorry about this late reply.)
On Thu, Jul 6, 2017 at 7:36 PM, Ben Peart <peart...@gmail.com> wrote:
>
> On 7/1/2017 3:41 PM, Christian Couder wrote:
>>
>> On Fri, Jun 23, 2017 at 8:24 PM, Ben Peart <peart...@gmail.com&g
On Thu, Sep 14, 2017 at 8:19 PM, Jonathan Tan <jonathanta...@google.com> wrote:
> On Thu, 14 Sep 2017 10:39:35 +0200
> Christian Couder <christian.cou...@gmail.com> wrote:
>
>> From the following email:
>>
>> https://public-inbox.org/git/201708041451
On Thu, Aug 3, 2017 at 9:34 PM, Junio C Hamano <gits...@pobox.com> wrote:
> Christian Couder <christian.cou...@gmail.com> writes:
>
>> diff --git a/external-odb.h b/external-odb.h
>> new file mode 100644
>> index 00..9989490c9e
>> --- /dev/nu
On Thu, Aug 3, 2017 at 9:52 PM, Junio C Hamano <gits...@pobox.com> wrote:
> Christian Couder <christian.cou...@gmail.com> writes:
>
>> The mechanism to decide which blobs should be sent to which
>> external object database will be very simple for now.
>> If
On Thu, Aug 3, 2017 at 9:50 PM, Junio C Hamano <gits...@pobox.com> wrote:
> Christian Couder <christian.cou...@gmail.com> writes:
>
>> Add support for a 'put_raw_obj' capability/instruction to send new
>> objects to an external odb. Objects will be sent as they
On Thu, Aug 3, 2017 at 11:40 PM, Junio C Hamano <gits...@pobox.com> wrote:
> Christian Couder <christian.cou...@gmail.com> writes:
>
>> This implements the 'get_direct' capability/instruction that makes
>> it possible for external odb helper scripts to pass blobs to G
On Thu, Aug 3, 2017 at 10:07 PM, Junio C Hamano <gits...@pobox.com> wrote:
> Christian Couder <christian.cou...@gmail.com> writes:
>
>> +OLDIFS="$IFS"
>> +IFS='&'
>> +set -- $QUERY_STRING
>> +IFS="$OLDIFS"
>> +
>> +while
On Sun, Sep 10, 2017 at 2:12 PM, Lars Schneider
<larsxschnei...@gmail.com> wrote:
>
>> On 03 Aug 2017, at 10:18, Christian Couder <christian.cou...@gmail.com>
>> wrote:
>>
>> +static void parse_capabilities(char *cap_buf,
>> +
On Sun, Sep 10, 2017 at 2:12 PM, Lars Schneider
<larsxschnei...@gmail.com> wrote:
>
>> On 03 Aug 2017, at 10:18, Christian Couder <christian.cou...@gmail.com>
>> wrote:
>>
>> To properly test passing objects from Git to an external odb
>> we n
On Sun, Sep 10, 2017 at 2:30 PM, Lars Schneider
<larsxschnei...@gmail.com> wrote:
>
>> On 03 Aug 2017, at 10:18, Christian Couder <christian.cou...@gmail.com>
>> wrote:
>>
>> ...
>>
>> * The "helpers" (registered commands)
>>
&
Hi,
On Sat, Sep 2, 2017 at 12:30 AM, Jeff King wrote:
>
> The big questions on whether we can make this happen are:
>
> 1. Do we have mentor interest?
>
> I'm willing to mentor, but I'd like to hear whether other people
> are interested, as well. Either way I can take
On Wed, Aug 30, 2017 at 2:50 PM, Ben Peart <peart...@gmail.com> wrote:
>
>
> On 8/29/2017 11:43 AM, Christian Couder wrote:
>>
>> On Mon, Aug 28, 2017 at 8:59 PM, Ben Peart <peart...@gmail.com> wrote:
>>>
>>>
>>> On 8/3/2
On Mon, Aug 28, 2017 at 8:59 PM, Ben Peart <peart...@gmail.com> wrote:
>
> On 8/3/2017 5:19 AM, Christian Couder wrote:
>>
>> +Helpers
>> +===
>> +
>> +ODB helpers are commands that have to be registered using either the
>> +"odb..subp
On Fri, Aug 25, 2017 at 11:23 PM, Jonathan Tan <jonathanta...@google.com> wrote:
> On Fri, 25 Aug 2017 08:14:08 +0200
> Christian Couder <christian.cou...@gmail.com> wrote:
>
>> As Git is used by more and more by people having different needs, I
>> think it is no
Since f1068efefe (sha1_file: drop experimental GIT_USE_LOOKUP search,
2017-08-09)
the definition of sha1_entry_pos() has been removed from "sha1-lookup.c", so
there is no need anymore for its declaration in "sha1-lookup.h".
Signed-off-by: Christian Couder <chrisc...@t
On Thu, Aug 3, 2017 at 8:38 PM, Stefan Beller <sbel...@google.com> wrote:
> On Thu, Aug 3, 2017 at 2:19 AM, Christian Couder
> <christian.cou...@gmail.com> wrote:
>> This describes the external odb mechanism's purpose and
>> how it works.
>
> Thanks for provi
Hi,
On Wed, Aug 23, 2017 at 10:10 AM, Nicolas Morey-Chaisemartin
wrote:
> Hi,
>
> I've created a small tool to display the current sequencer status.
> It mimics what Magit does to display what was done and what is left to do.
>
> As someone who often rebase large
On Tue, Aug 22, 2017 at 10:11 PM, Harry Putnam wrote:
>
> I run 5-10 vbox vms' on this host with various OS's involved.
> With each host, I've kept a local repo of some key OS rc files.
> and a couple of hundred home made scripts.
>
> They all follow the same pattern of setup,
On Wed, Aug 16, 2017 at 5:58 PM, Junio C Hamano <gits...@pobox.com> wrote:
> Christian Couder <christian.cou...@gmail.com> writes:
>
>>>> I am still wondering if protocol errors should be fatal,
>>>
>>> Yes, please.
>>
>> Unfortunately
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org>
---
Change since previous version:
- Use process->argv[0] instead of adding a new parameter to
handshake_capabilities(), thanks to Lars.
sub-process.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sub-
On Wed, Aug 16, 2017 at 2:22 AM, Jonathan Nieder <jrnie...@gmail.com> wrote:
> Jonathan Tan wrote:
>> Christian Couder <christian.cou...@gmail.com> wrote:
>
>>> In handshake_capabilities() we use warning() when a capability
>>> is not suppor
Hi everyone,
The 30th edition of Git Rev News is now published:
https://git.github.io/rev_news/2017/08/16/edition-30/
Thanks a lot to all the contributors and helpers!
Enjoy,
Christian, Thomas, Jakub and Markus.
On Tue, Aug 15, 2017 at 9:35 PM, Lars Schneider
<larsxschnei...@gmail.com> wrote:
>
>> On 15 Aug 2017, at 21:29, Christian Couder <christian.cou...@gmail.com>
>> wrote:
>>
>> On Tue, Aug 15, 2017 at 9:00 PM, Lars Schneider
>> <larsxschnei...@g
On Tue, Aug 15, 2017 at 9:29 PM, Christian Couder
<christian.cou...@gmail.com> wrote:
> On Tue, Aug 15, 2017 at 9:00 PM, Lars Schneider
> <larsxschnei...@gmail.com> wrote:
>>
>>> On 15 Aug 2017, at 19:36, Christian Couder <christian.cou...@gmail.com>
>>
On Tue, Aug 15, 2017 at 9:00 PM, Lars Schneider
<larsxschnei...@gmail.com> wrote:
>
>> On 15 Aug 2017, at 19:36, Christian Couder <christian.cou...@gmail.com>
>> wrote:
>>
>> In handshake_capabilities() we use warning() when a capability
>> is not sup
this function,
we use error() and then subprocess_start() outputs:
initialization for subprocess '' failed
so we can know which subprocess cmd failed.
Let's improve the warning() message, so that we can know which
subprocess cmd failed.
Signed-off-by: Christian Couder <chrisc...@tuxfamily.
Hi,
A draft of a new Git Rev News edition is available here:
https://github.com/git/git.github.io/blob/master/rev_news/drafts/edition-30.md
Everyone is welcome to contribute in any section either by editing the
above page on GitHub and sending a pull request, or by commenting on
this GitHub
On Fri, Aug 11, 2017 at 11:06 AM, Jeff King <p...@peff.net> wrote:
> On Fri, Aug 11, 2017 at 09:02:24AM +0200, Christian Couder wrote:
>
>> > But I really don't want callers to think of it as "unfold". I want it to
>> > be "turn this into so
On Fri, Aug 11, 2017 at 1:10 AM, Jeff King wrote:
> On Fri, Aug 11, 2017 at 12:02:49AM +0100, Ramsay Jones wrote:
>
>> > But some of those things are not 1:1 mappings with normalization. For
>> > instance, --json presumably implies --only-trailers. Or are we proposing
>> > to
On Thu, Aug 10, 2017 at 9:44 PM, Stefan Beller <sbel...@google.com> wrote:
> On Thu, Aug 10, 2017 at 12:39 PM, Christian Couder
> <christian.cou...@gmail.com> wrote:
>> On Thu, Aug 10, 2017 at 8:37 PM, Jeff King <p...@peff.net> wrote:
>>> On Thu, Aug 10,
On Thu, Aug 10, 2017 at 9:42 PM, Jeff King <p...@peff.net> wrote:
> On Thu, Aug 10, 2017 at 09:39:21PM +0200, Christian Couder wrote:
>
>> > If you prefer the normalized form (and the input was line-broken in a
>> > way that you don't like), then this would convert
On Thu, Aug 10, 2017 at 8:37 PM, Jeff King wrote:
> On Thu, Aug 10, 2017 at 11:35:00AM -0700, Stefan Beller wrote:
>
>> On Thu, Aug 10, 2017 at 1:03 AM, Jeff King wrote:
>> > The point of "--only-trailers" is to give a caller an output
>> > that's easy for them to
On Wed, Aug 9, 2017 at 5:54 PM, René Scharfe wrote:
> Use a NULL-and-NUL check to see if we have a prefix and consistently use
> C string functions on it instead of storing its length in a member of
> struct apply_state. This avoids strlen() calls and simplifies the code.
This
On Tue, Aug 8, 2017 at 10:50 PM, Jonathan Tan wrote:
> On Tue, 8 Aug 2017 13:36:24 -0700
> Stefan Beller wrote:
>>
>> There are also packed refs, so one could (like I did) think that
>> pack.c is for generic packing of things, maybe packfile.c
>>
On Mon, Aug 7, 2017 at 11:18 PM, Prathamesh Chavan wrote:
> +static enum {
> + DIFF_INDEX,
> + DIFF_FILES
> +} diff_cmd = DIFF_INDEX;
Using an enum could be a good idea, but I am not sure about using a
static variable.
> +static int
On Sat, Aug 5, 2017 at 12:28 PM, Prathamesh Chavan <pc44...@gmail.com> wrote:
> On Tue, Aug 1, 2017 at 4:57 AM, Christian Couder
> <christian.cou...@gmail.com> wrote:
>> On Mon, Jul 31, 2017 at 10:56 PM, Prathamesh Chavan <pc44...@gmail.com>
>> wrote:
On Thu, Aug 3, 2017 at 9:14 PM, Junio C Hamano <gits...@pobox.com> wrote:
> Christian Couder <christian.cou...@gmail.com> writes:
>
>> Add functions to help read and write capabilities.
>> Use these functions in 't/t0021/rot13-filter.pl'.
>>
>&g
On Thu, Aug 3, 2017 at 9:11 PM, Junio C Hamano wrote:
>> diff --git a/perl/Git/Packet.pm b/perl/Git/Packet.pm
>> new file mode 100644
>> index 00..aaffecbe2a
>> --- /dev/null
>> +++ b/perl/Git/Packet.pm
>> @@ -0,0 +1,71 @@
>> +package Git::Packet;
>> +use 5.008;
>>
Try to give a bit more information when we die()
because there is no new line at the end of something
we receive.
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org>
---
perl/Git/Packet.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/perl/Git/Packet.pm b/pe
This makes the code simpler by removing a few lines, and getting
rid of one variable.
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org>
---
builtin/clone.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/builtin/clone.c b/builtin/clone.c
index 08b5
To make it possible in a following commit to move packet
reading and writing functions into a Packet.pm module,
let's refactor these functions, so they don't handle
printing debug output and exiting.
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org>
---
t/t0021/rot13-filter.p
After creating Git/Packet.pm from part of t0021/rot13-filter.pl,
we can now simplify this script by using Git/Packet.pm.
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org>
---
t/t0021/rot13-filter.pl | 51 +++--
1 file changed, 3 inse
Add functions to help read and write capabilities.
Use these functions in 't/t0021/rot13-filter.pl'.
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org>
---
perl/Git/Packet.pm | 33 +
t/t0021/rot13-filter.pl | 9 ++---
2 files chang
This new environment variable will be used to perform git
commands without involving any external odb mechanism.
This makes it possible for example to create new blobs that
will not be sent to an external odb even if the external odb
supports "put_*" instructions.
Signed-off-by: Christ
cript mode is supported, and only the 'have' and
'get_git_obj' instructions are supported.
Helped-by: Jeff King <p...@peff.net>
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org>
---
Makefile| 2 +
cache.h | 1 +
externa
This tests that an apache web server can be used as an
external object database and store files in their native
format instead of converting them to a Git object.
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org>
---
t/t0420-transfer-http-e-odb.sh
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org>
---
t/t0410-transfer-e-odb.sh | 144 ++
1 file changed, 144 insertions(+)
create mode 100755 t/t0410-transfer-e-odb.sh
diff --git a/t/t0410-transfer-e-odb.sh b/t/t0410-transfer-e-odb.
This makes it possible to start an apache web server with different
config files.
This will be used in a later patch to pass a config file that makes
apache store external objects.
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org>
---
t/lib-httpd.sh | 6 --
1 file chan
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org>
---
t/t0430-clone-bundle-e-odb.sh | 85 +++
1 file changed, 85 insertions(+)
create mode 100755 t/t0430-clone-bundle-e-odb.sh
diff --git a/t/t0430-clone-bundle-e-odb.sh b/t/t0430-clone-bu
This describes the external odb mechanism's purpose and
how it works.
Helped-by: Ben Peart <benpe...@microsoft.com>
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org>
---
Documentation/technical/external-odb.txt | 295 +++
1 file changed, 29
rs defined using the existing "odb..scriptcommand"
are marked with the 'script_mode' field set to 1.
Implementation of the different capabilities/instructions in
the new (sub-)process mode is left for following commits.
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org>
This adds the infrastructure to handle 'have' instructions in
process mode.
The answer from the helper sub-process should be like the
output in script mode, that is lines like this:
sha1 SPACE size SPACE type NEWLINE
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org>
---
odb-he
To make it possible to have the external odb mechanism only kick in
after the initial part of a clone, we should disable it during the
initial part of the clone.
Let's do that by saving and then restoring the value of the
'use_external_odb' global variable.
Signed-off-by: Christian Couder
me kind of mechanism to "put" objects
into an external odb, where the odb helper would access blobs it
wants to send to an external odb directly from files, but it
would be strange to call that a fault-in mode too.
Signed-off-by: Christian Couder <chrisc...@tuxfam
From: Ben Peart <benpe...@microsoft.com>
This adds the infrastructure to launch and use long running
sub-processes as external odb helpers.
For now only the 'init' and 'get_direct' capabilities are
supported with sub-processes.
Signed-off-by: Christian Couder <chrisc...@tuxf
Objects managed by an external ODB should not be put into
pack files. They should be transfered using other mechanism
that can be specific to the external odb.
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org>
---
builtin/pack-objects.c | 4
1 file changed, 4 insertions(+)
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org>
---
t/t0400-external-odb.sh | 8
1 file changed, 8 insertions(+)
diff --git a/t/t0400-external-odb.sh b/t/t0400-external-odb.sh
index 3fa0449883..fa355bd7bb 100755
--- a/t/t0400-external-odb.sh
+++ b/t/t0400-external-
This adds the infrastructure to send objects to a sub-process
handling the communication with an external odb.
For now we only handle sending raw blobs using the 'put_raw_obj'
instruction.
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org>
---
odb-helper.
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org>
---
t/t0420-transfer-http-e-odb.sh | 7 +
t/t0470-read-object-http-e-odb.sh | 7 +
t/t0480-read-object-have-http-e-odb.sh | 7 +
t/t5616-clone-initial-refspec.sh | 48 +++
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org>
---
t/t0470-read-object-http-e-odb.sh | 109 ++
t/t0470/read-object-plain | 83 +
2 files changed, 192 insertions(+)
create mode 100755 t/t0470-read-object-
To tell which blobs should be sent to the "magic" external odb,
let's require that the blobs be marked using the 'odb=magic'
attribute.
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org>
---
external-odb.c | 22 --
We want to make it possible to separate fetching remote refs into
an initial part and a later part. To prepare for that, let's add
an 'initial' boolean parameter to write_remote_refs() to tell this
function if we are performing the initial part or not.
Signed-off-by: Christian Couder <chr
This is an apache config file to test external object databases.
It uses the upload.sh and list.sh cgi that have been added
previously to make apache store external objects.
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org>
---
t/lib-httpd/apache-e-odb.conf
the initial fetch.
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org>
---
builtin/clone.c | 55 ++-
1 file changed, 54 insertions(+), 1 deletion(-)
diff --git a/builtin/clone.c b/builtin/clone.c
index 2362dda880..76e561534d 100644
--- a/b
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org>
---
t/t0460-read-object-git.sh | 28 +
t/t0460/read-object-git| 78 ++
2 files changed, 106 insertions(+)
create mode 100755 t/t0460-read-object-git.sh
create mode 10
This cgi will be used to upload objects to, or to delete
objects from, an apache web server.
This way the apache server can work as an external object
database.
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org>
---
t/lib-httpd.sh| 1 +
t/lib-httpd/upload.s
The existing odb_helper_get_object() is renamed
odb_helper_get_git_object() and a new odb_helper_get_raw_object()
is introduced to deal with external objects that are not in Git format.
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org>
---
odb-helper.c
This cgi script can list Git objects that have been uploaded as
files to an apache web server. This script can also retrieve
the content of each of these files.
This will help make apache work as an external object database.
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org>
---
by an odb helper. This is not a great
default, but let's leave it to following commits to tweak that.
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org>
---
external-odb.c | 15 +++
external-odb.h | 2 ++
odb-helper.c | 43 ++-
odb-he
odb-helper
script works well.
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org>
---
t/t0400-external-odb.sh | 24
1 file changed, 24 insertions(+)
diff --git a/t/t0400-external-odb.sh b/t/t0400-external-odb.sh
index ed89f3ab40..3fa0449883 100755
--- a/t
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org>
---
t/t0480-read-object-have-http-e-odb.sh | 109 +
t/t0480/read-object-plain-have | 103 +++
2 files changed, 212 insertions(+)
create mode 100755 t/t0480-read-
The mechanism to decide which blobs should be sent to which
external object database will be very simple for now.
If the external odb helper support any "put_*" instruction
all the new blobs will be sent to it.
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org>
---
ex
From: Ben Peart <benpe...@microsoft.com>
Signed-off-by: Ben Peart <benpe...@microsoft.com>
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org>
---
t/t0450-read-object.sh | 28 +
t/t0450/read-object| 68 +
variable in struct odb_helper to store them.
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org>
---
external-odb.c | 9 -
odb-helper.c| 54 +
odb-helper.h| 12 +++
t/t0400-external-odb.s
benpe...@microsoft.com/
https://public-inbox.org/git/20170322165220.5660-1-benpe...@microsoft.com/
https://public-inbox.org/git/20170714132651.170708-1-benpe...@microsoft.com/
Links
~
This patch series is available here:
https://github.com/chriscool/git/commits/external-odb
Version 1, 2, 3 and 4 are he
Before further refactoring the "t0021/rot13-filter.pl" script,
let's modernize the style of its 'if .. elsif .. else' clauses
to improve its readability by making it more similar to our
other perl scripts.
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org>
---
t/t0021/rot1
split out 'sha1_file_name_alt()' from
'sha1_file_name()' and 'open_sha1_file_alt()' from
'open_sha1_file()', as we will need both of these new
functions too.
Helped-by: Jeff King <p...@peff.net>
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org>
---
cache.h | 8
This will make it possible to reuse packet reading and writing
functions in other test scripts.
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org>
---
perl/Git/Packet.pm | 71 ++
1 file changed, 71 insertions(+)
create mode 10064
Add a function to initialize the communication. And use this
function in 't/t0021/rot13-filter.pl'.
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org>
---
perl/Git/Packet.pm | 13 +
t/t0021/rot13-filter.pl | 8 +---
2 files changed, 14 insertions(+), 7 del
On Thu, Dec 1, 2016 at 12:37 AM, Jeff King <p...@peff.net> wrote:
> On Wed, Nov 30, 2016 at 03:30:09PM -0800, Junio C Hamano wrote:
>
>> Christian Couder <christian.cou...@gmail.com> writes:
>>
>> > From: Jeff King <p...@peff.net>
>> >
>>
(I realized that I didn't answer this email about the v3 version.
Sorry about this late answer.)
On Thu, Dec 1, 2016 at 12:30 AM, Junio C Hamano <gits...@pobox.com> wrote:
> Christian Couder <christian.cou...@gmail.com> writes:
>
>> From: Jeff King <p...@peff.net>
On Mon, Jul 31, 2017 at 10:56 PM, Prathamesh Chavan wrote:
> * variable head was no longer used in module_summary() and instead the strbuf
> was utilized.
Good but there might be a few problems in the way it is used. See below.
> +static int
On Sun, Jul 30, 2017 at 12:23 AM, Prathamesh Chavan wrote:
> +static void print_status(struct status_cb *info, char state, const char
> *path,
> +const struct object_id *oid, const char *displaypath)
> +{
> + if (info->quiet)
> +
On Sun, Jul 30, 2017 at 12:23 AM, Prathamesh Chavan wrote:
> +static int module_summary(int argc, const char **argv, const char *prefix)
> +{
> + struct summary_cb info = SUMMARY_CB_INIT;
> + int cached = 0;
> + char *diff_cmd = "diff-index";
> + int
On Fri, Jul 14, 2017 at 8:27 AM, Christian Couder
<christian.cou...@gmail.com> wrote:
> On Thu, Jul 13, 2017 at 10:55 PM, Jeff King <p...@peff.net> wrote:
>> On Thu, Jul 13, 2017 at 08:57:01PM +0200, Christian Couder wrote:
>>
>>> >> We want to make it po
On Sat, Jul 1, 2017 at 5:24 PM, Dan Kohn wrote:
> https://github.com/coreinfrastructure/best-practices-badge is a user
> of the https://github.com/probot/dco bot which checks that commits
> have a signoff. The issue is that there is no `--signoff` option in
> git for
This is shorter, makes the logic a bit easier to follow, and is
perhaps a bit faster too.
The logic is to make the final decision only when "subject" is there,
its early part matches "match", and the match is at the slash
boundary (or the whole thing).
Signed-off-by: Chri
This saves one line, makes the code a bit easier to understand
and perhaps a bit faster too.
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org>
---
refs.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/refs.c b/refs.c
index ba22f4acef..15cb36d426
On Tue, Jul 18, 2017 at 10:49 PM, Prathamesh Chavan wrote:
> +static void print_submodule_summary(struct summary_cb *info,
> + struct module_cb *p)
> +{
> + int missing_src = 0;
> + int missing_dst = 0;
> + char
On Tue, Jul 18, 2017 at 10:49 PM, Prathamesh Chavan wrote:
> +static void deinit_submodule(const struct cache_entry *list_item,
> +void *cb_data)
> +{
> + struct deinit_cb *info = cb_data;
> + const struct submodule *sub;
> + char
Hi everyone,
The 29th edition of Git Rev News is now published:
https://git.github.io/rev_news/2017/07/19/edition-29/
Thanks a lot to all the contributors and helpers!
Enjoy,
Christian, Thomas, Jakub and Markus.
On Thu, Jun 22, 2017 at 2:40 AM, Jonathan Tan wrote:
> diff --git a/sha1_file.c b/sha1_file.c
> index bf6b64ec8..778f01d92 100644
> --- a/sha1_file.c
> +++ b/sha1_file.c
> @@ -3494,18 +3494,10 @@ int has_sha1_pack(const unsigned char *sha1)
>
> int
Hi,
A draft of a new Git Rev News edition is available here:
https://github.com/git/git.github.io/blob/master/rev_news/drafts/edition-29.md
Everyone is welcome to contribute in any section either by editing the
above page on GitHub and sending a pull request, or by commenting on
this GitHub
On Sat, Jul 15, 2017 at 1:17 AM, Ævar Arnfjörð Bjarmason
wrote:
>
> On Thu, Jul 13 2017, Junio C. Hamano jotted:
>> * "git send-email" learned to overcome some SMTP server limitation
>>that does not allow many pieces of e-mails to be sent over a single
>>session.
>
>
On Fri, Jul 14, 2017 at 3:26 PM, Ben Peart wrote:
> diff --git a/contrib/long-running-read-object/example.pl
> b/contrib/long-running-read-object/example.pl
> new file mode 100755
> index 00..b8f37f836a
> --- /dev/null
> +++
On Thu, Jul 13, 2017 at 10:55 PM, Jeff King <p...@peff.net> wrote:
> On Thu, Jul 13, 2017 at 08:57:01PM +0200, Christian Couder wrote:
>
>> >> We want to make it possible to store the parameters to the 'run'
>> >> script in a config file. This will make it
On Thu, Jul 13, 2017 at 8:40 PM, Jeff King wrote:
> On Thu, Jul 13, 2017 at 11:29:10AM -0700, Junio C Hamano wrote:
>
>> > So then I think your config file primarily becomes about defining the
>> > properties of each run. I'm not sure if it would look like what you're
>> > starting
On Thu, Jul 13, 2017 at 6:58 PM, Jeff King <p...@peff.net> wrote:
> On Thu, Jul 13, 2017 at 08:50:46AM +0200, Christian Couder wrote:
>
>> Goal
>>
>>
>> Using many long environment variables to give parameters to the 'run'
>> script is error prone and
601 - 700 of 2901 matches
Mail list logo