Re: [PATCH 1/2] commit-slab: document clear_$slabname()

2013-11-29 Thread Thomas Rast
Jonathan Nieder jrnie...@gmail.com writes: Thomas Rast wrote: + * + * - void clear_indegree(struct indegree *); + * + * Free the slab's data structures. Tense shift (previous descriptions were in the present tense, while this one is in the imperative). More importantly, this doesn't

Re: [PATCH 1/2] commit-slab: document clear_$slabname()

2013-11-27 Thread Eric Sunshine
On Mon, Nov 25, 2013 at 3:39 PM, Junio C Hamano gits...@pobox.com wrote: Thomas Rast t...@thomasrast.ch writes: The clear_$slabname() function was only documented by source code so far. Write something about it. Signed-off-by: Thomas Rast t...@thomasrast.ch --- commit-slab.h | 4 1

[PATCH 1/2] commit-slab: document clear_$slabname()

2013-11-25 Thread Thomas Rast
The clear_$slabname() function was only documented by source code so far. Write something about it. Signed-off-by: Thomas Rast t...@thomasrast.ch --- commit-slab.h | 4 1 file changed, 4 insertions(+) diff --git a/commit-slab.h b/commit-slab.h index d4c8286..d77aaea 100644 ---

Re: [PATCH 1/2] commit-slab: document clear_$slabname()

2013-11-25 Thread Jonathan Nieder
Thomas Rast wrote: The clear_$slabname() function was only documented by source code so far. Write something about it. Good idea. [...] --- a/commit-slab.h +++ b/commit-slab.h @@ -24,6 +24,10 @@ * to each commit. 'stride' specifies how big each array is. The slab * that id

Re: [PATCH 1/2] commit-slab: document clear_$slabname()

2013-11-25 Thread Junio C Hamano
Thomas Rast t...@thomasrast.ch writes: The clear_$slabname() function was only documented by source code so far. Write something about it. Signed-off-by: Thomas Rast t...@thomasrast.ch --- commit-slab.h | 4 1 file changed, 4 insertions(+) diff --git a/commit-slab.h