Re: [PATCH v3 07/10] builtin/replace: teach listing using short, medium or full formats

2013-12-28 Thread Christian Couder
From: Junio C Hamano > > Christian Couder writes: >> >> Ok, so would you prefer the following: >> >> - NAME_ONLY_REPLACE_FMT and "--format=name_only" instead of >> SHORT_REPLACE_FMT and "--format=short" >> >> - NAME_AND_VALUE_REPLACE_FMT and "--format=name_and_value" instead of >> MEDIUM_REPLACE

Re: [PATCH v3 07/10] builtin/replace: teach listing using short, medium or full formats

2013-12-26 Thread Junio C Hamano
Christian Couder writes: > On Thu, Dec 19, 2013 at 7:58 PM, Junio C Hamano wrote: >> Christian Couder writes: >> >>> I think this last one might be useful for people replacing objects >>> with objects that have another type. >> >> ... which IIUC is strongly discouraged---didn't you have to tigh

Re: [PATCH v3 07/10] builtin/replace: teach listing using short, medium or full formats

2013-12-21 Thread Christian Couder
On Thu, Dec 19, 2013 at 7:58 PM, Junio C Hamano wrote: > Christian Couder writes: > >> I think this last one might be useful for people replacing objects >> with objects that have another type. > > ... which IIUC is strongly discouraged---didn't you have to tighten > it recently? > > And that mak

Re: [PATCH v3 07/10] builtin/replace: teach listing using short, medium or full formats

2013-12-19 Thread Junio C Hamano
Christian Couder writes: > I think this last one might be useful for people replacing objects > with objects that have another type. ... which IIUC is strongly discouraged---didn't you have to tighten it recently? And that makes it "useful primarily for debugging" unusual situations. > And as

Re: [PATCH v3 07/10] builtin/replace: teach listing using short, medium or full formats

2013-12-19 Thread Christian Couder
On Wed, Dec 18, 2013 at 6:37 PM, Junio C Hamano wrote: > Christian Couder writes: > >> On Wed, Dec 18, 2013 at 1:37 PM, Karsten Blees >> wrote: >>> Am 11.12.2013 08:46, schrieb Christian Couder: +enum repl_fmt { SHORT, MEDIUM, FULL }; >>> >>> SHORT is predefined on Windows, could you choos

Re: [PATCH v3 07/10] builtin/replace: teach listing using short, medium or full formats

2013-12-18 Thread Junio C Hamano
Christian Couder writes: > On Wed, Dec 18, 2013 at 1:37 PM, Karsten Blees > wrote: >> Am 11.12.2013 08:46, schrieb Christian Couder: >>> +enum repl_fmt { SHORT, MEDIUM, FULL }; >> >> SHORT is predefined on Windows, could you choose another name? > > Ok, I will change to: > > enum repl_fmt { SHO

Re: [PATCH v3 07/10] builtin/replace: teach listing using short, medium or full formats

2013-12-18 Thread Christian Couder
On Wed, Dec 18, 2013 at 1:37 PM, Karsten Blees wrote: > Am 11.12.2013 08:46, schrieb Christian Couder: >> +enum repl_fmt { SHORT, MEDIUM, FULL }; > > SHORT is predefined on Windows, could you choose another name? Ok, I will change to: enum repl_fmt { SHORT_FMT, MEDIUM_FMT, FULL_FMT }; Thanks, C

Re: [PATCH v3 07/10] builtin/replace: teach listing using short, medium or full formats

2013-12-18 Thread Karsten Blees
Am 11.12.2013 08:46, schrieb Christian Couder: > +enum repl_fmt { SHORT, MEDIUM, FULL }; SHORT is predefined on Windows, could you choose another name? MinGW: builtin/replace.c:23: error: 'SHORT' redeclared as different kind of symbol c:\git\msysgit\mingw\bin\../lib/gcc/mingw32/4.4.0/../../../..

[PATCH v3 07/10] builtin/replace: teach listing using short, medium or full formats

2013-12-10 Thread Christian Couder
By default when listing replace refs, only the sha1 of the replaced objects are shown. In many cases, it is much nicer to be able to list all the sha1 of the replaced objects along with the sha1 of the replacment objects. And in other cases it might be interesting to also show the types of the re