Re: [PATCHv3 0/3] Implements the GIT_TRACE_CURL environment variable

2016-04-20 Thread Jeff King
On Wed, Apr 20, 2016 at 08:49:55PM +0100, Ramsay Jones wrote: > > Strictly speaking 1 should come at the end for the same reason, as > > setting GIT_TRACE_CURL after seeing that commit would not give users > > anything new. > > Yep, I was just about to send an email saying that the patches should

Re: [PATCHv3 0/3] Implements the GIT_TRACE_CURL environment variable

2016-04-20 Thread Ramsay Jones
On 20/04/16 19:41, Junio C Hamano wrote: > Elia Pinto writes: > >> Elia Pinto (3): >> git.txt: document the new GIT_TRACE_CURL environment variable >> imap-send.c: introduce the GIT_TRACE_CURL enviroment variable >> http.c: implements the GIT_TRACE_CURL environment variable > > I think 2

Re: [PATCHv3 0/3] Implements the GIT_TRACE_CURL environment variable

2016-04-20 Thread Junio C Hamano
Elia Pinto writes: > Elia Pinto (3): > git.txt: document the new GIT_TRACE_CURL environment variable > imap-send.c: introduce the GIT_TRACE_CURL enviroment variable > http.c: implements the GIT_TRACE_CURL environment variable I think 2 & 3 need to be swapped; otherwise 2 would refer to yet

[PATCHv3 0/3] Implements the GIT_TRACE_CURL environment variable

2016-04-20 Thread Elia Pinto
This is the third version but in reality is the complete rewriting of the patches discussed here (here called V1) $gmane/290520 $gmane/290521 *Changes from V2 ($gmane/291868) - fix garbage comment in http.c (i am very sorry for that) - add final '.' to the commit message for imap-send.c and to