Re: [PATCH 4/4] cat-file: support --textconv/--filters in batch mode

Jeff King writes: >> Sorry, Torsten, this is not my doing. So I cannot explain why it is not an >> enum. >> >> I *guess* the rationale for 'c' being the cmdmode of --textconv is "c for >> convert". That is why I chose "w as in worktree" as new cmdmode. > > I think it started as a

Re: [PATCH 4/4] cat-file: support --textconv/--filters in batch mode

On Fri, Aug 19, 2016 at 02:25:51PM +0200, Johannes Schindelin wrote: > > On Thu, Aug 18, 2016 at 02:46:28PM +0200, Johannes Schindelin wrote: > > > diff --git a/builtin/cat-file.c b/builtin/cat-file.c > > > index 5ff58b3..5f91cf4 100644 > > > --- a/builtin/cat-file.c > > > +++

Re: [PATCH 4/4] cat-file: support --textconv/--filters in batch mode

On Fri, Aug 19, 2016 at 02:59:32PM +0200, Johannes Schindelin wrote: > > The only thing that somewhat is worrysome is what would happen to > > %(rest). > > What would happen is that it would print out the path, as it is exactly > that "rest" field that is used in the implementation, piggybacking

Re: [PATCH 4/4] cat-file: support --textconv/--filters in batch mode

On Fri, Aug 19, 2016 at 03:09:19PM +0200, Johannes Schindelin wrote: > > The object name can have spaces in it, too. E.g.: > > > > HEAD:path with spaces > > > > or even: > > > > :/grep for this > > > > (as was pointed out to me when I tried to turn on %(rest) handling by > > default, long

Re: [PATCH 4/4] cat-file: support --textconv/--filters in batch mode

Hi Junio, On Thu, 18 Aug 2016, Junio C Hamano wrote: > Jeff King writes: > > > On Thu, Aug 18, 2016 at 02:46:28PM +0200, Johannes Schindelin wrote: > > > >> With this patch, --batch can be combined with --textconv or --filters. > >> For this to work, the input needs to have the

Re: [PATCH 4/4] cat-file: support --textconv/--filters in batch mode

Hi Peff, On Thu, 18 Aug 2016, Jeff King wrote: > On Thu, Aug 18, 2016 at 02:46:28PM +0200, Johannes Schindelin wrote: > > > With this patch, --batch can be combined with --textconv or --filters. > > For this to work, the input needs to have the form > > > > > > > > so that the filters

Re: [PATCH 4/4] cat-file: support --textconv/--filters in batch mode

Hi Junio, On Thu, 18 Aug 2016, Junio C Hamano wrote: > Johannes Schindelin writes: > > > With this patch, --batch can be combined with --textconv or --filters. > > For this to work, the input needs to have the form > > > > > > > > so that the filters can be

Re: [PATCH 4/4] cat-file: support --textconv/--filters in batch mode

Hi Torsten, On Thu, 18 Aug 2016, Torsten Bögershausen wrote: > On Thu, Aug 18, 2016 at 02:46:28PM +0200, Johannes Schindelin wrote: > > diff --git a/builtin/cat-file.c b/builtin/cat-file.c > > index 5ff58b3..5f91cf4 100644 > > --- a/builtin/cat-file.c > > +++ b/builtin/cat-file.c > > @@ -17,6

Re: [PATCH 4/4] cat-file: support --textconv/--filters in batch mode

On Thu, Aug 18, 2016 at 02:46:28PM +0200, Johannes Schindelin wrote: > With this patch, --batch can be combined with --textconv or --filters. > For this to work, the input needs to have the form > > > > so that the filters can be chosen appropriately. > > Signed-off-by: Johannes

Re: [PATCH 4/4] cat-file: support --textconv/--filters in batch mode

On Thu, Aug 18, 2016 at 02:46:28PM +0200, Johannes Schindelin wrote: > With this patch, --batch can be combined with --textconv or --filters. > For this to work, the input needs to have the form > > > > so that the filters can be chosen appropriately. The object name can have spaces in

Re: [PATCH 4/4] cat-file: support --textconv/--filters in batch mode

Johannes Schindelin writes: > With this patch, --batch can be combined with --textconv or --filters. > For this to work, the input needs to have the form > > > > so that the filters can be chosen appropriately. > --batch:: > --batch=:: > Print object

Re: [PATCH 4/4] cat-file: support --textconv/--filters in batch mode

Jeff King writes: > On Thu, Aug 18, 2016 at 02:46:28PM +0200, Johannes Schindelin wrote: > >> With this patch, --batch can be combined with --textconv or --filters. >> For this to work, the input needs to have the form >> >> >> >> so that the filters can be chosen