Re: [PATCH v9 4/4] tag: support configuring --sort via .gitconfig

2014-07-16 Thread Junio C Hamano
Keller, Jacob E jacob.e.kel...@intel.com writes: On Tue, 2014-07-15 at 19:42 -0400, Jeff King wrote: On Tue, Jul 15, 2014 at 04:32:59PM -0700, Jacob Keller wrote: +static void error_bad_sort_config(const char *err, va_list params) +{ + vreportf(warning: tag.sort has , err, params);

Re: [PATCH v9 4/4] tag: support configuring --sort via .gitconfig

2014-07-16 Thread Keller, Jacob E
On Wed, 2014-07-16 at 10:59 -0700, Junio C Hamano wrote: Keller, Jacob E jacob.e.kel...@intel.com writes: On Tue, 2014-07-15 at 19:42 -0400, Jeff King wrote: On Tue, Jul 15, 2014 at 04:32:59PM -0700, Jacob Keller wrote: +static void error_bad_sort_config(const char *err, va_list

Re: [PATCH v9 4/4] tag: support configuring --sort via .gitconfig

2014-07-16 Thread Keller, Jacob E
On Wed, 2014-07-16 at 10:59 -0700, Junio C Hamano wrote: Keller, Jacob E jacob.e.kel...@intel.com writes: On Tue, 2014-07-15 at 19:42 -0400, Jeff King wrote: On Tue, Jul 15, 2014 at 04:32:59PM -0700, Jacob Keller wrote: +static void error_bad_sort_config(const char *err, va_list

Re: [PATCH v9 4/4] tag: support configuring --sort via .gitconfig

2014-07-16 Thread Junio C Hamano
Keller, Jacob E jacob.e.kel...@intel.com writes: After all, it seems to me that the one in http://thread.gmane.org/gmane.comp.version-control.git/253346 struck the right balance among various abuses; let's use the error reporter from that version, instead of going down this rabbit

Re: [PATCH v9 4/4] tag: support configuring --sort via .gitconfig

2014-07-16 Thread Keller, Jacob E
On Wed, 2014-07-16 at 14:40 -0700, Junio C Hamano wrote: Keller, Jacob E jacob.e.kel...@intel.com writes: After all, it seems to me that the one in http://thread.gmane.org/gmane.comp.version-control.git/253346 struck the right balance among various abuses; let's use the error

Re: [PATCH v9 4/4] tag: support configuring --sort via .gitconfig

2014-07-15 Thread Jeff King
On Tue, Jul 15, 2014 at 04:32:59PM -0700, Jacob Keller wrote: +static void error_bad_sort_config(const char *err, va_list params) +{ + vreportf(warning: tag.sort has , err, params); +} This feels a little like an abuse of the prefix field of vreportf, but as you probably saw in my for

Re: [PATCH v9 4/4] tag: support configuring --sort via .gitconfig

2014-07-15 Thread Keller, Jacob E
On Tue, 2014-07-15 at 19:42 -0400, Jeff King wrote: On Tue, Jul 15, 2014 at 04:32:59PM -0700, Jacob Keller wrote: +static void error_bad_sort_config(const char *err, va_list params) +{ + vreportf(warning: tag.sort has , err, params); +} This feels a little like an abuse of the