On Mon, May 13, 2013 at 04:57:55PM +0200, Michael J Gruber wrote:
I don't think that it is a property of the file itself. That is, you do
not say foo files are inherently uninteresting to git-show, and
therefore we always convert them, whereas bar files do not have that
property'. You say
On Sun, May 12, 2013 at 10:01:38PM -0700, Junio C Hamano wrote:
Michael J Gruber g...@drmicha.warpmail.net writes:
Adding to that:
Somehow I still feel I should introduce a new attribute show (or a
better name) similar to diff so that you can specifiy a diff driver to
use for showing
Jeff King venit, vidit, dixit 13.05.2013 13:55:
On Sun, May 12, 2013 at 10:01:38PM -0700, Junio C Hamano wrote:
Michael J Gruber g...@drmicha.warpmail.net writes:
Adding to that:
Somehow I still feel I should introduce a new attribute show (or a
better name) similar to diff so that you
Michael J Gruber g...@drmicha.warpmail.net writes:
But you do have the possibility to use different drivers for diff and
show. For example, for showing a file some sort of automatic pagination
or line numbering can be helpful whereas it would hurt the diff case.
I do not find the example
Adding to that:
Somehow I still feel I should introduce a new attribute show (or a
better name) similar to diff so that you can specifiy a diff driver to
use for showing a blob (or grepping it), which may or may not be the
same you use for diff. This would be a much more fine-grained and
Junio C Hamano venit, vidit, dixit 11.05.2013 19:36:
Michael J Gruber g...@drmicha.warpmail.net writes:
+ if (!DIFF_OPT_TOUCHED(rev-diffopt, ALLOW_TEXTCONV) ||
+ !DIFF_OPT_TST(rev-diffopt, ALLOW_TEXTCONV))
+ return stream_blob_to_fd(1, sha1, NULL, 0);
It is surprising that
Michael J Gruber g...@drmicha.warpmail.net writes:
Adding to that:
Somehow I still feel I should introduce a new attribute show (or a
better name) similar to diff so that you can specifiy a diff driver to
use for showing a blob (or grepping it), which may or may not be the
same you use for
Junio C Hamano venit, vidit, dixit 10.05.2013 19:02:
Michael J Gruber g...@drmicha.warpmail.net writes:
Currently, diff and cat-file for blobs honor --textconv options
(with the former defaulting to --textconv and the latter to
--no-textconv) whereas show does not honor this option, even
Michael J Gruber g...@drmicha.warpmail.net writes:
+ if (!DIFF_OPT_TOUCHED(rev-diffopt, ALLOW_TEXTCONV) ||
+ !DIFF_OPT_TST(rev-diffopt, ALLOW_TEXTCONV))
+ return stream_blob_to_fd(1, sha1, NULL, 0);
It is surprising that the necessary change is only this, but I think
it
Michael J Gruber g...@drmicha.warpmail.net writes:
Currently, diff and cat-file for blobs honor --textconv options
(with the former defaulting to --textconv and the latter to
--no-textconv) whereas show does not honor this option, even though
it takes diff options.
Make show on blobs behave
On Fri, May 10, 2013 at 10:02:51AM -0700, Junio C Hamano wrote:
Make show on blobs behave like diff, i.e. honor --textconv by
default and --no-textconv when given.
[...]
So show on blobs does show the raw contents by default, but the
user can explicitly ask to enable textconv with
Jeff King p...@peff.net writes:
On Fri, May 10, 2013 at 10:02:51AM -0700, Junio C Hamano wrote:
Make show on blobs behave like diff, i.e. honor --textconv by
default and --no-textconv when given.
[...]
So show on blobs does show the raw contents by default, but the
user can explicitly
12 matches
Mail list logo
