Re: git-pull-script hates me

2005-07-06 Thread Junio C Hamano
> "LT" == Linus Torvalds <[EMAIL PROTECTED]> writes: LT> But yeah, it's being a bit too anal. Just look at connect.c: shell_safe(), LT> and add both '_' and '@' to the safe list (and any other safe characters), LT> and off you go. LT> And if somebody wants to add code to do proper escaping of

Re: git-pull-script hates me

2005-07-06 Thread Linus Torvalds
On Wed, 6 Jul 2005, Junio C Hamano wrote: > > Anybody who is interested in doing this can just move > sq_expand() from diff.c to some public library and expose it in > cache.h. No, that doesn't work at all. "sq_expand()" tries to protect things inside single quotes. That's a totally different

Re: git-pull-script hates me

2005-07-06 Thread Greg KH
On Wed, Jul 06, 2005 at 01:37:55PM -0700, Linus Torvalds wrote: > > > On Wed, 6 Jul 2005, Greg KH wrote: > > > > I just updated to the latest git tree, and now get the following when I > > try to pull from a ssh repo: > > > > $ git-pull-script [EMAIL PROTECTED]:/public_html/udev.git/ > > fatal

Re: git-pull-script hates me

2005-07-06 Thread Linus Torvalds
On Wed, 6 Jul 2005, Greg KH wrote: > > Ok, below is a patch for this. It works, but then errors out with: > bash: git-upload-pack: command not found > fatal: unexpected EOF > > So I'm guessing that I have to convince the server owner to update their > version of git too? The easie

Re: git-pull-script hates me

2005-07-06 Thread Greg KH
On Wed, Jul 06, 2005 at 01:46:27PM -0700, Greg KH wrote: > Ok, below is a patch for this. It works, but then errors out with: > bash: git-upload-pack: command not found > fatal: unexpected EOF > > So I'm guessing that I have to convince the server owner to update their > version of gi

Re: git-pull-script hates me

2005-07-06 Thread Linus Torvalds
On Wed, 6 Jul 2005, Greg KH wrote: > > I just updated to the latest git tree, and now get the following when I > try to pull from a ssh repo: > > $ git-pull-script [EMAIL PROTECTED]:/public_html/udev.git/ > fatal: I don't like '@'. Sue me. > > So I drop the @ and then get: > $ git-pull-scrip

git-pull-script hates me

2005-07-06 Thread Greg KH
I just updated to the latest git tree, and now get the following when I try to pull from a ssh repo: $ git-pull-script [EMAIL PROTECTED]:/public_html/udev.git/ fatal: I don't like '@'. Sue me. So I drop the @ and then get: $ git-pull-script someserver.org:/public_html/udev.git/ fatal: I don't