modified fsck.c:fsck_commit(). Replaced memcmp() with starts_with() function.
starts_with() seems much more relevant than memcmp(). It uses one less argument
and its return value makes more sense.
skip_prefix() is not used as it uses strcmp() internally which seems
unnecessarily
for current task.
On Thu, Mar 20, 2014 at 3:39 PM, George Papanikolaou
g3orge@gmail.com wrote:
Removing the bloat of checking for both '\r' and '\n' with the prettier
iswspace() function which checks for other characters as well. (read: \f \t
\v)
Use imperative mood. Remove rather than Removing.
Bloat?
Thanks for the submission. Comments below to give you a feel for the
Git review process...
On Thu, Mar 20, 2014 at 9:54 PM, Ashwin Jha ajha@gmail.com wrote:
Subject: [PATCH] GSoC Miniproject 15. Rewrite fsck.c:fsck_commit()
The subject becomes part of the permanent Git history, but the fact
On 3/20/2014 1:18 PM, Eric Sunshine wrote:
On Thu, Mar 20, 2014 at 4:44 AM, Ilya Bobyr ilya.bo...@gmail.com wrote:
Built-in commands can specify names for option arguments when usage text
is generated for a command. sh based commands should be able to do the
same.
Option argument name hint is
Hello again,
Please it would be very helpful for me to get some comments on this
proposal I would be very grateful towards anyone who could take some
time to look at it, even if it's just the wording.
Regards,
Brian Bourn
On Thu, Mar 20, 2014 at 2:15 PM, Brian Bourn ba.bo...@gmail.com wrote:
On Fri, Mar 21, 2014 at 10:46:15AM +1100, Chris Angelico wrote:
oohh. Heh. I thought the porcelain sections of git were the
lower-level or machine-readable versions of other tools, and didn't
really think of mine as fitting into that.
The term sometimes gets used confusingly. The
On Thu, Mar 20, 2014 at 7:56 AM, Aleksey Mokhovikov moxobu...@gmail.com wrote:
On 03/19/2014 04:21 PM, Eric Sunshine wrote:
Thanks for the resubmission. Comments below...
On Tue, Mar 18, 2014 at 10:33 AM, Aleksey Mokhovikov
moxobu...@gmail.com wrote:
Subject: [PATCH][GSOC] Selection of the
On Fri, Mar 21, 2014 at 2:43 PM, Jeff King p...@peff.net wrote:
Thanks, the new text looks good to me. Please follow SubmittingPatches
(notably, you need to sign-off your work, and please send patches inline
rather than as attachments).
Ah, didn't see that file.
From
Thanks for the submission. Comments below to give you a feel for the
Git review process...
On Thu, Mar 20, 2014 at 1:48 AM, blacksimit cengoguzhanu...@gmail.com wrote:
Subject: Rewritten fsck.c:fsck_commit() through using starts_with() instead
of memcmp()
Use imperative mood (rewrite instead
On Thu, Mar 20, 2014 at 05:25:22PM +, Tanay Abhra wrote:
I have gone through commit.c, builtin/commit.c and api-config.txt but one
thing I cannot find is which functions handle writing config file to disk
after adding a new variable,value pair(for example git config my.option
true) . It
On Fri, Mar 21, 2014 at 08:51:18AM +0700, Duy Nguyen wrote:
On Thu, Mar 20, 2014 at 11:08 PM, Stefan Zager sza...@chromium.org wrote:
Duy, would you like to re-post your patch without the new pread
implementation?
I will but let me try out the sliding window idea first. My quick
tests on
On Thu, Mar 20, 2014 at 10:56:58PM -, Philip Oakley wrote:
This is by design. Git-log does not calculate or show merge diffs
unless
-c or --cc is specified, and thus no diff-filter can match.
This is hard to discern from the log(1) man page as this conflates
commit inclusion
On Thu, Mar 20, 2014 at 10:21 PM, Duy Nguyen pclo...@gmail.com wrote:
On Fri, Mar 21, 2014 at 08:51:18AM +0700, Duy Nguyen wrote:
On Thu, Mar 20, 2014 at 11:08 PM, Stefan Zager sza...@chromium.org wrote:
Duy, would you like to re-post your patch without the new pread
implementation?
I
On Thu, Mar 20, 2014 at 02:15:29PM -0400, Brian Bourn wrote:
Going through the annals of the listserve thus far I've found a few
discussions which provide some insight towards this process as well as
some experimental patches that never seem to have made it
through[1][2][3][4]
Reading the
101 - 114 of 114 matches
Mail list logo
