Re: [PATCH] Add documentation on how to integrate commands.

2012-11-25 Thread Eric S. Raymond
Michael Haggerty mhag...@alum.mit.edu: I think that here a reference to the file t/README would help (and perhaps make part of your text redundant). Thank you, done. -- a href=http://www.catb.org/~esr/;Eric S. Raymond/a -- To unsubscribe from this list: send the line

Re: Python extension commands in git - request for policy change

2012-11-25 Thread Felipe Contreras
On Sun, Nov 25, 2012 at 3:44 AM, Eric S. Raymond e...@thyrsus.com wrote: git presently contains one Python extension command, Pete Wycoff's p4 importer. If my git-weave code is merged it will acquire another. I think we can expect more submissions of Python extensions in the future, for two

Re: Python extension commands in git - request for policy change

2012-11-25 Thread Felipe Contreras
On Sun, Nov 25, 2012 at 6:18 AM, Eric S. Raymond e...@thyrsus.com wrote: Nguyen Thai Ngoc Duy pclo...@gmail.com: These may apply to other languages as well. Where do we draw a line? I'm in favor of the general policy of avoiding scripting languages other than the top three most widely

Re: Python extension commands in git - request for policy change

2012-11-25 Thread Johannes Sixt
Am 25.11.2012 03:44, schrieb Eric S. Raymond: That, among other things, means up-to-date versions of Python are ubiquitous unless we're looking at Windows - in which case Perl and shell actually become much bigger portability problems. You seem to ignore that more than a quater of users are on

Re: [PATCH] emacs: make 'git-status' work with separate git dirs

2012-11-25 Thread Alexandre Julliard
Junio C Hamano gits...@pobox.com writes: Enrico Scholz enrico.sch...@sigma-chemnitz.de writes: when trying 'M-x git-status' in a submodule created with recent (1.7.5+) git, the command fails with | ... is not a git working tree This is caused by creating submodules with

Re: git bash does not access drive f:

2012-11-25 Thread Sebastian Leske
On 2012-11-22, Angelo Borsotti angelo.borso...@gmail.com wrote: Hi I have attached an external disc, which appears on Windows as drive f: in Windows Explorer. Right-clicking on it displays a context menu showing (among other items) Git Init Here, Git Gui and Git Bash. The first two work

Re: [msysGit] Re: Python extension commands in git - request for policy change

2012-11-25 Thread Eric S. Raymond
Pat Thoyts pattho...@gmail.com: Git for Windows simply ships everything we need to run git - so if a desirable module requires a version of python, we will add that version plus any required modules into the installer. We already have a patch to provide python in the msysgit tree - it would

[PATCH 1/4] git-svn: Document branches with at-sign(@).

2012-11-25 Thread Sebastian Leske
git svn will sometimes create branches with an at-sign in the name (branchname@revision). These branches confuse many users and it is a FAQ why they are created. Document when git svn will create them. Signed-off-by: Sebastian Leske sebastian.le...@sleske.name --- I found various important

Re: Python extension commands in git - request for policy change

2012-11-25 Thread Michael Haggerty
On 11/25/2012 09:53 AM, Felipe Contreras wrote: On Sun, Nov 25, 2012 at 3:44 AM, Eric S. Raymond e...@thyrsus.com wrote: 1) In 2012, we can specify a floor Python version of 2.6 (shipped in 2008) and be pretty much guaranteed it will be anywhere we want to deploy except Windows. Windows will

Re: Python extension commands in git - request for policy change

2012-11-25 Thread Eric S. Raymond
Michael Haggerty mhag...@alum.mit.edu: There is, of course, the awkward issue of how/when to transition to Python 3.x, which is *not* backwards compatible with Python 2.x. I expect that when the time comes there will be volunteers (myself included) willing to help adapt Python scripts to the

[PATCH 0/8] Add function strbuf_addstr_xml_quoted() and more

2012-11-25 Thread Michael Haggerty
There were two functions doing almost the same XML quoting of character entities, so implement a library function strbuf_addstr_xml_quoted() and use that in both places. Along the way, do a lot of simplification within imap-send.c, which was doing a lot of its own string management instead of

[PATCH 2/8] xml_entities(): use function strbuf_addstr_xml_quoted()

2012-11-25 Thread Michael Haggerty
Signed-off-by: Michael Haggerty mhag...@alum.mit.edu --- http-push.c | 23 +-- 1 file changed, 1 insertion(+), 22 deletions(-) diff --git a/http-push.c b/http-push.c index 8701c12..9923441 100644 --- a/http-push.c +++ b/http-push.c @@ -172,28 +172,7 @@ enum dav_header_flag {

[PATCH 4/8] imap-send: store all_msgs as a strbuf

2012-11-25 Thread Michael Haggerty
all_msgs is only used as a glorified string, therefore there is no reason to declare it as a struct msg_data. Signed-off-by: Michael Haggerty mhag...@alum.mit.edu --- imap-send.c | 23 +-- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/imap-send.c

[PATCH 5/8] imap-send: correctly report errors reading from stdin

2012-11-25 Thread Michael Haggerty
Previously, read_message() didn't distinguish between an error and eof when reading its input. This could have resulted in incorrect behavior if there was an error: (1) reporting nothing to send if no bytes were read or (2) sending an incomplete message if some bytes were read before the error.

[PATCH 6/8] imap-send: change msg_data from storing (char *, len) to storing strbuf

2012-11-25 Thread Michael Haggerty
struct msg_data stored (char *, len) of the data to be included in a message, kept the character data NUL-terminated, etc., much like a strbuf would do. So change it to use a struct strbuf. This makes the code clearer and reduces copying a little bit. A side effect of this change is that the

[PATCH 7/8] wrap_in_html(): use strbuf_addstr_xml_quoted()

2012-11-25 Thread Michael Haggerty
Use the new function to quote characters as they are being added to buf, rather than quoting them in *p and then copying them into buf. This increases code sharing, and changes the algorithm from O(N^2) to O(N) in the number of characters in a line. Signed-off-by: Michael Haggerty

Re: Python extension commands in git - request for policy change

2012-11-25 Thread Nguyen Thai Ngoc Duy
On Sun, Nov 25, 2012 at 5:44 PM, Michael Haggerty mhag...@alum.mit.edu wrote: On the contrary, there is *constant* traffic on the mailing list about incompatibilities between different shell implementations (sh, dash, bash, etc), not to mention those in other utilities (sed, grep, etc) that

Re: Python extension commands in git - request for policy change

2012-11-25 Thread Felipe Contreras
On Sun, Nov 25, 2012 at 10:54 AM, Eric S. Raymond e...@thyrsus.com wrote: Felipe Contreras felipe.contre...@gmail.com: On Sun, Nov 25, 2012 at 6:18 AM, Eric S. Raymond e...@thyrsus.com wrote: Nguyen Thai Ngoc Duy pclo...@gmail.com: These may apply to other languages as well. Where do we draw

Re: Python extension commands in git - request for policy change

2012-11-25 Thread David Lang
On Sun, 25 Nov 2012, Eric S. Raymond wrote: Michael Haggerty mhag...@alum.mit.edu: There is, of course, the awkward issue of how/when to transition to Python 3.x, which is *not* backwards compatible with Python 2.x. I expect that when the time comes there will be volunteers (myself included)

Re: Python extension commands in git - request for policy change

2012-11-25 Thread Stefano Lattarini
Hi David. One minor but important correction ... On 11/25/2012 12:51 PM, David Lang wrote: You may think that C and Bash are poor choices, but that is what the community is familar with. Actually, it is C and POSIX shell -- not merely bash. Indeed, the shell code in Git is expected to work

[PATCH] Fix typo in remote set-head usage

2012-11-25 Thread Antoine Pelisse
parenthesis are not matching in `builtin_remote_sethead_usage` as a square bracket is closing something never opened. --- This will also break all translation files, should I also send a patch to update them ? Cheers, Antoine Pelisse builtin/remote.c |2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH] gitk tag delete/rename support

2012-11-25 Thread Leon KUKOVEC
Hi, On Sun, Nov 25, 2012 at 7:26 AM, Junio C Hamano gits...@pobox.com wrote: Thanks, but I prefer not to take patches to gitk-git/ directly; could you prepare a patch against Paul's tree at git://ozlabs.org/~paulus/gitk and send it in that direction (paulus@) instead? No problem.

Multiple threads of compression

2012-11-25 Thread Thorsten Glaser
Hi, I’m asking here informally first, because my information relates to a quite old version (the one from lenny-backports). A tl;dr is at the end. On a multi-core machine, the garbage collection of git, as well as pack compression on the server side when someone clones a repository remotely, the

Re: Python extension commands in git - request for policy change

2012-11-25 Thread Eric S. Raymond
Felipe Contreras felipe.contre...@gmail.com: Of course, but there are experts in C and shell around, not so many python experts. So if somebody sneaks in a python program that makes use of features specific to python 2.7, I doubt anybody would notice. I would. And if they did, I doubt that

Re: Python extension commands in git - request for policy change

2012-11-25 Thread Eric S. Raymond
David Lang da...@lang.hm: You may think that C and Bash are poor choices, but that is what the community is familar with. I don't think C is a poor choice. bash, on the other hand...so many dependencies on tool quirks! You are far from the first person to say that git should be re-written

Re: Python extension commands in git - request for policy change

2012-11-25 Thread Eric S. Raymond
Felipe Contreras felipe.contre...@gmail.com: Not according to ohloh: 1) shell 33% 2) tcl 9% 3) perl 9.7% 4) python 1.8% Look in the Makefile - all that tcl code is buried in gitk. We're very, very lucky the author did such a good job, because it's a potentially serious headache; who can

[PATCH] gitk tag delete/rename support

2012-11-25 Thread Leon KUKOVEC
Right clicking on a tag pops up a menu, which allows tag to be renamed or deleted. Signed-off-by: Leon KUKOVEC leon.kuko...@gmail.com --- gitk-git/gitk | 154 + 1 file changed, 154 insertions(+) diff --git a/gitk-git/gitk b/gitk-git/gitk

Re: Python extension commands in git - request for policy change

2012-11-25 Thread Felipe Contreras
On Sun, Nov 25, 2012 at 6:50 PM, Eric S. Raymond e...@thyrsus.com wrote: Felipe Contreras felipe.contre...@gmail.com: Not according to ohloh: 1) shell 33% 2) tcl 9% 3) perl 9.7% 4) python 1.8% Look in the Makefile - all that tcl code is buried in gitk. We're very, very lucky the author

Re: Python extension commands in git - request for policy change

2012-11-25 Thread Felipe Contreras
On Sun, Nov 25, 2012 at 6:36 PM, Eric S. Raymond e...@thyrsus.com wrote: Felipe Contreras felipe.contre...@gmail.com: Of course, but there are experts in C and shell around, not so many python experts. So if somebody sneaks in a python program that makes use of features specific to python 2.7,

[PATCH] Document the integration requirements for extension commands.

2012-11-25 Thread Eric S. Raymond
This contains no policy changes or proposals, it simply attempts to document the interfaces and conventions already in place. --- Documentation/technical/api-command.txt | 81 +++ 1 file changed, 81 insertions(+) create mode 100644

Re: Python extension commands in git - request for policy change

2012-11-25 Thread Krzysztof Mazur
On Sat, Nov 24, 2012 at 09:44:51PM -0500, Eric S. Raymond wrote: We're behind the best-practices curve here. The major Linux distributions, which have to deal with almost the same set of tradeoffs we do, went to Python for pretty much all glue and administration scripts outside /etc a

Re: Python extension commands in git - request for policy change

2012-11-25 Thread Felipe Contreras
On Sun, Nov 25, 2012 at 6:32 PM, Eric S. Raymond e...@thyrsus.com wrote: Felipe Contreras felipe.contre...@gmail.com: Seems sensible, but I don't know what rejection would actually mean. Why is this mysterious? We reject a patch when we don't choose to merge it. Why would you reject it? If,

Re: Python extension commands in git - request for policy change

2012-11-25 Thread Eric S. Raymond
Felipe Contreras felipe.contre...@gmail.com: And are you going to be around to spot them? It seems my patches for git-remote-hg slipped by your watch, because it seems they use stuff specific to python 2.7. The dev group hasn't decided (in whatever way it decides these things) to require 2.6

Re: Python extension commands in git - request for policy change

2012-11-25 Thread Eric S. Raymond
Krzysztof Mazur krzys...@podlesie.net: What about embedded systems? git is also useful there. C and shell is everywhere, python is not. Supposing this is true (and I question it with regard to shell) if you tell me how you live without gitk and the Perl pieces I'll play that right back at you

[PATCH 01/11] sequencer.c: remove broken support for rfc2822 continuation in footer

2012-11-25 Thread Brandon Casey
Commit c1e01b0c generalized the detection of the last paragraph signed-off-by footer and used rfc2822 as a guideline. Support for rfc2822 style continuation lines was also implemented, but not correctly, so it has never detected a line beginning with space or tab as a continuation of the previous

[PATCH 02/11] t/test-lib-functions.sh: allow to specify the tag name to test_commit

2012-11-25 Thread Brandon Casey
The message part of test_commit() may not be appropriate for a tag name. So let's allow test_commit to accept a fourth argument to specify the tag name. Signed-off-by: Brandon Casey bca...@nvidia.com --- t/test-lib-functions.sh | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff

[PATCH 03/11] t/t3511: add some tests of 'cherry-pick -s' functionality

2012-11-25 Thread Brandon Casey
Add some tests to ensure that 'cherry-pick -s' operates in the following manner: * Inserts a blank line before appending a s-o-b to a commit message that does not contain a s-o-b footer * Does not mistake first line subject: description as a s-o-b footer * Does not mistake single

[PATCH 04/11] sequencer.c: recognize (cherry picked from ... as part of s-o-b footer

2012-11-25 Thread Brandon Casey
When 'cherry-pick -s' is used to append a signed-off-by line to a cherry picked commit, it does not currently detect the (cherry picked from... that may have been appended by a previous 'cherry-pick -x' as part of the s-o-b footer and it will insert a blank line before appending a new s-o-b.

[PATCH 05/11] sequencer.c: always separate (cherry picked from from commit body

2012-11-25 Thread Brandon Casey
Start treating the (cherry picked from line added by cherry-pick -x the same way that the s-o-b lines are treated. Namely, separate them from the main commit message body with an empty line. Introduce tests to test this functionality. Signed-off-by: Brandon Casey bca...@nvidia.com ---

[PATCH 06/11] sequencer.c: teach append_signoff how to detect duplicate s-o-b

2012-11-25 Thread Brandon Casey
Teach append_signoff how to detect a duplicate s-o-b in the commit footer. This is in preparation to unify the append_signoff implementations in log-tree.c and sequencer.c. Fixes test in t3511. Signed-off-by: Brandon Casey bca...@nvidia.com --- builtin/commit.c | 2 +- sequencer.c

[PATCH 07/11] sequencer.c: teach append_signoff to avoid adding a duplicate newline

2012-11-25 Thread Brandon Casey
Teach append_signoff to detect whether a blank line exists at the position that the signed-off-by line will be added, and avoid adding an additional one if one already exists. This is necessary to allow format-patch to add a s-o-b to a patch with no commit message without adding an extra newline.

[PATCH 08/11] t4014: more tests about appending s-o-b lines

2012-11-25 Thread Brandon Casey
From: Nguyễn Thái Ngọc Duy pclo...@gmail.com [bc: fix test 90 signoff: some random signoff-alike and mark as failing. Correct behavior should insert a blank line after message body and signed-off-by ] Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com Signed-off-by: Brandon Casey

[PATCH 09/11] format-patch: stricter S-o-b detection

2012-11-25 Thread Brandon Casey
From: Nguyễn Thái Ngọc Duy pclo...@gmail.com S-o-b in the middle of a sentence, at the beginning of the sentence but it is just because of text wrapping, or a full paragraph of valid S-o-b in the middle of the message. All these are not S-o-b, but detected as is. Fix them. [bc: add two

[PATCH 10/11] format-patch: update append_signoff prototype

2012-11-25 Thread Brandon Casey
From: Nguyễn Thái Ngọc Duy pclo...@gmail.com This is a preparation step for merging with append_signoff from sequencer.c Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com Signed-off-by: Brandon Casey bca...@nvidia.com --- builtin/log.c | 13 + log-tree.c| 21

[PATCH 11/11] Unify appending signoff in format-patch, commit and sequencer

2012-11-25 Thread Brandon Casey
There are two implementations of append_signoff in log-tree.c and sequencer.c, which do more or less the same thing. Unify on top of the sequencer.c implementation. Add a test in t4014 to demonstrate support for non-s-o-b elements in the commit footer provided by sequence.c:append_sob. Mark

Re: [PATCH] fast-export: Allow pruned-references in mark file

2012-11-25 Thread Junio C Hamano
Antoine Pelisse apeli...@gmail.com writes: fast-export can fail because of some pruned-reference when importing a mark file. The problem happens in the following scenario: $ git fast-export --export-marks=MARKS master (rewrite master) $ git prune $ git fast-export

Re: [PATCH v3 0/7] New remote-bzr remote helper

2012-11-25 Thread Junio C Hamano
Felipe Contreras felipe.contre...@gmail.com writes: On Sun, Nov 11, 2012 at 3:19 PM, Felipe Contreras felipe.contre...@gmail.com wrote: This is a re-roll of the previous series to add support to fetch and push special modes, and refactor some related code. It seems this one got forgotten, I

Re: [PATCH] Add documentation on how to integrate commands.

2012-11-25 Thread Junio C Hamano
e...@thyrsus.com (Eric S. Raymond) writes: --- Sign off? Documentation/CommandIntegration | 69 ++ 1 file changed, 69 insertions(+) create mode 100644 Documentation/CommandIntegration diff --git a/Documentation/CommandIntegration

Re: Requirements for integrating a new git subcommand

2012-11-25 Thread Eric S. Raymond
Junio C Hamano gits...@pobox.com: Eric S. Raymond e...@thyrsus.com writes: While the weave operation can build a commit graph with any structure desired, an important restriction of the inverse (unraveling) operation is that it operates on *master branches only*. The unravel operation

Re: [PATCH 0/2] second try

2012-11-25 Thread Junio C Hamano
Sven Strickroth sven.strickr...@tu-clausthal.de writes: Am 11.11.2012 17:40 schrieb Sven Strickroth: Am 06.10.2012 20:28 schrieb Junio C Hamano: It is either that it was simply forgotten, or after I wrote the part you quoted early in January there were discussions later that showed the patch

Can I zip a git repo without losing anything?

2012-11-25 Thread Carl Smith
Hi all This is my first post to this list, so thank you for all your work. After suggesting using zip files to move our projects around, I was told that you can not zip a git repo without loosing all the history. This didn't make sense to me, but two people told me the same thing, so I wasn't

Re: Python extension commands in git - request for policy change

2012-11-25 Thread Sitaram Chamarty
On Mon, Nov 26, 2012 at 4:17 AM, Eric S. Raymond e...@thyrsus.com wrote: Krzysztof Mazur krzys...@podlesie.net: What about embedded systems? git is also useful there. C and shell is everywhere, python is not. Supposing this is true (and I question it with regard to shell) if you tell me how

links of london friendship bracelet try and proper some United kingdom eccentricity

2012-11-25 Thread salisa41
Necklaces has become utilized by means of human beings intended for many years, in addition to recommended different things to help families in addition to countries. In the course of heritage humankind include desired objects having which often to help accentuate independently, from time to time

[RFC] pack-objects: compression level for non-blobs

2012-11-25 Thread David Michael Barr
Add config pack.graphcompression similar to pack.compression. Applies to non-blob objects and if unspecified falls back to pack.compression. We may identify objects compressed with level 0 by their leading bytes. Use this to force recompression when the source and target levels mismatch. Limit

bijoux swarovski could be the selection of every person

2012-11-25 Thread zakeol6
There are various types of crystalfigurines as well as each individual gathers all of them with regard to their own factors. They may be big collectible figurines which are the discussion item on their own, as well as little sensitive types which are available in models. If you're considering

Re: [PATCH 00/11] alternative unify appending of sob

2012-11-25 Thread Nguyen Thai Ngoc Duy
On Mon, Nov 26, 2012 at 8:45 AM, Brandon Casey draf...@gmail.com wrote: From: Brandon Casey bca...@nvidia.com I hate to have the battle of the patches, but I kinda prefer the append_signoff code in sequencer.c over the code in log-tree.c as a foundation to build on. So, this series is