Hi Ben,
On Tue, 1 May 2018, Ben Peart wrote:
> Take advantage of the recent addition of support for lazy loading functions[1]
> on Windows to simplify the loading of NtSetSystemInformation.
>
> [1] db2f7c48cb (Win32: simplify loading of DLL functions, 2017-09-25)
>
> Signed-off-by: Ben Peart
>
Hi Junio,
On Wed, 2 May 2018, Junio C Hamano wrote:
> Johannes Schindelin writes:
>
> > So the problem you found is not a problem with *my* branch, of course, as
> > I did not fork off of ...
>
> Correct; there is no blame on you with the choice of the base. It
> was my mistake that I didn't
On 2 May 2018 at 06:50, Junio C Hamano wrote:
> Martin Ågren writes:
>
>> The diagram renders fine in AsciiDoc before and after this patch.
>> Asciidoctor, on the other hand, ignores the tabs entirely, which results
>> in different indentation for different lines. The graph illustration
>> earlie
Casey Fitzpatrick writes:
> 'recommend_shallow' and 'jobs' variables do not need quotes (they never
> contain
> spaces) and do not require any additional prefix, therefore remove the
> unnecessary subsitition.
The resulting patch is good, but "they never contain spaces" is not
a very good ratio
Samuel Lijin writes:
> Mark the commitable flag in the wt_status object in the call to
> `wt_status_collect()`, instead of in `wt_longstatus_print_updated()`,
> and simplify the logic in the latter function to take advantage of the
> logic shifted to the former. This means that callers do not nee
Daniel Villeneuve wrote:
> subscribe
That line should be "subscribe git" and it needs to be
sent to majord...@vger.kernel.org , not this list.
Martin Ågren writes:
> The diagram renders fine in AsciiDoc before and after this patch.
> Asciidoctor, on the other hand, ignores the tabs entirely, which results
> in different indentation for different lines. The graph illustration
> earlier in the document already uses spaces instead of a tab
Casey Fitzpatrick writes:
> These patches add --progress and --dissociate options to git submodule.
>
> The --progress option existed beforehand, but only for the update command and
> it was left undocumented.
>
> Both add and update submodule commands supported --reference, but not its pair
> op
Stefan Beller writes:
>> As far as I am aware this can be worked around with 'git repack -a'
>> and manual removal of the objects/info/alternates file afterward.
>> Though I don't know if this results in a less speedy clone than
>> dissociate would.
>
> That is an interesting workaround!
It's no
Ævar Arnfjörð Bjarmason writes:
> On Mon, Apr 30, 2018 at 1:30 PM, Casey Fitzpatrick wrote:
>> It also seems to be missing "--progress", and I imagine others.
>> Perhaps submodule add/update should be reworked to automatically
>> accept all the options that clone would?
>
> --progress is not mis
Johannes Schindelin writes:
> So the problem you found is not a problem with *my* branch, of course, as
> I did not fork off of ...
Correct; there is no blame on you with the choice of the base. It
was my mistake that I didn't check if the series could be queueable
on the maintenance track that
Duy Nguyen writes:
> On Mon, Apr 30, 2018 at 12:17 AM, Johannes Schindelin
> wrote:
>> t1406 specifically verifies that certain code paths fail with a BUG: ...
>> message.
>>
>> In the upcoming commit, we will convert that message to be generated via
>> BUG() instead of die("BUG: ..."), which im
Hello mentors,
As promised in my proposal, I've started
to write a blog series of GSoC '18 with Git. The initial blog is up.
You can find it here[1]. The initial one is just to get started and
from next iterations, I'll start detailing of my work towards converting
rebase to builtin.
[1]: https:/
Isabella Stephens writes:
> This is the existing behaviour. -L10,-20 for example will blame the
> first 10 lines of a file, it will not fail. My patch doesn't change
> this. The case I am discussing is -L,-20 which at the moment blames
> the first line of the file. Trying to go backwards from the
subscribe
When formatting a series of patches using --attach and --cover-letter,
the cover letter lacks the closing MIME boundary, violating RFC 2046.
Certain clients, such as Thunderbird, discard the message body in such a
case.
Since the cover letter is just one part and sending it as
multipart/mixed is n
Eric Sunshine writes:
> Although paged output is generally nice, I frequently find myself
> typing --no-pager numerous times during the day, so I, for one,
> welcome having a short option (and would be sad to see this patch
> retracted). As with Hannes, I too find -P a reasonably intuitive and
>
SZEDER Gábor writes:
> On Mon, Apr 30, 2018 at 5:25 AM, Junio C Hamano wrote:
>> * js/rebase-i-clean-msg-after-fixup-continue (2018-04-30) 4 commits
>> - rebase --skip: clean up commit message after a failed fixup/squash
>> - sequencer: always commit without editing when asked for
>> - reb
'recommend_shallow' and 'jobs' variables do not need quotes (they never contain
spaces) and do not require any additional prefix, therefore remove the
unnecessary subsitition.
'progress' is a boolean value. Treat it like the other boolean values in the
script by using a substitution.
Signed-off-b
Add --dissociate option to add and update commands, both clone helper commands
that already have the --reference option --dissociate pairs with.
Signed-off-by: Casey Fitzpatrick
---
Documentation/git-submodule.txt | 10 +-
builtin/submodule--helper.c | 16 +---
git-submod
The '--progress' was introduced in 72c5f88311d (clone: pass --progress
decision to recursive submodules, 2016-09-22) to fix the progress reporting
of the clone command. Also add the progress option to the 'submodule add'
command. The update command already supports the progress flag, but it
is not
These patches add --progress and --dissociate options to git submodule.
The --progress option existed beforehand, but only for the update command and
it was left undocumented.
Both add and update submodule commands supported --reference, but not its pair
option --dissociate which allows for indep
Just noticed I missed the other 'test_must_fail'. Resubmitting in a few moments.
On Tue, May 1, 2018 at 8:27 PM, Casey Fitzpatrick wrote:
> Add --dissociate option to add and update commands, both clone helper commands
> that already have the --reference option --dissociate pairs with.
>
> Signed
The fetch-pack/upload-pack protocol v2 was developed independently of
the filter parameter (used in partial fetches), thus it did not include
support for it. Add support for the filter parameter.
Like in the legacy protocol, the server advertises and supports "filter"
only if uploadpack.allowfilte
> This is a bit difficult to read and there is no reason why we would need
> to read the entire upload_pack_config to determine if we need to filter
> things (we will need to read the config if cmd "fetch" is requested
> though). Instead it may be better to do the following:
>
> if (value) {
>
The upload-pack code paths never call git_config() with
upload_pack_config() when protocol v2 is used, causing options like
uploadpack.packobjectshook to not take effect. Ensure that this function
is called.
Signed-off-by: Jonathan Tan
---
t/t5702-protocol-v2.sh | 14 ++
upload-pack.
Fix a typo in an error message.
Also, this line was introduced in 3145ea957d2c ("upload-pack: introduce
fetch server command", 2018-03-15), which did not contain a test for the
case which causes this error to be printed, so introduce a test.
Signed-off-by: Jonathan Tan
---
t/t5701-git-serve.sh
The '--progress' was introduced in 72c5f88311d (clone: pass --progress
decision to recursive submodules, 2016-09-22) to fix the progress reporting
of the clone command. Also add the progress option to the 'submodule add'
command. The update command already supports the progress flag, but it
is not
'recommend_shallow' and 'jobs' variables do not need quotes (they never contain
spaces) and do not require any additional prefix, therefore remove the
unnecessary subsitition.
'progress' is a boolean value. Treat it like the other boolean values in the
script by using a substitution.
---
git-subm
These patches add --progress and --dissociate options to git submodule.
The --progress option existed beforehand, but only for the update command and
it was left undocumented.
Both add and update submodule commands supported --reference, but not its pair
option --dissociate which allows for indep
Add --dissociate option to add and update commands, both clone helper commands
that already have the --reference option --dissociate pairs with.
Signed-off-by: Casey Fitzpatrick
---
Documentation/git-submodule.txt | 10 +-
builtin/submodule--helper.c | 16 +---
git-submod
Adjust struct index_state to use struct object_id instead of unsigned
char [20].
Signed-off-by: brian m. carlson
---
cache.h | 2 +-
read-cache.c | 16
t/helper/test-dump-split-index.c | 2 +-
unpack-trees.c | 2 +
The sha1 member in struct pack_entry is unused except for one instance
in which we store a value in it. Since nobody ever reads this value,
don't bother to compute it and remove the member from struct pack_entry.
Signed-off-by: brian m. carlson
---
cache.h| 1 -
packfile.c | 1 -
2 files ch
There are several instances of the constant 20 and 20-based values in
the packfile code. Abstract away dependence on SHA-1 by using the
values from the_hash_algo instead.
Use unsigned values for temporary constants to provide the compiler with
more information about what kinds of values it should
Convert the exclude_sha1 member of struct untracked_cache_dir and rename
it to exclude_oid. Eliminate several hard-coded integral constants, and
update a function name that referred to SHA-1.
Signed-off-by: brian m. carlson
---
dir.c| 23 ---
Signed-off-by: brian m. carlson
---
commit.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/commit.c b/commit.c
index ca474a7c11..9617f85caa 100644
--- a/commit.c
+++ b/commit.c
@@ -331,7 +331,7 @@ int parse_commit_buffer(struct commit *item, const void
*buffer, unsigned
The tree member of struct object_context is unused except in one place
where we write to it. Since there are no users of this member, remove
it.
Signed-off-by: brian m. carlson
---
cache.h | 1 -
sha1-name.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/cache.h b/cache.h
index af6693
Instead of using hard-coded 40 constants, refer to the_hash_algo for the
current hash size.
Signed-off-by: brian m. carlson
---
diff.c | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/diff.c b/diff.c
index 314c57e3c0..b1666b9b2d 100644
--- a/diff.c
+++ b/di
Use the_hash_algo to find the right size for parsing pack names.
Signed-off-by: brian m. carlson
---
http.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/http.c b/http.c
index 3034d10b68..312a5e1833 100644
--- a/http.c
+++ b/http.c
@@ -2047,7 +2047,8 @@ int ht
Update several uses of hard-coded 40-based constants to use either
the_hash_algo or GIT_MAX_HEXSZ, as appropriate. Replace a combined use
of oid_to_hex and memcpy with oid_to_hex_r, which not only avoids the
need for a constant, but is more efficient. Make use of parse_oid_hex
to eliminate the ne
To avoid dependency on a particular hash algorithm, convert a use of
EMPTY_TREE_SHA1_HEX to use the_hash_algo->empty_tree instead. Since
both branches now use oid_to_hex, condense the if statement into a
ternary.
Signed-off-by: brian m. carlson
---
merge.c | 5 +
1 file changed, 1 insertion
Convert one use of EMPTY_TREE_SHA1_HEX to use empty_tree_oid_hex to
avoid a dependency on a given hash algorithm.
Signed-off-by: brian m. carlson
---
sequencer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sequencer.c b/sequencer.c
index 5e3a50fafc..75ed9676fe 100644
---
Several of our shell scripts hard-code the object ID of the empty tree.
To avoid any problems when changing hashes, compute this value on
startup of the script. For performance, store the value in a variable
and reuse it throughout the life of the script.
Signed-off-by: brian m. carlson
---
git
The read_empty and reset_hard functions are static and their callers
have already changed to use struct object_id, so convert them as well.
To avoid dependency on the hash algorithm in use, switch from using
EMPTY_TREE_SHA1_HEX to using empty_tree_oid_hex.
Signed-off-by: brian m. carlson
---
bui
The interactive add script hard-codes the object ID of the empty tree.
To avoid any problems when changing hashes, compute this value when used
and cache it for any future uses.
Signed-off-by: brian m. carlson
---
git-add--interactive.perl | 11 +--
1 file changed, 9 insertions(+), 2 del
To ensure that we are hash algorithm agnostic, use the_hash_algo to look
up the object ID for the empty blob instead of using the empty_tree_oid
variable.
Signed-off-by: brian m. carlson
---
dir.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dir.c b/dir.c
index 06f4c4a8bf.
Replace two uses of the hard-coded constant 40 with references to
the_hash_algo.
Signed-off-by: brian m. carlson
---
revision.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/revision.c b/revision.c
index ce0e7b71f2..daf7fe6ff4 100644
--- a/revision.c
+++ b/revision.c
@
Use the GIT_SHA1_RAWSZ and GIT_SHA1_HEXSZ macros instead of hard-coding
the constants 20 and 40. Switch one use of 20 with a format specifier
for a hex value to use the hex constant instead, as the original appears
to have been a typo.
At this point, avoid converting the hard-coded use of SHA-1 t
Oftentimes, we'll want to refer to an empty tree or empty blob by its
hex name without having to call oid_to_hex or explicitly refer to
the_hash_algo. Add helper functions that format these values into
static buffers and return them for easy use.
Signed-off-by: brian m. carlson
---
cache.h
Convert the last use of EMPTY_TREE_SHA1_BIN to use a direct copy from
the_hash_algo->empty_tree to avoid a dependency on a given hash
algorithm.
Signed-off-by: brian m. carlson
---
builtin/reset.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/reset.c b/builtin/reset
Convert several uses of EMPTY_TREE_SHA1_HEX to use empty_tree_oid_hex to
avoid a dependency on a given hash algorithm.
Signed-off-by: brian m. carlson
---
submodule.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/submodule.c b/submodule.c
index 9a50168b23..ee7eea4877
Convert two uses of EMPTY_TREE_SHA1_HEX to use empty_tree_oid_hex to
avoid a dependency on a given hash algorithm.
Signed-off-by: brian m. carlson
---
wt-status.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/wt-status.c b/wt-status.c
index 50815e5faf..e44115b3be 100644
There really isn't any case in which we want to expose the constants for
empty trees and blobs outside of using the hash algorithm abstraction.
Make these constants static and stop exposing the defines in cache.h.
Remove the constants which are no longer in use.
Signed-off-by: brian m. carlson
--
To ensure that we are hash algorithm agnostic, use the_hash_algo to look
up the object ID for the empty tree instead of using the empty_tree_oid
variable.
Signed-off-by: brian m. carlson
---
sequencer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sequencer.c b/sequencer.c
When comparing an object ID against that of the empty tree, use the
is_empty_tree_oid function to ensure that we abstract over the hash
algorithm properly. In addition, this is more readable than a plain
oidcmp.
Signed-off-by: brian m. carlson
---
cache-tree.c | 2 +-
1 file changed, 1 insertio
Convert the code that looks up cached objects to use struct object_id.
Adjust the lookup for empty trees to use the_hash_algo. Note that we
don't need to be concerned about the hard-coded object ID in the
empty_tree object since we never use it.
Signed-off-by: brian m. carlson
---
sha1-file.c |
Convert one use of EMPTY_TREE_SHA1_HEX to use empty_tree_oid_hex to
avoid a dependency on a given hash algorithm.
Signed-off-by: brian m. carlson
---
builtin/receive-pack.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/receive-pack.c b/builtin/receive-pack.c
index 6
This script hard-codes the object ID of the empty blob. To avoid any
problems when changing hashes, compute this value by calling git
hash-object.
Signed-off-by: brian m. carlson
---
git-merge-one-file.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/git-merge-one-file.sh
This is the thirteenth series of patches to convert to struct object_id
and the_hash_algo.
The series adds an oidread function to read object IDs from a buffer,
removes unused structure members (which therefore don't require
conversion), converts various functions to struct object_id, and
improves
Since the only caller of this function already uses struct object_id,
update get_tree_entry_follow_symlinks to use it in parameters and
internally.
Signed-off-by: brian m. carlson
---
sha1-name.c | 4 ++--
tree-walk.c | 16
tree-walk.h | 2 +-
3 files changed, 11 insertions(+)
Convert the base_sha1 member of struct split_index to use struct
object_id and rename it base_oid. Include cache.h to make the structure
visible.
Signed-off-by: brian m. carlson
---
builtin/rev-parse.c | 4 ++--
read-cache.c | 22 +++---
split-i
Convert two static functions to use struct object_id and parse_oid_hex,
instead of relying on harcoded 20 and 40-based constants.
Signed-off-by: brian m. carlson
---
fsck.c | 20 +++-
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git a/fsck.c b/fsck.c
index 9218c2a643.
Convert the various functions for freshening objects and
has_loose_object_nonlocal to use struct object_id.
Signed-off-by: brian m. carlson
---
builtin/pack-objects.c | 2 +-
cache.h| 2 +-
sha1-file.c| 36 ++--
3 files changed, 20 in
Convert several uses of EMPTY_TREE_SHA1_BIN to use the_hash_algo
and struct object_id instead.
Signed-off-by: brian m. carlson
---
builtin/am.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/builtin/am.c b/builtin/am.c
index d834f9e62b..206af06a18 100644
--- a/builti
Instead of using hard-coded instances of the constant 20, use
the_hash_algo to look up the correct constant.
Signed-off-by: brian m. carlson
---
builtin/pack-objects.c | 30 --
1 file changed, 16 insertions(+), 14 deletions(-)
diff --git a/builtin/pack-objects.c b/bu
Convert find_pack_entry and the static function fill_pack_entry to take
pointers to struct object_id.
Signed-off-by: brian m. carlson
---
packfile.c | 12 ++--
packfile.h | 2 +-
sha1-file.c | 6 +++---
3 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/packfile.c b/pac
The head member of struct pack_info is completely unused and the
nr_heads member is used only in one place, which is an assignment. This
member was last usefully used in 3e15c67c90 (server-info: throw away T
computation as well, 2005-12-04).
Since this structure member is not useful, remove it.
Convert struct llist_item and the rest of the linked list code to use
struct object_id. Add a use of GIT_MAX_HEXSZ to avoid a dependency on a
hard-coded constant.
Signed-off-by: brian m. carlson
---
builtin/pack-redundant.c | 50 +---
1 file changed, 26 inser
Instead of using hard-coded instances of the constant 20, use
the_hash_algo to look up the correct constant.
Signed-off-by: brian m. carlson
---
builtin/pack-redundant.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/builtin/pack-redundant.c b/builtin/pack-redun
Convert struct submodule and struct parse_config_parameter to use struct
object_id. Adjust the functions which take members of these structures
as arguments to also use struct object_id. Include cache.h into
submodule-config.h to make struct object_id visible.
Signed-off-by: brian m. carlson
--
The code for reading certain pack v2 offsets had a hard-coded 5
representing the number of uint32_t words that we needed to skip over.
Specify this value in terms of a value from the_hash_algo.
Signed-off-by: brian m. carlson
---
builtin/index-pack.c | 3 ++-
1 file changed, 2 insertions(+), 1 d
Convert this function to take a pointer to struct object_id and rename
it has_object_pack for consistency with has_object_file.
Signed-off-by: brian m. carlson
---
builtin/count-objects.c | 2 +-
builtin/fsck.c | 2 +-
builtin/prune-packed.c | 2 +-
diff.c | 2 +-
pack
Use the_hash_algo to look up the length of our current hash instead of
hard-coding the value 20.
Signed-off-by: brian m. carlson
---
tree-walk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tree-walk.c b/tree-walk.c
index e11b3063af..27797c5406 100644
--- a/tree-walk.c
+++
In various places throughout the codebase, we need to read data into a
struct object_id from a pack or other unsigned char buffer. Add an
inline function that does this based on the current hash algorithm in
use, and use it in several places.
Signed-off-by: brian m. carlson
---
cache-tree.c |
On Mon, Apr 30, 2018 at 09:53:33PM -0400, Eric Sunshine wrote:
> On Mon, Apr 30, 2018 at 8:02 PM, brian m. carlson
> wrote:
> > When formatting a series of patches using --attach and --cover-letter,
> > the cover letter lacks the closing MIME boundary, violating RFC 2046.
> > Certain clients, such
On Tue, May 01, 2018 at 12:22:43PM +0200, Duy Nguyen wrote:
> On Mon, Apr 23, 2018 at 11:39:18PM +, brian m. carlson wrote:
> > There are several instances of the constant 20 and 20-based values in
> > the packfile code. Abstract away dependence on SHA-1 by using the
> > values from the_hash_a
On Tue, May 1, 2018 at 4:24 PM, Junio C Hamano wrote:
> Jacob Keller writes:
>
>> I also agree, I'd prefer if we aim for the mapping to be something
>> which works for all refs in the future, even if such support isn't
>> added now, which is why i've proposed using "refs/remote//" so
>> that a ta
On Tue, May 1, 2018 at 4:11 PM, Junio C Hamano wrote:
> Elijah Newren writes:
>
>> I'm not certain what the default should be, but I do believe that it
>> should be consistent between these commands. I lean towards
>> considering break detection being on by default a good thing, but
>> there are
On Tue, May 01, 2018 at 11:36:03AM +0200, Duy Nguyen wrote:
> On Mon, Apr 23, 2018 at 11:39:11PM +, brian m. carlson wrote:
> > diff --git a/cache.h b/cache.h
> > index bbaf5c349a..4bca177cf3 100644
> > --- a/cache.h
> > +++ b/cache.h
> > @@ -1008,6 +1008,11 @@ static inline void oidclr(struct
Ævar Arnfjörð Bjarmason writes:
> As a workaround for that maybe we'll need something like:
>
> [remote "gbenchmark"]
> url = g...@github.com:google/benchmark
> fetch = +refs/heads/*:refs/remotes/gbenchmark/*
> fetch = +refs/tags/*:refs/remote-tags/gbenchmark/*
> tagStyle = re
Jacob Keller writes:
> I also agree, I'd prefer if we aim for the mapping to be something
> which works for all refs in the future, even if such support isn't
> added now, which is why i've proposed using "refs/remote//" so
> that a tag would go from
>
> refs/tags/v1.7
>
> to
>
> refs/remote//tag
Elijah Newren writes:
> I'm not certain what the default should be, but I do believe that it
> should be consistent between these commands. I lean towards
> considering break detection being on by default a good thing, but
> there are some interesting issues to address:
> - there is no knob to
On 05/01, Jonathan Tan wrote:
> The fetch-pack/upload-pack protocol v2 was developed independently of
> the filter parameter (used in partial fetches), thus it did not include
> support for it. Add support for the filter parameter.
>
> Like in the legacy protocol, the server advertises and support
On Tue, 1 May 2018 15:22:20 -0700
Jonathan Tan wrote:
> +test_expect_success 'unexpected lines are not allowed in fetch request' '
> + git init server &&
> +
> + # Custom request that tries to filter even though it is not advertised.
Oops...I saw this copy-and-paste error right after I
The fetch-pack/upload-pack protocol v2 was developed independently of
the filter parameter (used in partial fetches), thus it did not include
support for it. Add support for the filter parameter.
Like in the legacy protocol, the server advertises and supports "filter"
only if uploadpack.allowfilte
This patch set is built on "next". (I had to build it on "next" because
bw/protocol-v2 is built on v2.16, which does not have support for
partial clones.)
Partial clones and protocol v2 were built independently, so here is a
patch to support partial clones in protocol v2.
One thing I am a little
Fix a typo in an error message.
Also, this line was introduced in 3145ea957d2c ("upload-pack: introduce
fetch server command", 2018-03-15), which did not contain a test for the
case which causes this error to be printed, so introduce a test.
Signed-off-by: Jonathan Tan
---
t/t5701-git-serve.sh
On Tue, May 1, 2018 at 5:33 PM, Stefan Beller wrote:
> Add a repository argument to allow the callers of create_object
> to be more specific about which repository to act on. This is a small
> mechanical change; it doesn't change the implementation to handle
> repositories other than the_repositor
Signed-off-by: Stefan Beller
---
alloc.c | 2 +-
cache.h | 3 ++-
object.c | 2 +-
3 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/alloc.c b/alloc.c
index 290250e3595..f031ce422d9 100644
--- a/alloc.c
+++ b/alloc.c
@@ -73,7 +73,7 @@ void *alloc_tag_node_the_repository(void)
}
Signed-off-by: Stefan Beller
---
alloc.c | 2 +-
blame.c | 2 +-
cache.h | 3 ++-
commit.c | 2 +-
merge-recursive.c | 2 +-
5 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/alloc.c b/alloc.c
index 2c8d1430758..9e2b897ec1d 100644
--- a/alloc.c
Signed-off-by: Stefan Beller
---
alloc.c | 2 +-
blob.c | 2 +-
cache.h | 3 ++-
3 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/alloc.c b/alloc.c
index 12afadfacdd..6c5c376a25a 100644
--- a/alloc.c
+++ b/alloc.c
@@ -49,7 +49,7 @@ static inline void *alloc_node(struct alloc_state
From: Jonathan Nieder
Add a repository argument to allow the caller of grow_object_hash to
be more specific about which repository to handle. This is a small
mechanical change; it doesn't change the implementation to handle
repositories other than the_repository yet.
As with the previous commits
Signed-off-by: Jonathan Nieder
Signed-off-by: Stefan Beller
---
object.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/object.c b/object.c
index ddf4b7b196e..43954fadf93 100644
--- a/object.c
+++ b/object.c
@@ -116,27 +116,27 @@ struct object *lookup_object
Signed-off-by: Stefan Beller
---
alloc.c | 2 +-
cache.h | 3 ++-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/alloc.c b/alloc.c
index f031ce422d9..28b85b22144 100644
--- a/alloc.c
+++ b/alloc.c
@@ -105,7 +105,7 @@ static void report(const char *name, unsigned int count,
size_t
Signed-off-by: Stefan Beller
---
alloc.c | 4 ++--
cache.h | 3 ++-
object.c | 2 +-
3 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/alloc.c b/alloc.c
index 28b85b22144..277dadd221b 100644
--- a/alloc.c
+++ b/alloc.c
@@ -82,7 +82,7 @@ void *alloc_object_node_the_repository(void)
We have to convert all of the alloc functions at once, because alloc_report
uses a funky macro for reporting. It is better for the sake of mechanical
conversion to convert multiple functions at once rather than changing the
structure of the reporting function.
We record all memory allocation in al
Signed-off-by: Jonathan Nieder
Signed-off-by: Stefan Beller
---
object.c | 12 ++--
object.h | 3 +--
2 files changed, 7 insertions(+), 8 deletions(-)
diff --git a/object.c b/object.c
index 43954fadf93..fd27cf54faa 100644
--- a/object.c
+++ b/object.c
@@ -139,7 +139,7 @@ static void gr
Signed-off-by: Stefan Beller
---
alloc.c | 2 +-
cache.h | 3 ++-
tree.c | 2 +-
3 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/alloc.c b/alloc.c
index 6c5c376a25a..2c8d1430758 100644
--- a/alloc.c
+++ b/alloc.c
@@ -57,7 +57,7 @@ void *alloc_blob_node_the_repository(void)
}
s
Add a repository argument to allow the callers of create_object
to be more specific about which repository to act on. This is a small
mechanical change; it doesn't change the implementation to handle
repositories other than the_repository yet.
As with the previous commits, use a macro to catch cal
Signed-off-by: Stefan Beller
---
alloc.c | 2 +-
cache.h | 3 ++-
tag.c | 2 +-
3 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/alloc.c b/alloc.c
index 9e2b897ec1d..290250e3595 100644
--- a/alloc.c
+++ b/alloc.c
@@ -65,7 +65,7 @@ void *alloc_tree_node_the_repository(void)
}
s
1 - 100 of 210 matches
Mail list logo
