[PATCH 14/14] p5302-pack-index.sh: use the $( ... ) construct for command substitution

2014-04-23 Thread Elia Pinto
, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Eli

[PATCH 13/14] lib-gpg.sh: use the $( ... ) construct for command substitution

2014-04-23 Thread Elia Pinto
, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: El

[PATCH 06/14] git-pull.sh: use the $( ... ) construct for command substitution

2014-04-23 Thread Elia Pinto
, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by:

[PATCH 09/14] git-stash.sh: use the $( ... ) construct for command substitution

2014-04-23 Thread Elia Pinto
, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by:

[PATCH 08/14] git-rebase.sh: use the $( ... ) construct for command substitution

2014-04-23 Thread Elia Pinto
, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by:

[PATCH 11/14] lib-credential.sh: use the $( ... ) construct for command substitution

2014-04-23 Thread Elia Pinto
, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: El

[PATCH 12/14] lib-cvs.sh: use the $( ... ) construct for command substitution

2014-04-23 Thread Elia Pinto
, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: El

[PATCH 07/14] git-rebase--merge.sh: use the $( ... ) construct for command substitution

2014-04-23 Thread Elia Pinto
, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia Pi

[PATCH 02/14] test-gitmw-lib.sh: use the $( ... ) construct for command substitution

2014-04-23 Thread Elia Pinto
, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia Pi

[PATCH 03/14] t7900-subtree.sh: use the $( ... ) construct for command substitution

2014-04-23 Thread Elia Pinto
, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia

[PATCH 04/14] appp.sh: use the $( ... ) construct for command substitution

2014-04-23 Thread Elia Pinto
, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia

[PATCH 01/14] t0001-init.sh: use the $( ... ) construct for command substitution

2014-04-28 Thread Elia Pinto
, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia

[PATCH 10/14] t1002-read-tree-m-u-2way.sh: use the $( ... ) construct for command substitution

2014-04-28 Thread Elia Pinto
, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia

[PATCH 02/14] t0010-racy-git.sh: use the $( ... ) construct for command substitution

2014-04-28 Thread Elia Pinto
, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia

[PATCH 03/14] t0020-crlf.sh: use the $( ... ) construct for command substitution

2014-04-28 Thread Elia Pinto
, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia

[PATCH 14/14] t1050-large.sh: use the $( ... ) construct for command substitution

2014-04-28 Thread Elia Pinto
, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia

[PATCH 13/14] t1020-subdirectory.sh: use the $( ... ) construct for command substitution

2014-04-28 Thread Elia Pinto
, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia

[PATCH 11/14] t1003-read-tree-prefix.sh: use the $( ... ) construct for command substitution

2014-04-28 Thread Elia Pinto
, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia

[PATCH 04/14] t0025-crlf-auto.sh: use the $( ... ) construct for command substitution

2014-04-28 Thread Elia Pinto
, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia

[PATCH 09/14] t1001-read-tree-m-2way.sh: use the $( ... ) construct for command substitution

2014-04-28 Thread Elia Pinto
, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia

[PATCH 08/14] t1000-read-tree-m-3way.sh: use the $( ... ) construct for command substitution

2014-04-28 Thread Elia Pinto
, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia

[PATCH 05/14] t0026-eol-config.sh: use the $( ... ) construct for command substitution

2014-04-28 Thread Elia Pinto
, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia

[PATCH 12/14] t1004-read-tree-m-u-wf.sh: use the $( ... ) construct for command substitution

2014-04-28 Thread Elia Pinto
, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia

[PATCH 07/14] t0300-credentials.sh: use the $( ... ) construct for command substitution

2014-04-28 Thread Elia Pinto
, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia

[PATCH 06/14] t0030-stripspace.sh: use the $( ... ) construct for command substitution

2014-04-28 Thread Elia Pinto
, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia

[PATCH 14/14] t5000-tar-tree.sh: use the $( ... ) construct for command substitution

2014-04-30 Thread Elia Pinto
, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia

[PATCH 04/14] t4010-diff-pathspec.sh: use the $( ... ) construct for command substitution

2014-04-30 Thread Elia Pinto
, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia

[PATCH 07/14] t4014-format-patch.sh: use the $( ... ) construct for command substitution

2014-04-30 Thread Elia Pinto
, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia

[PATCH 12/14] t4119-apply-config.sh: use the $( ... ) construct for command substitution

2014-04-30 Thread Elia Pinto
, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia

[PATCH 11/14] t4116-apply-reverse.sh: use the $( ... ) construct for command substitution

2014-04-30 Thread Elia Pinto
, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia

[PATCH 13/14] t4204-patch-id.sh: use the $( ... ) construct for command substitution

2014-04-30 Thread Elia Pinto
, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia

[PATCH 05/14] t4012-diff-binary.sh: use the $( ... ) construct for command substitution

2014-04-30 Thread Elia Pinto
, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia

[PATCH 03/14] t4006-diff-mode.sh: use the $( ... ) construct for command substitution

2014-04-30 Thread Elia Pinto
, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia

[PATCH 02/14] t3910-mac-os-precompose.sh: use the $( ... ) construct for command substitution

2014-04-30 Thread Elia Pinto
, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia

[PATCH 08/14] t4036-format-patch-signer-mime.sh: use the $( ... ) construct for command substitution

2014-04-30 Thread Elia Pinto
, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia

[PATCH 10/14] t4057-diff-combined-paths.sh: use the $( ... ) construct for command substitution

2014-04-30 Thread Elia Pinto
, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia

[PATCH 06/14] t4013-diff-various.sh: use the $( ... ) construct for command substitution

2014-04-30 Thread Elia Pinto
, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia

[PATCH 09/14] t4038-diff-combined.sh: use the $( ... ) construct for command substitution

2014-04-30 Thread Elia Pinto
, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia

[PATCH 01/14] t3905-stash-include-untracked.sh: use the $( ... ) construct for command substitution

2014-04-30 Thread Elia Pinto
, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia

Please pull the patch series "use the $( ... ) construct for command substitution"

2014-05-14 Thread Elia Pinto
a previous observation made here http://www.spinics.net/lists/git/msg230236.html Thanks very much to the people (Matthieu i think) that will make the reviews, I understand it's boring -------- Elia Pinto (83): t5003-archive-

[PATCH 09/10] git-rebase--interactive.sh: don't use the -a or -b option with the test command

2014-05-15 Thread Elia Pinto
a = b but this doesn't $ test -z "$x" -a a = b bash: test: too many arguments because it groups "test -n = -a" and is left with "a = b". Similarly, if $x is "-f", these $ test "$x" $ test "$x" || test c = d correctly ad

[PATCH 03/10] contrib/examples/git-commit.sh: don't use the -a or -b option with the test command

2014-05-15 Thread Elia Pinto
a = b but this doesn't $ test -z "$x" -a a = b bash: test: too many arguments because it groups "test -n = -a" and is left with "a = b". Similarly, if $x is "-f", these $ test "$x" $ test "$x" || test c = d correctly

[PATCH 07/10] git-bisect.sh: don't use the -a or -b option with the test command

2014-05-15 Thread Elia Pinto
a = b but this doesn't $ test -z "$x" -a a = b bash: test: too many arguments because it groups "test -n = -a" and is left with "a = b". Similarly, if $x is "-f", these $ test "$x" $ test "$x" || test c = d correctly

[PATCH 01/10] check_bindir: don't use the -a or -b option with the test command

2014-05-15 Thread Elia Pinto
a = b but this doesn't $ test -z "$x" -a a = b bash: test: too many arguments because it groups "test -n = -a" and is left with "a = b". Similarly, if $x is "-f", these $ test "$x" $ test "$x" || test c = d correctly

[PATCH 04/10] contrib/examples/git-merge.sh: don't use the -a or -b option with the test command

2014-05-15 Thread Elia Pinto
a = b but this doesn't $ test -z "$x" -a a = b bash: test: too many arguments because it groups "test -n = -a" and is left with "a = b". Similarly, if $x is "-f", these $ test "$x" $ test "$x" || test c = d correctl

[PATCH 05/10] contrib/examples/git-repack.sh: don't use the -a or -b option with the test command

2014-05-15 Thread Elia Pinto
a = b but this doesn't $ test -z "$x" -a a = b bash: test: too many arguments because it groups "test -n = -a" and is left with "a = b". Similarly, if $x is "-f", these $ test "$x" $ test "$x" || test c = d correctly

[PATCH 02/10] contrib/examples/git-clone.sh: don't use the -a or -b option with the test command

2014-05-15 Thread Elia Pinto
a = b but this doesn't $ test -z "$x" -a a = b bash: test: too many arguments because it groups "test -n = -a" and is left with "a = b". Similarly, if $x is "-f", these $ test "$x" $ test "$x" || test c = d correctl

[PATCH 08/10] git-mergetool.sh: don't use the -a or -b option with the test command

2014-05-15 Thread Elia Pinto
a = b but this doesn't $ test -z "$x" -a a = b bash: test: too many arguments because it groups "test -n = -a" and is left with "a = b". Similarly, if $x is "-f", these $ test "$x" $ test "$x" || test c = d correctly

[PATCH 10/10] git-submodule.sh: don't use the -a or -b option with the test command

2014-05-15 Thread Elia Pinto
a = b but this doesn't $ test -z "$x" -a a = b bash: test: too many arguments because it groups "test -n = -a" and is left with "a = b". Similarly, if $x is "-f", these $ test "$x" $ test "$x" || test c = d co

[PATCH 06/10] contrib/examples/git-resolve.sh: don't use the -a or -b option with the test command

2014-05-15 Thread Elia Pinto
a = b but this doesn't $ test -z "$x" -a a = b bash: test: too many arguments because it groups "test -n = -a" and is left with "a = b". Similarly, if $x is "-f", these $ test "$x" $ test "$x" || test c = d correctly

Re: [PATCH 10/10] git-submodule.sh: don't use the -a or -b option with the test command

2014-05-15 Thread Elia Pinto
I am very sorry : the comment is wrong. I will repost shortly. Best regards 2014-05-15 16:17 GMT+02:00 Elia Pinto : > Even though POSIX.1 lists -a/-o as options to "test", they are > marked "Obsolescent XSI". Scripts using these expressions > should be converted as

[PATCH 01/10] check_bindir: don't use the -a or -o option with the test command

2014-05-15 Thread Elia Pinto
a = b but this doesn't $ test -z "$x" -a a = b bash: test: too many arguments because it groups "test -n = -a" and is left with "a = b". Similarly, if $x is "-f", these $ test "$x" $ test "$x" || test c = d correctly

[PATCH 05/10] contrib/examples/git-repack.sh: don't use the -a or -o option with the test command

2014-05-15 Thread Elia Pinto
a = b but this doesn't $ test -z "$x" -a a = b bash: test: too many arguments because it groups "test -n = -a" and is left with "a = b". Similarly, if $x is "-f", these $ test "$x" $ test "$x" || test c = d correctly

[PATCH 08/10] git-mergetool.sh: don't use the -a or -o option with the test command

2014-05-15 Thread Elia Pinto
a = b but this doesn't $ test -z "$x" -a a = b bash: test: too many arguments because it groups "test -n = -a" and is left with "a = b". Similarly, if $x is "-f", these $ test "$x" $ test "$x" || test c = d correctly

[PATCH 04/10] contrib/examples/git-merge.sh: don't use the -a or -o option with the test command

2014-05-15 Thread Elia Pinto
a = b but this doesn't $ test -z "$x" -a a = b bash: test: too many arguments because it groups "test -n = -a" and is left with "a = b". Similarly, if $x is "-f", these $ test "$x" $ test "$x" || test c = d correctl

[PATCH 03/10] contrib/examples/git-commit.sh: don't use the -a or -o option with the test command

2014-05-15 Thread Elia Pinto
a = b but this doesn't $ test -z "$x" -a a = b bash: test: too many arguments because it groups "test -n = -a" and is left with "a = b". Similarly, if $x is "-f", these $ test "$x" $ test "$x" || test c = d correctly

[PATCH 06/10] contrib/examples/git-resolve.sh: don't use the -a or -b option with the test command

2014-05-15 Thread Elia Pinto
a = b but this doesn't $ test -z "$x" -a a = b bash: test: too many arguments because it groups "test -n = -a" and is left with "a = b". Similarly, if $x is "-f", these $ test "$x" $ test "$x" || test c = d correctly

[PATCH 09/10] git-rebase--interactive.sh: don't use the -a or -o option with the test command

2014-05-15 Thread Elia Pinto
a = b but this doesn't $ test -z "$x" -a a = b bash: test: too many arguments because it groups "test -n = -a" and is left with "a = b". Similarly, if $x is "-f", these $ test "$x" $ test "$x" || test c = d correctly ad

[PATCH 10/10] git-submodule.sh: don't use the -a or -o option with the test command

2014-05-15 Thread Elia Pinto
a = b but this doesn't $ test -z "$x" -a a = b bash: test: too many arguments because it groups "test -n = -a" and is left with "a = b". Similarly, if $x is "-f", these $ test "$x" $ test "$x" || test c = d co

[PATCH 02/10] contrib/examples/git-clone.sh: don't use the -a or -o option with the test command

2014-05-15 Thread Elia Pinto
a = b but this doesn't $ test -z "$x" -a a = b bash: test: too many arguments because it groups "test -n = -a" and is left with "a = b". Similarly, if $x is "-f", these $ test "$x" $ test "$x" || test c = d correctl

[PATCH 07/10] git-bisect.sh: don't use the -a or -o option with the test command

2014-05-15 Thread Elia Pinto
a = b but this doesn't $ test -z "$x" -a a = b bash: test: too many arguments because it groups "test -n = -a" and is left with "a = b". Similarly, if $x is "-f", these $ test "$x" $ test "$x" || test c = d correctly

[PATCH 09/19] git-rebase--interactive.sh: convert test -a/-o to && and ||

2014-05-20 Thread Elia Pinto
The interaction with unary operators and operator precedence for && and || are better known than -a and -o, and for that reason we prefer them. Replace all existing instances of -a and -o to save readers from the burden of thinking about such things. Signed-off-by: Elia Pinto --- gi

[PATCH 01/19] check_bindir: convert test -a/-o to && and ||

2014-05-20 Thread Elia Pinto
The interaction with unary operators and operator precedence for && and || are better known than -a and -o, and for that reason we prefer them. Replace all existing instances of -a and -o to save readers from the burden of thinking about such things. Signed-off-by: Elia Pinto --- chec

[PATCH 07/19] git-bisect.sh: convert test -a/-o to && and ||

2014-05-20 Thread Elia Pinto
The interaction with unary operators and operator precedence for && and || are better known than -a and -o, and for that reason we prefer them. Replace all existing instances of -a and -o to save readers from the burden of thinking about such things. Signed-off-by: Elia Pinto --- git-b

[PATCH 06/19] contrib/examples/git-resolve.sh: convert test -a/-o to && and ||

2014-05-20 Thread Elia Pinto
The interaction with unary operators and operator precedence for && and || are better known than -a and -o, and for that reason we prefer them. Replace all existing instances of -a and -o to save readers from the burden of thinking about such things. Signed-off-by: Elia Pinto ---

[PATCH 02/19] contrib/examples/git-clone.sh: convert test -a/-o to && and ||

2014-05-20 Thread Elia Pinto
The interaction with unary operators and operator precedence for && and || are better known than -a and -o, and for that reason we prefer them. Replace all existing instances of -a and -o to save readers from the burden of thinking about such things. Signed-off-by: Elia Pinto ---

[PATCH 00/19] convert test -a/-o to && and || patch series

2014-05-20 Thread Elia Pinto
These patch series convert test -a/-o to && and ||. This is the second version. Changes: - Modified commit comment based on Jonathan Nieder suggestions (was "don't use the -a or -o option with the test command") - Modified patch on git-submodule.sh based on Jonathan Ni

[PATCH 04/19] contrib/examples/git-merge.sh: convert test -a/-o to && and ||

2014-05-20 Thread Elia Pinto
The interaction with unary operators and operator precedence for && and || are better known than -a and -o, and for that reason we prefer them. Replace all existing instances of -a and -o to save readers from the burden of thinking about such things. Signed-off-by: Elia Pinto ---

[PATCH 13/19] t/t4102-apply-rename.sh: convert test -a/-o to && and ||

2014-05-20 Thread Elia Pinto
The interaction with unary operators and operator precedence for && and || are better known than -a and -o, and for that reason we prefer them. Replace all existing instances of -a and -o to save readers from the burden of thinking about such things. Signed-off-by: Elia Pinto --- t/t41

[PATCH 10/19] git-submodule.sh: convert test -a/-o to && and ||

2014-05-20 Thread Elia Pinto
The interaction with unary operators and operator precedence for && and || are better known than -a and -o, and for that reason we prefer them. Replace all existing instances of -a and -o to save readers from the burden of thinking about such things. Signed-off-by: Elia Pinto

[PATCH 17/19] t/t5538-push-shallow.sh: convert test -a/-o to && and ||

2014-05-20 Thread Elia Pinto
The interaction with unary operators and operator precedence for && and || are better known than -a and -o, and for that reason we prefer them. Replace all existing instances of -a and -o to save readers from the burden of thinking about such things. Signed-off-by: Elia Pinto --- t/t5

[PATCH 05/19] contrib/examples/git-repack.sh: convert test -a/-o to && and ||

2014-05-20 Thread Elia Pinto
The interaction with unary operators and operator precedence for && and || are better known than -a and -o, and for that reason we prefer them. Replace all existing instances of -a and -o to save readers from the burden of thinking about such things. Signed-off-by: Elia Pinto ---

[PATCH 19/19] t/test-lib-functions.sh: convert test -a/-o to && and ||

2014-05-20 Thread Elia Pinto
The interaction with unary operators and operator precedence for && and || are better known than -a and -o, and for that reason we prefer them. Replace all existing instances of -a and -o to save readers from the burden of thinking about such things. Signed-off-by: Elia Pinto --- t/

[PATCH 12/19] t/t0026-eol-config.sh: convert test -a/-o to && and ||

2014-05-20 Thread Elia Pinto
The interaction with unary operators and operator precedence for && and || are better known than -a and -o, and for that reason we prefer them. Replace all existing instances of -a and -o to save readers from the burden of thinking about such things. Signed-off-by: Elia Pinto --- t/t

[PATCH 14/19] t/t5000-tar-tree.sh: convert test -a/-o to && and ||

2014-05-20 Thread Elia Pinto
The interaction with unary operators and operator precedence for && and || are better known than -a and -o, and for that reason we prefer them. Replace all existing instances of -a and -o to save readers from the burden of thinking about such things. Signed-off-by: Elia Pinto --- t/t

[PATCH 18/19] t/t9814-git-p4-rename.sh: convert test -a/-o to && and ||

2014-05-20 Thread Elia Pinto
The interaction with unary operators and operator precedence for && and || are better known than -a and -o, and for that reason we prefer them. Replace all existing instances of -a and -o to save readers from the burden of thinking about such things. Signed-off-by: Elia Pinto --- t/t981

[PATCH 08/19] git-mergetool.sh: convert test -a/-o to && and ||

2014-05-20 Thread Elia Pinto
The interaction with unary operators and operator precedence for && and || are better known than -a and -o, and for that reason we prefer them. Replace all existing instances of -a and -o to save readers from the burden of thinking about such things. Signed-off-by: Elia Pinto

[PATCH 03/19] contrib/examples/git-commit.sh: convert test -a/-o to && and ||

2014-05-20 Thread Elia Pinto
The interaction with unary operators and operator precedence for && and || are better known than -a and -o, and for that reason we prefer them. Replace all existing instances of -a and -o to save readers from the burden of thinking about such things. Signed-off-by: Elia Pinto ---

[PATCH 15/19] t/t5403-post-checkout-hook.sh: convert test -a/-o to && and ||

2014-05-20 Thread Elia Pinto
The interaction with unary operators and operator precedence for && and || are better known than -a and -o, and for that reason we prefer them. Replace all existing instances of -a and -o to save readers from the burden of thinking about such things. Signed-off-by: Elia Pinto --- t/t5

[PATCH 11/19] t/t0025-crlf-auto.sh: convert test -a/-o to && and ||

2014-05-20 Thread Elia Pinto
The interaction with unary operators and operator precedence for && and || are better known than -a and -o, and for that reason we prefer them. Replace all existing instances of -a and -o to save readers from the burden of thinking about such things. Signed-off-by: Elia Pinto --- t/t0

[PATCH 16/19] t/t5537-fetch-shallow.sh: convert test -a/-o to && and ||

2014-05-20 Thread Elia Pinto
The interaction with unary operators and operator precedence for && and || are better known than -a and -o, and for that reason we prefer them. Replace all existing instances of -a and -o to save readers from the burden of thinking about such things. Signed-off-by: Elia Pinto --- t/t55

[PATCHv2 10/19] git-submodule.sh: convert test -a/-o to && and ||

2014-05-21 Thread Elia Pinto
The interaction with unary operators and operator precedence for && and || are better known than -a and -o, and for that reason we prefer them. Replace all existing instances of -a and -o to save readers from the burden of thinking about such things. --- This is version 2 of the patch to git-submod

Re: [PATCHv2 10/19] git-submodule.sh: convert test -a/-o to && and ||

2014-05-22 Thread Elia Pinto
2014-05-22 8:49 GMT+02:00 Matthieu Moy : > Elia Pinto writes: > >> This is version 2 of the patch to git-submodule of the >> patch series "convert test -a/-o to && and ||". >> It contains the fixes identified by Johannes and >> Matthieu. > &g

[PATCH] Get rid of the non portable shell export VAR=VALUE costruct

2014-05-22 Thread Elia Pinto
Found by check-non-portable-shell.pl Signed-off-by: Elia Pinto --- contrib/subtree/t/t7900-subtree.sh |2 +- git-remote-testgit.sh |2 +- git-stash.sh |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/contrib/subtree/t/t7900

Re: [PATCH] Get rid of the non portable shell export VAR=VALUE costruct

2014-05-22 Thread Elia Pinto
5-22 14.48, Elia Pinto wrote: >> Found by check-non-portable-shell.pl > > Thanks for picking this up >> -export TEST_DIRECTORY=$(pwd)/../../../t >> +TEST_DIRECTORY=$(pwd)/../../../t && export TEST_DIRECTORY > Minor remark: > Both commands should go on their o

[PATCH v2] Get rid of the non portable shell export VAR=VALUE costruct

2014-05-23 Thread Elia Pinto
Found by check-non-portable-shell.pl Signed-off-by: Elia Pinto --- This is the second version of the patch that includes Junio suggestions. contrib/subtree/t/t7900-subtree.sh |3 ++- git-remote-testgit.sh |3 ++- git-stash.sh |3 ++- 3 files

[PATCH] git-remote-testgit.sh: cleaned up the logic for setting the refspec variable

2014-05-23 Thread Elia Pinto
This patch makes the code more readable for setting the refspec variable Signed-off-by: Elia Pinto --- git-remote-testgit.sh | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/git-remote-testgit.sh b/git-remote-testgit.sh index 1c006a0..fb8a003 100755 --- a/git

[PATCH 04/20] contrib/examples/git-merge.sh: avoid "test -a/-o "

2014-06-06 Thread Elia Pinto
The construct is error-prone; "test" being built-in in most modern shells, the reason to avoid "test && test " spawning one extra process by using a single "test -a " no longer exists. Signed-off-by: Elia Pinto --- contrib/examples/git-merge.sh |4 ++

[PATCH 11/20] t/lib-httpd.sh: avoid "test -a/-o "

2014-06-06 Thread Elia Pinto
The construct is error-prone; "test" being built-in in most modern shells, the reason to avoid "test && test " spawning one extra process by using a single "test -a " no longer exists. Signed-off-by: Elia Pinto --- t/lib-httpd.sh |2 +- 1 file change

[PATCH 16/20] t/t5403-post-checkout-hook.sh: avoid "test -a/-o "

2014-06-06 Thread Elia Pinto
The construct is error-prone; "test" being built-in in most modern shells, the reason to avoid "test && test " spawning one extra process by using a single "test -a " no longer exists. Signed-off-by: Elia Pinto --- t/t5403-post-checkout-hook.sh |8

[PATCH 12/20] t/t0025-crlf-auto.sh: avoid "test -a/-o "

2014-06-06 Thread Elia Pinto
The construct is error-prone; "test" being built-in in most modern shells, the reason to avoid "test && test " spawning one extra process by using a single "test -a " no longer exists. Signed-off-by: Elia Pinto --- t/t0025-crlf-auto.sh |6 +++-

[PATCH 07/20] git-bisect.sh: avoid "test -a/-o "

2014-06-06 Thread Elia Pinto
The construct is error-prone; "test" being built-in in most modern shells, the reason to avoid "test && test " spawning one extra process by using a single "test -a " no longer exists. Signed-off-by: Elia Pinto --- git-bisect.sh |2 +- 1 file change

[PATCH 06/20] contrib/examples/git-resolve.sh: avoid "test -a/-o "

2014-06-06 Thread Elia Pinto
The construct is error-prone; "test" being built-in in most modern shells, the reason to avoid "test && test " spawning one extra process by using a single "test -a " no longer exists. Signed-off-by: Elia Pinto --- contrib/examples/git-resolve.sh |2

[PATCH 13/20] t/t0026-eol-config.sh: avoid "test -a/-o "

2014-06-06 Thread Elia Pinto
The construct is error-prone; "test" being built-in in most modern shells, the reason to avoid "test && test " spawning one extra process by using a single "test -a " no longer exists. Signed-off-by: Elia Pinto --- t/t0026-eol-config.sh |8 --

[PATCH 15/20] t/t5000-tar-tree.sh: avoid "test -a/-o "

2014-06-06 Thread Elia Pinto
The construct is error-prone; "test" being built-in in most modern shells, the reason to avoid "test && test " spawning one extra process by using a single "test -a " no longer exists. Signed-off-by: Elia Pinto --- t/t5000-tar-tree.sh |2 +- 1 fi

[PATCH 08/20] git-mergetool.sh: avoid "test -a/-o "

2014-06-06 Thread Elia Pinto
The construct is error-prone; "test" being built-in in most modern shells, the reason to avoid "test && test " spawning one extra process by using a single "test -a " no longer exists. Signed-off-by: Elia Pinto --- git-mergetool.sh |4 ++-- 1 file

[PATCH 17/20] t/t5538-push-shallow.sh: avoid "test -a/-o "

2014-06-06 Thread Elia Pinto
The construct is error-prone; "test" being built-in in most modern shells, the reason to avoid "test && test " spawning one extra process by using a single "test -a " no longer exists. Signed-off-by: Elia Pinto --- t/t5538-push-shallow.sh |2 +- 1 fi

[PATCH 18/20] t/t9814-git-p4-rename.sh: avoid "test -a/-o "

2014-06-06 Thread Elia Pinto
The construct is error-prone; "test" being built-in in most modern shells, the reason to avoid "test && test " spawning one extra process by using a single "test -a " no longer exists. Signed-off-by: Elia Pinto --- t/t9814-git-p4-rename.sh |4 ++

[PATCH 05/20] contrib/examples/git-repack.sh: avoid "test -a/-o "

2014-06-06 Thread Elia Pinto
The construct is error-prone; "test" being built-in in most modern shells, the reason to avoid "test && test " spawning one extra process by using a single "test -a " no longer exists. Signed-off-by: Elia Pinto --- contrib/examples/git-repack.sh |4 ++

[PATCH 20/20] CodingGuidelines: avoid "test -a/-o "

2014-06-06 Thread Elia Pinto
The construct is error-prone; "test" being built-in in most modern shells, the reason to avoid "test && test " spawning one extra process by using a single "test -a " no longer exists. Signed-off-by: Junio C Hamano Signed-off-by: Elia Pinto ---

<    1   2   3   4   5   6   >