The construct is error-prone; "test" being built-in in most modern
shells, the reason to avoid "test && test " spawning
one extra process by using a single "test -a " no
longer exists.
Signed-off-by: Elia Pinto
---
t/t4102-apply-rename.sh |2 +-
1 fi
The construct is error-prone; "test" being built-in in most modern
shells, the reason to avoid "test && test " spawning
one extra process by using a single "test -a " no
longer exists.
Signed-off-by: Elia Pinto
---
git-submodule.sh | 32 ++
The construct is error-prone; "test" being built-in in most modern
shells, the reason to avoid "test && test " spawning
one extra process by using a single "test -a " no
longer exists.
Signed-off-by: Elia Pinto
---
t/test-lib-functions.sh |4 ++
The construct is error-prone; "test" being built-in in most modern
shells, the reason to avoid "test && test " spawning
one extra process by using a single "test -a " no
longer exists.
Signed-off-by: Elia Pinto
---
contrib/examples/git-commit.sh |4 ++
The construct is error-prone; "test" being built-in in most modern
shells, the reason to avoid "test && test " spawning
one extra process by using a single "test -a " no
longer exists.
Signed-off-by: Elia Pinto
---
git-rebase--interactive.sh |2
er" and the patches also apply to "next".
I hope I have done the right thing in resending the patch series.
I am Sorry if not.
Elia Pinto (20):
check_bindir: avoid "test -a/-o "
contrib/examples/git-clone.sh: avoid "test -a/-o "
contrib/examples/g
The construct is error-prone; "test" being built-in in most modern
shells, the reason to avoid "test && test " spawning
one extra process by using a single "test -a " no
longer exists.
Signed-off-by: Elia Pinto
---
check_bindir |2 +-
1 file change
The construct is error-prone; "test" being built-in in most modern
shells, the reason to avoid "test && test " spawning
one extra process by using a single "test -a " no
longer exists.
Signed-off-by: Elia Pinto
---
contrib/examples/git-clone.sh |2
The construct is error-prone; "test" being built-in in most modern
shells, the reason to avoid "test && test " spawning
one extra process by using a single "test -a " no
longer exists.
Signed-off-by: Elia Pinto
---
This is the fourth revision of this pat
The construct is error-prone; "test" being built-in in most modern
shells, the reason to avoid "test && test " spawning
one extra process by using a single "test -a " no
longer exists.
Signed-off-by: Elia Pinto
---
This is the fifth revision.
Change based
Use the ARRAY_SIZE macro to get the number
of elements in an array.
Signed-off-by: Elia Pinto
---
submodule.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/submodule.c b/submodule.c
index b80ecac..48e3b44 100644
--- a/submodule.c
+++ b/submodule.c
@@ -965,7 +965,7
Add cppcheck target to Makefile. Cppcheck is a static
analysis tool for C/C++ code. Cppcheck primarily detects
the types of bugs that the compilers normally do not detect.
It is an useful target for doing QA analysis.
Signed-off-by: Elia Pinto
---
Makefile |6 ++
config.mak.in
Signed-off-by: Elia Pinto
---
archive.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/archive.c b/archive.c
index 346f3b2..49b79f8 100644
--- a/archive.c
+++ b/archive.c
@@ -112,7 +112,6 @@ static int write_archive_entry(const unsigned char *sha1,
const char *base
Signed-off-by: Elia Pinto
---
bisect.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/bisect.c b/bisect.c
index 37200b4..8448d27 100644
--- a/bisect.c
+++ b/bisect.c
@@ -685,7 +685,6 @@ static void mark_expected_rev(char *bisect_rev_hex)
static int bisect_checkout(char
Signed-off-by: Elia Pinto
---
builtin/apply.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/builtin/apply.c b/builtin/apply.c
index b0d0986..a7e72d5 100644
--- a/builtin/apply.c
+++ b/builtin/apply.c
@@ -1943,13 +1943,7 @@ static int parse_chunk(char *buffer
Signed-off-by: Elia Pinto
---
builtin/blame.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/builtin/blame.c b/builtin/blame.c
index e44a6bb..967a7c6 100644
--- a/builtin/blame.c
+++ b/builtin/blame.c
@@ -1580,14 +1580,14 @@ static const char *format_time(unsigned
Signed-off-by: Elia Pinto
---
builtin/clean.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/builtin/clean.c b/builtin/clean.c
index 2f26297..a1f8969 100644
--- a/builtin/clean.c
+++ b/builtin/clean.c
@@ -154,7 +154,7 @@ static int remove_dirs(struct strbuf *path, const
Signed-off-by: Elia Pinto
---
builtin/commit.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/builtin/commit.c b/builtin/commit.c
index 3767478..eea4421 100644
--- a/builtin/commit.c
+++ b/builtin/commit.c
@@ -307,7 +307,6 @@ static char *prepare_index(int argc
Signed-off-by: Elia Pinto
---
builtin/fetch.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/fetch.c b/builtin/fetch.c
index 025bc3e..55f457c 100644
--- a/builtin/fetch.c
+++ b/builtin/fetch.c
@@ -1026,7 +1026,6 @@ static int fetch_multiple(struct string_list
Signed-off-by: Elia Pinto
---
builtin/gc.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/builtin/gc.c b/builtin/gc.c
index c19545d..5bbb5e3 100644
--- a/builtin/gc.c
+++ b/builtin/gc.c
@@ -188,13 +188,12 @@ static int need_to_gc(void)
static const char
Signed-off-by: Elia Pinto
---
This a reroll of a previous patch. Corrected the declaration
after statement issue.
builtin/commit.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/builtin/commit.c b/builtin/commit.c
index 3767478..a684296 100644
--- a/builtin
the file(s).
Signed-off-by: Elia Pinto
---
This is a second version of this patch
http://article.gmane.org/gmane.comp.version-control.git/231984.
The first was plain wrong, my bad. I am sorry for the long delay.
Sure it is something low-hanging fruit
configure.ac
2013/9/11 Stefano Lattarini :
> Hi Elia. Sorry, but I have to give my NAK to this patch.
>
I hold in great consideration the comments of Stephen in this area.
>
> On 09/11/2013 04:46 PM, Elia Pinto wrote:
>>
>> Git use, as many project that use autoconf, private m4 macr
The second argument to test_path_is_file and test_path_is_dir
must be $2 and not $*, which instead would repeat the file
name in the error message.
Signed-off-by: Elia Pinto
---
t/test-lib-functions.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/test-lib
d-off-by: Elia Pinto
---
Makefile | 7 +++
configure.ac | 24
git-compat-util.h | 36 +++-
3 files changed, 66 insertions(+), 1 deletion(-)
This is the second version of this patch.
It had not been discussed before. I
called AC_CONFIG_MACRO_DIRS, that provides a space-separated list
of directories to use for looking up m4 files.
The same macro will be available as part of autoconf 2.70,
actually in development. Anyway also this version permit
to use AC_CONFIG_MACRO_DIR and not need automake.
Signed-off-by: Elia Pinto
2013/8/9 Junio C Hamano :
> Elia Pinto writes:
>
>> Git use, as many project that use autoconf, private m4 macros.
>>
>> When not using automake, and just relying on autoconf, the macro
>> files are not picked up by default.
>>
>> A possibility, as gi
2013/5/16 Thomas Rast :
> 1b3185f (MALLOC_CHECK: various clean-ups, 2012-09-14) moved around the
> MALLOC_CHECK_ and MALLOC_PERTURB_ assignments, intending to limit
> their effect to only the test runs. However, they were actually
> enabled only during test cleanup. Call setup/teardown_malloc_che
Why someone should be do something like this ? What is the use case ?
Best regards
2013/5/25, Gioele Barabucci :
> Hello,
>
> it seems that `git clone` does not understand keywords used `insteadOf`
> longer URLs.
>
> $ git clone remote-repo/ProjectA.git
> fatal repository 'remote-repo/P
Fwiw, look very a sound idea for me.
Best
2013/3/30, Junio C Hamano :
> Junio C Hamano writes:
>
>> What we may want is another type peeling operator, ^{object}.
>> that makes sure it is an object, like this:
>>
>> rev-parse --verify 572a535454612a046e7dd7404dcca94d6243c788^{object}
>>
>> It
I know julio notes about libgit2. Anyway the rpm5 mantainer had
decided to integrate libgit2 recently. Jfi.
Regards
2012/8/25, Nicolas Sebrecht :
> The 25/08/12, Vicent Marti wrote:
>
>> The development of libgit2 happens 100% in the open. I don't know what
>> "commercial entity" are you talking
tting MALLOC_PERTURB_ to zero disables the feature.
This technique can find hard to detect bugs.
It is therefore suggested to always use this flag (at least temporarily)
when testing out code or a new distribution.
Signed-off-by: Elia Pinto
---
t/test-lib.sh | 6 ++
1 file changed, 6 insertions(+)
2012/9/12 Junio C Hamano :
>
> Interesting, but it bothers me to make it enabled unconditionally.
> At least, this shouldn't be enabled under GIT_TEST_OPTS=--valgrind, no?
Sorry for the late response and thanks.
No, setting MALLOC_CHECK don't require
valgrind and it considered a best QA to have th
tting MALLOC_PERTURB_ to zero disables the feature.
This technique can find hard to detect bugs.
It is therefore suggested to always use this flag (at least temporarily)
when testing out code or a new distribution.
Signed-off-by: Elia Pinto
---
This the second reroll of the original patch.
I redid the
e MALLOC_CHECK_ and valgrind(memcheck) at the
same time.
Signed-off-by: Elia Pinto
---
This the third reroll of the original patch.
I redid the patch correcting the export command in a more portable
way thanks to the Junio observation and not setting MALLOC_CHECK_
at the same time we are using valgrind
2012/9/14 Erik Faye-Lund :
> On Fri, Sep 14, 2012 at 6:54 PM, Erik Faye-Lund wrote:
>> On Fri, Sep 14, 2012 at 6:41 PM, Erik Faye-Lund wrote:
>>> diff --git a/t/test-lib.sh b/t/test-lib.sh
>>> index 78c4286..7d1b34b 100644
>>> --- a/t/test-lib.sh
>>> +++ b/t/test-lib.sh
>>> @@ -129,6 +129,20 @@ e
2012/9/14 Elia Pinto :
> 2012/9/14 Erik Faye-Lund :
>> On Fri, Sep 14, 2012 at 6:54 PM, Erik Faye-Lund wrote:
>>> On Fri, Sep 14, 2012 at 6:41 PM, Erik Faye-Lund wrote:
>>>> diff --git a/t/test-lib.sh b/t/test-lib.sh
>>>> index 78c4286..7d1b34b 100644
2012/9/15 Junio C Hamano :
> Junio C Hamano writes:
>
>> Elia Pinto writes:
>>
>>> Recent versions of Linux libc (later than 5.4.23) and glibc (2.x)
>>> include a malloc() implementation which is tunable via environment
>>> variables. When MA
Ok.
Please use the patch that you have already queued in the ep integration branch.
Thank you
2012/9/17, Junio C Hamano :
> Elia Pinto writes:
>
>>> - That "165" thing I mentioned earlier.
>>
>> Thank you so much for the comments, that's fine. A s
Hi Julio.
No, i don't know this message before. Difficult that can be related to
a recent glibc change, i think. Perhaps eglibc ? I tomorrow take a
look, i am on travel now.
Best
2012/10/6, Junio C Hamano :
> Ramsay Jones writes:
>
>> The malloc checks can be disabled using the TEST_NO_MALLOC_CH
2012/10/6 Junio C Hamano :
> Ramsay Jones writes:
>
>> The malloc checks can be disabled using the TEST_NO_MALLOC_CHECK
>> variable, either from the environment or command line of an
>> 'make test' invocation. In order to allow the malloc checks to be
>> disabled from the 'config.mak' file, we add
Hemm, too old release distro , no ? 4-5 year ago. It is time to
upgrade to something more recent , 5.7 5.8 . Rhel5.3 is not a good
distro for a developer isn't it ?
2012/10/10, Ramsay Jones :
> Junio C Hamano wrote:
>> Ramsay Jones writes:
>>
>>> The malloc checks can be disabled using the TEST_N
No reboot. lsb-release -a from memory or something similar, always on travel...
Regards
2012/10/10, Elia Pinto :
> Hemm, too old release distro , no ? 4-5 year ago. It is time to
> upgrade to something more recent , 5.7 5.8 . Rhel5.3 is not a good
> distro for a developer isn't it
Very clear analysis. Well written. Perhaps is it the time to update
http://git-scm.com/book/ch6-1.html (A SHORT NOTE ABOUT SHA-1) ?
Hope useful
http://www.schneier.com/crypto-gram-1210.html
Best Regards
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to
2012/10/15 Ævar Arnfjörð Bjarmason :
> On Mon, Oct 15, 2012 at 6:42 PM, Elia Pinto wrote:
>> Very clear analysis. Well written. Perhaps is it the time to update
>> http://git-scm.com/book/ch6-1.html (A SHORT NOTE ABOUT SHA-1) ?
>>
>> Hope useful
>>
>> http:/
Hem , sha-3 i suppose, keccak, no ? But really is not so urgent as you
have already told .
Best
2012/10/15, Jeff King :
> On Mon, Oct 15, 2012 at 07:47:09PM +0200, Ævar Arnfjörð Bjarmason wrote:
>
>> On Mon, Oct 15, 2012 at 6:42 PM, Elia Pinto
>> wrote:
>> > Very c
The shell word splitting done in base is a bashism, iow not portable.
Best
2012/10/30, Felipe Contreras :
> No reason to use the full path in case this is used externally.
>
> Signed-off-by: Felipe Contreras
> ---
> t/test-lib.sh | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> dif
Best
2012/10/30, Jonathan Nieder :
> Elia Pinto wrote:
>
>> The shell word splitting done in base is a bashism, iow not portable.
>
> No, ${varname##glob} is in POSIX and we already use it here and there.
> See Documentation/CodingGuidelines:
>
>- We use ${parameter#
Well, many folks use puppet in serverless configuration pushing the
manifest from a central git server via cron and applying locally the
configuration fetched. In this sense git IS used for deployement. And,
for a configuration management system as puppet this could be a
sensible thing to do - redu
he
complete url now - old smartphone, no wifi etc. But i hope this can
help you the same.
Best regards
2012/7/21, Martin Langhoff :
> On Sat, Jul 21, 2012 at 3:11 AM, Elia Pinto
> wrote:
>> Well, many folks use puppet in serverless configuration pushing the
>> manifest from a centr
(the missing link)
cheers
2012/7/21, Elia Pinto :
> Sure . There is a complete paragraph " creating decentralized puppet
> architecture" in "puppet 2.7 cookbook". I am also sure to have read
> the same topic on web on the site bitfieldconsulting.com , not
> casua
Difficult that it is a git problem. It is better to trace the network
communication, a wireshark trace for example. But it is probably a
firewall or UTM, if you have, issue.
Best
2012/8/11, Paul Alesius :
> I should add to the facts that:
>
>
> - git version: git version 1.7.11.2
> - Happens only
501 - 552 of 552 matches
Mail list logo
