On Thu, Aug 13, 2015 at 10:37 AM, Johannes Schindelin
wrote:
> Hi kusma,
>
> On 2015-08-12 13:58, Erik Faye-Lund wrote:
>> On Wed, Aug 12, 2015 at 1:07 PM, Johannes Schindelin
>> wrote:
>>>
>>> On 2015-08-11 22:51, Johannes Sixt wrote:
>>>> Inv
On Wed, Aug 12, 2015 at 1:07 PM, Johannes Schindelin
wrote:
> Hi Johannes,
>
> On 2015-08-11 22:51, Johannes Sixt wrote:
>> Invoking plink requires special treatment, and we have support and even
>> test cases for the commands 'plink' and 'tortoiseplink'. We also support
>> .exe variants for these
On Wed, Apr 15, 2015 at 8:29 PM, Johannes Sixt wrote:
> Windows does not have process groups. It is, therefore, the simplest
> to pretend that each process is in its own process group.
Windows does have some concept of process groups, but probably not
quite what you want:
https://msdn.microsoft.
On Thu, Apr 2, 2015 at 8:09 AM, Shawn Landden wrote:
> From: Shawn Landden
>
> v1.1: actually test...
>
> Signed-off-by: Shawn Landden
> ---
> daemon.c | 35 +++---
> git-daemon.service | 7 +++
> git-daemon.socket | 9
> sd-daemon.c| 132
>
On Tue, Jan 27, 2015 at 3:51 AM, Junio C Hamano wrote:
> Erik Faye-Lund writes:
>
>> On Fri, Jan 16, 2015 at 1:04 AM, Junio C Hamano wrote:
>>> Jeff King writes:
>>>
>>>> Exactly. I am happy to submit a patch, but I cannot think of any
>>&
On Fri, Jan 16, 2015 at 1:04 AM, Junio C Hamano wrote:
> Jeff King writes:
>
>> Exactly. I am happy to submit a patch, but I cannot think of any
>> mechanisms besides:
>>
>> 1. Calling `id`, which I suspect is very not portable.
>>
>> 2. Writing a C program to check getuid(). That's portable
Sorry for very late reply. I had a bug in my mail rules that caused
this email to skip my inbox. That should be fixed now.
On Mon, Dec 15, 2014 at 7:11 PM, Junio C Hamano wrote:
> Arjun Sreedharan writes:
>
>> use a temporary variable to free the memory in case
>> realloc() fails.
>>
>> Signed-o
return match_part_with_last(ptarget, want, delim, 1);
>> +}
>> +
>> static int match_cred(const CREDENTIALW *cred)
>> {
>> LPCWSTR target = cred->TargetName;
>> @@ -146,7 +165,7 @@ static int match_cred(const CREDENTIALW *cred)
>>
>> return match_p
On Wed, Oct 8, 2014 at 8:00 PM, Marat Radchenko wrote:
> Unlike MinGW, MinGW-W64 has lseek already properly defined in io.h.
>
> Signed-off-by: Marat Radchenko
> Acked-by: Eric Faye-Lund
I spell my name with a K, "Erik Faye-Lund".
--
To unsubscribe from this list: send
On Thu, Jan 10, 2013 at 1:10 PM, Karsten Blees wrote:
> static int match_cred(const CREDENTIALW *cred)
> {
> - return (!wusername || !wcscmp(wusername, cred->UserName)) &&
> - match_attr(cred, L"git_protocol", protocol) &&
> - match_attr(cred, L"git_host", host) &&
> -
On Mon, Aug 18, 2014 at 7:05 PM, Daniel Corbe wrote:
> Erik Faye-Lund writes:
>
>> On Mon, Aug 18, 2014 at 5:47 PM, Erik Faye-Lund wrote:
>>> On Mon, Aug 18, 2014 at 5:40 PM, Daniel Corbe wrote:
>>>>
>>>> Erik Faye-Lund writes:
>>>
On Mon, Aug 18, 2014 at 5:47 PM, Erik Faye-Lund wrote:
> On Mon, Aug 18, 2014 at 5:40 PM, Daniel Corbe wrote:
>>
>> Erik Faye-Lund writes:
>>
>>> Or you could just restart your shell when you disconnect...
>>
>> Well I'm not that daft. I tr
On Mon, Aug 18, 2014 at 5:40 PM, Daniel Corbe wrote:
>
> Erik Faye-Lund writes:
>
>> Or you could just restart your shell when you disconnect...
>
> Well I'm not that daft. I tried that and if it had resolved my problem
> I wouldn't have posted.
Hm, but isn&#
On Mon, Aug 18, 2014 at 5:14 PM, Daniel Corbe wrote:
>
> Karsten Blees writes:
>
>> Am 18.08.2014 00:01, schrieb Erik Faye-Lund:
>>> On Sun, Aug 17, 2014 at 10:18 PM, Daniel Corbe wrote:
>>>>
>>>> I installed git on my Windows machine while it
On Sun, Aug 17, 2014 at 10:18 PM, Daniel Corbe wrote:
>
> I installed git on my Windows machine while it was connected to my
> corporate network. It picked up on that fact and used a mapped drive to
> store its configuration file.
>
> As a result, I cannot currently use git when disconnected from
On Wed, Aug 13, 2014 at 10:36 AM, Радослав Йовчев wrote:
> Dear GIT community,
>
>
> I found myself in situation where I had to install GIT on Debian 3.1
> sarge. It comes with GCC 3.3.5. I tried to built from source but the
> libgcc was not providing the ctzll function, thus I decided to put an
On Thu, Jul 17, 2014 at 5:37 PM, Stepan Kasal wrote:
> From: Pat Thoyts
>
> On Windows the application command line is provided as unicode and in
> mingw-git we convert that to utf-8. So these tests that require a iso-8859-1
> input are being subverted by the encoding transformations we perform a
On Wed, Jul 9, 2014 at 10:00 PM, Eric Wong wrote:
> Torsten Bögershausen wrote:
>> (And why is it "& 0" and not "& 0777")
>
> This is to preserve the uncommon sticky/sgid/suid bits. Probably not
> needed, but better to keep as much intact as possible.
>
>> Can we avoid the fchmod() all to
On Mon, Jun 23, 2014 at 11:28 AM, Eric Sunshine wrote:
> On Wed, Jun 18, 2014 at 4:36 PM, Jeff King wrote:
>> When we get the author name and email either from an
>> existing commit or from the "--author" option, we create a
>> copy of the strings. We cannot just free() these copies,
>> since the
On Tue, Jun 17, 2014 at 9:34 AM, Jeremiah Mahler wrote:
> Add a strnncmp() function which behaves like strncmp() except it takes
> the length of both strings instead of just one. It behaves the same as
> strncmp() up to the minimum common length between the strings. When the
> strings are identi
On Fri, Jun 13, 2014 at 1:44 PM, wrote:
> Hi,
>
> Here is a simple script to show my problem. I don't know if it's a
> wrong operation (from me), a wrong configuration/parameter, or either a bug,
> but I don't get what I expected.
> From a git repo (#1), I created a commit message conta
On Thu, Jun 5, 2014 at 11:40 AM, Karsten Blees wrote:
> Am 05.06.2014 10:03, schrieb Stepan Kasal:
>> From: Johannes Schindelin
>> Date: Wed, 2 Jun 2010 00:41:33 +0200
>>
>> If HOME is not set, use $HOMEDRIVE$HOMEPATH
>>
>> Signed-off-by: Johannes Schindelin
>> Signed-off-by: Stepan Kasal
>> --
On Wed, Jun 4, 2014 at 5:14 PM, Johannes Schindelin
wrote:
> Hi Erik,
>
> On Wed, 4 Jun 2014, Erik Faye-Lund wrote:
>
>> On Wed, Jun 4, 2014 at 3:47 PM, Duy Nguyen wrote:
>> > On Wed, Jun 4, 2014 at 6:47 PM, Stepan Kasal wrote:
>> >> @@ -133,7 +
On Wed, Jun 4, 2014 at 3:47 PM, Duy Nguyen wrote:
> On Wed, Jun 4, 2014 at 6:47 PM, Stepan Kasal wrote:
>> @@ -133,7 +133,7 @@ char *git_path(const char *fmt, ...)
>> void home_config_paths(char **global, char **xdg, char *file)
>> {
>> char *xdg_home = getenv("XDG_CONFIG_HOME");
>> -
On Wed, May 28, 2014 at 10:19 AM, David Kastrup wrote:
> Chris Packham writes:
>
>> On 28/05/14 18:14, Jeremiah Mahler wrote:
>>> From signal(2)
>>>
>>> The behavior of signal() varies across UNIX versions, and has also var‐
>>> ied historically across different versions of Linux. Avoid it
On Wed, May 28, 2014 at 10:11 AM, Chris Packham wrote:
> On 28/05/14 19:40, Johannes Sixt wrote:
>> Am 5/28/2014 8:14, schrieb Jeremiah Mahler:
>>> From signal(2)
>>>
>>> The behavior of signal() varies across UNIX versions, and has also var‐
>>> ied historically across different versions of L
On Tue, May 27, 2014 at 6:37 PM, Jeff King wrote:
> On Tue, May 27, 2014 at 04:17:34PM +0200, Erik Faye-Lund wrote:
>
>> The combination of "git clean" and fat fingers can some times cause
>> data-loss, which can be frustrating.
>>
>> So let's add a f
n-runs.
Signed-off-by: Erik Faye-Lund
---
I've had a similar patch laying around for quite a while, but since
f538a91 ("git-clean: Display more accurate delete messages"), this
patch is a lot less nasty than before. So here you go, perhaps
someone else has fat fingers and hate
On Tue, May 20, 2014 at 10:46 AM, Thomas Braun
wrote:
> Am 19.05.2014 22:29, schrieb Erik Faye-Lund:
>>> [...]
>>> Would we need to wrap both ends, shouldn't wrapping only reading be
>>> good enough to prevent deadlocking?
>>>
>>>
On Mon, May 19, 2014 at 11:15 PM, Thomas Braun
wrote:
> Am 19.05.2014 21:33, schrieb Jonathan Nieder:
>
>> Hi,
>>
>> Thomas Braun wrote:
>>
>>> pushing over the dump git protocol with a windows git client.
>>
>>
>> I've never heard of the dump git protocol. Do you mean the git
>> protocol that's
On Mon, May 19, 2014 at 10:00 PM, Erik Faye-Lund wrote:
> On Mon, May 19, 2014 at 9:33 PM, Jonathan Nieder wrote:
>> Hi,
>>
>> Thomas Braun wrote:
>>
>>> pushing over the dump git protocol with a windows git client.
>>
>> I've never
On Mon, May 19, 2014 at 9:33 PM, Jonathan Nieder wrote:
> Hi,
>
> Thomas Braun wrote:
>
>> pushing over the dump git protocol with a windows git client.
>
> I've never heard of the dump git protocol. Do you mean the git
> protocol that's used with git:// URLs?
>
> [...]
>> Alternative approaches
On Mon, May 19, 2014 at 9:17 PM, Thomas Braun
wrote:
> Am Montag, den 19.05.2014, 11:59 +0200 schrieb Erik Faye-Lund:
>> On Mon, May 19, 2014 at 9:44 AM, Erik Faye-Lund wrote:
>> > On Mon, May 19, 2014 at 9:13 AM, Johannes Sixt
>> > wrote:
>> >&
On Mon, May 19, 2014 at 9:44 AM, Erik Faye-Lund wrote:
> On Mon, May 19, 2014 at 9:13 AM, Johannes Sixt wrote:
>> Am 5/6/2014 2:17, schrieb Eric Wong:
>>> Users may already store sensitive data such as imap.pass in
>>> ..git/config; making the file world-readable when
On Mon, May 19, 2014 at 9:13 AM, Johannes Sixt wrote:
> Am 5/6/2014 2:17, schrieb Eric Wong:
>> Users may already store sensitive data such as imap.pass in
>> ..git/config; making the file world-readable when "git config"
>> is called to edit means their password would be compromised
>> on a share
On Wed, May 14, 2014 at 10:45 AM, Stepan Kasal wrote:
> Hello kusma,
>
> On Tue, May 13, 2014 at 08:56:54AM +0200, Erik Faye-Lund wrote:
>> > --- a/contrib/credential/wincred/Makefile
>> > +++ b/contrib/credential/wincred/Makefile
>> > @@ -1,12 +1,12 @@
&
On Tue, May 13, 2014 at 4:10 PM, Duy Nguyen wrote:
> On Tue, May 13, 2014 at 9:06 PM, Erik Faye-Lund wrote:
>> On Tue, May 13, 2014 at 3:49 PM, Duy Nguyen wrote:
>>> On Tue, May 13, 2014 at 8:37 PM, Erik Faye-Lund wrote:
>>>> On Tue, May 13, 2014 at 3:01 PM, Du
On Tue, May 13, 2014 at 3:49 PM, Duy Nguyen wrote:
> On Tue, May 13, 2014 at 8:37 PM, Erik Faye-Lund wrote:
>> On Tue, May 13, 2014 at 3:01 PM, Duy Nguyen wrote:
>>> What do you think is a good replacement for unix socket on Windows?
>>> It's only used to ref
On Tue, May 13, 2014 at 3:01 PM, Duy Nguyen wrote:
> What do you think is a good replacement for unix socket on Windows?
> It's only used to refresh the cache in the daemon, no sensitive data
> sent over, so security is not a problem. I'm thinking maybe just
> TCP/IP server, but that's going to be
On Tue, May 13, 2014 at 1:15 PM, Nguyễn Thái Ngọc Duy wrote:
> The daemon would immediately load the new index in memory in
> background. Next time Git needs to read the index again, everything is
> ready.
>
> Signed-off-by: Nguyễn Thái Ngọc Duy
> ---
> cache.h | 1 +
> read-cache.c | 53 +
On Tue, May 13, 2014 at 1:15 PM, Nguyễn Thái Ngọc Duy wrote:
> Signed-off-by: Nguyễn Thái Ngọc Duy
> ---
> Documentation/config.txt | 4
> cache.h | 1 +
> config.c | 12
> environment.c| 1 +
> read-cache.c | 43 +
On Tue, May 13, 2014 at 1:59 PM, Erik Faye-Lund wrote:
> On Tue, May 13, 2014 at 1:15 PM, Nguyễn Thái Ngọc Duy
> wrote:
>> With this we can make unix_stream_* calls without #ifdef.
>>
>> Signed-off-by: Nguyễn Thái Ngọc Duy
>> ---
>> Makefile
On Tue, May 13, 2014 at 1:15 PM, Nguyễn Thái Ngọc Duy wrote:
> With this we can make unix_stream_* calls without #ifdef.
>
> Signed-off-by: Nguyễn Thái Ngọc Duy
> ---
> Makefile | 2 ++
> unix-socket.h | 18 ++
> 2 files changed, 20 insertions(+)
>
> diff --git a/Makefile b
On Tue, May 13, 2014 at 1:15 PM, Nguyễn Thái Ngọc Duy wrote:
> diff --git a/Documentation/git-read-cache--daemon.txt
> b/Documentation/git-read-cache--daemon.txt
> new file mode 100644
> index 000..1b05be4
> --- /dev/null
> +++ b/Documentation/git-read-cache--daemon.txt
> @@ -0,0 +1,27 @@
> +
On Tue, May 13, 2014 at 1:15 PM, Nguyễn Thái Ngọc Duy wrote:
> diff --git a/Makefile b/Makefile
> index 028749b..98d22de 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1502,6 +1502,12 @@ ifdef HAVE_DEV_TTY
> BASIC_CFLAGS += -DHAVE_DEV_TTY
> endif
>
> +ifdef HAVE_SHM
> + BASIC_CFLAGS
On Tue, May 13, 2014 at 11:38 AM, Johannes Sixt wrote:
> Am 5/13/2014 11:09, schrieb Erik Faye-Lund:
>> On Mon, May 12, 2014 at 9:16 PM, Thomas-Louis Laforest
>> wrote:
>>> When running this command on Git for Windows (version 1.9.2-preview20140411)
>>> git r
On Mon, May 12, 2014 at 9:16 PM, Thomas-Louis Laforest
wrote:
> Good afternoon,
>
> When running this command on Git for Windows (version 1.9.2-preview20140411)
> git reset --quiet --hard with one file having read/write lock git ask this
> question :
> Unlink of file '' failed. Should I try a
On Tue, May 13, 2014 at 8:01 AM, Stepan Kasal wrote:
> From: Pat Thoyts
> Date: Wed, 24 Oct 2012 00:15:29 +0100
>
> Signed-off-by: Pat Thoyts
> Signed-off-by: Stepan Kasal
> ---
> contrib/credential/wincred/Makefile | 4
> 1 file changed, 4 deletions(-)
>
> diff --git a/contrib/credential
On Fri, May 9, 2014 at 12:57 PM, Felipe Contreras
wrote:
> Erik Faye-Lund wrote:
>> On Fri, May 9, 2014 at 11:32 AM, Felipe Contreras
>> wrote:
>> > Erik Faye-Lund wrote:
>> >> On Fri, May 9, 2014 at 10:48 AM, Felipe Contreras
>> >> > You think
On Fri, May 9, 2014 at 11:32 AM, Felipe Contreras
wrote:
> Erik Faye-Lund wrote:
>> On Fri, May 9, 2014 at 10:48 AM, Felipe Contreras
>> wrote:
>> > Erik Faye-Lund wrote:
>> >> On Fri, May 9, 2014 at 10:14 AM, Felipe Contreras
>> >> wrote:
>
On Fri, May 9, 2014 at 10:48 AM, Felipe Contreras
wrote:
> Erik Faye-Lund wrote:
>> On Fri, May 9, 2014 at 10:14 AM, Felipe Contreras
>> wrote:
>> > If you want this script to remain in contrib, please:
>> >
>> > a) Write at least a few tests
>>
On Fri, May 9, 2014 at 10:14 AM, Felipe Contreras
wrote:
> Erik Faye-Lund wrote:
>> On Fri, May 9, 2014 at 2:58 AM, Felipe Contreras
>> wrote:
>> > No activity since 2010, no documentation, no tests.
>> >
>> > Signed-off-by: Felipe Contreras
>>
On Fri, May 9, 2014 at 2:58 AM, Felipe Contreras
wrote:
> No activity since 2010, no documentation, no tests.
>
> Signed-off-by: Felipe Contreras
> ---
> contrib/buildsystems/Generators.pm| 42 --
> contrib/buildsystems/Generators/QMake.pm | 189 -
> contrib/buildsystems/Genera
On Mon, May 5, 2014 at 11:46 PM, Jeff King wrote:
> On Sun, May 04, 2014 at 08:13:15AM +0200, Torsten Bögershausen wrote:
>
>> > 1. Tell everyone that NFD in the git repo is wrong, and
>> > they should make a new commit to normalize all their
>> > in-repo files to be precomposed.
>> >
On Wed, Apr 30, 2014 at 9:46 PM, Sebastian Schuberth
wrote:
> On Wed, Apr 30, 2014 at 6:52 PM, Johannes Schindelin
> wrote:
>
>>> We can keep this patch in the msysGit repo for the 2.0 release.
>>
>> FWIW the plan is to switch to mingwGitDevEnv for the 2.0 release. It is
>> not quite clear as of
On Fri, May 2, 2014 at 7:23 PM, Jonathan Nieder wrote:
> (resending with the correct address for the Git for Windows developers.
> Sorry for the noise.)
> Hi Dave,
>
> Dave Bradley wrote:
>
>> G:\ws_test_env\GIT_TESTBED_TMP\fest-swing-1.x>git log --all
>> --pretty=format:"%an %ad" -- pom.xml
>> x
On Fri, May 2, 2014 at 1:50 PM, Dave Bradley wrote:
> Hi,
>
> I’m very new to ‘git’ github. I reported the #178 issue in github and the
> issue has been closed, I believe this means no further discussion.
When you say "the #178 issue in github", you really mean "issue #178
for Git for Windows on
On Wed, Apr 30, 2014 at 5:13 PM, Junio C Hamano wrote:
> I think something along the lines of
>
> ifdef CURLDIR
> CURL_LIBCURL =
> else
> CURL_CONFIG = curl-config
> CURL_LIBCURL := $(shell sh -c '$(CURL_CONFIG) --libs'
> 2>/dev/null
On Wed, Apr 30, 2014 at 5:27 PM, Junio C Hamano wrote:
> Erik Faye-Lund writes:
>
>> MinGW builds of cURL does not ship with curl-config unless built
>> with the autoconf based build system, which is not the practice
>> recommended by the documentation. MsysGit has had is
On Mon, Apr 28, 2014 at 6:29 PM, Erik Faye-Lund wrote:
> MinGW builds of cURL does not ship with curl-config unless built
> with the autoconf based build system, which is not the practice
> recommended by the documentation. MsysGit has had issues with
> binaries of that sort, so it
On Mon, Apr 28, 2014 at 11:01 PM, Dave Borowitz wrote:
> The original implementation of CURL_CONFIG support did not match the
> original behavior of using -lcurl when CURLDIR was not set. This broke
> implementations that were lacking curl-config but did have libcurl
> installed along system libra
---
>> > Another one from msysGit project.
>> > Original subject by Pat; I would suggest:
>> > wincred: improve Makefile
>
> On Wed, Apr 30, 2014 at 11:21:17AM +0200, Erik Faye-Lund wrote:
>> I'm a little bit unsure about this, because the makef
On Wed, Apr 30, 2014 at 8:46 AM, Stepan Kasal wrote:
> From: Pat Thoyts
> Date: Wed, 24 Oct 2012 00:15:29 +0100
>
> Signed-off-by: Pat Thoyts
> Signed-off-by: Stepan Kasal
> ---
> Another one from msysGit project.
> Original subject by Pat; I would suggest:
> wincred: improve Makefile
I'm
On Wed, Apr 30, 2014 at 10:35 AM, Karsten Blees wrote:
> Am 29.04.2014 11:12, schrieb Marat Radchenko:
>> On MinGW, compat/mingw.h defines a 'mingw_main' wrapper function.
>> Fix `warning: passing argument 2 of 'mingw_main' from incompatible
>> pointer type` in http-fetch.c and remote-curl.c by dr
On Mon, Apr 28, 2014 at 9:59 PM, Torsten Bögershausen wrote:
> On 2014-04-28 15.51, Marat Radchenko wrote:
>> mingw-w64 has lseek defined in io.h.
> []
>> #define off_t off64_t
>> +#ifndef lseek
>> #define lseek _lseeki64
>> +#endif
> Is the commit message in line with the code?
>
> I would have
On Mon, Apr 28, 2014 at 8:39 PM, Dave Borowitz wrote:
> On Mon, Apr 28, 2014 at 11:31 AM, Junio C Hamano wrote:
>> Erik Faye-Lund writes:
>>
>>> We're using Curl 7.30.0 in msysGit (and thus also Git for Windows), so
>>> we should be able to include i
.
Instead, add a check for curl_multi_init to our configure-script,
for those on ancient system. They probably already need to do the
configure-dance anyway.
Signed-off-by: Erik Faye-Lund
---
OK, here's a proper patch. I've even tested it! ;)
Makefile | 8 +++-
configure.ac
On Mon, Apr 28, 2014 at 6:23 PM, Marat Radchenko wrote:
> On Mon, Apr 28, 2014 at 05:26:38PM +0200, Erik Faye-Lund wrote:
>> On Mon, Apr 28, 2014 at 3:51 PM, Marat Radchenko
>> wrote:
>> > Also, fix `warning: passing argument 2 of 'mingw_main' from
>&
On Mon, Apr 28, 2014 at 5:35 PM, Stepan Kasal wrote:
> From: theoleblond
> Date: Wed, 16 May 2012 06:52:49 -0700
>
> SwitchToThread() only gives away the rest of the current time slice
> to another thread in the current process. So if the thread that feeds
> the file decscriptor we're polling is
On Mon, Apr 28, 2014 at 3:51 PM, Marat Radchenko wrote:
> -D__USE_MINGW_ACCESS only affects MinGW and does nothing when
> MSVC is used.
Seems reasonable in itself.
But, doesn't this mean that our access are currently broken on MSVC?
The comment about __USE_MINGW_ACCESS is:
/* Old versions of M
On Mon, Apr 28, 2014 at 3:51 PM, Marat Radchenko wrote:
> This patch series fixes building on modern MinGW and (32bit only yet)
> MinGW-W64.
>
> *Compilation* tested on:
> - MSVC (via WinGit environment)
> - msysGit environment
> - Linux cross-toolchain i686-pc-mingw32 (4.8.2) with mingw-runti
On Mon, Apr 28, 2014 at 3:51 PM, Marat Radchenko wrote:
> Also, fix `warning: passing argument 2 of 'mingw_main' from
> incompatible pointer type` in http-fetch.c and remote-curl.c.
These seems completely unrelated, perhaps it should be split in two?
--
To unsubscribe from this list: send the lin
> +
> static __inline int strcasecmp (const char *s1, const char *s2)
> {
> int size1 = strlen(s1);
Looks good!
Acked-by: Erik Faye-Lund
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Apr 28, 2014 at 3:51 PM, Marat Radchenko wrote:
> nedalloc was initially added in f0ed82 to fix slowness of standard WinXP
> memory allocator. Since WinXP is EOLed, this point is no longer valid.
>
> The actual reason behind this commit is incompatibility of malloc.c.h
> with MinGW-W64 hea
; }
> static inline int fchmod(int fildes, mode_t mode)
> { errno = ENOSYS; return -1; }
> -static inline pid_t fork(void)
> -{ errno = ENOSYS; return -1; }
> static inline unsigned int alarm(unsigned int seconds)
> { return 0; }
> static inline int fsync(int fd)
I
On Mon, Apr 28, 2014 at 5:09 PM, Marat Radchenko wrote:
> On Mon, Apr 28, 2014 at 05:02:09PM +0200, Erik Faye-Lund wrote:
>> msysGit has a declaration of it in io.h as well. But it's not a
>> preprocessor-definition... Are you saying that it's a
>> preprocessor-defi
On Mon, Apr 28, 2014 at 5:04 PM, Marat Radchenko wrote:
> On Mon, Apr 28, 2014 at 04:58:11PM +0200, Erik Faye-Lund wrote:
>> On Mon, Apr 28, 2014 at 3:51 PM, Marat Radchenko
>> wrote:
>> > HAVE_LIBCHARSET_H and NO_R_TO_GCC_LINKER are not specific to
>> > msysGi
On Mon, Apr 28, 2014 at 5:00 PM, Marat Radchenko wrote:
> On Mon, Apr 28, 2014 at 04:53:52PM +0200, Erik Faye-Lund wrote:
>> Just checking that I understand: Does this mean that we now require an
>> MSVC-version that has stdint.h? If so, I'm not against such a case.
>> I
On Mon, Apr 28, 2014 at 3:51 PM, Marat Radchenko wrote:
> mingw-w64 has lseek defined in io.h.
msysGit has a declaration of it in io.h as well. But it's not a
preprocessor-definition... Are you saying that it's a
preprocessor-define in mingw-w64, that points to a 64-bit version? If
so, looks good
On Mon, Apr 28, 2014 at 3:51 PM, Marat Radchenko wrote:
> HAVE_LIBCHARSET_H and NO_R_TO_GCC_LINKER are not specific to
> msysGit, they're general MinGW settings.
Actually, HAVE_LIBCHARSET_H is. It's only present because we have
libiconv installed.
--
To unsubscribe from this list: send the line "
On Mon, Apr 28, 2014 at 3:51 PM, Marat Radchenko wrote:
> On MinGW-W64, MsgWaitForMultipleObjects is guarded with #ifndef NOGDI.
>
> Unfortunately, including wingdi.h brings in #define ERROR 0 which
> conflicts with several Git internal enums. So, #undef ERROR.
>
> Signed-off-by: Marat Radchenko
On Mon, Apr 28, 2014 at 4:52 PM, Marat Radchenko wrote:
> On Mon, Apr 28, 2014 at 04:45:43PM +0200, Erik Faye-Lund wrote:
>> bswap.h is included after stdint.h from git-compat-util.h anyway...
>
> That only becomes true after PATCH 05 when talking about MinGW.
>
> Will
On Mon, Apr 28, 2014 at 3:51 PM, Marat Radchenko wrote:
> Also, pass -D__USE_MINGW_ANSI_STDIO=0 to select MSVCRT-compatible
> macro definitions.
>
> Signed-off-by: Marat Radchenko
> ---
> compat/mingw.h| 2 --
> compat/msvc.h | 3 +++
> config.mak.uname | 3 ++-
> git-compat-util.h |
On Mon, Apr 28, 2014 at 3:51 PM, Marat Radchenko wrote:
> bswap.h uses uint32_t type which might not be defined.
> This patch adds direct include so bswap.h can be safely included.
>
> Signed-off-by: Marat Radchenko
> ---
> compat/bswap.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git
On Mon, Apr 28, 2014 at 3:47 PM, Marat Radchenko wrote:
> On Mon, Apr 28, 2014 at 03:20:46PM +0200, Johannes Schindelin wrote:
>> That way, upstream Git does not have anything to change (and we avoid
>> discussing five versions of essentially the same patch :-P).
>
> This bug isn't specific to msy
On Mon, Apr 28, 2014 at 3:20 PM, Johannes Schindelin
wrote:
> Hi kusma,
>
> On Mon, 28 Apr 2014, Erik Faye-Lund wrote:
>
>> On Mon, Apr 28, 2014 at 10:48 AM, Erik Faye-Lund wrote:
>> > So it seems that 08900987 ("Decide whether to build http-push in the
>&g
On Mon, Apr 28, 2014 at 11:01 AM, Erik Faye-Lund wrote:
> On Mon, Apr 28, 2014 at 10:48 AM, Erik Faye-Lund wrote:
>> So it seems that 08900987 ("Decide whether to build http-push in the
>> Makefile") makes a bad assumption about the availability of
>> curl-conf
out == INFTIM)
> {
> - SwitchToThread();
> + SleepEx (1, TRUE);
> goto restart;
> }
>
> --
> 1.9.2.msysgit.0.158.g6070cee
>
Thanks for taking the effort!
Acked-by: Erik Faye-Lund
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Apr 28, 2014 at 11:01 AM, Erik Faye-Lund wrote:
> On Mon, Apr 28, 2014 at 10:48 AM, Erik Faye-Lund wrote:
>> So it seems that 08900987 ("Decide whether to build http-push in the
>> Makefile") makes a bad assumption about the availability of
>> curl-conf
On Mon, Apr 28, 2014 at 10:39 AM, Stepan Kasal wrote:
> From: theoleblond
> Date: Wed, 16 May 2012 06:52:49 -0700
>
> I played around with this quite a bit. After trying some more complex
> schemes, I found that what worked best is to just sleep 1 millisecond
> between iterations. Though it's a v
On Mon, Apr 28, 2014 at 10:48 AM, Erik Faye-Lund wrote:
> So it seems that 08900987 ("Decide whether to build http-push in the
> Makefile") makes a bad assumption about the availability of
> curl-config on new libcurl installations; it's not present on "stock"
&
On Mon, Apr 28, 2014 at 9:36 AM, Marat Radchenko wrote:
> Silvola Tuomas wrote
>> Hello,
>>
>> I installed git for windows 1.9.0 but any push operation I tried with it
>> produced an error message saying "git: 'http-push' is not a git command".
>> Other commands like pull, add, and commit worked j
On Tue, Apr 22, 2014 at 6:50 PM, Junio C Hamano wrote:
> Erik Faye-Lund writes:
>
>>>> Shouldn't the latter also be anchored at the beginning of the string
>>>> with a leading "^"?
>>>>
>>>>> +}
>>>>&
On Wed, Apr 16, 2014 at 7:19 PM, Junio C Hamano wrote:
> Junio C Hamano writes:
>
>> Erik Faye-Lund writes:
>>
>>> So let's manually check for these in that case, and fall back to
>>> the File::Spec-helper on other platforms (e.g Win
On Wed, Apr 16, 2014 at 11:33 AM, Elia Pinto wrote:
> Signed-off-by: Elia Pinto
> ---
> xdiff/xprepare.c |5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/xdiff/xprepare.c b/xdiff/xprepare.c
> index 63a22c6..e0b6987 100644
> --- a/xdiff/xprepare.c
> +++ b/xdiff/xpr
On Wed, Apr 16, 2014 at 11:33 AM, Elia Pinto wrote:
> Signed-off-by: Elia Pinto
> ---
> contrib/credential/osxkeychain/git-credential-osxkeychain.c |8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/contrib/credential/osxkeychain/git-credential-osxkeychain.c
> b
On Wed, Apr 16, 2014 at 11:33 AM, Elia Pinto wrote:
> Signed-off-by: Elia Pinto
> ---
> contrib/credential/wincred/git-credential-wincred.c |6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/contrib/credential/wincred/git-credential-wincred.c
> b/contrib/credentia
From: Erik Faye-Lund
On Windows, absolute paths might start with a DOS drive prefix,
which these two checks failed to recognize.
Unfortunately, we cannot simply use the file_name_is_absolute
helper in File::Spec::Functions, because Git for Windows has an
MSYS-based Perl, where this helper
On Tue, Apr 15, 2014 at 10:37 PM, Junio C Hamano wrote:
> Junio C Hamano writes:
>
>> Thanks, both. I'd expect another round then?
>>
>> -- >8 --
>> From: Erik Faye-Lund
>>
>> On Windows, absolute paths might start with a DOS drive prefix,
On Tue, Apr 15, 2014 at 12:42 PM, Erik Faye-Lund wrote:
> On Tue, Apr 15, 2014 at 12:32 PM, Johannes Sixt wrote:
>> Am 4/15/2014 10:44, schrieb Erik Faye-Lund:
>>> From: Erik Faye-Lund
>>>
>>> On Windows, absolute paths might start with a DOS drive p
1 - 100 of 268 matches
Mail list logo
