Jeff King p...@peff.net writes:
On Thu, Jan 24, 2013 at 08:19:30PM -0800, Junio C Hamano wrote:
Ahh, ok, we show one element per line and just make sure bundle
is there, and we do not care what other buns appear in the output.
Not so quick, though. The lower level read from help -a is
On Thu, Jan 24, 2013 at 03:07:42PM -0800, Junio C Hamano wrote:
When you have random build artifacts in your build directory, left
behind by running make while on another branch, the git help -a
command run by __git_list_all_commands in the completion script that
is being tested does not have
Jeff King wrote:
On Thu, Jan 24, 2013 at 03:07:42PM -0800, Junio C Hamano wrote[1]:
Instrument the completion script and give it a way for us to tell
what (subset of) subcommands we are going to ship.
[...]
The only thing I might add is a test just to double-check that git help
-a is parsed
Jeff King p...@peff.net writes:
This looks good to me.
The only thing I might add is a test just to double-check that git help
-a is parsed correctly. Like:
test_expect_success 'command completion works without test harness' '
GIT_TESTING_COMMAND_COMPLETION= run_completion git
On Thu, Jan 24, 2013 at 08:11:07PM -0800, Junio C Hamano wrote:
Jeff King p...@peff.net writes:
This looks good to me.
The only thing I might add is a test just to double-check that git help
-a is parsed correctly. Like:
test_expect_success 'command completion works without test
Junio C Hamano gits...@pobox.com writes:
Jeff King p...@peff.net writes:
This looks good to me.
The only thing I might add is a test just to double-check that git help
-a is parsed correctly. Like:
test_expect_success 'command completion works without test harness' '
On Thu, Jan 24, 2013 at 08:19:30PM -0800, Junio C Hamano wrote:
Ahh, ok, we show one element per line and just make sure bundle
is there, and we do not care what other buns appear in the output.
Not so quick, though. The lower level read from help -a is only
run once and its output kept
7 matches
Mail list logo
