Jeff King <p...@peff.net> writes: > On Thu, Jan 24, 2013 at 08:19:30PM -0800, Junio C Hamano wrote: > >> > Ahh, ok, we show one element per line and just make sure "bundle" >> > is there, and we do not care what other buns appear in the output. >> > >> Not so quick, though. The lower level "read from help -a" is only >> run once and its output kept in a two-level cache hierarchy; we need >> to reset both. > > Ugh, I didn't even think about that. > > I wonder if it would be simpler if the completion tests actually ran a > new bash for each test. That would be slower, but it somehow seems > cleaner.
I agree 100% with that. Let's leave this fix as-is, at least as a tentative fix while "git check-ignore" graduates into the upcoming release, and let somebody who is interested work on an update to this test script to do so as an independent topic. > >> It starts to look a bit too intimately tied to the implementation of >> what is being tested for my taste, though. >> [...] >> +test_expect_success 'help -a read correctly by command list generator' ' >> + __git_all_commands= && >> + __git_porcelain_commands= && >> + GIT_TESTING_COMMAND_COMPLETION= && >> + run_completion "git bun" && >> + grep "^bundle $" out >> +' > > Agreed. I could take or leave it at this point. It's nice to check that > changes to "help -a" will not break it, but ultimately it feels a bit > too contrived to catch anything useful. > > -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
