Re: [PATCH] Teach applymbox to keep the Subject: line.

2005-08-18 Thread Junio C Hamano
Linus Torvalds <[EMAIL PROTECTED]> writes: > Well, Junio has been talking about adding commit hooks. I don't think > that's been done. No, notyet. But tonight. > The only question is what the hook/trigger should look like. just put > something like > > [ -x .git/hooks/applypatch-hook ] &&

Re: [PATCH] Teach applymbox to keep the Subject: line.

2005-08-18 Thread Junio C Hamano
Sam Ravnborg <[EMAIL PROTECTED]> writes: > I prefer to add it myself rather than to have it added automatically - > but mayve thats you me being a bit mistrusting. > > The only git- command I use today is git-applymbox. If you did not have that "add it myself" preference, I would have recommended

Re: [PATCH] Teach applymbox to keep the Subject: line.

2005-08-18 Thread Linus Torvalds
On Thu, 18 Aug 2005, Sam Ravnborg wrote: > > I almost always handedit my mails and I find myself forgetting to add > "Signed-off-by" from time to time. > Is there a simple way to implment a trigger that can check that _I_ > signed off the patch before applying it? Well, Junio has been talking a

Re: [PATCH] Teach applymbox to keep the Subject: line.

2005-08-18 Thread Sam Ravnborg
> (Also, with proper "Signed-off-by:" lines it's also always clear that > there were other people involved, and that the author of the patch is > different from the person who applied it). I almost always handedit my mails and I find myself forgetting to add "Signed-off-by" from time to time. Is

Re: [PATCH] Teach applymbox to keep the Subject: line.

2005-08-18 Thread David Kågedal
Linus Torvalds <[EMAIL PROTECTED]> writes: > On Wed, 17 Aug 2005, Jeff Garzik wrote: >> >> 1) Fix applymbox such that it understands RFC822-valid Subject lines >> which wrap across multiple text lines. > > It already should do this. > >> 2) Teach it to understand MIME, and not treat the MIME hea

Re: [PATCH] Teach applymbox to keep the Subject: line.

2005-08-17 Thread Johannes Schindelin
Hi, On Wed, 17 Aug 2005, Linus Torvalds wrote: > On Wed, 17 Aug 2005, Jeff Garzik wrote: > > > > 2) Teach it to understand MIME, and not treat the MIME headers like part > > of the message. > > [...] > > Ergo: if somebody sends you mime-encoded patches, hit them with a baseball > bat (polite

Re: [PATCH] Teach applymbox to keep the Subject: line.

2005-08-17 Thread Junio C Hamano
Linus Torvalds <[EMAIL PROTECTED]> writes: > The fact is, anybody who doesn't edit the emails that come in is BROKEN. > There are two kinds of emails: > > - the nicely formatted ones where the author follows all the rules > >This kind of email doesn't need MIME decoding anyway. That depends

Re: [PATCH] Teach applymbox to keep the Subject: line.

2005-08-17 Thread Linus Torvalds
On Wed, 17 Aug 2005, Jeff Garzik wrote: > > 1) Fix applymbox such that it understands RFC822-valid Subject lines > which wrap across multiple text lines. It already should do this. > 2) Teach it to understand MIME, and not treat the MIME headers like part > of the message. But this one I re

Re: [PATCH] Teach applymbox to keep the Subject: line.

2005-08-17 Thread Junio C Hamano
Jeff Garzik <[EMAIL PROTECTED]> writes: > 1) Fix applymbox such that it understands RFC822-valid Subject lines > which wrap across multiple text lines. I thought I did this in mailinfo (read_one_header() function) some time ago. I'd appreciate it if you could point me at a sample message that f

Re: [PATCH] Teach applymbox to keep the Subject: line.

2005-08-17 Thread Jeff Garzik
If someone is thus motivated, I have two requests in this area: 1) Fix applymbox such that it understands RFC822-valid Subject lines which wrap across multiple text lines. 2) Teach it to understand MIME, and not treat the MIME headers like part of the message. - To unsubscribe from this l

Re: [PATCH] Teach applymbox to keep the Subject: line.

2005-08-17 Thread Linus Torvalds
On Tue, 16 Aug 2005, Junio C Hamano wrote: > > This is a companion patch to the previous format-patch fix. > With "-k", format-patch can be told not to remove the [PATCH] in > the original commit, nor to add the [PATCH] on its own. I think this might be the point in time to just make the "[PATCH

[PATCH] Teach applymbox to keep the Subject: line.

2005-08-16 Thread Junio C Hamano
This is a companion patch to the previous format-patch fix. With "-k", format-patch can be told not to remove the [PATCH] in the original commit, nor to add the [PATCH] on its own. However, applymbox toolchain has a code to remove [PATCH] (among other things) from the Subject: line, which is the r