Re: [PATCH] convert: mark a file-local symbol static

2016-10-17 Thread Ramsay Jones
On 17/10/16 21:07, Junio C Hamano wrote: > Ramsay Jones writes: > >> Heh, I actually have the following in my config.mak already: >> >> extra-clean: clean >> find . -iname '*.o' -exec rm {} \; >> >> But for some reason I _always_ type 'make clean' and then, to top >> it off, I _always_ typ

Re: [PATCH] convert: mark a file-local symbol static

2016-10-17 Thread Stefan Beller
On Mon, Oct 17, 2016 at 1:07 PM, Junio C Hamano wrote: > Ramsay Jones writes: > >> Heh, I actually have the following in my config.mak already: >> >> extra-clean: clean >> find . -iname '*.o' -exec rm {} \; >> >> But for some reason I _always_ type 'make clean' and then, to top >> it off, I

Re: [PATCH] convert: mark a file-local symbol static

2016-10-17 Thread René Scharfe
Am 17.10.2016 um 22:07 schrieb Junio C Hamano: Ramsay Jones writes: Heh, I actually have the following in my config.mak already: extra-clean: clean find . -iname '*.o' -exec rm {} \; But for some reason I _always_ type 'make clean' and then, to top it off, I _always_ type the 'find'

Re: [PATCH] convert: mark a file-local symbol static

2016-10-17 Thread Junio C Hamano
Ramsay Jones writes: > Heh, I actually have the following in my config.mak already: > > extra-clean: clean > find . -iname '*.o' -exec rm {} \; > > But for some reason I _always_ type 'make clean' and then, to top > it off, I _always_ type the 'find' command by hand (I have no idea > why) :

Re: [PATCH] convert: mark a file-local symbol static

2016-10-17 Thread Ramsay Jones
On 17/10/16 10:37, Jeff King wrote: > On Mon, Oct 17, 2016 at 11:04:19AM +0200, Johannes Schindelin wrote: > >>> Gross. I would not be opposed to a Makefile rule that outputs the >>> correct set of OBJECTS so this (or other) scripts could build on it. >> >> You could also use the method I use in

Re: [PATCH] convert: mark a file-local symbol static

2016-10-17 Thread Ramsay Jones
On 17/10/16 03:18, Jeff King wrote: > On Mon, Oct 17, 2016 at 02:37:58AM +0100, Ramsay Jones wrote: > >> Hmm, well, you have to remember that 'make clean' sometimes >> doesn't make clean. Ever since the Makefile was changed to only >> remove $(OBJECTS), rather than *.o xdiff/*.o etc., you have t

Re: [PATCH] convert: mark a file-local symbol static

2016-10-17 Thread Jeff King
On Mon, Oct 17, 2016 at 11:04:19AM +0200, Johannes Schindelin wrote: > > Gross. I would not be opposed to a Makefile rule that outputs the > > correct set of OBJECTS so this (or other) scripts could build on it. > > You could also use the method I use in Git for Windows to "extend" the > Makefile

Re: [PATCH] convert: mark a file-local symbol static

2016-10-17 Thread Johannes Schindelin
Hi Ramsay & Peff, On Sun, 16 Oct 2016, Jeff King wrote: > On Mon, Oct 17, 2016 at 02:37:58AM +0100, Ramsay Jones wrote: > > > Hmm, well, you have to remember that 'make clean' sometimes doesn't > > make clean. Ever since the Makefile was changed to only remove > > $(OBJECTS), rather than *.o xdi

Re: [PATCH] convert: mark a file-local symbol static

2016-10-16 Thread Jeff King
On Mon, Oct 17, 2016 at 02:37:58AM +0100, Ramsay Jones wrote: > Hmm, well, you have to remember that 'make clean' sometimes > doesn't make clean. Ever since the Makefile was changed to only > remove $(OBJECTS), rather than *.o xdiff/*.o etc., you have to > remember to 'make clean' _before_ you swi

Re: [PATCH] convert: mark a file-local symbol static

2016-10-16 Thread Ramsay Jones
On 16/10/16 01:15, Lars Schneider wrote: >> On 15 Oct 2016, at 14:01, Ramsay Jones wrote: >> On 15/10/16 16:05, Lars Schneider wrote: On 11 Oct 2016, at 16:46, Ramsay Jones wrote: >> [snip] -void stop_multi_file_filter(struct child_process *process) +static void stop_multi_file_f

Re: [PATCH] convert: mark a file-local symbol static

2016-10-15 Thread Lars Schneider
> On 15 Oct 2016, at 14:01, Ramsay Jones wrote: > > > > On 15/10/16 16:05, Lars Schneider wrote: >>> On 11 Oct 2016, at 16:46, Ramsay Jones wrote: > [snip] >>> -void stop_multi_file_filter(struct child_process *process) >>> +static void stop_multi_file_filter(struct child_process *process) >>

Re: [PATCH] convert: mark a file-local symbol static

2016-10-15 Thread Ramsay Jones
On 15/10/16 16:05, Lars Schneider wrote: >> On 11 Oct 2016, at 16:46, Ramsay Jones wrote: [snip] >> -void stop_multi_file_filter(struct child_process *process) >> +static void stop_multi_file_filter(struct child_process *process) > > Done! Do you have some kind of script to detect these things

Re: [PATCH] convert: mark a file-local symbol static

2016-10-15 Thread Lars Schneider
> On 11 Oct 2016, at 16:46, Ramsay Jones wrote: > > If you need to re-roll your 'ls/filter-process' branch, could you > please squash this into commit 85290197 > ("convert: add filter..process option", 08-10-2016). > > > -void stop_multi_file_filter(struct child_process *process) > +static voi

[PATCH] convert: mark a file-local symbol static

2016-10-11 Thread Ramsay Jones
Signed-off-by: Ramsay Jones --- Hi Lars, If you need to re-roll your 'ls/filter-process' branch, could you please squash this into commit 85290197 ("convert: add filter..process option", 08-10-2016). Thanks. ATB, Ramsay Jones convert.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)