Re: [QUESTION] Git fails to detect merge conflict?

2019-07-04 Thread Anton Ermolenko
gt; Anton Ermolenko wrote: > >> My understanding is that recursive merge here won't consider that situation >> to >> be a merge conflict as the changes have been introduced in different spots in >> the file. > > Yes, that seems right to me. > > Do yo

Re: [QUESTION] Git fails to detect merge conflict?

2019-07-01 Thread Jonathan Nieder
Anton Ermolenko wrote: > My understanding is that recursive merge here won't consider that situation to > be a merge conflict as the changes have been introduced in different spots in > the file. Yes, that seems right to me. Do you have more details about the context? What do th

[QUESTION] Git fails to detect merge conflict?

2019-07-01 Thread Anton Ermolenko
ge --no-ff -m "merge change-b" change-b And the resulting content of "example.txt" is: --- START --- LINE 1 LINE B LINE 3 LINE D LINE E LINE 3 LINE 4 LINE 5 LINE 6 LINE 7 LINE 8 LINE 9 --- END --- My understanding is that recursive merge here won'

[PATCH v10 10/10] cherry-pick/revert: add scissors line on merge conflict

2019-04-17 Thread Phillip Wood
From: Denton Liu Fix a bug where the scissors line is placed after the Conflicts: section, in the case where a merge conflict occurs and commit.cleanup = scissors. Helped-by: Phillip Wood Signed-off-by: Denton Liu --- Documentation/git-cherry-pick.txt | 7 +++ Documentation/git-revert.txt

[PATCH v10 08/10] merge: add scissors line on merge conflict

2019-04-17 Thread Phillip Wood
From: Denton Liu This fixes a bug where the scissors line is placed after the Conflicts: section, in the case where a merge conflict occurs and commit.cleanup = scissors. Next, if commit.cleanup = scissors is specified, don't produce a scissors line in commit if one already exists i

[PATCH v9 11/11] cherry-pick/revert: add scissors line on merge conflict

2019-03-20 Thread Denton Liu
Fix a bug where the scissors line is placed after the Conflicts: section, in the case where a merge conflict occurs and commit.cleanup = scissors. Helped-by: Phillip Wood Signed-off-by: Denton Liu --- Documentation/git-cherry-pick.txt | 7 +++ Documentation/git-revert.txt | 7

[PATCH v9 09/11] merge: add scissors line on merge conflict

2019-03-20 Thread Denton Liu
This fixes a bug where the scissors line is placed after the Conflicts: section, in the case where a merge conflict occurs and commit.cleanup = scissors. Next, if commit.cleanup = scissors is specified, don't produce a scissors line in commit if one already exists in the MERGE_MSG file. H

[PATCH v8 09/11] merge: add scissors line on merge conflict

2019-03-17 Thread Denton Liu
This fixes a bug where the scissors line is placed after the Conflicts: section, in the case where a merge conflict occurs and commit.cleanup = scissors. Next, if commit.cleanup = scissors is specified, don't produce a scissors line in commit if one already exists in the MERGE_MSG file. Rev

[PATCH v8 11/11] cherry-pick/revert: add scissors line on merge conflict

2019-03-17 Thread Denton Liu
Fix a bug where the scissors line is placed after the Conflicts: section, in the case where a merge conflict occurs and commit.cleanup = scissors. Reviewed-by: Phillip Wood Signed-off-by: Denton Liu --- Documentation/git-cherry-pick.txt | 7 +++ Documentation/git-revert.txt | 7

Re: [PATCH v7 8/8] cherry-pick/revert: add scissors line on merge conflict

2019-03-12 Thread Phillip Wood
Hi Denton I've got a couple of small comments, but this looks fine to me On 11/03/2019 03:42, Denton Liu wrote: Fix a bug where the scissors line is placed after the Conflicts: section, in the case where a merge conflict occurs and commit.cleanup = scissors. Signed-off-by: Dento

Re: [PATCH v7 6/8] merge: add scissors line on merge conflict

2019-03-10 Thread Eric Sunshine
On Sun, Mar 10, 2019 at 11:42 PM Denton Liu wrote: > This fixes a bug where the scissors line is placed after the Conflicts: > section, in the case where a merge conflict occurs and > commit.cleanup = scissors. > > Next, if commit.cleanup = scissors is specified, don't produ

[PATCH v7 6/8] merge: add scissors line on merge conflict

2019-03-10 Thread Denton Liu
This fixes a bug where the scissors line is placed after the Conflicts: section, in the case where a merge conflict occurs and commit.cleanup = scissors. Next, if commit.cleanup = scissors is specified, don't produce a scissors line in commit if one already exists in the MERGE_MSG file. S

[PATCH v7 8/8] cherry-pick/revert: add scissors line on merge conflict

2019-03-10 Thread Denton Liu
Fix a bug where the scissors line is placed after the Conflicts: section, in the case where a merge conflict occurs and commit.cleanup = scissors. Signed-off-by: Denton Liu --- Documentation/git-cherry-pick.txt | 7 +++ Documentation/git-revert.txt | 7 +++ builtin/merge.c

Re: [PATCH v3 3/4] cherry-pick/revert: add scissors line on merge conflict

2019-03-07 Thread Junio C Hamano
Phillip Wood writes: >>> What are you basing this series on? builtin/rebase--helper.c was removed >>> last September in 34b47315d9 ("rebase -i: move rebase--helper modes to >>> rebase--interactive", 2018-09-27) >> >> I was basing this patch on the tip of dl/merge-cleanup-scissors-fix. I >> can r

Re: [PATCH v3 3/4] cherry-pick/revert: add scissors line on merge conflict

2019-03-07 Thread Phillip Wood
On 07/03/2019 17:56, Denton Liu wrote: > Hi Phillip, > > On Thu, Mar 07, 2019 at 03:24:16PM +, Phillip Wood wrote: >> Hi Denton >> >> On 07/03/2019 09:58, Denton Liu wrote: >>> diff --git a/builtin/rebase--helper.c b/builtin/rebase--helper.c >>> index f7c2a5fdc8..5f1bc9d383 100644 >>> --- a/bu

Re: [PATCH v3 3/4] cherry-pick/revert: add scissors line on merge conflict

2019-03-07 Thread Denton Liu
Hi Phillip, On Thu, Mar 07, 2019 at 03:24:16PM +, Phillip Wood wrote: > Hi Denton > > On 07/03/2019 09:58, Denton Liu wrote: > >Fix a bug where the scissors line is placed after the Conflicts: > >section, in the case where a merge conflict occurs and > >commit.clea

Re: [PATCH v3 3/4] cherry-pick/revert: add scissors line on merge conflict

2019-03-07 Thread Phillip Wood
Hi Denton On 07/03/2019 09:58, Denton Liu wrote: Fix a bug where the scissors line is placed after the Conflicts: section, in the case where a merge conflict occurs and commit.cleanup = scissors. Note that the removal of the if-else tower in git_sequencer_config may appear to be a no-op

[PATCH v3 3/4] cherry-pick/revert: add scissors line on merge conflict

2019-03-07 Thread Denton Liu
Fix a bug where the scissors line is placed after the Conflicts: section, in the case where a merge conflict occurs and commit.cleanup = scissors. Note that the removal of the if-else tower in git_sequencer_config may appear to be a no-op refactor but it actually isn't. First of all, w

Re: [PATCH v2 2/3] cherry-pick/revert: add scissors line on merge conflict

2019-03-07 Thread Denton Liu
file is the part that would become the > commit message, so I would have expected the second step would be > described as "appended to". I copied this over from 6f06b6aeef (merge: add scissors line on merge conflict, 2019-01-22). I guess I'll have to fix it up in git-merge too. &g

Re: [PATCH v2 2/3] cherry-pick/revert: add scissors line on merge conflict

2019-03-06 Thread Junio C Hamano
Denton Liu writes: > Fix a bug where the scissors line is placed after the Conflicts: > section, in the case where a merge conflict occurs and > commit.cleanup = scissors. > > Note that the removal of the if-else tower in git_sequencer_config may > appear to be a no-op refact

[PATCH v2 2/3] cherry-pick/revert: add scissors line on merge conflict

2019-03-06 Thread Denton Liu
Fix a bug where the scissors line is placed after the Conflicts: section, in the case where a merge conflict occurs and commit.cleanup = scissors. Note that the removal of the if-else tower in git_sequencer_config may appear to be a no-op refactor but it actually isn't. First of all, w

Re: [PATCH 2/2] cherry-pick/revert: add scissors line on merge conflict

2019-03-06 Thread Denton Liu
Hi Phillip, sorry I forgot to address one of your replies. On Wed, Mar 06, 2019 at 04:29:20PM +, Phillip Wood wrote: > Hi Denton > > On 06/03/2019 10:30, Denton Liu wrote: > >Fix a bug where the scissors line is placed after the Conflicts: > >section, in the case w

Re: [PATCH 2/2] cherry-pick/revert: add scissors line on merge conflict

2019-03-06 Thread Denton Liu
Hi Phillip, On Wed, Mar 06, 2019 at 04:29:20PM +, Phillip Wood wrote: > Hi Denton > > On 06/03/2019 10:30, Denton Liu wrote: > >Fix a bug where the scissors line is placed after the Conflicts: > >section, in the case where a merge conflict occurs and > >commit.c

Re: [PATCH 2/2] cherry-pick/revert: add scissors line on merge conflict

2019-03-06 Thread Phillip Wood
Hi Denton On 06/03/2019 10:30, Denton Liu wrote: Fix a bug where the scissors line is placed after the Conflicts: section, in the case where a merge conflict occurs and commit.cleanup = scissors. Was that the case with cherry-pick and revert as well as merge, or were they missing the

[PATCH 2/2] cherry-pick/revert: add scissors line on merge conflict

2019-03-06 Thread Denton Liu
Fix a bug where the scissors line is placed after the Conflicts: section, in the case where a merge conflict occurs and commit.cleanup = scissors. Note that the removal of the if-else tower in git_sequencer_config may appear to be a no-op refactor but it actually isn't. First of all, w

[PATCH 0/1] Provide a fix for the semantic merge conflict between 'js/vsts-ci' and 'sg/travis-specific-cc'

2019-01-29 Thread Johannes Schindelin via GitGitGadget
There are merge conflicts that do not result in merge conflict markers: e.g. when one branch extends a function's signature, and another branch adds a caller. In this instance, sg/travis-specific-cc wants to use gcc-8 in the osx-gcc job (which is already installed, but not linked, on T

[PATCH v6 4/4] merge: add scissors line on merge conflict

2019-01-22 Thread Denton Liu
This fixes a bug where the scissors line is placed after the Conflicts: section, in the case where a merge conflict occurs and commit.cleanup = scissors. Next, if commit.cleanup = scissors is specified, don't produce a scissors line in commit if one already exists in the MERGE_MSG file. S

[PATCH v5 4/4] merge: add scissors line on merge conflict

2018-12-25 Thread Denton Liu
This fixes a bug where the scissors line is placed after the Conflicts: section, in the case where a merge conflict occurs and commit.cleanup = scissors. Next, if commit.cleanup = scissors is specified, don't produce a scissors line in commit if one already exists in the MERGE_MSG file. S

Re: [PATCH v4 0/2] Fix scissors bug during merge conflict

2018-11-23 Thread Junio C Hamano
wever, since we taught git-merge the --cleanup option, this might be > misleading for the end-user since they would expect the MERGE_MSG to be > cleaned up as specified. > > I see two resolutions for this. We can either rename --cleanup more > precisely so users won't be confus

Re: [PATCH v4 0/2] Fix scissors bug during merge conflict

2018-11-21 Thread Denton Liu
isleading for the end-user since they would expect the MERGE_MSG to be cleaned up as specified. I see two resolutions for this. We can either rename --cleanup more precisely so users won't be confused (perhaps something like --merge-conflict-scissors but a lot more snappy) or we can actu

Re: [PATCH v4 0/2] Fix scissors bug during merge conflict

2018-11-21 Thread Junio C Hamano
Denton Liu writes: > Changes since V3: > * Add patch to cleanup 'merge --squash c3 with c7' test in t7600 > * Use test_i18ncmp instead of test_cmp to pass GETTEXT_POISON tests Queued. Thanks, both.

[PATCH v4 2/2] merge: add scissors line on merge conflict

2018-11-20 Thread Denton Liu
This fixes a bug where the scissors line is placed after the Conflicts: section, in the case where a merge conflict occurs and merge.cleanup = scissors. Next, if commit.cleanup = scissors is specified, don't produce a scissors line in commit if one already exists in the MERGE_MSG file. Fi

[PATCH v4 0/2] Fix scissors bug during merge conflict

2018-11-20 Thread Denton Liu
merge --squash c3 with c7' test in t7600 * Use test_i18ncmp instead of test_cmp to pass GETTEXT_POISON tests Denton Liu (2): t7600: clean up 'merge --squash c3 with c7' test merge: add scissors line on merge conflict Documentation/merge-options.txt | 6 ++

Re: [PATCH v3 1/1] merge: add scissors line on merge conflict

2018-11-18 Thread SZEDER Gábor
On Sat, Nov 17, 2018 at 06:32:33PM -0500, Denton Liu wrote: > diff --git a/t/t7600-merge.sh b/t/t7600-merge.sh > index 106148254d..0d3db34f08 100755 > --- a/t/t7600-merge.sh > +++ b/t/t7600-merge.sh > @@ -247,6 +247,54 @@ test_expect_success 'merge --squash c3 with c7' ' > test_cmp expect act

Re: [PATCH v3 0/1] Fix scissors bug during merge conflict

2018-11-17 Thread Junio C Hamano
Denton Liu writes: >> I wonder if this is what you really meant to have instead: >> >> >else if (cleanup_mode == COMMIT_MSG_CLEANUP_SCISSORS && >> > - whence == FROM_COMMIT) >> > - wt_status_add_cut_line(s->fp); >> > + whence == FR

[PATCH v3 1/1] merge: add scissors line on merge conflict

2018-11-17 Thread Denton Liu
This fixes a bug where the scissors line is placed after the Conflicts: section, in the case where a merge conflict occurs and merge.cleanup = scissors. Next, if commit.cleanup = scissors is specified, don't produce a scissors line in commit if one already exists in the MERGE_MSG file. Fi

[PATCH v3 0/1] Fix scissors bug during merge conflict

2018-11-17 Thread Denton Liu
about `#` _not_ being removed is now silenced in both cases. Changes since V1: * Only check MERGE_MSG for a scissors line instead of all prepended files * Make a variable static in merge where appropriate * Add passthrough options in pull * Add documen

[PATCH v2 2/2] merge: add scissors line on merge conflict

2018-11-16 Thread Denton Liu
This fixes a bug where the scissors line is placed after the Conflicts: section, in the case where a merge conflict occurs and merge.cleanup = scissors. In addition, we give pull the passthrough option of --cleanup so that it can also take advantage of this change. Signed-off-by: Denton Liu

[PATCH v2 0/2] Fix scissors bug during merge conflict

2018-11-16 Thread Denton Liu
ke a variable static in merge where appropriate * Add passthrough options in pull * Add documentation for the new option * Add tests to ensure desired behaviour Denton Liu (2): commit: don't add scissors line if one exists merge: add scissors line on merge conflict Documentati

Re: [RFC PATCH 0/2] Fix scissors bug during merge conflict

2018-11-14 Thread Denton Liu
On Wed, Nov 14, 2018 at 04:52:59PM +0900, Junio C Hamano wrote: > Denton Liu writes: > > > With this fix, the message becomes the following: > > > > Merge branch 'master' into new > > > > # >8 > > # Do not modify or remove the line abo

Re: [RFC PATCH 0/2] Fix scissors bug during merge conflict

2018-11-13 Thread Junio C Hamano
Denton Liu writes: > With this fix, the message becomes the following: > > Merge branch 'master' into new > > # >8 > # Do not modify or remove the line above. > # Everything below it will be ignored. > # > # Con

[RFC PATCH 2/2] merge: add scissors line on merge conflict

2018-11-13 Thread Denton Liu
This fixes a bug where the scissors line is placed after the Conflicts: section, in the case where a merge conflict occurs and merge.cleanup = scissors. Signed-off-by: Denton Liu --- builtin/merge.c | 16 1 file changed, 16 insertions(+) diff --git a/builtin/merge.c b/builtin

[RFC PATCH 0/2] Fix scissors bug during merge conflict

2018-11-13 Thread Denton Liu
I discovered a bug in Git a while ago where if one is using commit.cleanup = scissors, if making a commit after a merge conflict, the scissors line will be placed after the `Conflicts:` section. As a result, a careless Git user (e.g. me) may accidentally commit the `Conflicts:` section. Here is a

Two RFC/WIP series for facilitating merge conflict resolution

2018-08-06 Thread Elijah Newren
Hi everyone, Last week, Duy posted an interesting RFC patch for improving merge conflict resolution by coloring the "CONFLICT' messages that are output during a merge. I have two more ideas (complementary to his) for improving merge conflict resolution experience. My two ideas

Re: [PATCH v3 1/3] t7501: add merge conflict tests for dry run

2018-07-17 Thread Junio C Hamano
Junio C Hamano writes: > But by splitting these into separate tests, the patch makes such a > potential failure with "git commit --short" break the later steps. > > Not very nice. > > It may be a better change to just do in the original one > > git add test-file && > git commit --dry-

Re: [PATCH v3 1/3] t7501: add merge conflict tests for dry run

2018-07-17 Thread Junio C Hamano
or of all flags which imply a dry run > when (1) there is at least one unfixed merge conflict and (2) when all > merge conflicts are all fixed. s/conflits/conflicts/ s/fixed/resolved/g (both above and in the patch text) s/unfixed/unresolved/g (both above and in the patch text) > Sig

[PATCH v3 1/3] t7501: add merge conflict tests for dry run

2018-07-15 Thread Samuel Lijin
) there is at least one unfixed merge conflict and (2) when all merge conflicts are all fixed. Signed-off-by: Samuel Lijin --- t/t7501-commit.sh | 45 - 1 file changed, 40 insertions(+), 5 deletions(-) diff --git a/t/t7501-commit.sh b/t/t7501-commit.sh index

Re: unexpected "unresolved merge conflict" for a new file

2018-05-25 Thread Michal Hocko
entation/core-api/gfp_mask-from-fs-io.rst > > * unresolved merge conflict (line 27) > > Documentation/core-api/gfp_mask-from-fs-io.rst:27:=== > > This message isn't generated by git itself, but rather by a pre-commit > hook. You can skip the hook by running "git commit --n

Re: unexpected "unresolved merge conflict" for a new file

2018-05-24 Thread Jeff King
On Thu, May 24, 2018 at 01:36:57PM +0200, Michal Hocko wrote: > `git commit' fails on a newly added file with the following > * > * You have some suspicious patch lines: > * > * In Documentation/core-api/gfp_mask-from-fs-io.rst > * unresolved merge conflict (line 27) &

unexpected "unresolved merge conflict" for a new file

2018-05-24 Thread Michal Hocko
Hi, `git commit' fails on a newly added file with the following * * You have some suspicious patch lines: * * In Documentation/core-api/gfp_mask-from-fs-io.rst * unresolved merge conflict (line 27) Documentation/core-api/gfp_mask-from-fs-io.rst:27:=== $ git status --porcela

Re: Unexpected git diff output during merge conflict

2018-02-08 Thread Nick O'Leary
Ah, the whitespace that was added to enable the >>> markers to be added... that makes sense. Which means the output is correct and some assumptions my code makes about the format of the Combined Diff are wrong. Thanks! Nick On 8 February 2018 at 11:25, Jeff King wrote: > On Thu, Feb 08, 2018

Re: Unexpected git diff output during merge conflict

2018-02-08 Thread Jeff King
On Thu, Feb 08, 2018 at 10:51:57AM +, Nick O'Leary wrote: > $ git diff README.md > diff --cc README.md > index 61d78b2,620d806..000 > --- a/README.md > +++ b/README.md > @@@ -1,7 -1,1 +1,11 @@@ > -This is my default readme > ++<<< HEAD > +merged-history-test > +=== >

Unexpected git diff output during merge conflict

2018-02-08 Thread Nick O'Leary
Hi, I have a merge conflict on a file and the git diff output looks wrong to me. Here's how to recreate: On branch 'dev' add/commit a file (called README.md) with the contents ( '--' used to delimit the file, not included in the content): --- This is my de

Not expected merge conflict output

2017-02-21 Thread KES
Hi. I have merge conflict and this output: --- a/crypto/lib/Crypto/Routes.pm +++ b/crypto/lib/Crypto/Routes.pm @@@ -98,17 -94,16 +98,36 @@@ sub register ,payment_cancel_landing => '/payment-cancel' }}); # Route configuration is moved from plugin: ++<<&

Re: Question about about a trivial merge conflict that git should resolve alone

2015-10-23 Thread Johannes Schindelin
Hi Francis, On Fri, 23 Oct 2015, Francis Moreau wrote: > I have a simple merge conflict use case: > > $ mkdir foo > $ cd foo/ > $ git init > $ echo line1 > a > $ git add . > $ git commit -q -m init > $ echo line2 >>a > $ git commit -a -q -m "add l

Question about about a trivial merge conflict that git should resolve alone

2015-10-23 Thread Francis Moreau
Hi, I have a simple merge conflict use case: $ mkdir foo $ cd foo/ $ git init $ echo line1 > a $ git add . $ git commit -q -m init $ echo line2 >>a $ git commit -a -q -m "add line2" $ git checkout -b foo HEAD~1 $ git cherry-pick -x master $ echo line3 >>a $ git stage

Re: Inexplicable merge conflict produced when when lines next to each other are changed

2015-04-28 Thread Jeff King
On Tue, Apr 28, 2015 at 07:34:30AM +, Anuradha Dissanayake wrote: > Let's say I have a file with this content in master: > > _ > Line 1 > Line 2 > Line 3 > Line 4 > _ > > Now say I create and checkout a new branch called Test. In this branch I > change the file to this: > > _

Inexplicable merge conflict produced when when lines next to each other are changed

2015-04-28 Thread Anuradha Dissanayake
I posted this question to StackOverflow a while ago but no one answered it so I thought I'd try here. Let's say I have a file with this content in master: _ Line 1 Line 2 Line 3 Line 4 _ Now say I create and checkout a new branch called Test. In this branch I change the file to this:

Re: Sharing merge conflict resolution between multiple developers

2014-08-17 Thread Jeff King
On Mon, Aug 11, 2014 at 04:59:15PM +1200, Chris Packham wrote: > Is there any way where we could share the conflict resolution around > but still end up with a single merge commit. I'm thinking of something > like the following workflow This came up once a while back. Here's the discussion: ht

Re: Sharing merge conflict resolution between multiple developers

2014-08-11 Thread Junio C Hamano
On Mon, Aug 11, 2014 at 4:29 PM, Chris Packham wrote: >> So, the "recording" phase may go something like this: >> ... >> git checkout merge-fix/$this-$that >> git read-tree -m -u HEAD $this >> git commit -a -m 'merge-fix/$this-$that postimage' >> >> The rough idea is "git show merge-f

Re: Sharing merge conflict resolution between multiple developers

2014-08-11 Thread Chris Packham
On Tue, Aug 12, 2014 at 6:44 AM, Junio C Hamano wrote: > Chris Packham writes: > >> Is there any way where we could share the conflict resolution around >> but still end up with a single merge commit. > > One idea that immediately comes to me is to use something like > "rerere" (not its implement

Re: Sharing merge conflict resolution between multiple developers

2014-08-11 Thread Nico Williams
IIUC, this might help, http://www.mail-archive.com/git@vger.kernel.org/msg56418.html http://www.mail-archive.com/git@vger.kernel.org/msg56468.html -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://

Re: Sharing merge conflict resolution between multiple developers

2014-08-11 Thread Christian Couder
Le 11 août 2014 07:50, "Christian Couder" a écrit : > > This should be possible using "git imerge" which is separate tool. Sorry I sent the above using the gmail app on my mobile phone and unfortunately I can't make it send plain text emails. (Emails which are not plain text are rejected by vger.

Re: Sharing merge conflict resolution between multiple developers

2014-08-11 Thread Junio C Hamano
Chris Packham writes: > Is there any way where we could share the conflict resolution around > but still end up with a single merge commit. One idea that immediately comes to me is to use something like "rerere" (not its implementation and storage, but the underlying idea) enhanced with the tric

Sharing merge conflict resolution between multiple developers

2014-08-10 Thread Chris Packham
Hi List, At $dayjob we maintain internal forks of the a number of upstream repositories. Unsurprisingly updating these forks can be extremely problematic, especially when it's only one person doing the merge. Fortunately most of us are in the same physical location so it is possible to drag in so

Re: [PATCH 0/3] Make git more user-friendly during a merge conflict

2014-03-19 Thread Junio C Hamano
Andrew Wong writes: > On Mon, Mar 17, 2014 at 7:04 PM, Junio C Hamano wrote: >> Has this series been tested with existing test suite? ... > I tested it during RFC, but missed it when I sent it as patch. > ... > I'll fix the problem. Sorry about that. Thanks. Will hold onto the topic branch les

Re: [PATCH 0/3] Make git more user-friendly during a merge conflict

2014-03-17 Thread Andrew Wong
On Mon, Mar 17, 2014 at 7:04 PM, Junio C Hamano wrote: > Has this series been tested with existing test suite? I tentatively > queued it to 'pu' but then had to revert because many tests started > failing, causing me to redo the today's integration cycle for 'pu' > once again. I tested it during

Re: [PATCH 0/3] Make git more user-friendly during a merge conflict

2014-03-17 Thread Junio C Hamano
Andrew Wong writes: > 2/3: I've added advice.mergeHints to silent the messages that suggests "git > merge--abort". > > 3/3: I've added a warning message when users used "git reset" during a merge. > This warning will be printed if the user is in the middle of a merge. In > future > releases, we'

[PATCH 0/3] Make git more user-friendly during a merge conflict

2014-03-13 Thread Andrew Wong
2/3: I've added advice.mergeHints to silent the messages that suggests "git merge--abort". 3/3: I've added a warning message when users used "git reset" during a merge. This warning will be printed if the user is in the middle of a merge. In future releases, we'll change this into an error to prev

Re: [RFC 0/3] Make git more user-friendly during a merge conflict

2014-03-01 Thread Stephen Leake
Matthieu Moy writes: > $ git status > On branch master > nothing to commit, working directory clean > $ ok, you've lost your conflict resolutions. >> In fact, it now seems that 'git reset --mixed' is always the same as >> 'git reset --merge'. So I must be missing something! > > "git reset --mer

Re: [RFC 0/3] Make git more user-friendly during a merge conflict

2014-03-01 Thread Matthieu Moy
Stephen Leake writes: > So as I understand it, this does _not_ lose your conflict resolutions. Well, then maybe it's time to try the command before continuing commenting on its behavior ;-). $ git status [...] both modified: foo.txt [...] $ git diff diff --cc foo.txt index 595f399,

Re: [RFC 0/3] Make git more user-friendly during a merge conflict

2014-03-01 Thread Stephen Leake
David Kastrup writes: > Stephen Leake writes: > >> David Kastrup writes: >> >>> Stephen Leake writes: >>> David Kastrup writes: > "do the right thing" commands also tend to do the wrong thing > occasionally with potentially disastrous results when they are used > in scri

Re: [RFC 0/3] Make git more user-friendly during a merge conflict

2014-02-28 Thread David Kastrup
Stephen Leake writes: > David Kastrup writes: > >> Stephen Leake writes: >> >>> David Kastrup writes: >>> "do the right thing" commands also tend to do the wrong thing occasionally with potentially disastrous results when they are used in scripts where the followup actions rely

Re: [RFC 0/3] Make git more user-friendly during a merge conflict

2014-02-28 Thread Stephen Leake
David Kastrup writes: > Stephen Leake writes: > >> David Kastrup writes: >> >>> "do the right thing" commands also tend to do the wrong thing >>> occasionally with potentially disastrous results when they are used >>> in scripts where the followup actions rely on the actual result. >> >> That i

Re: [RFC 0/3] Make git more user-friendly during a merge conflict

2014-02-28 Thread David Kastrup
Stephen Leake writes: > David Kastrup writes: > >> "do the right thing" commands also tend to do the wrong thing >> occasionally with potentially disastrous results when they are used >> in scripts where the followup actions rely on the actual result. > > That is bad, and should not be allowed.

Re: [RFC 0/3] Make git more user-friendly during a merge conflict

2014-02-28 Thread Stephen Leake
David Kastrup writes: > Stephen Leake writes: > >> I like commands that "do the right thing". So no, this would not be >> confusing. > > I _hate_ commands that think they know better than to do what they are > told. In particular when doing destructive things. And just because > _you_ like the

Re: [RFC 0/3] Make git more user-friendly during a merge conflict

2014-02-28 Thread David Kastrup
Stephen Leake writes: > I like commands that "do the right thing". So no, this would not be > confusing. I _hate_ commands that think they know better than to do what they are told. In particular when doing destructive things. And just because _you_ like them does not mean they are not confusi

Re: [RFC 0/3] Make git more user-friendly during a merge conflict

2014-02-28 Thread Charles Bailey
On Fri, Feb 28, 2014 at 03:01:53AM -0600, Stephen Leake wrote: > Jonathan Nieder writes: > > And for experienced users, this would be a bad regression. > > Backward incompatibility is a real concern. > > It might be best if "git reset" (with _no_ option) be made to error out, > so all users have

Re: [RFC 0/3] Make git more user-friendly during a merge conflict

2014-02-28 Thread Stephen Leake
the patches. > >> We could stop here and hope that the users would read the messages, but I >> think >> git could be a bit more user-friendly. The last patch might be a bit more >> controversial. It changes the default behavior of "git reset" to default to &

Re: [RFC 0/3] Make git more user-friendly during a merge conflict

2014-02-26 Thread Jonathan Nieder
sers would read the messages, but I > think > git could be a bit more user-friendly. The last patch might be a bit more > controversial. It changes the default behavior of "git reset" to default to > "git reset --merge" during a merge conflict. I imagine that's w

[RFC 0/3] Make git more user-friendly during a merge conflict

2014-02-26 Thread Andrew Wong
Users may not be aware that they need to use "git merge --abort" or "git reset --merge" to properly abort a merge conflict. They are likely to just use "git reset", because that "usually" cleans up the repo. But in the case where the user had local change

Re: Git merge: conflict is expected, but not detected

2013-12-01 Thread Evgeniy Ivanov
7;s say I have two identical branches: master and topic. In master I >> remove some code, i.e. function bar(). In topic I do the same (commit) >> and after some time I realize I need bar() and revert previous commit >> with removal. >> So I end with master with no bar()

Re: Git merge: conflict is expected, but not detected

2013-11-30 Thread Jon Seymour
I end with master with no bar() and topic with bar() in its > original state. When I merge I get code without bar() and no merge > conflict (recursive or resolve strategies). Is it possible to detect > such situations as conflicts? When bar() is C++ virtual there is no > possibility to ca

Re: Git merge: conflict is expected, but not detected

2013-11-29 Thread Kyle J. McKay
aster with no bar() and topic with bar() in its original state. When I merge I get code without bar() and no merge conflict (recursive or resolve strategies). Is it possible to detect such situations as conflicts? When bar() is C++ virtual there is no possibility to catch this with compiler. You c

Re: Git merge: conflict is expected, but not detected

2013-11-29 Thread brian m. carlson
evious commit > with removal. > So I end with master with no bar() and topic with bar() in its > original state. When I merge I get code without bar() and no merge > conflict (recursive or resolve strategies). Is it possible to detect > such situations as conflicts? When bar() is C++ v

Git merge: conflict is expected, but not detected

2013-11-29 Thread Evgeniy Ivanov
n its original state. When I merge I get code without bar() and no merge conflict (recursive or resolve strategies). Is it possible to detect such situations as conflicts? When bar() is C++ virtual there is no possibility to catch this with compiler. Please, CC me since I'm not subscribed. Thanks

git subtree pull incorrectly reports merge conflict

2013-06-22 Thread Eric Lindsey
nother project also using it as a subtree, or directly with 'git push' -- doesn't matter). When I go back to the initial project, 'git subtree pull' has a merge conflict, and fails to merge the new changes. The reported conflict is half-empty, so I can't see why ther

Re: [PATCH v2] bash-prompt.sh: Show where rebase is at when interrupted by a merge conflict

2013-04-25 Thread Junio C Hamano
Zoltan Klinger writes: > When a rebase is interrupted by a merge conflict it could be useful to The command also stops when told to stop with "amend", etc. no? I would phrase this way "When a rebase stops (e.g. interrupted ...), it could be useful...". > This

[PATCH v2] bash-prompt.sh: Show where rebase is at when interrupted by a merge conflict

2013-04-25 Thread Zoltan Klinger
When a rebase is interrupted by a merge conflict it could be useful to know how far a rebase has progressed and how many commits in total this rebase will apply. Teach the __git_ps1() command to display the number of commits so far applied and the total number of commits to be applied. Below is a

Re: [PATCH] git-prompt.sh: Show where rebase is at when interrupted by a merge conflict

2013-04-24 Thread Felipe Contreras
On Tue, Apr 23, 2013 at 10:08 AM, Junio C Hamano wrote: > Zoltan Klinger writes: > >> When a rebase is interrupted by a merge conflict it could be useful to >> know how far a rebase has progressed and how many commits in total this >> rebase will apply. Teach the __git_

Re: [PATCH] git-prompt.sh: Show where rebase is at when interrupted by a merge conflict

2013-04-24 Thread Eric Sunshine
On Tue, Apr 23, 2013 at 8:35 AM, Zoltan Klinger wrote: > When a rebase is interrupted by a merge conflict it could be useful to > know how far a rebase has progressed and how many commits in total this > rebase will apply. Teach the __git_ps1() command to display the number > of co

Re: [PATCH] git-prompt.sh: Show where rebase is at when interrupted by a merge conflict

2013-04-23 Thread Junio C Hamano
Zoltan Klinger writes: > When a rebase is interrupted by a merge conflict it could be useful to > know how far a rebase has progressed and how many commits in total this > rebase will apply. Teach the __git_ps1() command to display the number > of commits so far applied and the tot

[PATCH] git-prompt.sh: Show where rebase is at when interrupted by a merge conflict

2013-04-23 Thread Zoltan Klinger
When a rebase is interrupted by a merge conflict it could be useful to know how far a rebase has progressed and how many commits in total this rebase will apply. Teach the __git_ps1() command to display the number of commits so far applied and the total number of commits to be applied. Below is a

Re: Suggestion for difftool behaviour during a merge conflict

2013-03-13 Thread David Aguilar
On Wed, Mar 13, 2013 at 11:48 AM, Øystein Walle wrote: > When a merge is ongoing and there are conflicts, 'git difftool' will > output the exact same --cc-style diff output as 'git diff' will without > further explanation. This has lead to some confusion: A couple of weeks > ago a person asked on

Re: Submodule not updated automatically on merge conflict

2012-12-17 Thread Heiko Voigt
Hi, On Thu, Dec 13, 2012 at 01:46:43PM +0800, ?A???Y wrote: > If there are merge conflict files, then changed submodules are not > updated automatically. > Why not submodules? > Files do try to merge / update. This is work in progress, currently you still have to use submodule update

Submodule not updated automatically on merge conflict

2012-12-12 Thread 乙酸鋰
Hi, If there are merge conflict files, then changed submodules are not updated automatically. Why not submodules? Files do try to merge / update. Regards, ch3cooli -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kerne

Re: Unstaging during a merge conflict

2012-10-03 Thread Jeff King
On Mon, Oct 01, 2012 at 08:13:21PM -0500, Matt McClellan wrote: > We had an issue at our organization where changes were reverted when a > user was merging his local repo with the remote repo changes. The > merge conflicted and he unstaged all the changes that were not a > conflict, he then resol

Re: Unstaging during a merge conflict

2012-10-02 Thread Junio C Hamano
Matt McClellan writes: > I've done this using git add --interactive then reverting a files > changes, though the actual crime was done using egit staging tool. It > seems the command line won't let you unstage changes but gui tools and > interactive tools seem to allow it. I think you could do

Re: Merge conflict.

2005-08-13 Thread Petr Baudis
Dear diary, on Sat, Aug 13, 2005 at 04:45:32PM CEST, I got a letter where Kenneth Johansson <[EMAIL PROTECTED]> told me that... > I used cogito to do a cg-update and got conflicts and the exact files are > printed to the screen. But say I somehow lost that output is there anyway > to list conflicti