Re: [PATCHv2] tag: add --edit option

2018-02-04 Thread Nicolas Morey-Chaisemartin
Le 02/02/2018 à 20:16, Eric Sunshine a écrit : > On Fri, Feb 2, 2018 at 11:48 AM, Nicolas Morey-Chaisemartin > wrote: >> What message do you suggest ? As I said in a previous mail, a >> simple "Editor failure, cancelling {commit, tag}" should be enough >> as

Re: contrib/completion/git-completion.bash: declare -g is not portable

2018-02-04 Thread Duy Nguyen
On Sun, Feb 4, 2018 at 12:20 AM, Torsten Bögershausen wrote: > Hej Duy, > After running t9902-completion.sh on Mac OS I got a failure > in this style: Sorry I was new with this bash thingy. Jeff already answered this (and I will fix it in the re-roll) but just for my own

Re: [GSoC][PATCH] commit: add a commit.signOff config variable

2018-02-04 Thread Eric Sunshine
On Sun, Feb 04, 2018 at 10:03:18AM +0800, Chen Jingpiao wrote: > Add the commit.signOff configuration variable to use the -s or --signoff > option of git commit by default. > > Signed-off-by: Chen Jingpiao > --- > > Though we can configure signoff using format.signOff

F.LLI PISTOLESI Snc

2018-02-04 Thread . F.LLI PISTOLESI Snc
Hello , I am looking for a reliable supplier /manufacturer of products for sell in Europe. I came across your listing and wanted to get some information regarding minimum Order Quantities, FOB pricing and also the possibility of packaging including payments terms. So could you please get

[PATCH] gitk: Add option to not save window geometry

2018-02-04 Thread Rodney Lorrimar
Saving and restoring the pane widths is not helpful when running gitk under a tiling window manager. It often results in the second and third panes being pushed to the far right of the window at startup. This change adds a preference to disable the saving of window geometry -- i.e. window

Re: contrib/completion/git-completion.bash: declare -g is not portable

2018-02-04 Thread Eric Sunshine
On Sun, Feb 4, 2018 at 4:45 AM, Duy Nguyen wrote: > On Sun, Feb 4, 2018 at 12:20 AM, Torsten Bögershausen wrote: >> After running t9902-completion.sh on Mac OS I got a failure >> in this style: > > Sorry I was new with this bash thingy. Jeff already answered

Re: [PATCH v4] daemon: add --log-destination=(stderr|syslog|none)

2018-02-04 Thread Ævar Arnfjörð Bjarmason
On Sun, Feb 04 2018, Lucas Werkmeister jotted: >[--inetd | > [--listen=] [--port=] > [--user= [--group=]]] > + [--log-destination=(stderr|syslog|none)] I micronit, but maybe worthwhile to have a preceeding commit to fix up that indentation of

Re: [PATCH v4] daemon: add --log-destination=(stderr|syslog|none)

2018-02-04 Thread Lucas Werkmeister
On 04.02.2018 19:55, Ævar Arnfjörð Bjarmason wrote: > > On Sun, Feb 04 2018, Lucas Werkmeister jotted: > >> [--inetd | >>[--listen=] [--port=] >>[--user= [--group=]]] >> + [--log-destination=(stderr|syslog|none)] > > I micronit, but maybe worthwhile to

Re: [PATCH v3] daemon: add --log-destination=(stderr|syslog|none)

2018-02-04 Thread Lucas Werkmeister
On 04.02.2018 07:36, Eric Sunshine wrote: > On Sat, Feb 3, 2018 at 6:08 PM, Lucas Werkmeister > wrote: >> This new option can be used to override the implicit --syslog of >> --inetd, or to disable all logging. (While --detach also implies >> --syslog,

Re: [GSoC][PATCH] commit: add a commit.signOff config variable

2018-02-04 Thread Ævar Arnfjörð Bjarmason
On Sun, Feb 04 2018, Eric Sunshine jotted: > --- >8 --- > for cfg in true false > do > for opt in '' --signoff --no-signoff > do > case "$opt:$cfg" in > --signoff:*|:true) expect= ;; > --no-signoff:*|:false) expect=! ;; > esac > test_expect_success

Re: [PATCH v4] daemon: add --log-destination=(stderr|syslog|none)

2018-02-04 Thread Eric Sunshine
On Sun, Feb 4, 2018 at 1:30 PM, Lucas Werkmeister wrote: > This new option can be used to override the implicit --syslog of > --inetd, or to disable all logging. (While --detach also implies > --syslog, --log-destination=stderr with --detach is useless since > --detach

Re: [PATCH v4] daemon: add --log-destination=(stderr|syslog|none)

2018-02-04 Thread Eric Sunshine
On Sun, Feb 4, 2018 at 1:55 PM, Ævar Arnfjörð Bjarmason wrote: > On Sun, Feb 04 2018, Lucas Werkmeister jotted: >>[--inetd | >> [--listen=] [--port=] >> [--user= [--group=]]] >> + [--log-destination=(stderr|syslog|none)] > > I

[PATCH v4] daemon: add --log-destination=(stderr|syslog|none)

2018-02-04 Thread Lucas Werkmeister
This new option can be used to override the implicit --syslog of --inetd, or to disable all logging. (While --detach also implies --syslog, --log-destination=stderr with --detach is useless since --detach disassociates the process from the original stderr.) --syslog is retained as an alias for

[PATCH v2] rebase: add --allow-empty-message option

2018-02-04 Thread Genki Sky
This option allows commits with empty commit messages to be rebased, matching the same option in git-commit and git-cherry-pick. While empty log messages are frowned upon, sometimes one finds them in older repositories (e.g. translated from another VCS [0]), or have other reasons for desiring

[PATCH v2 3/3] worktree: teach "add" to check out existing branches

2018-02-04 Thread Thomas Gummerer
Currently 'git worktree add ' creates a new branch named after the basename of the path by default. If a branch with that name already exists, the command refuses to do anything, unless the '--force' option is given. However we can do a little better than that, and check the branch out if it is

[PATCH v2 1/3] worktree: improve message when creating a new worktree

2018-02-04 Thread Thomas Gummerer
Currently 'git worktree add' produces output like the following, when '--no-checkout' is not given: Preparing foo (identifier foo) HEAD is now at 26da330922 where the first line is written to stderr, and the second line coming from 'git reset --hard' is written to stdout, even though

[PATCH v2 2/3] worktree: be clearer when "add" dwim-ery kicks in

2018-02-04 Thread Thomas Gummerer
Currently there is no indication in the "git worktree add" output that a new branch was created. This would be especially useful information in the case where the dwim of "git worktree add " kicks in, as the user didn't explicitly ask for a new branch, but we create one from them. Print some

[PATCH v2 0/3] worktree: teach "add" to check out existing branches

2018-02-04 Thread Thomas Gummerer
The previous round was at <20180121120208.12760-1-t.gumme...@gmail.com>. Thanks Duy for the comments on the previous round. In addition to the additional functionality, this series now includes improvements to the output of the "git worktree add" command. It doesn't include any new magic to

Re: [PATCH v2 1/3] worktree: improve message when creating a new worktree

2018-02-04 Thread Duy Nguyen
On Sun, Feb 04, 2018 at 10:13:03PM +, Thomas Gummerer wrote: > diff --git a/builtin/worktree.c b/builtin/worktree.c > index 7cef5b120b..d1549e441d 100644 > --- a/builtin/worktree.c > +++ b/builtin/worktree.c > @@ -303,7 +303,7 @@ static int add_worktree(const char *path, const char >

Re: [PATCH v2 3/3] worktree: teach "add" to check out existing branches

2018-02-04 Thread Duy Nguyen
On Sun, Feb 04, 2018 at 10:13:05PM +, Thomas Gummerer wrote: > - if (opts->new_branch) > + if (opts->checkout_existing_branch) > + fprintf(stderr, _(", checking out existing branch '%s'"), > + refname); > + else if (opts->new_branch) >

[PATCH] dir.c: ignore paths containing .git when invalidating untracked cache

2018-02-04 Thread Nguyễn Thái Ngọc Duy
read_directory() code ignores all paths named ".git" even if it's not a valid git repository. See treat_path() for details. Since ".git" is basically invisible to read_directory(), when we are asked to invalidate a path that contains ".git", we can safely ignore it because the slow path would not

Re: contrib/completion/git-completion.bash: declare -g is not portable

2018-02-04 Thread Lucas Werkmeister
On 04.02.2018 10:57, Eric Sunshine wrote: > On Sun, Feb 4, 2018 at 4:45 AM, Duy Nguyen wrote: >> On Sun, Feb 4, 2018 at 12:20 AM, Torsten Bögershausen wrote: >>> After running t9902-completion.sh on Mac OS I got a failure >>> in this style: >> >> Sorry I was new

Re: [PATCH v7 17/31] merge-recursive: add a new hashmap for storing directory renames

2018-02-04 Thread Johannes Sixt
Am 03.02.2018 um 22:34 schrieb Elijah Newren: > If anyone can find an > example of a real world open source repository (linux, webkit, git, > etc.) with a merge where n is greater than about 10, I'll be > surprised. git rev-list --parents --merges master | grep " .* .* .* .* .* .* .* .* .* .* "