[GIT PULL] l10n updates for 2.23.0 round 2

2019-08-16 Thread Jiang Xin
Hi Junio, Please pull the following l10n updates for Git 2.23.0. The following changes since commit 2e27de94d485a6da0c8e264c165e55100f1a13a8: Git 2.23-rc2 (2019-08-09 10:15:39 -0700) are available in the Git repository at: git://github.com/git-l10n/git-po tags/l10n-2.23.0-rnd2 for you to

May I Have Your Attention Please

2019-08-16 Thread H . E . Mr . Aurélien Agbénonci
It is my pleasure to inform you that after our brief meeting this morning with the Board of Directors WU we have concluded to release your outstanding payments worth $1.5 Million USD through Western Union Service. Therefore be advise to contact the WU office in charge of your payments with the bel

RE: QGit 2.8 for Windows?

2019-08-16 Thread Dyer, Edwin
Not sure if this is the same thing or not but I found this: https://github.com/tibirna/qgit It looks to be v2.6. Maybe this might be of use? Cheers, Ed Dyer Associate DevOps Engineer Alliance Data Retail Services 3075 Loyalty Circle, Columbus OH 43219 Office: 614-944-3923| Mobile: 614-432-3862

Re: [PATCH] bugreport: add tool to generate debugging info

2019-08-16 Thread Junio C Hamano
Emily Shaffer writes: > I think comparing this habit to the .gitignore isn't quite fair - > .gitignore tells me I forgot to add my new command binary to it, when I > run `git status` to see what I need to add to my commit with new > command. That is why I said that we need to actively work on, i

Re: What's cooking in git.git (Aug 2019, #04; Wed, 14)

2019-08-16 Thread Junio C Hamano
Matheus Tavares Bernardino writes: >> Thanks. Or we could just go the lazier route. A new stable release >> would happen within a day or two, and then in a week or so after that, >> the tip of 'next' gets rewound and rebuilt on top of it. We can >> discard the older copy and replace with the n

Re: BUG?: xdl_merge surprisingly does not recognize content conflict

2019-08-16 Thread Junio C Hamano
Elijah Newren writes: > Now, a manual merge of these files gives no conflicts, which surprises me: > > $ git merge-file ours base theirs; echo $? > 0 Indeed that is surprising. > -- 8< -- > Subject: checkout: remove duplicate code > > Both commit a7256debd4b6 ("checkout.txt: note about losi

Re: Git Test Coverage Report (Thursday, Aug 15)

2019-08-16 Thread Jeff King
On Thu, Aug 15, 2019 at 10:01:04PM -0400, Derrick Stolee wrote: > Here is today's test coverage report. Are the scripts you use to generate these available somewhere? I think it's useful to look at uncovered code, but I often struggle to figure out whether the parts attached to my name are relev

Re: Git Test Coverage Report (Thursday, Aug 15)

2019-08-16 Thread Jeff King
On Fri, Aug 16, 2019 at 02:11:03PM -0400, Jeff King wrote: > if (opts->ignore_whitespace) { > struct strbuf buf = STRBUF_INIT; > > if (strategy_opts) > strbuf_addstr(&buf, strategy_opts); > > strbuf_add

Re: BUG?: xdl_merge surprisingly does not recognize content conflict

2019-08-16 Thread Jeff King
On Thu, Aug 15, 2019 at 03:03:03PM -0700, Elijah Newren wrote: > The problematic merge was commit 4a3ed2bec603 ("Merge branch > 'nd/checkout-m'", 2019-04-25), but redoing that merge produces no merge > conflicts. This can be seen at the individual file level with the > following: > [...] > I'm no

Re: [PATCH] bugreport: add tool to generate debugging info

2019-08-16 Thread Emily Shaffer
On Fri, Aug 16, 2019 at 09:41:41AM -0700, Junio C Hamano wrote: > Emily Shaffer writes: > > > I think comparing this habit to the .gitignore isn't quite fair - > > .gitignore tells me I forgot to add my new command binary to it, when I > > run `git status` to see what I need to add to my commit w

RE: suggestion for improved docs on autocrlf

2019-08-16 Thread Yagnatinsky, Mark
Yay! Feel free to tweak and/or butcher the wording, I won't be offended :) -Original Message- From: Torsten Bögershausen [mailto:tbo...@web.de] Sent: Friday, August 16, 2019 12:20 AM To: Yagnatinsky, Mark Cc: 'Junio C Hamano' ; 'git@vger.kernel.org' Subject: Re: suggestion for improve

Re: BUG?: xdl_merge surprisingly does not recognize content conflict

2019-08-16 Thread Elijah Newren
On Fri, Aug 16, 2019 at 9:51 AM Junio C Hamano wrote: > > Elijah Newren writes: > > > Now, a manual merge of these files gives no conflicts, which surprises me: > > > > $ git merge-file ours base theirs; echo $? > > 0 > > Indeed that is surprising. > > > -- 8< -- > > Subject: checkout: remove

Re: [PATCH v3 23/24] merge-recursive: add sanity checks for relevant merge_options

2019-08-16 Thread Junio C Hamano
Elijah Newren writes: > There are lots of options that callers can set, yet most have a limited > range of valid values, some options are meant for output (e.g. > opt->obuf, which is expected to start empty), and callers are expected > to not set opt->priv. Add several sanity checks to ensure ca

Re: [PATCH v3 23/24] merge-recursive: add sanity checks for relevant merge_options

2019-08-16 Thread Junio C Hamano
> diff --git a/merge-recursive.c b/merge-recursive.c > index 647b1f25c3..bc0da608c4 100644 > --- a/merge-recursive.c > +++ b/merge-recursive.c > @@ -3620,6 +3620,29 @@ static int merge_start(struct merge_options *opt, > struct tree *head) > ... > + assert(opt->buffer_output >= 0 && opt->buffe

Re: [GIT PULL] l10n updates for 2.23.0 round 2

2019-08-16 Thread Junio C Hamano
Jiang Xin writes: > Hi Junio, > > Please pull the following l10n updates for Git 2.23.0. > > The following changes since commit 2e27de94d485a6da0c8e264c165e55100f1a13a8: > > Git 2.23-rc2 (2019-08-09 10:15:39 -0700) > > are available in the Git repository at: > > git://github.com/git-l10n/git-

Re: [PATCH] bugreport: add tool to generate debugging info

2019-08-16 Thread Johannes Schindelin
Hi Emily, On Thu, 15 Aug 2019, Emily Shaffer wrote: > On Thu, Aug 15, 2019 at 10:07:57PM +0200, Johannes Schindelin wrote: > > > > On Thu, 15 Aug 2019, Derrick Stolee wrote: > > > > > On 8/14/2019 10:34 PM, Emily Shaffer wrote: > > > > diff --git a/git-bugreport.sh b/git-bugreport.sh > > > > new

Re: [PATCH v2 0/1] pack-refs: always refreshing after take the lock file

2019-08-16 Thread Jeff King
On Thu, Aug 01, 2019 at 02:35:43AM +0800, 16657101...@163.com wrote: > > So I actually think the best path forward is just always refreshing when > > we take the lock, something like: > > > > Ultimately the best solution there is to move to a better format (like > > the reftables proposal). > >

[ANNOUNCE] Git v2.23.0

2019-08-16 Thread Junio C Hamano
The latest feature release Git v2.23.0 is now available at the usual places. It is comprised of 505 non-merge commits since v2.22.0, contributed by 77 people, 26 of which are new faces. The tarballs are found at: https://www.kernel.org/pub/software/scm/git/ The following public repositories

Re: [PATCH v3 03/24] merge-recursive: enforce opt->ancestor != NULL when calling merge_trees()

2019-08-16 Thread Junio C Hamano
Elijah Newren writes: > We always want our conflict hunks to be labelled so that users can know > where each came from. The previous commit fixed the one caller in the > codebase which was not setting opt->ancestor (and thus not providing a > label for the "merge base" conflict hunk in diff3-sty

Re: [PATCH v3 21/24] merge-recursive: split internal fields into a separate struct

2019-08-16 Thread SZEDER Gábor
On Thu, Aug 15, 2019 at 02:40:50PM -0700, Elijah Newren wrote: > diff --git a/merge-recursive.c b/merge-recursive.c > static void merge_finalize(struct merge_options *opt) > { > flush_output(opt); > - if (!opt->call_depth && opt->buffer_output < 2) > + if (!opt->priv->call_depth &&

Re: [ANNOUNCE] Git v2.23.0

2019-08-16 Thread Bhaskar Chowdhury
Thanks, a bunch Junio! :) On 14:00 Fri 16 Aug 2019, Junio C Hamano wrote: The latest feature release Git v2.23.0 is now available at the usual places. It is comprised of 505 non-merge commits since v2.22.0, contributed by 77 people, 26 of which are new faces. The tarballs are found at: ht

Re: [PATCH v3 04/24] merge-recursive: provide a better label for diff3 common ancestor

2019-08-16 Thread Junio C Hamano
Elijah Newren writes: > @@ -3507,6 +3507,11 @@ int merge_recursive(struct merge_options *opt, > struct commit *merged_common_ancestors; > struct tree *mrtree; > int clean; > + int num_merge_bases; > + struct strbuf merge_base_abbrev = STRBUF_INIT; > + > + if (!opt->c

NEED YOUR ASSIST PLEASE

2019-08-16 Thread Mrs Ann Johnson
Hello My name Mrs. Ann Johnson from UK,I am a dying woman who had decided to donate what I have left to you. I am 59 years old and was diagnosed of ovarian cancer about 2 years ago immediately after the death of my husband, who had left me with everything he worked for. I have decided to dona

Re: [PATCH v3 12/24] cache-tree: share code between functions writing an index as a tree

2019-08-16 Thread Junio C Hamano
Elijah Newren writes: > write_tree_from_memory() appeared to be a merge-recursive special that > basically duplicated write_index_as_tree(). The two have a different > signature, but the bigger difference was just that write_index_as_tree() > would always unconditionally read the index off of di

Re: [PATCH v3 23/24] merge-recursive: add sanity checks for relevant merge_options

2019-08-16 Thread Elijah Newren
On Fri, Aug 16, 2019 at 12:52 PM Junio C Hamano wrote: > > Elijah Newren writes: > > > There are lots of options that callers can set, yet most have a limited > > range of valid values, some options are meant for output (e.g. > > opt->obuf, which is expected to start empty), and callers are expec

Re: [PATCH v3 23/24] merge-recursive: add sanity checks for relevant merge_options

2019-08-16 Thread Elijah Newren
On Fri, Aug 16, 2019 at 12:59 PM Junio C Hamano wrote: > > > diff --git a/merge-recursive.c b/merge-recursive.c > > index 647b1f25c3..bc0da608c4 100644 > > --- a/merge-recursive.c > > +++ b/merge-recursive.c > > @@ -3620,6 +3620,29 @@ static int merge_start(struct merge_options *opt, > > struct t

Re: [PATCH v3 18/24] merge-recursive: consolidate unnecessary fields in merge_options

2019-08-16 Thread Junio C Hamano
Elijah Newren writes: > static inline int merge_detect_rename(struct merge_options *opt) > { > - return opt->merge_detect_rename >= 0 ? opt->merge_detect_rename : > - opt->diff_detect_rename >= 0 ? opt->diff_detect_rename : 1; > + return (opt->detect_renames != -1) ? opt->de

Re: [PATCH v3 21/24] merge-recursive: split internal fields into a separate struct

2019-08-16 Thread Junio C Hamano
Elijah Newren writes: > merge_options has several internal fields that should not be set or read > by external callers. This just complicates the API. Move them into an > opaque merge_options_internal struct that is defined only in > merge-recursive.c and keep these out of merge-recursive.h. >

[RFE] Teach hash-object to be able to choose signature types

2019-08-16 Thread Randall S. Becker
Hi All, I do not know whether this would be a good enhancement or micro project for someone (maybe me) to take on, but I'm wondering whether it might be a good idea to provide an option to hash-object to select the signature being computed. The use case begins when someone computes an object signa

Re: [PATCH v3 04/24] merge-recursive: provide a better label for diff3 common ancestor

2019-08-16 Thread Elijah Newren
On Fri, Aug 16, 2019 at 2:33 PM Junio C Hamano wrote: > > Elijah Newren writes: > > > @@ -3507,6 +3507,11 @@ int merge_recursive(struct merge_options *opt, > > struct commit *merged_common_ancestors; > > struct tree *mrtree; > > int clean; > > + int num_merge_bases; > > +

Re: [PATCH v3 12/24] cache-tree: share code between functions writing an index as a tree

2019-08-16 Thread Elijah Newren
On Fri, Aug 16, 2019 at 3:01 PM Junio C Hamano wrote: > > Elijah Newren writes: > > > write_tree_from_memory() appeared to be a merge-recursive special that > > basically duplicated write_index_as_tree(). The two have a different > > signature, but the bigger difference was just that write_index

Re: [PATCH v3 18/24] merge-recursive: consolidate unnecessary fields in merge_options

2019-08-16 Thread Elijah Newren
On Fri, Aug 16, 2019 at 3:14 PM Junio C Hamano wrote: > > Elijah Newren writes: > > > static inline int merge_detect_rename(struct merge_options *opt) > > { > > - return opt->merge_detect_rename >= 0 ? opt->merge_detect_rename : > > - opt->diff_detect_rename >= 0 ? opt->diff_det

Re: [PATCH v3 21/24] merge-recursive: split internal fields into a separate struct

2019-08-16 Thread Elijah Newren
On Fri, Aug 16, 2019 at 2:19 PM SZEDER Gábor wrote: > > On Thu, Aug 15, 2019 at 02:40:50PM -0700, Elijah Newren wrote: > > diff --git a/merge-recursive.c b/merge-recursive.c > > > static void merge_finalize(struct merge_options *opt) > > { > > flush_output(opt); > > - if (!opt->call_de

[PATCH v2] userdiff: Add a builtin pattern for dts files

2019-08-16 Thread Stephen Boyd
The Linux kernel receives many patches to the devicetree files each release. The hunk header for those patches typically show nothing, making it difficult to figure out what node is being modified without applying the patch or opening the file and seeking to the context. Let's add a builtin 'dts' p

Re: [PATCH v3 23/24] merge-recursive: add sanity checks for relevant merge_options

2019-08-16 Thread Junio C Hamano
Elijah Newren writes: > If the only possible values are 0 and 1, I can either add assertions > to check that at run time, or make the compiler check it for us by > confining its value to a single bit. A compile-time check seems more > robust... Sure, as long as they can catch assignments (e.g.

Re: [PATCH v3 18/24] merge-recursive: consolidate unnecessary fields in merge_options

2019-08-16 Thread Junio C Hamano
Elijah Newren writes: > At the end of this series, the "merge-recursive: add sanity checks for > relevant merge_options" commit adds some assertions that would fail if > someone passed such a value, regardless of whether this patch was > included or not. (Are we worried about people having such

[PATCH v2 0/2] add git-bugreport tool

2019-08-16 Thread Emily Shaffer
Having read Dscho's response after already writing this reroll, I think it is a compelling case to rewrite as a C builtin, although I'm worried a little about the best way to continue to call porcelain commands to protect against bitrot. Regardless, I think the proof of concept in patch 2/2 still

[PATCH v2 2/2] bugreport: generate config whitelist based on docs

2019-08-16 Thread Emily Shaffer
Add a new step to the build to generate a whitelist of git-config variables which are appropriate to include in the output of git-bugreport. New variables can be added to the whitelist by annotating their documentation in Documentation/config with the line "// bugreport-include". Some configs are

[PATCH v2 1/2] bugreport: add tool to generate debugging info

2019-08-16 Thread Emily Shaffer
Make it easier for users who encounter a bug to send a report by collecting some state information, intended to be viewed by humans familiar with Git. Teach Git how to prompt the user for a good bug report: reproduction steps, expected behavior, and actual behavior. Also, teach Git to write down i

Re: [PATCH v2] userdiff: Add a builtin pattern for dts files

2019-08-16 Thread Frank Rowand
+Frank (me) On 8/16/19 3:56 PM, Stephen Boyd wrote: > The Linux kernel receives many patches to the devicetree files each > release. The hunk header for those patches typically show nothing, > making it difficult to figure out what node is being modified without > applying the patch or opening the

Re: [RFE] Teach hash-object to be able to choose signature types

2019-08-16 Thread brian m. carlson
On 2019-08-16 at 22:22:17, Randall S. Becker wrote: > Hi All, > > I do not know whether this would be a good enhancement or micro project for > someone (maybe me) to take on, but I'm wondering whether it might be a good > idea to provide an option to hash-object to select the signature being > com

Keep your secrets safe!

2019-08-16 Thread git
Hello! I am a representative of the ChaosCC hacker group. In the period from 23/06/2019 to 11/08/2019 we got access to your account git@vger.kernel.org by hacking one of the domain.com mail servers. Your pass for above account on moment of hack was: bread4u2d You already changed the password? S

Keep your secrets safe!

2019-08-16 Thread git
Hello! I am a representative of the ChaosCC hacker group. In the period from 23/06/2019 to 11/08/2019 we got access to your account git@vger.kernel.org by hacking one of the domain.com mail servers. Your pass for above account on moment of hack was: 28121971 You already changed the password? S

I WANT YOU TO USE THIS DONATION TO HELP THE POOR URGENT.

2019-08-16 Thread Mrs Yvonne D Balakiwal
My Sincere Greetings, I am Mrs Yvonne D Balakiwal, I decided to donate what I have to you for investment towards the good work of charity organization, and also to help the motherless and the less privileged ones and to carry out a charitable works in your Country and around the World on my Be