Re: [PATCH] stgit: allow spaces in filenames (second try)

2005-07-14 Thread Catalin Marinas
Catalin Marinas <[EMAIL PROTECTED]> wrote: > One note about patch description. I would prefer to have the > convention of the Linux kernel patches: > > --- > Short description line Probably without this line in the e-mail body since it is already in the subject line. -- Catalin - To unsubscribe

Re: [PATCH] stgit: allow spaces in filenames (second try)

2005-07-14 Thread Catalin Marinas
Bryan Larsen <[EMAIL PROTECTED]> wrote: > The current version of stgit does not allow whitespace in filenames. This > patch fixes that. It also speeds up operations on large filesets > considerably. > > Signed-off-by: Bryan Larsen <[EMAIL PROTECTED]> Applied. It will be visible tonight via the

Re: [PATCH] stgit: allow spaces in filenames

2005-07-14 Thread Bryan Larsen
Does it make that big difference if the commands are invoked via the shell? I haven't run any tests. It wasn't for the time difference that I bypassed the shell, it was to support spaces and other strange characters in parameters. It's easy to use spawnvp than it is to escape the paramete

Re: [PATCH] stgit: allow spaces in filenames

2005-07-14 Thread Catalin Marinas
On Wed, 2005-07-13 at 15:26 -0700, Junio C Hamano wrote: > Catalin Marinas <[EMAIL PROTECTED]> writes: > > >> I'd very much like to stay on the same list. By the same logic, cogito > >> should have it's own list as well... > > > > I'd like this too and it's probably OK with a low traffic (we'll

[PATCH] stgit: allow spaces in filenames (second try)

2005-07-13 Thread Bryan Larsen
The current version of stgit does not allow whitespace in filenames. This patch fixes that. It also speeds up operations on large filesets considerably. Signed-off-by: Bryan Larsen <[EMAIL PROTECTED]> --- stgit/commands/export.py |4 - stgit/git.py | 203 +

Re: [PATCH] stgit: allow spaces in filenames

2005-07-13 Thread Junio C Hamano
Catalin Marinas <[EMAIL PROTECTED]> writes: >> I'd very much like to stay on the same list. By the same logic, cogito >> should have it's own list as well... > > I'd like this too and it's probably OK with a low traffic (we'll see if > we receive complaints :-) ). I'd like to keep Porcelain dis

Re: [PATCH] stgit: allow spaces in filenames

2005-07-13 Thread Catalin Marinas
On Wed, 2005-07-13 at 14:17 -0400, Bryan Larsen wrote: > Catalin Marinas wrote: > I would have hoped that emacs py-mode would "do the right thing". > Anybody know how to make it do what Catalin wants? It looks like the python-mode in my emacs does the right thing. You could add something like bel

Re: [PATCH] stgit: allow spaces in filenames

2005-07-13 Thread Jerry Seutter
Bryan Larsen wrote: Catalin Marinas wrote: An additional thing, can you please convert all the tabs to spaces? That's a better convention for a language like Python where you delimit blocks by indentation. I would have hoped that emacs py-mode would "do the right thing". Anybody know how to

Re: [PATCH] stgit: allow spaces in filenames

2005-07-13 Thread Linus Torvalds
On Wed, 13 Jul 2005, Matthias Urlichs wrote: > > Hi, Bryan Larsen wrote: > > > + r=os.spawnvp(os.P_WAIT, args_l[0], args_l + args[i:min(i+1000, > > len(args))]) > > The max length for argv is 32k IIRC, so 1000 is 28-byte file names. I think 32k may be the posix-mandated minimum. Linux does

Re: [PATCH] stgit: allow spaces in filenames

2005-07-13 Thread Bryan Larsen
Catalin Marinas wrote: An additional thing, can you please convert all the tabs to spaces? That's a better convention for a language like Python where you delimit blocks by indentation. I would have hoped that emacs py-mode would "do the right thing". Anybody know how to make it do what Catali

Re: [PATCH] stgit: allow spaces in filenames

2005-07-13 Thread Matthias Urlichs
Hi, Bryan Larsen wrote: > + r=os.spawnvp(os.P_WAIT, args_l[0], args_l + args[i:min(i+1000, > len(args))]) The max length for argv is 32k IIRC, so 1000 is 28-byte file names. That's probably not enough. I't suggest using chunks of 100. -- Matthias Urlichs | {M:U} IT Design @ m-u-it.de

Re: [PATCH] stgit: allow spaces in filenames

2005-07-13 Thread Catalin Marinas
Bryan Larsen <[EMAIL PROTECTED]> wrote: > The current version of stgit does not allow whitespace in filenames. > This patch fixes that. It also speeds up operations on large > filesets considerably. Thanks, I will apply it but I have a few comments below: > +# __run: runs cmd using spawnvp. > +#

[PATCH] stgit: allow spaces in filenames

2005-07-13 Thread Bryan Larsen
The current version of stgit does not allow whitespace in filenames. This patch fixes that. It also speeds up operations on large filesets considerably. Signed-off-by: Bryan Larsen <[EMAIL PROTECTED]> --- stgit/git.py | 158 +++-- stgit/ma