Ramkumar Ramachandra writes:
> Junio C Hamano wrote:
>> Note that we leave "return undef;" in validate_address on purpose,
>> even though Perlcritic may complain. The primary "return" site of
>> the function returns whatever is in the scaler variable $address, so
>> it is pointless to change onl
Junio C Hamano wrote:
> Note that we leave "return undef;" in validate_address on purpose,
> even though Perlcritic may complain. The primary "return" site of
> the function returns whatever is in the scaler variable $address, so
> it is pointless to change only the other "return undef;" to "retur
On Sun, Mar 31, 2013 at 9:40 PM, Junio C Hamano wrote:
> All the callers of "ask", "extract_valid_address", and "validate_patch"
> subroutines assign the return values from them to a single scaler:
s/scaler/scalar/g
(note the /g)
>
> $var = subr(...);
>
> and "return undef;" in these su
From: Ramkumar Ramachandra
All the callers of "ask", "extract_valid_address", and "validate_patch"
subroutines assign the return values from them to a single scaler:
$var = subr(...);
and "return undef;" in these subroutine can safely be turned into a
simpler "return;". Doing so will a
4 matches
Mail list logo
