Re: [PATCH v3] Add an explicit GIT_DIR to the list of excludes

2014-05-29 Thread Jakub Narębski
On Thu, May 29, 2014 at 4:33 AM, Pasha Bolokhov wrote: > > Agree, but "partial" here means... what? just a little doc? I'm sorry, I tried to be cute and failed :$ This is not official name for documentation files that are meant for inclusion and not as standalone manpages. I think they are simi

Re: [PATCH v3] Add an explicit GIT_DIR to the list of excludes

2014-05-28 Thread Pasha Bolokhov
Agree, but "partial" here means... what? just a little doc? On Wed, May 28, 2014 at 11:53 AM, Jakub Narębski wrote: > W dniu 2014-05-27 19:16, Pasha Bolokhov pisze: > Add GIT_DIR to the list of excludes in setup_standard_excludes(), while checking that GIT_DIR is not just '.git', in wh

Re: [PATCH v3] Add an explicit GIT_DIR to the list of excludes

2014-05-28 Thread Jakub Narębski
W dniu 2014-05-27 19:16, Pasha Bolokhov pisze: Add GIT_DIR to the list of excludes in setup_standard_excludes(), while checking that GIT_DIR is not just '.git', in which case it would be ignored by default, and that GIT_DIR is inside GIT_WORK_TREE gives git-grep.txt and git-ls-files.txt. I don'

Re: [PATCH v3] Add an explicit GIT_DIR to the list of excludes

2014-05-27 Thread Pasha Bolokhov
I've sent out version [PATCH v4] with most of the things addressed. That one hasn't been reviewed by anyone yet On Tue, May 27, 2014 at 11:04 AM, Junio C Hamano wrote: > Duy Nguyen writes: > >> On Sat, May 24, 2014 at 12:33 AM, Pasha Bolokhov >> wrote: >>> When an explicit '--git-dir' option p

Re: [PATCH v3] Add an explicit GIT_DIR to the list of excludes

2014-05-27 Thread Junio C Hamano
Duy Nguyen writes: > On Sat, May 24, 2014 at 12:33 AM, Pasha Bolokhov > wrote: >> When an explicit '--git-dir' option points to a directory inside >> the work tree, git treats it as if it were any other directory. >> In particular, 'git status' lists it as untracked, while 'git add -A' >> stages

Re: [PATCH v3] Add an explicit GIT_DIR to the list of excludes

2014-05-27 Thread Pasha Bolokhov
>> Add GIT_DIR to the list of excludes in setup_standard_excludes(), >> while checking that GIT_DIR is not just '.git', in which case it >> would be ignored by default, and that GIT_DIR is inside GIT_WORK_TREE >> > gives git-grep.txt and git-ls-files.txt. I don't know if we need to > add something

Re: [PATCH v3] Add an explicit GIT_DIR to the list of excludes

2014-05-23 Thread Duy Nguyen
On Sat, May 24, 2014 at 12:33 AM, Pasha Bolokhov wrote: > When an explicit '--git-dir' option points to a directory inside > the work tree, git treats it as if it were any other directory. > In particular, 'git status' lists it as untracked, while 'git add -A' > stages the metadata directory entir

Re: [PATCH v3] Add an explicit GIT_DIR to the list of excludes

2014-05-23 Thread Pasha Bolokhov
Hi, > >> /* "--git-dir" has been given */ > > ... or it could have come from GIT_DIR environment, no? Yes, it does not matter where it came from, but I'll correct the comment > > Does this "additional exclude" need to kick in if GIT_DIR is set to > "/home/pasha/w/.git"? That is, w

Re: [PATCH v3] Add an explicit GIT_DIR to the list of excludes

2014-05-23 Thread Junio C Hamano
Pasha Bolokhov writes: > diff --git a/dir.c b/dir.c > index 98bb50f..76969a7 100644 > --- a/dir.c > +++ b/dir.c > @@ -1588,6 +1588,26 @@ void setup_standard_excludes(struct dir_struct *dir) > { > const char *path; > char *xdg_path; > + const char *gitdir = get_git_dir(); > + > +