Re: [PATCH v8 4/5] Implement line-history search (git log -L)

2013-03-01 Thread Thomas Rast
Thomas Rast writes: > Junio C Hamano writes: > >> I notice that "careful and slow" is just "too slow >> to be usable" even on a small tree like ours. Try running >> >> $ git log -M -L:get_name:builtin/describe.c >> >> and see how long you have to wait until you hit the first line of >> outp

Re: [PATCH v8 4/5] Implement line-history search (git log -L)

2013-03-01 Thread Thomas Rast
Junio C Hamano writes: > Junio C Hamano writes: > >> Overall, I like this better than the "log --follow" hack; as the >> revision traversal is done without any pathspec when being "careful >> and slow" (aka -M), you do not suffer from the "just use a singleton >> pathspec globally regardless of

Re: [PATCH v8 4/5] Implement line-history search (git log -L)

2013-02-28 Thread Junio C Hamano
Junio C Hamano writes: > Overall, I like this better than the "log --follow" hack; as the > revision traversal is done without any pathspec when being "careful > and slow" (aka -M), you do not suffer from the "just use a singleton > pathspec globally regardless of what other history paths are bei

Re: [PATCH v8 4/5] Implement line-history search (git log -L)

2013-02-28 Thread Thomas Rast
Junio C Hamano writes: > Thomas Rast writes: > >> Junio C Hamano writes: >> +/* + * NEEDSWORK: manually building a diff here is not the Right + * Thing(tm). log -L should be built into the diff pipeline. >>> >>> I am not sure about this design, and do not necessarily agree that

Re: [PATCH v8 4/5] Implement line-history search (git log -L)

2013-02-28 Thread Junio C Hamano
Thomas Rast writes: > Junio C Hamano writes: > >>> +/* >>> + * NEEDSWORK: manually building a diff here is not the Right >>> + * Thing(tm). log -L should be built into the diff pipeline. >> >> I am not sure about this design, and do not necessarily agree that >> wedging this to the diff pipelin

Re: [PATCH v8 4/5] Implement line-history search (git log -L)

2013-02-28 Thread Thomas Rast
Junio C Hamano writes: >> +/* >> + * NEEDSWORK: manually building a diff here is not the Right >> + * Thing(tm). log -L should be built into the diff pipeline. > > I am not sure about this design, and do not necessarily agree that > wedging this to the diff pipeline is the right future direction

Re: [PATCH v8 4/5] Implement line-history search (git log -L)

2013-02-28 Thread Junio C Hamano
Thomas Rast writes: > @@ -138,6 +155,11 @@ Examples > This makes sense only when following a strict policy of merging all > topic branches when staying on a single integration branch. > > +git log -L '/int main/',/^}/:main.c:: > + > + Shows how the function `main()` in the file