[GitHub] [activemq-nms-amqp] Havret opened a new pull request #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

Havret opened a new pull request #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31 It addresses https://issues.apache.org/jira/browse/AMQNET-612 This is

[GitHub] [activemq-nms-amqp] Havret opened a new pull request #30: AMQNET-611: Apache.NMS.IllegalStateException is throw on transport thread

Havret opened a new pull request #30: AMQNET-611: Apache.NMS.IllegalStateException is throw on transport thread URL: https://github.com/apache/activemq-nms-amqp/pull/30 It closes https://issues.apache.org/jira/projects/AMQNET/issues/AMQNET-611

[GitHub] [activemq-nms-amqp] Havret commented on issue #28: NO-JIRA: Extend logging

Havret commented on issue #28: NO-JIRA: Extend logging URL: https://github.com/apache/activemq-nms-amqp/pull/28#issuecomment-530553439 @cjwmorgan-sol There weren't any logs there, because in qpid-jms there weren't any logs. I don't see any reason why wouldn't we have them included. The

[GitHub] [activemq-nms-amqp] Havret commented on a change in pull request #28: NO-JIRA: Extend logging

Havret commented on a change in pull request #28: NO-JIRA: Extend logging URL: https://github.com/apache/activemq-nms-amqp/pull/28#discussion_r323441669 ## File path: src/NMS.AMQP/Transport/TransportContext.cs ## @@ -56,7 +56,6 @@ static TransportContext() //

[GitHub] [activemq-nms-amqp] Havret commented on a change in pull request #28: NO-JIRA: Extend logging

Havret commented on a change in pull request #28: NO-JIRA: Extend logging URL: https://github.com/apache/activemq-nms-amqp/pull/28#discussion_r323436467 ## File path: src/NMS.AMQP/Provider/Amqp/AmqpProvider.cs ## @@ -58,6 +58,9 @@ public Task Connect(ConnectionInfo

[GitHub] [activemq-nms-amqp] cjwmorgan-sol commented on a change in pull request #28: NO-JIRA: Extend logging

cjwmorgan-sol commented on a change in pull request #28: NO-JIRA: Extend logging URL: https://github.com/apache/activemq-nms-amqp/pull/28#discussion_r323430045 ## File path: src/NMS.AMQP/Provider/Amqp/AmqpProvider.cs ## @@ -58,6 +58,9 @@ public Task Connect(ConnectionInfo

[GitHub] [activemq-nms-amqp] Havret commented on a change in pull request #28: NO-JIRA: Extend logging

Havret commented on a change in pull request #28: NO-JIRA: Extend logging URL: https://github.com/apache/activemq-nms-amqp/pull/28#discussion_r323419221 ## File path: src/NMS.AMQP/Provider/Amqp/AmqpProvider.cs ## @@ -58,6 +58,9 @@ public Task Connect(ConnectionInfo

[GitHub] [activemq-nms-amqp] Havret commented on a change in pull request #28: NO-JIRA: Extend logging

Havret commented on a change in pull request #28: NO-JIRA: Extend logging URL: https://github.com/apache/activemq-nms-amqp/pull/28#discussion_r323419156 ## File path: src/NMS.AMQP/NmsSession.cs ## @@ -470,6 +479,10 @@ public NmsMessageProducer ProducerClosed(Id producerId,

[GitHub] [activemq-nms-amqp] Havret commented on a change in pull request #28: NO-JIRA: Extend logging

Havret commented on a change in pull request #28: NO-JIRA: Extend logging URL: https://github.com/apache/activemq-nms-amqp/pull/28#discussion_r323418968 ## File path: src/NMS.AMQP/NmsMessageConsumer.cs ## @@ -219,19 +225,24 @@ private void DeliverNextPending()

[GitHub] [activemq-nms-amqp] Havret commented on a change in pull request #28: NO-JIRA: Extend logging

Havret commented on a change in pull request #28: NO-JIRA: Extend logging URL: https://github.com/apache/activemq-nms-amqp/pull/28#discussion_r323418636 ## File path: src/NMS.AMQP/NmsMessageConsumer.cs ## @@ -219,19 +225,24 @@ private void DeliverNextPending()

[GitHub] [activemq-nms-amqp] Havret commented on a change in pull request #28: NO-JIRA: Extend logging

Havret commented on a change in pull request #28: NO-JIRA: Extend logging URL: https://github.com/apache/activemq-nms-amqp/pull/28#discussion_r323418784 ## File path: src/NMS.AMQP/NmsMessageConsumer.cs ## @@ -219,19 +225,24 @@ private void DeliverNextPending()

[GitHub] [activemq-nms-amqp] Havret commented on a change in pull request #28: NO-JIRA: Extend logging

Havret commented on a change in pull request #28: NO-JIRA: Extend logging URL: https://github.com/apache/activemq-nms-amqp/pull/28#discussion_r323418336 ## File path: src/NMS.AMQP/NmsSession.cs ## @@ -428,6 +432,11 @@ public void AcknowledgeIndividual(AckType ackType,

[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #29: AMQNET-610: Race conditions during consumer creation

michaelandrepearce commented on issue #29: AMQNET-610: Race conditions during consumer creation URL: https://github.com/apache/activemq-nms-amqp/pull/29#issuecomment-530462233 Ok. Just remember there will always be bugs. We do want to cut a release at somepoint. Once we have a release

[GitHub] [activemq-nms-amqp] Havret commented on issue #29: AMQNET-610: Race conditions during consumer creation

Havret commented on issue #29: AMQNET-610: Race conditions during consumer creation URL: https://github.com/apache/activemq-nms-amqp/pull/29#issuecomment-530458732 Yep. But it would be nice to have [this one](https://issues.apache.org/jira/projects/AMQNET/issues/AMQNET-611) included in

[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #29: AMQNET-610: Race conditions during consumer creation

michaelandrepearce commented on issue #29: AMQNET-610: Race conditions during consumer creation URL: https://github.com/apache/activemq-nms-amqp/pull/29#issuecomment-530456020 Cool was this the only blocker for CI? Or more issues you want to fix. Just trying to gauge when to cut release

[GitHub] [activemq-nms-amqp] michaelandrepearce merged pull request #29: AMQNET-610: Race conditions during consumer creation

michaelandrepearce merged pull request #29: AMQNET-610: Race conditions during consumer creation URL: https://github.com/apache/activemq-nms-amqp/pull/29 This is an automated message from the Apache Git Service. To respond

[GitHub] [activemq-nms-amqp] Havret commented on issue #29: AMQNET-610: Race conditions during consumer creation

Havret commented on issue #29: AMQNET-610: Race conditions during consumer creation URL: https://github.com/apache/activemq-nms-amqp/pull/29#issuecomment-530447174 I'm going to look at it tonight. This is an automated

[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #29: AMQNET-610: Race conditions during consumer creation

michaelandrepearce commented on issue #29: AMQNET-610: Race conditions during consumer creation URL: https://github.com/apache/activemq-nms-amqp/pull/29#issuecomment-530446482 @HavretGC did we resolve the issue robbie raised in dev mail list re object msg

[GitHub] [activemq-artemis] asfgit closed pull request #2831: ARTEMIS-2480 - Reloading configuration can kill broker

asfgit closed pull request #2831: ARTEMIS-2480 - Reloading configuration can kill broker URL: https://github.com/apache/activemq-artemis/pull/2831 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [activemq-nms-amqp] HavretGC commented on issue #29: AMQNET-610: Race conditions during consumer creation

HavretGC commented on issue #29: AMQNET-610: Race conditions during consumer creation URL: https://github.com/apache/activemq-nms-amqp/pull/29#issuecomment-530422019 @michaelandrepearce It is ready to merge then. This is an

[GitHub] [activemq-nms-amqp] cjwmorgan-sol commented on issue #29: AMQNET-610: Race conditions during consumer creation

cjwmorgan-sol commented on issue #29: AMQNET-610: Race conditions during consumer creation URL: https://github.com/apache/activemq-nms-amqp/pull/29#issuecomment-530393632 Raised https://issues.apache.org/jira/browse/AMQNET-611, this PR looks fine to me.

[GitHub] [activemq-artemis] asfgit closed pull request #2828: ARTEMIS-2478 Expired message not removed in non destructive queue

asfgit closed pull request #2828: ARTEMIS-2478 Expired message not removed in non destructive queue URL: https://github.com/apache/activemq-artemis/pull/2828 This is an automated message from the Apache Git Service. To

[GitHub] [activemq-artemis] clebertsuconic commented on issue #2828: ARTEMIS-2478 Expired message not removed in non destructive queue

clebertsuconic commented on issue #2828: ARTEMIS-2478 Expired message not removed in non destructive queue URL: https://github.com/apache/activemq-artemis/pull/2828#issuecomment-530373259 Actually, there's one issue (it seems the test added takes a long time to run.. 1 minute). I'm

[GitHub] [activemq-artemis] clebertsuconic commented on issue #2828: ARTEMIS-2478 Expired message not removed in non destructive queue

clebertsuconic commented on issue #2828: ARTEMIS-2478 Expired message not removed in non destructive queue URL: https://github.com/apache/activemq-artemis/pull/2828#issuecomment-530371857 I ran the whole testsuite (2.5 hours run) with this change, no issues! merging!

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers

franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers URL: https://github.com/apache/activemq-artemis/pull/2832#issuecomment-530319911 @wy96f I've taken a second look to the way Netty handle thread local `ByteBuf`pools and I can confirm that

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers

franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers URL: https://github.com/apache/activemq-artemis/pull/2832#issuecomment-530319911 @wy96f I've taken a second look to the way Netty handle thread local `ByteBuf`pools and I can confirm that

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers

franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers URL: https://github.com/apache/activemq-artemis/pull/2832#issuecomment-530319911 @wy96f I've taken a second look to the way Netty handle thread local pools and I can confirm that

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers

franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers URL: https://github.com/apache/activemq-artemis/pull/2832#issuecomment-530319911 @wy96f I've taken a second look to the way Netty handle thread local pools and I can confirm that

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers

franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers URL: https://github.com/apache/activemq-artemis/pull/2832#issuecomment-530319911 @wy96f I've taken a second look to the way Netty handle thread local pools and I can confirm that

[GitHub] [activemq-artemis] andytaylor commented on issue #2831: ARTEMIS-2480 - Reloading configuration can kill broker

andytaylor commented on issue #2831: ARTEMIS-2480 - Reloading configuration can kill broker URL: https://github.com/apache/activemq-artemis/pull/2831#issuecomment-530319715 feedback applied This is an automated message from

[GitHub] [activemq-artemis] franz1981 commented on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers

franz1981 commented on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers URL: https://github.com/apache/activemq-artemis/pull/2832#issuecomment-530319911 @wy96f I've taken a second look to the way Netty handle thread local pools and I can confirm that

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers

franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers URL: https://github.com/apache/activemq-artemis/pull/2832#issuecomment-530284944 @wy96f Yes and no :) They would leak (at first look, but let me take a better look), but they just

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers

franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers URL: https://github.com/apache/activemq-artemis/pull/2832#issuecomment-530284944 @wy96f Yes and no :) They would leak (at first look, but let me take a better look), but they just

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers

franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers URL: https://github.com/apache/activemq-artemis/pull/2832#issuecomment-530284944 @wy96f Yes and no :) They would leak (at first look, but let me take a better look), but they just

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers

franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers URL: https://github.com/apache/activemq-artemis/pull/2832#issuecomment-530284944 @wy96f Yes and no :) They would leak (at first look, but let me take a better look), but they just

[GitHub] [activemq-artemis] wy96f edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers

wy96f edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers URL: https://github.com/apache/activemq-artemis/pull/2832#issuecomment-530283213 > @wy96f > > > PooledByteBufAllocator::directBuffer uses java's ThreadLocal. Wouldn't this result in

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers

franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers URL: https://github.com/apache/activemq-artemis/pull/2832#issuecomment-530284944 @wy96f Yes and no :) They would leak (at first look, but let me take a better look), but they just

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers

franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers URL: https://github.com/apache/activemq-artemis/pull/2832#issuecomment-530284944 @wy96f Yes and no :) They would leak (at first look, but let me take a better look), but they just

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers

franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers URL: https://github.com/apache/activemq-artemis/pull/2832#issuecomment-530284944 @wy96f Yes and no :) They would leak (at first look, but let me take a better look), but they just

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers

franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers URL: https://github.com/apache/activemq-artemis/pull/2832#issuecomment-530284944 @wy96f Yes and no :) They would leak (at first look, but let me take a better look), but they would

[GitHub] [activemq-artemis] franz1981 commented on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers

franz1981 commented on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers URL: https://github.com/apache/activemq-artemis/pull/2832#issuecomment-530284944 @wy96f Yes and no :) The would leak (at first look, but let me take a better look), but they would contain just

[GitHub] [activemq-artemis] wy96f commented on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers

wy96f commented on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers URL: https://github.com/apache/activemq-artemis/pull/2832#issuecomment-530283213 > @wy96f > > > PooledByteBufAllocator::directBuffer uses java's ThreadLocal. Wouldn't this result in leak in

[GitHub] [activemq-artemis] franz1981 commented on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers

franz1981 commented on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers URL: https://github.com/apache/activemq-artemis/pull/2832#issuecomment-530273041 @wy96f > PooledByteBufAllocator::directBuffer uses java's ThreadLocal. Wouldn't this result in leak in the

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers

franz1981 commented on a change in pull request #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers URL: https://github.com/apache/activemq-artemis/pull/2832#discussion_r323108903 ## File path:

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers

franz1981 commented on a change in pull request #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers URL: https://github.com/apache/activemq-artemis/pull/2832#discussion_r323108156 ## File path:

[GitHub] [activemq-artemis] wy96f commented on a change in pull request #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers

wy96f commented on a change in pull request #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers URL: https://github.com/apache/activemq-artemis/pull/2832#discussion_r323071740 ## File path:

[GitHub] [activemq-artemis] wy96f commented on a change in pull request #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers

wy96f commented on a change in pull request #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers URL: https://github.com/apache/activemq-artemis/pull/2832#discussion_r323071598 ## File path:

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers

franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers URL: https://github.com/apache/activemq-artemis/pull/2832#issuecomment-530138441 @wy96f please take a look: I know you've recently have fun with `ByteBuf`s :) I see too that the change