MrEasy commented on a change in pull request #2750: ARTEMIS-2399 Improve
performance when there are a lot of subscribers
URL: https://github.com/apache/activemq-artemis/pull/2750#discussion_r323786778
##
File path: pom.xml
##
@@ -90,6 +90,7 @@
3.6.13.Final
Havret commented on issue #31: AMQNET-612: ObjectMessage shouldn't have
jms-msg-type set
URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530972823
no worries
This is an automated message from the Apache
michaelandrepearce commented on a change in pull request #31: AMQNET-612:
ObjectMessage shouldn't have jms-msg-type set
URL: https://github.com/apache/activemq-nms-amqp/pull/31#discussion_r323929755
##
File path: src/NMS.AMQP/Provider/Amqp/Message/AmqpCodec.cs
##
@@
gemmellr commented on issue #31: AMQNET-612: ObjectMessage shouldn't have
jms-msg-type set
URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530996473
The new check for serialized dotnet content type should never be true while
the annotation is set to reflect a JMS
Havret commented on issue #27: NO-JIRA: Configure continuous integration
URL: https://github.com/apache/activemq-nms-amqp/pull/27#issuecomment-530996289
Added.
This is an automated message from the Apache Git Service.
To
Havret commented on issue #31: AMQNET-612: ObjectMessage shouldn't have
jms-msg-type set
URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-531004899
I believe we can have our own content type, but we cannot use it alongside
with `x-opt-jms-msg-type`.
michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't
have jms-msg-type set
URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530969794
x-opt-jms-msg-type should be honoured, his suggestion was to key on the
content type and if java serialized,
michaelandrepearce edited a comment on issue #31: AMQNET-612: ObjectMessage
shouldn't have jms-msg-type set
URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530969794
x-opt-jms-msg-type should be honoured, his suggestion was when msg type =obj
then also key on the
Havret commented on issue #31: AMQNET-612: ObjectMessage shouldn't have
jms-msg-type set
URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530970167
Yes and this is how I've implemented it. Still I am not particularly happy
with it. :(
michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't
have jms-msg-type set
URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530972488
thus if no content type (assumed AmqpTypedObject) then return obj, if
content type is set, then you only
michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't
have jms-msg-type set
URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530972062
what you do is:
if (properties.hasProperty(content type) ) {
if (property.getProperty(content
michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't
have jms-msg-type set
URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530972684
very poor but quick pseudo code (sorry)
Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have
jms-msg-type set
URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530971944
Because they have `x-opt-jms-msg-type=object` type and do not have neither
`application/x-java-serialized-object`
michaelandrepearce commented on a change in pull request #31: AMQNET-612:
ObjectMessage shouldn't have jms-msg-type set
URL: https://github.com/apache/activemq-nms-amqp/pull/31#discussion_r323926285
##
File path: src/NMS.AMQP/Provider/Amqp/Message/AmqpCodec.cs
##
@@
michaelandrepearce commented on a change in pull request #31: AMQNET-612:
ObjectMessage shouldn't have jms-msg-type set
URL: https://github.com/apache/activemq-nms-amqp/pull/31#discussion_r323927309
##
File path: src/NMS.AMQP/Provider/Amqp/Message/AmqpCodec.cs
##
@@
Havret commented on a change in pull request #31: AMQNET-612: ObjectMessage
shouldn't have jms-msg-type set
URL: https://github.com/apache/activemq-nms-amqp/pull/31#discussion_r323927693
##
File path: src/NMS.AMQP/Provider/Amqp/Message/AmqpCodec.cs
##
@@ -55,16 +55,19 @@
michaelandrepearce commented on a change in pull request #31: AMQNET-612:
ObjectMessage shouldn't have jms-msg-type set
URL: https://github.com/apache/activemq-nms-amqp/pull/31#discussion_r323927309
##
File path: src/NMS.AMQP/Provider/Amqp/Message/AmqpCodec.cs
##
@@
Havret commented on a change in pull request #31: AMQNET-612: ObjectMessage
shouldn't have jms-msg-type set
URL: https://github.com/apache/activemq-nms-amqp/pull/31#discussion_r323927693
##
File path: src/NMS.AMQP/Provider/Amqp/Message/AmqpCodec.cs
##
@@ -55,16 +55,19 @@
michaelandrepearce commented on issue #28: NO-JIRA: Extend logging
URL: https://github.com/apache/activemq-nms-amqp/pull/28#issuecomment-530989618
so frame tracing should be at TRACE level, it should be expected than you
run with this off, and you'd enable change your apps logging level to
Havret commented on issue #28: NO-JIRA: Extend logging
URL: https://github.com/apache/activemq-nms-amqp/pull/28#issuecomment-530998160
That's understandable, but I was referring to the @cjwmorgan-sol suggestion
to log to this scenario:
Havret edited a comment on issue #28: NO-JIRA: Extend logging
URL: https://github.com/apache/activemq-nms-amqp/pull/28#issuecomment-530998160
That's understandable, but I was referring to the @cjwmorgan-sol suggestion
to log this scenario:
Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have
jms-msg-type set
URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530971944
Because they have `x-opt-jms-msg-type=object` type and have neither
`application/x-java-serialized-object` nor
Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have
jms-msg-type set
URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-531001279
So it seems we are bringing back the initial solution.
michaelandrepearce commented on issue #27: NO-JIRA: Configure continuous
integration
URL: https://github.com/apache/activemq-nms-amqp/pull/27#issuecomment-531002896
@Havret i dont see any update on the readme did you commit it?
Havret commented on a change in pull request #27: NO-JIRA: Configure continuous
integration
URL: https://github.com/apache/activemq-nms-amqp/pull/27#discussion_r323945589
##
File path: README.md
##
@@ -1,4 +1,7 @@
# Apache-NMS-AMQP
+
+[